[INFO] updating cached repository Geal/proust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Geal/proust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Geal/proust" "work/ex/clippy-test-run/sources/stable/gh/Geal/proust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Geal/proust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Geal/proust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Geal/proust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Geal/proust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d34a337e95e0c0cf6bd444c73b763ec759b25584 [INFO] sha for GitHub repo Geal/proust: d34a337e95e0c0cf6bd444c73b763ec759b25584 [INFO] validating manifest of Geal/proust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Geal/proust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Geal/proust [INFO] finished frobbing Geal/proust [INFO] frobbed toml for Geal/proust written to work/ex/clippy-test-run/sources/stable/gh/Geal/proust/Cargo.toml [INFO] started frobbing Geal/proust [INFO] finished frobbing Geal/proust [INFO] frobbed toml for Geal/proust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Geal/proust/Cargo.toml [INFO] crate Geal/proust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Geal/proust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Geal/proust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43dd0a0c2e33fefc487017fdffa70fbc35df1cb76f4b10a8025511599450e87e [INFO] running `"docker" "start" "-a" "43dd0a0c2e33fefc487017fdffa70fbc35df1cb76f4b10a8025511599450e87e"` [INFO] [stderr] Checking build_const v0.2.0 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Compiling crc v1.6.0 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking proust v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | Some(Storage{ filename: filename, file: file, data: sl, size: size, map: mm }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:50:41 [INFO] [stderr] | [INFO] [stderr] 50 | Some(Storage{ filename: filename, file: file, data: sl, size: size, map: mm }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:50:63 [INFO] [stderr] | [INFO] [stderr] 50 | Some(Storage{ filename: filename, file: file, data: sl, size: size, map: mm }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | Some(Storage{ filename: filename, file: file, data: sl, size: size, map: mm }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:50:41 [INFO] [stderr] | [INFO] [stderr] 50 | Some(Storage{ filename: filename, file: file, data: sl, size: size, map: mm }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:50:63 [INFO] [stderr] | [INFO] [stderr] 50 | Some(Storage{ filename: filename, file: file, data: sl, size: size, map: mm }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/primitive.rs:36:11 [INFO] [stderr] | [INFO] [stderr] 36 | return Done(&i[sz..], &i[0..sz]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Done(&i[sz..], &i[0..sz])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/primitive.rs:38:11 [INFO] [stderr] | [INFO] [stderr] 38 | return Incomplete(Needed::Size(length as usize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Incomplete(Needed::Size(length as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/primitive.rs:57:11 [INFO] [stderr] | [INFO] [stderr] 57 | return Done(&i[sz..], &i[0..sz]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Done(&i[sz..], &i[0..sz])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/primitive.rs:59:11 [INFO] [stderr] | [INFO] [stderr] 59 | return Incomplete(Needed::Size(length as usize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Incomplete(Needed::Size(length as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BufMut`, `BytesMut` [INFO] [stderr] --> src/network/kafka.rs:3:13 [INFO] [stderr] | [INFO] [stderr] 3 | use bytes::{BytesMut, BufMut}; [INFO] [stderr] | ^^^^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `responses::metadata::*` [INFO] [stderr] --> src/network/handler.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use responses::metadata::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `responses::response::*` [INFO] [stderr] --> src/network/handler.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use responses::response::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/network/handler.rs:263:20 [INFO] [stderr] | [INFO] [stderr] 263 | else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 264 | | if let ClientErr::ShouldClose = client.handle_message(&mut buffer) { [INFO] [stderr] 265 | | error = true; [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 263 | else if let ClientErr::ShouldClose = client.handle_message(&mut buffer) { [INFO] [stderr] 264 | error = true; [INFO] [stderr] 265 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/network/handler.rs:290:16 [INFO] [stderr] | [INFO] [stderr] 290 | else { [INFO] [stderr] | ________________^ [INFO] [stderr] 291 | | if let ClientErr::ShouldClose = client.handle_message(&mut buffer) { [INFO] [stderr] 292 | | error = true; [INFO] [stderr] 293 | | } [INFO] [stderr] 294 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 290 | else if let ClientErr::ShouldClose = client.handle_message(&mut buffer) { [INFO] [stderr] 291 | error = true; [INFO] [stderr] 292 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/response.rs:39:78 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn ser_response_message(response: ResponseMessage, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:13:48 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn ser_i8<'a>(v: i8, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn ser_i16<'a>(v: i16, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:23:50 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn ser_i32<'a>(v: i32, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:31:55 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn ser_i32_ref<'a>(v: &i32, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:35:50 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn ser_i64<'a>(v: i64, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:47:55 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn ser_i64_ref<'a>(v: &i64, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:51:62 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn ser_kafka_bytes(bs: KafkaBytes, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:57:68 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn ser_kafka_string(string: KafkaString, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:65:79 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn ser_kafka_array(elems: &Vec, closure: F, output: &mut Vec) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:71:99 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn ser_kafka_array_without_size_prefix(elems: &Vec, closure: F, output: &mut Vec) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/consumer_metadata.rs:20:98 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn ser_consumer_metadata_response<'a>(r: ConsumerMetadataResponse<'a>, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/produce.rs:21:75 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn ser_produce_response<'a>(r: &ProduceResponse<'a>, o: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/metadata.rs:58:77 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn ser_metadata_response<'a>(r: &MetadataResponse<'a>, o: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/metadata.rs:63:56 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn ser_broker<'a>(b: &Broker<'a>, o: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/metadata.rs:69:72 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn ser_topic_metadata<'a>(tm: &TopicMetadata<'a>, o: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/metadata.rs:75:72 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn ser_partition_metadata(pm: &PartitionMetadata, o: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/fetch.rs:26:74 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn ser_fetch_response(response: FetchResponse, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/fetch.rs:44:72 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn ser_message_set(message_set: &MessageSet, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/fetch.rs:56:61 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn ser_message(message: &Message, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/offset.rs:22:77 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn ser_offset_response<'a>(r: OffsetResponse<'a>, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/offset_commit.rs:21:90 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn ser_offset_commit_response<'a>(r: OffsetCommitResponse<'a>, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/offset_fetch.rs:23:88 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn ser_offset_fetch_response<'a>(r: OffsetFetchResponse<'a>, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Ready::all': removed [INFO] [stderr] --> src/network/handler.rs:223:42 [INFO] [stderr] | [INFO] [stderr] 223 | self.poll.register(&stream, token, Ready::all(), PollOpt::edge()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/storage.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | if let Ok(count) = rx.recv() { [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/storage.rs:88:56 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn storage(out:&Sender, name: &str) -> Sender { [INFO] [stderr] | ^^^^ help: consider using `_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `restart_count` [INFO] [stderr] --> src/util.rs:4:28 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn monitor(f: F, restart_count: u8) -> Result [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_restart_count` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/proust.rs:31:38 [INFO] [stderr] | [INFO] [stderr] 31 | RequestPayload::ProduceRequest(x) => { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/network/handler.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | Done(buf, size) => Ok(size as usize), [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `size` [INFO] [stderr] --> src/network/handler.rs:90:52 [INFO] [stderr] | [INFO] [stderr] 90 | fn read_to_buf(&mut self, buffer: &mut BytesMut, size: usize) -> ClientResult { [INFO] [stderr] | ^^^^ help: consider using `_size` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fd` [INFO] [stderr] --> src/storage.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | let fd = self.file.as_raw_fd(); [INFO] [stderr] | ^^ help: consider using `_fd` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/network/handler.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | if let Ok((stream, addr)) = self.tcp_listener.accept() { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/storage.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | if let Ok(mut file) = OpenOptions::new().read(true).write(true).create(true).open(filename) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/storage.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | let mut sl: &mut[u8] = unsafe { from_raw_parts_mut(mm.as_mut_ptr(), mm.len()) }; [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `from_int` [INFO] [stderr] --> src/parser/errors.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn from_int(code: u32) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Request` [INFO] [stderr] --> src/storage.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub type Request = u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Response` [INFO] [stderr] --> src/storage.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub type Response = u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `filename` [INFO] [stderr] --> src/storage.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | filename: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `storage` [INFO] [stderr] --> src/storage.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn storage(out:&Sender, name: &str) -> Sender { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Message` [INFO] [stderr] --> src/network/handler.rs:149:1 [INFO] [stderr] | [INFO] [stderr] 149 | pub enum Message { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `monitor` [INFO] [stderr] --> src/util.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub fn monitor(f: F, restart_count: u8) -> Result [INFO] [stderr] 5 | | where F: Fn() -> R + Send + 'static { [INFO] [stderr] 6 | | [INFO] [stderr] 7 | | thread::spawn( move || { [INFO] [stderr] ... | [INFO] [stderr] 10 | | Err(0) [INFO] [stderr] 11 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/primitive.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn kafka_bytes<'a>(input:&'a [u8]) -> IResult<&'a [u8], KafkaBytes<'a>> { [INFO] [stderr] 31 | | match be_i32(input) { [INFO] [stderr] 32 | | Done(i, length) => { [INFO] [stderr] 33 | | if length >= 0 { [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/primitive.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn kafka_bytestring<'a>(input:&'a [u8]) -> IResult<&'a [u8], &'a [u8]> { [INFO] [stderr] 52 | | match be_i16(input) { [INFO] [stderr] 53 | | Done(i, length) => { [INFO] [stderr] 54 | | if length >= 0 { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/primitive.rs:72:1 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn kafka_string<'a>(input:&'a [u8]) -> IResult<&'a [u8], KafkaString<'a>> { [INFO] [stderr] 73 | | map_res!(input, kafka_bytestring, |bs| { [INFO] [stderr] 74 | | str::from_utf8(bs) [INFO] [stderr] 75 | | }) [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/request.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn parse_request_payload<'a>(input:&'a [u8], api_version: i16, api_key: i16) -> IResult<&'a [u8], RequestPayload<'a>> { [INFO] [stderr] 40 | | match api_key { [INFO] [stderr] 41 | | 0 => map!(input, produce_request, |p| { RequestPayload::ProduceRequest(p) }), [INFO] [stderr] 42 | | 1 => map!(input, fetch_request, |p| { RequestPayload::FetchRequest(p) }), [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/request.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn request_message<'a>(input:&'a [u8]) -> IResult<&'a [u8], RequestMessage<'a>> { [INFO] [stderr] 89 | | do_parse!( [INFO] [stderr] 90 | | input, [INFO] [stderr] 91 | | key: be_i16 >> [INFO] [stderr] ... | [INFO] [stderr] 105 | | ) [INFO] [stderr] 106 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/produce.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn produce_request<'a>(input:&'a [u8]) -> IResult<&'a [u8], ProduceRequest<'a>> { [INFO] [stderr] 19 | | do_parse!( [INFO] [stderr] 20 | | input, [INFO] [stderr] 21 | | required_acks: be_i16 >> [INFO] [stderr] ... | [INFO] [stderr] 31 | | ) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/message.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn topic_message_set<'a>(input: &'a [u8]) -> IResult<&'a [u8], TopicMessageSet<'a>> { [INFO] [stderr] 21 | | do_parse!( [INFO] [stderr] 22 | | input, [INFO] [stderr] 23 | | topic_name: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 31 | | ) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/message.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn partition_message_set<'a>(input: &'a [u8]) -> IResult<&'a [u8], PartitionMessageSet<'a>> { [INFO] [stderr] 41 | | do_parse!( [INFO] [stderr] 42 | | input, [INFO] [stderr] 43 | | partition: be_i32 >> [INFO] [stderr] ... | [INFO] [stderr] 52 | | ) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/message.rs:69:1 [INFO] [stderr] | [INFO] [stderr] 69 | / pub fn message_set_message<'a>(input: &'a [u8]) -> IResult<&'a [u8], MessageSet<'a>> { [INFO] [stderr] 70 | | do_parse!( [INFO] [stderr] 71 | | input, [INFO] [stderr] 72 | | m: o_ms_message >> [INFO] [stderr] ... | [INFO] [stderr] 79 | | ) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/message.rs:82:1 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn message_set_messages<'a>(input: &'a [u8]) -> IResult<&'a [u8], MessageSet<'a>> { [INFO] [stderr] 83 | | alt!(input, [INFO] [stderr] 84 | | eof!() => { |_| vec![] } [INFO] [stderr] 85 | | | message_set_message) [INFO] [stderr] 86 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/message.rs:94:1 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn o_ms_message<'a>(input: &'a [u8]) -> IResult<&'a [u8], OMsMessage<'a>> { [INFO] [stderr] 95 | | do_parse!( [INFO] [stderr] 96 | | input, [INFO] [stderr] 97 | | offset: be_i64 >> [INFO] [stderr] ... | [INFO] [stderr] 106 | | ) [INFO] [stderr] 107 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/fetch.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn fetch_request<'a>(input:&'a [u8]) -> IResult<&'a [u8], FetchRequest<'a>> { [INFO] [stderr] 19 | | do_parse!( [INFO] [stderr] 20 | | input, [INFO] [stderr] 21 | | replica_id: be_i32 >> [INFO] [stderr] ... | [INFO] [stderr] 33 | | ) [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/fetch.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn topic_fetch<'a>(input:&'a [u8]) -> IResult<&'a [u8], TopicFetch<'a>> { [INFO] [stderr] 43 | | do_parse!( [INFO] [stderr] 44 | | input, [INFO] [stderr] 45 | | topic_name: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 53 | | ) [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/fetch.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn partition_fetch<'a>(input:&'a [u8]) -> IResult<&'a [u8], PartitionFetch> { [INFO] [stderr] 64 | | do_parse!( [INFO] [stderr] 65 | | input, [INFO] [stderr] 66 | | partition: be_i32 >> [INFO] [stderr] ... | [INFO] [stderr] 76 | | ) [INFO] [stderr] 77 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn offset_request<'a>(input:&'a [u8]) -> IResult<&'a [u8], OffsetRequest<'a>> { [INFO] [stderr] 18 | | do_parse!( [INFO] [stderr] 19 | | input, [INFO] [stderr] 20 | | replica_id: be_i32 >> [INFO] [stderr] ... | [INFO] [stderr] 28 | | ) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn topic_offset<'a>(input:&'a [u8]) -> IResult<&'a [u8], TopicOffset<'a>> { [INFO] [stderr] 38 | | do_parse!( [INFO] [stderr] 39 | | input, [INFO] [stderr] 40 | | topic_name: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 48 | | ) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn partition_offset<'a>(input:&'a [u8]) -> IResult<&'a [u8], PartitionOffset> { [INFO] [stderr] 59 | | do_parse!( [INFO] [stderr] 60 | | input, [INFO] [stderr] 61 | | partition: be_i32 >> [INFO] [stderr] ... | [INFO] [stderr] 71 | | ) [INFO] [stderr] 72 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/metadata.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn topic_metadata_request<'a>(input:&'a [u8]) -> IResult<&'a [u8], TopicMetadataRequest<'a>> { [INFO] [stderr] 13 | | kafka_array(input, kafka_string) [INFO] [stderr] 14 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_commit.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn offset_commit_request<'a>(input:&'a [u8], api_version: i16) -> IResult<&'a [u8], OffsetCommitRequest<'a>> { [INFO] [stderr] 21 | | match api_version { [INFO] [stderr] 22 | | 0 => map!(input, offset_commit_request_v0, |p| { OffsetCommitRequest::V0(p) }), [INFO] [stderr] 23 | | 1 => map!(input, offset_commit_request_v1, |p| { OffsetCommitRequest::V1(p) }), [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_commit.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn offset_commit_request_v0<'a>(input:&'a [u8]) -> IResult<&'a [u8], OffsetCommitRequestV0<'a>> { [INFO] [stderr] 37 | | do_parse!( [INFO] [stderr] 38 | | input, [INFO] [stderr] 39 | | consumer_group: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 47 | | ) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_commit.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / pub fn topic_offset_commit_v0<'a>(input:&'a [u8]) -> IResult<&'a [u8], TopicOffsetCommitV0<'a>> { [INFO] [stderr] 57 | | do_parse!( [INFO] [stderr] 58 | | input, [INFO] [stderr] 59 | | topic_name: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 67 | | ) [INFO] [stderr] 68 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_commit.rs:102:1 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn offset_commit_request_v1<'a>(input:&'a [u8]) -> IResult<&'a [u8], OffsetCommitRequestV1<'a>> { [INFO] [stderr] 103 | | do_parse!( [INFO] [stderr] 104 | | input, [INFO] [stderr] 105 | | consumer_group: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 117 | | ) [INFO] [stderr] 118 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_commit.rs:126:1 [INFO] [stderr] | [INFO] [stderr] 126 | / pub fn topic_offset_commit_v1<'a>(input:&'a [u8]) -> IResult<&'a [u8], TopicOffsetCommitV1<'a>> { [INFO] [stderr] 127 | | do_parse!( [INFO] [stderr] 128 | | input, [INFO] [stderr] 129 | | topic_name: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 137 | | ) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_commit.rs:176:1 [INFO] [stderr] | [INFO] [stderr] 176 | / pub fn offset_commit_request_v2<'a>(input:&'a [u8]) -> IResult<&'a [u8], OffsetCommitRequestV2<'a>> { [INFO] [stderr] 177 | | do_parse!( [INFO] [stderr] 178 | | input, [INFO] [stderr] 179 | | consumer_group: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 193 | | ) [INFO] [stderr] 194 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_fetch.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn offset_fetch_request<'a>(input:&'a [u8]) -> IResult<&'a [u8], OffsetFetchRequest<'a>> { [INFO] [stderr] 17 | | do_parse!( [INFO] [stderr] 18 | | input, [INFO] [stderr] 19 | | consumer_group: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 27 | | ) [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_fetch.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn topic_offset_fetch<'a>(input:&'a [u8]) -> IResult<&'a [u8], TopicOffsetFetch<'a>> { [INFO] [stderr] 37 | | do_parse!( [INFO] [stderr] 38 | | input, [INFO] [stderr] 39 | | topic_name: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 47 | | ) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_fetch.rs:55:1 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn partition_offset_fetch<'a>(input:&'a [u8]) -> IResult<&'a [u8], PartitionOffsetFetch> { [INFO] [stderr] 56 | | map!(input, be_i32, |p| { PartitionOffsetFetch { partition: p } }) [INFO] [stderr] 57 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/consumer_metadata.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn consumer_metadata_request<'a>(input:&'a [u8]) -> IResult<&'a [u8], ConsumerMetadataRequest<'a>> { [INFO] [stderr] 13 | | kafka_string(input) [INFO] [stderr] 14 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/storage.rs:33:11 [INFO] [stderr] | [INFO] [stderr] 33 | file.set_len(4096); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/storage.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | self.file.set_len((self.size + 4096) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/storage.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | self.size = self.size + 4096; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.size += 4096` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/storage.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | t2.send(network::handler::Message::Data(v.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/network/kafka.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | self.write(&v[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/network/handler.rs:176:40 [INFO] [stderr] | [INFO] [stderr] 176 | tcp_listener: TcpListener::bind(&addr.into()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused label `'main` [INFO] [stderr] --> src/network/handler.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | / 'main: loop { [INFO] [stderr] 190 | | self.poll.poll(&mut events, None).unwrap(); [INFO] [stderr] 191 | | [INFO] [stderr] 192 | | for event in events.iter() { [INFO] [stderr] ... | [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/network/handler.rs:223:7 [INFO] [stderr] | [INFO] [stderr] 223 | self.poll.register(&stream, token, Ready::all(), PollOpt::edge()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/network/handler.rs:324:7 [INFO] [stderr] | [INFO] [stderr] 324 | self.poll.deregister(client.socket()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/responses/primitive.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn ser_i8<'a>(v: i8, output: &mut Vec) -> () { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/responses/primitive.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn ser_i16<'a>(v: i16, output: &mut Vec) -> () { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/responses/primitive.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn ser_i32<'a>(v: i32, output: &mut Vec) -> () { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/responses/primitive.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn ser_i32_ref<'a>(v: &i32, output: &mut Vec) -> () { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/responses/primitive.rs:31:27 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn ser_i32_ref<'a>(v: &i32, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/responses/primitive.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn ser_i64<'a>(v: i64, output: &mut Vec) -> () { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/responses/primitive.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn ser_i64_ref<'a>(v: &i64, output: &mut Vec) -> () { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/responses/primitive.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn ser_i64_ref<'a>(v: &i64, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/responses/primitive.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn ser_kafka_array(elems: &Vec, closure: F, output: &mut Vec) -> () [INFO] [stderr] | ^^^^^^^ help: change this to: `&[O]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/responses/primitive.rs:71:56 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn ser_kafka_array_without_size_prefix(elems: &Vec, closure: F, output: &mut Vec) -> () [INFO] [stderr] | ^^^^^^^ help: change this to: `&[O]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/responses/produce.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn ser_produce_response<'a>(r: &ProduceResponse<'a>, o: &mut Vec) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/responses/fetch.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn ser_message_set(message_set: &MessageSet, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | jg.join(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/primitive.rs:36:11 [INFO] [stderr] | [INFO] [stderr] 36 | return Done(&i[sz..], &i[0..sz]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Done(&i[sz..], &i[0..sz])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/primitive.rs:38:11 [INFO] [stderr] | [INFO] [stderr] 38 | return Incomplete(Needed::Size(length as usize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Incomplete(Needed::Size(length as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/primitive.rs:57:11 [INFO] [stderr] | [INFO] [stderr] 57 | return Done(&i[sz..], &i[0..sz]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Done(&i[sz..], &i[0..sz])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/primitive.rs:59:11 [INFO] [stderr] | [INFO] [stderr] 59 | return Incomplete(Needed::Size(length as usize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Incomplete(Needed::Size(length as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BufMut`, `BytesMut` [INFO] [stderr] --> src/network/kafka.rs:3:13 [INFO] [stderr] | [INFO] [stderr] 3 | use bytes::{BytesMut, BufMut}; [INFO] [stderr] | ^^^^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `responses::metadata::*` [INFO] [stderr] --> src/network/handler.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use responses::metadata::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `responses::response::*` [INFO] [stderr] --> src/network/handler.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use responses::response::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/network/handler.rs:263:20 [INFO] [stderr] | [INFO] [stderr] 263 | else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 264 | | if let ClientErr::ShouldClose = client.handle_message(&mut buffer) { [INFO] [stderr] 265 | | error = true; [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 263 | else if let ClientErr::ShouldClose = client.handle_message(&mut buffer) { [INFO] [stderr] 264 | error = true; [INFO] [stderr] 265 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/network/handler.rs:290:16 [INFO] [stderr] | [INFO] [stderr] 290 | else { [INFO] [stderr] | ________________^ [INFO] [stderr] 291 | | if let ClientErr::ShouldClose = client.handle_message(&mut buffer) { [INFO] [stderr] 292 | | error = true; [INFO] [stderr] 293 | | } [INFO] [stderr] 294 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 290 | else if let ClientErr::ShouldClose = client.handle_message(&mut buffer) { [INFO] [stderr] 291 | error = true; [INFO] [stderr] 292 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/response.rs:39:78 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn ser_response_message(response: ResponseMessage, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:13:48 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn ser_i8<'a>(v: i8, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn ser_i16<'a>(v: i16, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:23:50 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn ser_i32<'a>(v: i32, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:31:55 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn ser_i32_ref<'a>(v: &i32, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:35:50 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn ser_i64<'a>(v: i64, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:47:55 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn ser_i64_ref<'a>(v: &i64, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:51:62 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn ser_kafka_bytes(bs: KafkaBytes, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:57:68 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn ser_kafka_string(string: KafkaString, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:65:79 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn ser_kafka_array(elems: &Vec, closure: F, output: &mut Vec) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/primitive.rs:71:99 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn ser_kafka_array_without_size_prefix(elems: &Vec, closure: F, output: &mut Vec) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/responses/primitive.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | ser_i32(2147483647_i32, &mut v); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `2_147_483_647_i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/responses/primitive.rs:112:14 [INFO] [stderr] | [INFO] [stderr] 112 | ser_i32(-2147483648_i32, &mut v); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `2_147_483_648_i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/responses/primitive.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | ser_i64(9223372036854775807_i64, &mut v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807_i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/responses/primitive.rs:122:14 [INFO] [stderr] | [INFO] [stderr] 122 | ser_i64(-9223372036854775808_i64, &mut v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808_i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/consumer_metadata.rs:20:98 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn ser_consumer_metadata_response<'a>(r: ConsumerMetadataResponse<'a>, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/produce.rs:21:75 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn ser_produce_response<'a>(r: &ProduceResponse<'a>, o: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/metadata.rs:58:77 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn ser_metadata_response<'a>(r: &MetadataResponse<'a>, o: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/metadata.rs:63:56 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn ser_broker<'a>(b: &Broker<'a>, o: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/metadata.rs:69:72 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn ser_topic_metadata<'a>(tm: &TopicMetadata<'a>, o: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/metadata.rs:75:72 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn ser_partition_metadata(pm: &PartitionMetadata, o: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/fetch.rs:26:74 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn ser_fetch_response(response: FetchResponse, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/fetch.rs:44:72 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn ser_message_set(message_set: &MessageSet, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/fetch.rs:56:61 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn ser_message(message: &Message, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/offset.rs:22:77 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn ser_offset_response<'a>(r: OffsetResponse<'a>, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/offset_commit.rs:21:90 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn ser_offset_commit_response<'a>(r: OffsetCommitResponse<'a>, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/responses/offset_fetch.rs:23:88 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn ser_offset_fetch_response<'a>(r: OffsetFetchResponse<'a>, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Ready::all': removed [INFO] [stderr] --> src/network/handler.rs:223:42 [INFO] [stderr] | [INFO] [stderr] 223 | self.poll.register(&stream, token, Ready::all(), PollOpt::edge()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/storage.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | if let Ok(count) = rx.recv() { [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/storage.rs:88:56 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn storage(out:&Sender, name: &str) -> Sender { [INFO] [stderr] | ^^^^ help: consider using `_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `restart_count` [INFO] [stderr] --> src/util.rs:4:28 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn monitor(f: F, restart_count: u8) -> Result [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_restart_count` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/proust.rs:31:38 [INFO] [stderr] | [INFO] [stderr] 31 | RequestPayload::ProduceRequest(x) => { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/network/handler.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | Done(buf, size) => Ok(size as usize), [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `size` [INFO] [stderr] --> src/network/handler.rs:90:52 [INFO] [stderr] | [INFO] [stderr] 90 | fn read_to_buf(&mut self, buffer: &mut BytesMut, size: usize) -> ClientResult { [INFO] [stderr] | ^^^^ help: consider using `_size` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fd` [INFO] [stderr] --> src/storage.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | let fd = self.file.as_raw_fd(); [INFO] [stderr] | ^^ help: consider using `_fd` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/network/handler.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | if let Ok((stream, addr)) = self.tcp_listener.accept() { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/storage.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | if let Ok(mut file) = OpenOptions::new().read(true).write(true).create(true).open(filename) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/storage.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | let mut sl: &mut[u8] = unsafe { from_raw_parts_mut(mm.as_mut_ptr(), mm.len()) }; [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `from_int` [INFO] [stderr] --> src/parser/errors.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn from_int(code: u32) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Request` [INFO] [stderr] --> src/storage.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub type Request = u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Response` [INFO] [stderr] --> src/storage.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub type Response = u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `filename` [INFO] [stderr] --> src/storage.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | filename: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `storage` [INFO] [stderr] --> src/storage.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn storage(out:&Sender, name: &str) -> Sender { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Message` [INFO] [stderr] --> src/network/handler.rs:149:1 [INFO] [stderr] | [INFO] [stderr] 149 | pub enum Message { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `monitor` [INFO] [stderr] --> src/util.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub fn monitor(f: F, restart_count: u8) -> Result [INFO] [stderr] 5 | | where F: Fn() -> R + Send + 'static { [INFO] [stderr] 6 | | [INFO] [stderr] 7 | | thread::spawn( move || { [INFO] [stderr] ... | [INFO] [stderr] 10 | | Err(0) [INFO] [stderr] 11 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/primitive.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn kafka_bytes<'a>(input:&'a [u8]) -> IResult<&'a [u8], KafkaBytes<'a>> { [INFO] [stderr] 31 | | match be_i32(input) { [INFO] [stderr] 32 | | Done(i, length) => { [INFO] [stderr] 33 | | if length >= 0 { [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/primitive.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn kafka_bytestring<'a>(input:&'a [u8]) -> IResult<&'a [u8], &'a [u8]> { [INFO] [stderr] 52 | | match be_i16(input) { [INFO] [stderr] 53 | | Done(i, length) => { [INFO] [stderr] 54 | | if length >= 0 { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/primitive.rs:72:1 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn kafka_string<'a>(input:&'a [u8]) -> IResult<&'a [u8], KafkaString<'a>> { [INFO] [stderr] 73 | | map_res!(input, kafka_bytestring, |bs| { [INFO] [stderr] 74 | | str::from_utf8(bs) [INFO] [stderr] 75 | | }) [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/request.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn parse_request_payload<'a>(input:&'a [u8], api_version: i16, api_key: i16) -> IResult<&'a [u8], RequestPayload<'a>> { [INFO] [stderr] 40 | | match api_key { [INFO] [stderr] 41 | | 0 => map!(input, produce_request, |p| { RequestPayload::ProduceRequest(p) }), [INFO] [stderr] 42 | | 1 => map!(input, fetch_request, |p| { RequestPayload::FetchRequest(p) }), [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/request.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn request_message<'a>(input:&'a [u8]) -> IResult<&'a [u8], RequestMessage<'a>> { [INFO] [stderr] 89 | | do_parse!( [INFO] [stderr] 90 | | input, [INFO] [stderr] 91 | | key: be_i16 >> [INFO] [stderr] ... | [INFO] [stderr] 105 | | ) [INFO] [stderr] 106 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/produce.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn produce_request<'a>(input:&'a [u8]) -> IResult<&'a [u8], ProduceRequest<'a>> { [INFO] [stderr] 19 | | do_parse!( [INFO] [stderr] 20 | | input, [INFO] [stderr] 21 | | required_acks: be_i16 >> [INFO] [stderr] ... | [INFO] [stderr] 31 | | ) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/message.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn topic_message_set<'a>(input: &'a [u8]) -> IResult<&'a [u8], TopicMessageSet<'a>> { [INFO] [stderr] 21 | | do_parse!( [INFO] [stderr] 22 | | input, [INFO] [stderr] 23 | | topic_name: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 31 | | ) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/message.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn partition_message_set<'a>(input: &'a [u8]) -> IResult<&'a [u8], PartitionMessageSet<'a>> { [INFO] [stderr] 41 | | do_parse!( [INFO] [stderr] 42 | | input, [INFO] [stderr] 43 | | partition: be_i32 >> [INFO] [stderr] ... | [INFO] [stderr] 52 | | ) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/message.rs:69:1 [INFO] [stderr] | [INFO] [stderr] 69 | / pub fn message_set_message<'a>(input: &'a [u8]) -> IResult<&'a [u8], MessageSet<'a>> { [INFO] [stderr] 70 | | do_parse!( [INFO] [stderr] 71 | | input, [INFO] [stderr] 72 | | m: o_ms_message >> [INFO] [stderr] ... | [INFO] [stderr] 79 | | ) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/message.rs:82:1 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn message_set_messages<'a>(input: &'a [u8]) -> IResult<&'a [u8], MessageSet<'a>> { [INFO] [stderr] 83 | | alt!(input, [INFO] [stderr] 84 | | eof!() => { |_| vec![] } [INFO] [stderr] 85 | | | message_set_message) [INFO] [stderr] 86 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/message.rs:94:1 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn o_ms_message<'a>(input: &'a [u8]) -> IResult<&'a [u8], OMsMessage<'a>> { [INFO] [stderr] 95 | | do_parse!( [INFO] [stderr] 96 | | input, [INFO] [stderr] 97 | | offset: be_i64 >> [INFO] [stderr] ... | [INFO] [stderr] 106 | | ) [INFO] [stderr] 107 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/fetch.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn fetch_request<'a>(input:&'a [u8]) -> IResult<&'a [u8], FetchRequest<'a>> { [INFO] [stderr] 19 | | do_parse!( [INFO] [stderr] 20 | | input, [INFO] [stderr] 21 | | replica_id: be_i32 >> [INFO] [stderr] ... | [INFO] [stderr] 33 | | ) [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/fetch.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn topic_fetch<'a>(input:&'a [u8]) -> IResult<&'a [u8], TopicFetch<'a>> { [INFO] [stderr] 43 | | do_parse!( [INFO] [stderr] 44 | | input, [INFO] [stderr] 45 | | topic_name: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 53 | | ) [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/fetch.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn partition_fetch<'a>(input:&'a [u8]) -> IResult<&'a [u8], PartitionFetch> { [INFO] [stderr] 64 | | do_parse!( [INFO] [stderr] 65 | | input, [INFO] [stderr] 66 | | partition: be_i32 >> [INFO] [stderr] ... | [INFO] [stderr] 76 | | ) [INFO] [stderr] 77 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn offset_request<'a>(input:&'a [u8]) -> IResult<&'a [u8], OffsetRequest<'a>> { [INFO] [stderr] 18 | | do_parse!( [INFO] [stderr] 19 | | input, [INFO] [stderr] 20 | | replica_id: be_i32 >> [INFO] [stderr] ... | [INFO] [stderr] 28 | | ) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn topic_offset<'a>(input:&'a [u8]) -> IResult<&'a [u8], TopicOffset<'a>> { [INFO] [stderr] 38 | | do_parse!( [INFO] [stderr] 39 | | input, [INFO] [stderr] 40 | | topic_name: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 48 | | ) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn partition_offset<'a>(input:&'a [u8]) -> IResult<&'a [u8], PartitionOffset> { [INFO] [stderr] 59 | | do_parse!( [INFO] [stderr] 60 | | input, [INFO] [stderr] 61 | | partition: be_i32 >> [INFO] [stderr] ... | [INFO] [stderr] 71 | | ) [INFO] [stderr] 72 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/metadata.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn topic_metadata_request<'a>(input:&'a [u8]) -> IResult<&'a [u8], TopicMetadataRequest<'a>> { [INFO] [stderr] 13 | | kafka_array(input, kafka_string) [INFO] [stderr] 14 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_commit.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn offset_commit_request<'a>(input:&'a [u8], api_version: i16) -> IResult<&'a [u8], OffsetCommitRequest<'a>> { [INFO] [stderr] 21 | | match api_version { [INFO] [stderr] 22 | | 0 => map!(input, offset_commit_request_v0, |p| { OffsetCommitRequest::V0(p) }), [INFO] [stderr] 23 | | 1 => map!(input, offset_commit_request_v1, |p| { OffsetCommitRequest::V1(p) }), [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_commit.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn offset_commit_request_v0<'a>(input:&'a [u8]) -> IResult<&'a [u8], OffsetCommitRequestV0<'a>> { [INFO] [stderr] 37 | | do_parse!( [INFO] [stderr] 38 | | input, [INFO] [stderr] 39 | | consumer_group: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 47 | | ) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_commit.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / pub fn topic_offset_commit_v0<'a>(input:&'a [u8]) -> IResult<&'a [u8], TopicOffsetCommitV0<'a>> { [INFO] [stderr] 57 | | do_parse!( [INFO] [stderr] 58 | | input, [INFO] [stderr] 59 | | topic_name: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 67 | | ) [INFO] [stderr] 68 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_commit.rs:102:1 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn offset_commit_request_v1<'a>(input:&'a [u8]) -> IResult<&'a [u8], OffsetCommitRequestV1<'a>> { [INFO] [stderr] 103 | | do_parse!( [INFO] [stderr] 104 | | input, [INFO] [stderr] 105 | | consumer_group: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 117 | | ) [INFO] [stderr] 118 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_commit.rs:126:1 [INFO] [stderr] | [INFO] [stderr] 126 | / pub fn topic_offset_commit_v1<'a>(input:&'a [u8]) -> IResult<&'a [u8], TopicOffsetCommitV1<'a>> { [INFO] [stderr] 127 | | do_parse!( [INFO] [stderr] 128 | | input, [INFO] [stderr] 129 | | topic_name: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 137 | | ) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_commit.rs:176:1 [INFO] [stderr] | [INFO] [stderr] 176 | / pub fn offset_commit_request_v2<'a>(input:&'a [u8]) -> IResult<&'a [u8], OffsetCommitRequestV2<'a>> { [INFO] [stderr] 177 | | do_parse!( [INFO] [stderr] 178 | | input, [INFO] [stderr] 179 | | consumer_group: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 193 | | ) [INFO] [stderr] 194 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_fetch.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn offset_fetch_request<'a>(input:&'a [u8]) -> IResult<&'a [u8], OffsetFetchRequest<'a>> { [INFO] [stderr] 17 | | do_parse!( [INFO] [stderr] 18 | | input, [INFO] [stderr] 19 | | consumer_group: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 27 | | ) [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_fetch.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn topic_offset_fetch<'a>(input:&'a [u8]) -> IResult<&'a [u8], TopicOffsetFetch<'a>> { [INFO] [stderr] 37 | | do_parse!( [INFO] [stderr] 38 | | input, [INFO] [stderr] 39 | | topic_name: kafka_string >> [INFO] [stderr] ... | [INFO] [stderr] 47 | | ) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/offset_fetch.rs:55:1 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn partition_offset_fetch<'a>(input:&'a [u8]) -> IResult<&'a [u8], PartitionOffsetFetch> { [INFO] [stderr] 56 | | map!(input, be_i32, |p| { PartitionOffsetFetch { partition: p } }) [INFO] [stderr] 57 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/consumer_metadata.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn consumer_metadata_request<'a>(input:&'a [u8]) -> IResult<&'a [u8], ConsumerMetadataRequest<'a>> { [INFO] [stderr] 13 | | kafka_string(input) [INFO] [stderr] 14 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/storage.rs:33:11 [INFO] [stderr] | [INFO] [stderr] 33 | file.set_len(4096); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/storage.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | self.file.set_len((self.size + 4096) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/storage.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | self.size = self.size + 4096; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.size += 4096` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/storage.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | t2.send(network::handler::Message::Data(v.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/network/kafka.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | self.write(&v[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/network/handler.rs:176:40 [INFO] [stderr] | [INFO] [stderr] 176 | tcp_listener: TcpListener::bind(&addr.into()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused label `'main` [INFO] [stderr] --> src/network/handler.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | / 'main: loop { [INFO] [stderr] 190 | | self.poll.poll(&mut events, None).unwrap(); [INFO] [stderr] 191 | | [INFO] [stderr] 192 | | for event in events.iter() { [INFO] [stderr] ... | [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/network/handler.rs:223:7 [INFO] [stderr] | [INFO] [stderr] 223 | self.poll.register(&stream, token, Ready::all(), PollOpt::edge()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/network/handler.rs:324:7 [INFO] [stderr] | [INFO] [stderr] 324 | self.poll.deregister(client.socket()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/responses/primitive.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn ser_i8<'a>(v: i8, output: &mut Vec) -> () { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/responses/primitive.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn ser_i16<'a>(v: i16, output: &mut Vec) -> () { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/responses/primitive.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn ser_i32<'a>(v: i32, output: &mut Vec) -> () { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/responses/primitive.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn ser_i32_ref<'a>(v: &i32, output: &mut Vec) -> () { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/responses/primitive.rs:31:27 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn ser_i32_ref<'a>(v: &i32, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/responses/primitive.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn ser_i64<'a>(v: i64, output: &mut Vec) -> () { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/responses/primitive.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn ser_i64_ref<'a>(v: &i64, output: &mut Vec) -> () { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/responses/primitive.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn ser_i64_ref<'a>(v: &i64, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/responses/primitive.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn ser_kafka_array(elems: &Vec, closure: F, output: &mut Vec) -> () [INFO] [stderr] | ^^^^^^^ help: change this to: `&[O]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/responses/primitive.rs:71:56 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn ser_kafka_array_without_size_prefix(elems: &Vec, closure: F, output: &mut Vec) -> () [INFO] [stderr] | ^^^^^^^ help: change this to: `&[O]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/responses/produce.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn ser_produce_response<'a>(r: &ProduceResponse<'a>, o: &mut Vec) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/responses/fetch.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn ser_message_set(message_set: &MessageSet, output: &mut Vec) -> () { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | jg.join(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.66s [INFO] running `"docker" "inspect" "43dd0a0c2e33fefc487017fdffa70fbc35df1cb76f4b10a8025511599450e87e"` [INFO] running `"docker" "rm" "-f" "43dd0a0c2e33fefc487017fdffa70fbc35df1cb76f4b10a8025511599450e87e"` [INFO] [stdout] 43dd0a0c2e33fefc487017fdffa70fbc35df1cb76f4b10a8025511599450e87e