[INFO] updating cached repository GChicha/RustBoy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/GChicha/RustBoy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/GChicha/RustBoy" "work/ex/clippy-test-run/sources/stable/gh/GChicha/RustBoy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/GChicha/RustBoy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/GChicha/RustBoy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GChicha/RustBoy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GChicha/RustBoy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0fbe3b6d145b6083bd2cebdd3fcca00631c21112 [INFO] sha for GitHub repo GChicha/RustBoy: 0fbe3b6d145b6083bd2cebdd3fcca00631c21112 [INFO] validating manifest of GChicha/RustBoy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of GChicha/RustBoy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing GChicha/RustBoy [INFO] finished frobbing GChicha/RustBoy [INFO] frobbed toml for GChicha/RustBoy written to work/ex/clippy-test-run/sources/stable/gh/GChicha/RustBoy/Cargo.toml [INFO] started frobbing GChicha/RustBoy [INFO] finished frobbing GChicha/RustBoy [INFO] frobbed toml for GChicha/RustBoy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GChicha/RustBoy/Cargo.toml [INFO] crate GChicha/RustBoy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting GChicha/RustBoy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/GChicha/RustBoy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 987f4d8e16b61c92ab208c61cb1569da56b3521e2e886fdff3c382743f9a18e1 [INFO] running `"docker" "start" "-a" "987f4d8e16b61c92ab208c61cb1569da56b3521e2e886fdff3c382743f9a18e1"` [INFO] [stderr] Checking tempfile v3.0.2 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling glium v0.20.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking glutin v0.12.2 [INFO] [stderr] Checking gb_emulator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | let mut events_loop = glutin::EventsLoop::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | let mut events_loop = glutin::EventsLoop::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rom_size` [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | let rom_size = match rom_file.read_to_end(&mut rom) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_rom_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `C` [INFO] [stderr] --> src/cpu.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | C, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RegisterAddressU16` [INFO] [stderr] --> src/cpu.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | RegisterAddressU16(Register), // Decay to AddressU16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | Register::A => cpu.a as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:76:28 [INFO] [stderr] | [INFO] [stderr] 76 | Register::B => cpu.b as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:77:28 [INFO] [stderr] | [INFO] [stderr] 77 | Register::C => cpu.c as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:78:28 [INFO] [stderr] | [INFO] [stderr] 78 | Register::D => cpu.d as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:79:28 [INFO] [stderr] | [INFO] [stderr] 79 | Register::E => cpu.e as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:80:28 [INFO] [stderr] | [INFO] [stderr] 80 | Register::H => cpu.h as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | Register::L => cpu.l as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:82:52 [INFO] [stderr] | [INFO] [stderr] 82 | Register::BC => ((cpu.b as u16) << 8 | (cpu.c as u8) as u16) as i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((cpu.c as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:83:52 [INFO] [stderr] | [INFO] [stderr] 83 | Register::HL => ((cpu.h as u16) << 8 | (cpu.l as u8) as u16) as i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((cpu.l as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:84:52 [INFO] [stderr] | [INFO] [stderr] 84 | Register::DE => ((cpu.d as u16) << 8 | (cpu.e as u8) as u16) as i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((cpu.e as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | cpu.memory.get_byte(*address).unwrap() as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(cpu.memory.get_byte(*address).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:165:18 [INFO] [stderr] | [INFO] [stderr] 165 | ((cpu.pc as i32) + by as i32) as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(cpu.pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:165:36 [INFO] [stderr] | [INFO] [stderr] 165 | ((cpu.pc as i32) + by as i32) as i16 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(by)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu.rs:283:31 [INFO] [stderr] | [INFO] [stderr] 283 | fn decode(opcode: u8, pc: &u16) -> (Instructions, u8) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `::decode` doesn't need a mutable reference [INFO] [stderr] --> src/cpu.rs:515:48 [INFO] [stderr] | [INFO] [stderr] 515 | Instructions::decode(opcode as u8, &mut self.pc); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:517:20 [INFO] [stderr] | [INFO] [stderr] 517 | self.pc += size as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: literal out of range for i8 [INFO] [stderr] --> src/cpu.rs:529:16 [INFO] [stderr] | [INFO] [stderr] 529 | e: 0xD8, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] = note: the literal `0xD8` (decimal `216`) does not fit into an `i8` and will become `-40i8` [INFO] [stderr] = help: consider using `u8` instead [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/memory.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | if address <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using address == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:59:46 [INFO] [stderr] | [INFO] [stderr] 59 | let data = (((m_data as u16) << 8) | (l_data as u8) as u16) as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((l_data as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:68:38 [INFO] [stderr] | [INFO] [stderr] 68 | events_loop.poll_events(|ev| match ev { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 69 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 70 | | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 71 | | _ => (), [INFO] [stderr] 72 | | }, [INFO] [stderr] 73 | | _ => (), [INFO] [stderr] 74 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | events_loop.poll_events(|ev| if let glutin::Event::WindowEvent { event, .. } = ev { match event { [INFO] [stderr] 69 | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 70 | _ => (), [INFO] [stderr] 71 | } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:69:57 [INFO] [stderr] | [INFO] [stderr] 69 | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 70 | | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 71 | | _ => (), [INFO] [stderr] 72 | | }, [INFO] [stderr] | |_____________^ help: try this: `if let glutin::WindowEvent::Closed = event { closed = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gb_emulator`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `rom_size` [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | let rom_size = match rom_file.read_to_end(&mut rom) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_rom_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `C` [INFO] [stderr] --> src/cpu.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | C, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RegisterAddressU16` [INFO] [stderr] --> src/cpu.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | RegisterAddressU16(Register), // Decay to AddressU16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | Register::A => cpu.a as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:76:28 [INFO] [stderr] | [INFO] [stderr] 76 | Register::B => cpu.b as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:77:28 [INFO] [stderr] | [INFO] [stderr] 77 | Register::C => cpu.c as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:78:28 [INFO] [stderr] | [INFO] [stderr] 78 | Register::D => cpu.d as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:79:28 [INFO] [stderr] | [INFO] [stderr] 79 | Register::E => cpu.e as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:80:28 [INFO] [stderr] | [INFO] [stderr] 80 | Register::H => cpu.h as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | Register::L => cpu.l as i16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(cpu.l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:82:52 [INFO] [stderr] | [INFO] [stderr] 82 | Register::BC => ((cpu.b as u16) << 8 | (cpu.c as u8) as u16) as i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((cpu.c as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:83:52 [INFO] [stderr] | [INFO] [stderr] 83 | Register::HL => ((cpu.h as u16) << 8 | (cpu.l as u8) as u16) as i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((cpu.l as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:84:52 [INFO] [stderr] | [INFO] [stderr] 84 | Register::DE => ((cpu.d as u16) << 8 | (cpu.e as u8) as u16) as i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((cpu.e as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | cpu.memory.get_byte(*address).unwrap() as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(cpu.memory.get_byte(*address).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:165:18 [INFO] [stderr] | [INFO] [stderr] 165 | ((cpu.pc as i32) + by as i32) as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(cpu.pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:165:36 [INFO] [stderr] | [INFO] [stderr] 165 | ((cpu.pc as i32) + by as i32) as i16 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(by)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu.rs:283:31 [INFO] [stderr] | [INFO] [stderr] 283 | fn decode(opcode: u8, pc: &u16) -> (Instructions, u8) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `::decode` doesn't need a mutable reference [INFO] [stderr] --> src/cpu.rs:515:48 [INFO] [stderr] | [INFO] [stderr] 515 | Instructions::decode(opcode as u8, &mut self.pc); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:517:20 [INFO] [stderr] | [INFO] [stderr] 517 | self.pc += size as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: literal out of range for i8 [INFO] [stderr] --> src/cpu.rs:529:16 [INFO] [stderr] | [INFO] [stderr] 529 | e: 0xD8, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] = note: the literal `0xD8` (decimal `216`) does not fit into an `i8` and will become `-40i8` [INFO] [stderr] = help: consider using `u8` instead [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/memory.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | if address <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using address == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:59:46 [INFO] [stderr] | [INFO] [stderr] 59 | let data = (((m_data as u16) << 8) | (l_data as u8) as u16) as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((l_data as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:68:38 [INFO] [stderr] | [INFO] [stderr] 68 | events_loop.poll_events(|ev| match ev { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 69 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 70 | | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 71 | | _ => (), [INFO] [stderr] 72 | | }, [INFO] [stderr] 73 | | _ => (), [INFO] [stderr] 74 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | events_loop.poll_events(|ev| if let glutin::Event::WindowEvent { event, .. } = ev { match event { [INFO] [stderr] 69 | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 70 | _ => (), [INFO] [stderr] 71 | } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:69:57 [INFO] [stderr] | [INFO] [stderr] 69 | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 70 | | glutin::WindowEvent::Closed => closed = true, [INFO] [stderr] 71 | | _ => (), [INFO] [stderr] 72 | | }, [INFO] [stderr] | |_____________^ help: try this: `if let glutin::WindowEvent::Closed = event { closed = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gb_emulator`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "987f4d8e16b61c92ab208c61cb1569da56b3521e2e886fdff3c382743f9a18e1"` [INFO] running `"docker" "rm" "-f" "987f4d8e16b61c92ab208c61cb1569da56b3521e2e886fdff3c382743f9a18e1"` [INFO] [stdout] 987f4d8e16b61c92ab208c61cb1569da56b3521e2e886fdff3c382743f9a18e1