[INFO] updating cached repository Fuzzerker/card_game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Fuzzerker/card_game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Fuzzerker/card_game" "work/ex/clippy-test-run/sources/stable/gh/Fuzzerker/card_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Fuzzerker/card_game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Fuzzerker/card_game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fuzzerker/card_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fuzzerker/card_game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 036b32a755b5d02d978a0744a9621d93dcbcc67f [INFO] sha for GitHub repo Fuzzerker/card_game: 036b32a755b5d02d978a0744a9621d93dcbcc67f [INFO] validating manifest of Fuzzerker/card_game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Fuzzerker/card_game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Fuzzerker/card_game [INFO] finished frobbing Fuzzerker/card_game [INFO] frobbed toml for Fuzzerker/card_game written to work/ex/clippy-test-run/sources/stable/gh/Fuzzerker/card_game/Cargo.toml [INFO] started frobbing Fuzzerker/card_game [INFO] finished frobbing Fuzzerker/card_game [INFO] frobbed toml for Fuzzerker/card_game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fuzzerker/card_game/Cargo.toml [INFO] crate Fuzzerker/card_game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Fuzzerker/card_game against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Fuzzerker/card_game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 48f5bc670d8dc9c70df173a0e1e2d0855270e18cac436f527b716e9fbd0feb71 [INFO] running `"docker" "start" "-a" "48f5bc670d8dc9c70df173a0e1e2d0855270e18cac436f527b716e9fbd0feb71"` [INFO] [stderr] Checking card_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:178:28 [INFO] [stderr] | [INFO] [stderr] 178 | println!("{}", ""); [INFO] [stderr] | ^^ [INFO] [stderr] --> src/main.rs:178:28 [INFO] [stderr] | [INFO] [stderr] 178 | println!("{}", ""); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::stdin` [INFO] [stderr] --> src/main.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::stdin; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::process; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `SystemTime`, `UNIX_EPOCH` [INFO] [stderr] --> src/main.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | use std::time::{SystemTime, UNIX_EPOCH}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return entered_number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `entered_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return entered_number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `entered_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | g [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | let g = Game { [INFO] [stderr] | _________________^ [INFO] [stderr] 76 | | board: Board { [INFO] [stderr] 77 | | cols_and_rows: Vec::new(), [INFO] [stderr] 78 | | col_count: 0, [INFO] [stderr] ... | [INFO] [stderr] 83 | | cur_highest_val: 0, [INFO] [stderr] 84 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | num_digits [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:240:22 [INFO] [stderr] | [INFO] [stderr] 240 | let num_digits = num.to_string().len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `end_game_with_message` [INFO] [stderr] --> src/main.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | fn end_game_with_message(&self, msg: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::stdin` [INFO] [stderr] --> src/main.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::stdin; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::process; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `SystemTime`, `UNIX_EPOCH` [INFO] [stderr] --> src/main.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | use std::time::{SystemTime, UNIX_EPOCH}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return entered_number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `entered_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return entered_number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `entered_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | g [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | let g = Game { [INFO] [stderr] | _________________^ [INFO] [stderr] 76 | | board: Board { [INFO] [stderr] 77 | | cols_and_rows: Vec::new(), [INFO] [stderr] 78 | | col_count: 0, [INFO] [stderr] ... | [INFO] [stderr] 83 | | cur_highest_val: 0, [INFO] [stderr] 84 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | num_digits [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:240:22 [INFO] [stderr] | [INFO] [stderr] 240 | let num_digits = num.to_string().len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:159:30 [INFO] [stderr] | [INFO] [stderr] 159 | fn print(&self, highest: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | let val = self [INFO] [stderr] | ___________________________^ [INFO] [stderr] 164 | | .cols_and_rows [INFO] [stderr] 165 | | .get(col_index) [INFO] [stderr] 166 | | .unwrap() [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 163 | let val = self [INFO] [stderr] 164 | .cols_and_rows[col_index] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row_idx` is only used to index `immutable_self_col_ref`. [INFO] [stderr] --> src/main.rs:184:24 [INFO] [stderr] | [INFO] [stderr] 184 | for row_idx in 0..self.row_count { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 184 | for in immutable_self_col_ref.iter().take(self.row_count) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row_idx` is used to index `end_col` [INFO] [stderr] --> src/main.rs:188:24 [INFO] [stderr] | [INFO] [stderr] 188 | for row_idx in 0..self.row_count { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 188 | for (row_idx, ) in end_col.iter().enumerate().take(self.row_count) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:218:17 [INFO] [stderr] | [INFO] [stderr] 218 | cur_val = cur_val * 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_val *= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | fn get_digit_count(num: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: method is never used: `end_game_with_message` [INFO] [stderr] --> src/main.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | fn end_game_with_message(&self, msg: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:159:30 [INFO] [stderr] | [INFO] [stderr] 159 | fn print(&self, highest: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | let val = self [INFO] [stderr] | ___________________________^ [INFO] [stderr] 164 | | .cols_and_rows [INFO] [stderr] 165 | | .get(col_index) [INFO] [stderr] 166 | | .unwrap() [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 163 | let val = self [INFO] [stderr] 164 | .cols_and_rows[col_index] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row_idx` is only used to index `immutable_self_col_ref`. [INFO] [stderr] --> src/main.rs:184:24 [INFO] [stderr] | [INFO] [stderr] 184 | for row_idx in 0..self.row_count { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 184 | for in immutable_self_col_ref.iter().take(self.row_count) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row_idx` is used to index `end_col` [INFO] [stderr] --> src/main.rs:188:24 [INFO] [stderr] | [INFO] [stderr] 188 | for row_idx in 0..self.row_count { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 188 | for (row_idx, ) in end_col.iter().enumerate().take(self.row_count) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:218:17 [INFO] [stderr] | [INFO] [stderr] 218 | cur_val = cur_val * 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_val *= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | fn get_digit_count(num: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "48f5bc670d8dc9c70df173a0e1e2d0855270e18cac436f527b716e9fbd0feb71"` [INFO] running `"docker" "rm" "-f" "48f5bc670d8dc9c70df173a0e1e2d0855270e18cac436f527b716e9fbd0feb71"` [INFO] [stdout] 48f5bc670d8dc9c70df173a0e1e2d0855270e18cac436f527b716e9fbd0feb71