[INFO] updating cached repository FrogInABox/rusty-chip-8
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/FrogInABox/rusty-chip-8
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/FrogInABox/rusty-chip-8" "work/ex/clippy-test-run/sources/stable/gh/FrogInABox/rusty-chip-8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FrogInABox/rusty-chip-8'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/FrogInABox/rusty-chip-8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrogInABox/rusty-chip-8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrogInABox/rusty-chip-8'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 137b87dae42b4d2fe95fd02b83ba772ad8e0269a
[INFO] sha for GitHub repo FrogInABox/rusty-chip-8: 137b87dae42b4d2fe95fd02b83ba772ad8e0269a
[INFO] validating manifest of FrogInABox/rusty-chip-8 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of FrogInABox/rusty-chip-8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing FrogInABox/rusty-chip-8
[INFO] finished frobbing FrogInABox/rusty-chip-8
[INFO] frobbed toml for FrogInABox/rusty-chip-8 written to work/ex/clippy-test-run/sources/stable/gh/FrogInABox/rusty-chip-8/Cargo.toml
[INFO] started frobbing FrogInABox/rusty-chip-8
[INFO] finished frobbing FrogInABox/rusty-chip-8
[INFO] frobbed toml for FrogInABox/rusty-chip-8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrogInABox/rusty-chip-8/Cargo.toml
[INFO] crate FrogInABox/rusty-chip-8 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting FrogInABox/rusty-chip-8 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FrogInABox/rusty-chip-8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b863154cbd61a76e5c233a355ba8d8f5cd5350925e24a3f689c21cfdfdcee583
[INFO] running `"docker" "start" "-a" "b863154cbd61a76e5c233a355ba8d8f5cd5350925e24a3f689c21cfdfdcee583"`
[INFO] [stderr]     Checking rusty-chip-8 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/chip8/mod.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             renderer: renderer,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `renderer`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/chip8/mod.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             renderer: renderer,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `renderer`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/renderers/cli.rs:14:28
[INFO] [stderr]    |
[INFO] [stderr] 14 |         println!("{}{}{}", "╔", format!("{:═<1$}", "", width), "╗");
[INFO] [stderr]    |                            ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/renderers/cli.rs:14:64
[INFO] [stderr]    |
[INFO] [stderr] 14 |         println!("{}{}{}", "╔", format!("{:═<1$}", "", width), "╗");
[INFO] [stderr]    |                                                                ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/renderers/cli.rs:14:28
[INFO] [stderr]    |
[INFO] [stderr] 14 |         println!("{}{}{}", "╔", format!("{:═<1$}", "", width), "╗");
[INFO] [stderr]   --> src/renderers/cli.rs:29:28
[INFO] [stderr]    |                            ^^^
[INFO] [stderr]    |
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr] 29 |         println!("{}{}{}", "╚", format!("{:═<1$}", "", width), "╝");
[INFO] [stderr]    |                            ^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/renderers/cli.rs:14:64
[INFO] [stderr]    |
[INFO] [stderr] 14 |         println!("{}{}{}", "╔", format!("{:═<1$}", "", width), "╗");
[INFO] [stderr]    |                                                                ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/renderers/cli.rs:29:64
[INFO] [stderr]    |
[INFO] [stderr] 29 |         println!("{}{}{}", "╚", format!("{:═<1$}", "", width), "╝");
[INFO] [stderr]    |                                                                ^^^
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/renderers/cli.rs:29:28
[INFO] [stderr]    |
[INFO] [stderr] 29 |         println!("{}{}{}", "╚", format!("{:═<1$}", "", width), "╝");
[INFO] [stderr]    |                            ^^^
[INFO] [stderr]    |
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/renderers/cli.rs:29:64
[INFO] [stderr]    |
[INFO] [stderr] 29 |         println!("{}{}{}", "╚", format!("{:═<1$}", "", width), "╝");
[INFO] [stderr]    |                                                                ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_nn`
[INFO] [stderr]   --> src/chip8/interpreter.rs:74:5
[INFO] [stderr]    |
[INFO] [stderr] 74 |     fn get_nn(&self, opcode: &u16) -> u8 {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `timer_delay`
[INFO] [stderr]   --> src/chip8/mod.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     timer_delay: u8,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `timer_sound`
[INFO] [stderr]   --> src/chip8/mod.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     timer_sound: u8,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `keyboard`
[INFO] [stderr]   --> src/chip8/mod.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     keyboard: [bool; config::KEYBOARD_SIZE],
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/chip8/interpreter.rs:60:29
[INFO] [stderr]    |
[INFO] [stderr] 60 |     fn get_x(&self, opcode: &u16) -> u8 {
[INFO] [stderr]    |                             ^^^^ help: consider passing by value instead: `u16`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/chip8/interpreter.rs:65:29
[INFO] [stderr]    |
[INFO] [stderr] 65 |     fn get_y(&self, opcode: &u16) -> u8 {
[INFO] [stderr]    |                             ^^^^ help: consider passing by value instead: `u16`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/chip8/interpreter.rs:70:29
[INFO] [stderr]    |
[INFO] [stderr] 70 |     fn get_n(&self, opcode: &u16) -> u8 {
[INFO] [stderr]    |                             ^^^^ help: consider passing by value instead: `u16`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/chip8/interpreter.rs:74:30
[INFO] [stderr]    |
[INFO] [stderr] 74 |     fn get_nn(&self, opcode: &u16) -> u8 {
[INFO] [stderr]    |                              ^^^^ help: consider passing by value instead: `u16`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/chip8/interpreter.rs:78:31
[INFO] [stderr]    |
[INFO] [stderr] 78 |     fn get_nnn(&self, opcode: &u16) -> usize {
[INFO] [stderr]    |                               ^^^^ help: consider passing by value instead: `u16`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/chip8/mod.rs:49:37
[INFO] [stderr]    |
[INFO] [stderr] 49 |     pub fn run(&mut self, rom_path: &String) {
[INFO] [stderr]    |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/chip8/mod.rs:51:16
[INFO] [stderr]    |
[INFO] [stderr] 51 |           if let Err(_) = self.load(rom_path) {
[INFO] [stderr]    |  _________-      ^^^^^^
[INFO] [stderr] 52 | |             println!("Failed to load ROM \"{}\"", &rom_path);
[INFO] [stderr] 53 | |             return;
[INFO] [stderr] 54 | |         }
[INFO] [stderr]    | |_________- help: try this: `if self.load(rom_path).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/chip8/mod.rs:59:27
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 let msb = self.ram[self.program_counter] as u16;
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram[self.program_counter])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/chip8/mod.rs:60:27
[INFO] [stderr]    |
[INFO] [stderr] 60 |                 let lsb = self.ram[self.program_counter + 1] as u16;
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram[self.program_counter + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/chip8/mod.rs:72:34
[INFO] [stderr]    |
[INFO] [stderr] 72 |     fn load(&mut self, rom_path: &String) -> Result<(), Error> {
[INFO] [stderr]    |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/chip8/mod.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 |         File::open(rom_path)?.read(&mut self.ram[0x200..])?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/renderers/cli.rs:20:25
[INFO] [stderr]    |
[INFO] [stderr] 20 |                   line += match display.get(x, y) {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 21 | |                     true => "█",
[INFO] [stderr] 22 | |                     false => " ",
[INFO] [stderr] 23 | |                 }
[INFO] [stderr]    | |_________________^ help: consider using an if/else expression: `if display.get(x, y) { "█" } else { " " }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rusty-chip-8`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: method is never used: `get_nn`
[INFO] [stderr]   --> src/chip8/interpreter.rs:74:5
[INFO] [stderr]    |
[INFO] [stderr] 74 |     fn get_nn(&self, opcode: &u16) -> u8 {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `timer_delay`
[INFO] [stderr]   --> src/chip8/mod.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     timer_delay: u8,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `timer_sound`
[INFO] [stderr]   --> src/chip8/mod.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     timer_sound: u8,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `keyboard`
[INFO] [stderr]   --> src/chip8/mod.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     keyboard: [bool; config::KEYBOARD_SIZE],
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/chip8/interpreter.rs:60:29
[INFO] [stderr]    |
[INFO] [stderr] 60 |     fn get_x(&self, opcode: &u16) -> u8 {
[INFO] [stderr]    |                             ^^^^ help: consider passing by value instead: `u16`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/chip8/interpreter.rs:65:29
[INFO] [stderr]    |
[INFO] [stderr] 65 |     fn get_y(&self, opcode: &u16) -> u8 {
[INFO] [stderr]    |                             ^^^^ help: consider passing by value instead: `u16`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/chip8/interpreter.rs:70:29
[INFO] [stderr]    |
[INFO] [stderr] 70 |     fn get_n(&self, opcode: &u16) -> u8 {
[INFO] [stderr]    |                             ^^^^ help: consider passing by value instead: `u16`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/chip8/interpreter.rs:74:30
[INFO] [stderr]    |
[INFO] [stderr] 74 |     fn get_nn(&self, opcode: &u16) -> u8 {
[INFO] [stderr]    |                              ^^^^ help: consider passing by value instead: `u16`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/chip8/interpreter.rs:78:31
[INFO] [stderr]    |
[INFO] [stderr] 78 |     fn get_nnn(&self, opcode: &u16) -> usize {
[INFO] [stderr]    |                               ^^^^ help: consider passing by value instead: `u16`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/chip8/mod.rs:49:37
[INFO] [stderr]    |
[INFO] [stderr] 49 |     pub fn run(&mut self, rom_path: &String) {
[INFO] [stderr]    |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/chip8/mod.rs:51:16
[INFO] [stderr]    |
[INFO] [stderr] 51 |           if let Err(_) = self.load(rom_path) {
[INFO] [stderr]    |  _________-      ^^^^^^
[INFO] [stderr] 52 | |             println!("Failed to load ROM \"{}\"", &rom_path);
[INFO] [stderr] 53 | |             return;
[INFO] [stderr] 54 | |         }
[INFO] [stderr]    | |_________- help: try this: `if self.load(rom_path).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/chip8/mod.rs:59:27
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 let msb = self.ram[self.program_counter] as u16;
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram[self.program_counter])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/chip8/mod.rs:60:27
[INFO] [stderr]    |
[INFO] [stderr] 60 |                 let lsb = self.ram[self.program_counter + 1] as u16;
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram[self.program_counter + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/chip8/mod.rs:72:34
[INFO] [stderr]    |
[INFO] [stderr] 72 |     fn load(&mut self, rom_path: &String) -> Result<(), Error> {
[INFO] [stderr]    |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/chip8/mod.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 |         File::open(rom_path)?.read(&mut self.ram[0x200..])?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/renderers/cli.rs:20:25
[INFO] [stderr]    |
[INFO] [stderr] 20 |                   line += match display.get(x, y) {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 21 | |                     true => "█",
[INFO] [stderr] 22 | |                     false => " ",
[INFO] [stderr] 23 | |                 }
[INFO] [stderr]    | |_________________^ help: consider using an if/else expression: `if display.get(x, y) { "█" } else { " " }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rusty-chip-8`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "b863154cbd61a76e5c233a355ba8d8f5cd5350925e24a3f689c21cfdfdcee583"`
[INFO] running `"docker" "rm" "-f" "b863154cbd61a76e5c233a355ba8d8f5cd5350925e24a3f689c21cfdfdcee583"`
[INFO] [stdout] b863154cbd61a76e5c233a355ba8d8f5cd5350925e24a3f689c21cfdfdcee583