[INFO] updating cached repository FreeMasen/wasm-chrome-hack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FreeMasen/wasm-chrome-hack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FreeMasen/wasm-chrome-hack" "work/ex/clippy-test-run/sources/stable/gh/FreeMasen/wasm-chrome-hack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FreeMasen/wasm-chrome-hack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FreeMasen/wasm-chrome-hack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/wasm-chrome-hack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/wasm-chrome-hack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e95ad7d9486fa7a9178f58493f67f70ae0b8a002 [INFO] sha for GitHub repo FreeMasen/wasm-chrome-hack: e95ad7d9486fa7a9178f58493f67f70ae0b8a002 [INFO] validating manifest of FreeMasen/wasm-chrome-hack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FreeMasen/wasm-chrome-hack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FreeMasen/wasm-chrome-hack [INFO] finished frobbing FreeMasen/wasm-chrome-hack [INFO] frobbed toml for FreeMasen/wasm-chrome-hack written to work/ex/clippy-test-run/sources/stable/gh/FreeMasen/wasm-chrome-hack/Cargo.toml [INFO] started frobbing FreeMasen/wasm-chrome-hack [INFO] finished frobbing FreeMasen/wasm-chrome-hack [INFO] frobbed toml for FreeMasen/wasm-chrome-hack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/wasm-chrome-hack/Cargo.toml [INFO] crate FreeMasen/wasm-chrome-hack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FreeMasen/wasm-chrome-hack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FreeMasen/wasm-chrome-hack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 66ef97af9d8502f5a4bbc703a7621695d2325d479fa662d3f094647121937a13 [INFO] running `"docker" "start" "-a" "66ef97af9d8502f5a4bbc703a7621695d2325d479fa662d3f094647121937a13"` [INFO] [stderr] Checking wbch v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:73:43 [INFO] [stderr] | [INFO] [stderr] 73 | let paren_idx = name.find("(").unwrap_or(name.len() - 1); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:73:43 [INFO] [stderr] | [INFO] [stderr] 73 | let paren_idx = name.find("(").unwrap_or(name.len() - 1); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | } else if l.starts_with("/* tslint:disable */") { [INFO] [stderr] | ____________________^ [INFO] [stderr] 105 | | false [INFO] [stderr] 106 | | } else { [INFO] [stderr] 107 | | true [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `!l.starts_with("/* tslint:disable */")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | } else if l.starts_with("/* tslint:disable */") { [INFO] [stderr] | ____________________^ [INFO] [stderr] 105 | | false [INFO] [stderr] 106 | | } else { [INFO] [stderr] 107 | | true [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `!l.starts_with("/* tslint:disable */")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:117:22 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:117:22 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "66ef97af9d8502f5a4bbc703a7621695d2325d479fa662d3f094647121937a13"` [INFO] running `"docker" "rm" "-f" "66ef97af9d8502f5a4bbc703a7621695d2325d479fa662d3f094647121937a13"` [INFO] [stdout] 66ef97af9d8502f5a4bbc703a7621695d2325d479fa662d3f094647121937a13