[INFO] updating cached repository FreeMasen/sqlite_parser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FreeMasen/sqlite_parser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FreeMasen/sqlite_parser" "work/ex/clippy-test-run/sources/stable/gh/FreeMasen/sqlite_parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FreeMasen/sqlite_parser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FreeMasen/sqlite_parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/sqlite_parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/sqlite_parser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b37641373843adb4b655980be2918f81e3373196 [INFO] sha for GitHub repo FreeMasen/sqlite_parser: b37641373843adb4b655980be2918f81e3373196 [INFO] validating manifest of FreeMasen/sqlite_parser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FreeMasen/sqlite_parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FreeMasen/sqlite_parser [INFO] finished frobbing FreeMasen/sqlite_parser [INFO] frobbed toml for FreeMasen/sqlite_parser written to work/ex/clippy-test-run/sources/stable/gh/FreeMasen/sqlite_parser/Cargo.toml [INFO] started frobbing FreeMasen/sqlite_parser [INFO] finished frobbing FreeMasen/sqlite_parser [INFO] frobbed toml for FreeMasen/sqlite_parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/sqlite_parser/Cargo.toml [INFO] crate FreeMasen/sqlite_parser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FreeMasen/sqlite_parser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FreeMasen/sqlite_parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1ad85dd9d339b9633ec462412f898ea9171691c5cb36682f8797468f940871e7 [INFO] running `"docker" "start" "-a" "1ad85dd9d339b9633ec462412f898ea9171691c5cb36682f8797468f940871e7"` [INFO] [stderr] Checking sqlite v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `page::TreeType` [INFO] [stderr] --> src/row.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use page::TreeType; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `page::TreeType` [INFO] [stderr] --> src/row.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use page::TreeType; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | (big_end as u16) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(big_end)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | little_end as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(little_end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | (bytes[0] ^ 128) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0] ^ 128)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | bytes[0] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | (bytes[1] as u32) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | (bytes[2] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | (bytes[0] ^ 128) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0] ^ 128)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | bytes[0] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | (first as u64) << 48 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | (bytes[1] as u64) << 40 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | (bytes[2] as u64) << 32 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | (bytes[3] as u64) << 24 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | (bytes[4] as u64) << 16 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | (bytes[5] as u64) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | (bytes[6] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | (bytes[0] as u32) << 24 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | (bytes[1] as u32) << 16 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | (bytes[2] as u32) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | (bytes[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | (bytes[0] as u64) << 56 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | (bytes[1] as u64) << 48 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | (bytes[2] as u64) << 40 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | (bytes[3] as u64) << 32 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | (bytes[4] as u64) << 24 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | (bytes[5] as u64) << 16 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | (bytes[6] as u64) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | (bytes[7] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:92:20 [INFO] [stderr] | [INFO] [stderr] 92 | return bytes[0] as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in bytes.enumerate()` or similar iterators [INFO] [stderr] --> src/data.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | for byte in bytes { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | ret |= byte as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:102:24 [INFO] [stderr] | [INFO] [stderr] 102 | ret |= (byte ^ 128) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(byte ^ 128)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/page.rs:40:51 [INFO] [stderr] | [INFO] [stderr] 40 | let mut cell_start = header.cells_start - (header.size() as u16) - (pointer_array.len() * 2) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(header.size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/page.rs:116:11 [INFO] [stderr] | [INFO] [stderr] 116 | while bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/row.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | data: Data::Int(value as i64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/row.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | data: Data::Int(value as i64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/row.rs:50:41 [INFO] [stderr] | [INFO] [stderr] 50 | data: Data::Int(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/row.rs:58:41 [INFO] [stderr] | [INFO] [stderr] 58 | data: Data::Int(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/buffer.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | varint_bytes.push(byte.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:29:11 [INFO] [stderr] | [INFO] [stderr] 29 | while db_vec.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!db_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | (big_end as u16) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(big_end)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | little_end as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(little_end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | (bytes[0] ^ 128) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0] ^ 128)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | bytes[0] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | (bytes[1] as u32) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | (bytes[2] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | (bytes[0] ^ 128) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0] ^ 128)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | bytes[0] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | (first as u64) << 48 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | (bytes[1] as u64) << 40 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | (bytes[2] as u64) << 32 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | (bytes[3] as u64) << 24 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | (bytes[4] as u64) << 16 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | (bytes[5] as u64) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | (bytes[6] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | (bytes[0] as u32) << 24 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | (bytes[1] as u32) << 16 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | (bytes[2] as u32) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | (bytes[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | (bytes[0] as u64) << 56 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | (bytes[1] as u64) << 48 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | (bytes[2] as u64) << 40 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | (bytes[3] as u64) << 32 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | (bytes[4] as u64) << 24 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | (bytes[5] as u64) << 16 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | (bytes[6] as u64) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | (bytes[7] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:92:20 [INFO] [stderr] | [INFO] [stderr] 92 | return bytes[0] as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in bytes.enumerate()` or similar iterators [INFO] [stderr] --> src/data.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | for byte in bytes { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | ret |= byte as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:102:24 [INFO] [stderr] | [INFO] [stderr] 102 | ret |= (byte ^ 128) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(byte ^ 128)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/page.rs:40:51 [INFO] [stderr] | [INFO] [stderr] 40 | let mut cell_start = header.cells_start - (header.size() as u16) - (pointer_array.len() * 2) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(header.size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/page.rs:116:11 [INFO] [stderr] | [INFO] [stderr] 116 | while bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/row.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | data: Data::Int(value as i64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/row.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | data: Data::Int(value as i64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/row.rs:50:41 [INFO] [stderr] | [INFO] [stderr] 50 | data: Data::Int(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/row.rs:58:41 [INFO] [stderr] | [INFO] [stderr] 58 | data: Data::Int(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/buffer.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | varint_bytes.push(byte.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:29:11 [INFO] [stderr] | [INFO] [stderr] 29 | while db_vec.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!db_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.60s [INFO] running `"docker" "inspect" "1ad85dd9d339b9633ec462412f898ea9171691c5cb36682f8797468f940871e7"` [INFO] running `"docker" "rm" "-f" "1ad85dd9d339b9633ec462412f898ea9171691c5cb36682f8797468f940871e7"` [INFO] [stdout] 1ad85dd9d339b9633ec462412f898ea9171691c5cb36682f8797468f940871e7