[INFO] updating cached repository FreeMasen/cargo-upstall [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FreeMasen/cargo-upstall [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FreeMasen/cargo-upstall" "work/ex/clippy-test-run/sources/stable/gh/FreeMasen/cargo-upstall"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FreeMasen/cargo-upstall'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FreeMasen/cargo-upstall" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/cargo-upstall"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/cargo-upstall'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 97a1581e991890ec669817917870f033e3c68269 [INFO] sha for GitHub repo FreeMasen/cargo-upstall: 97a1581e991890ec669817917870f033e3c68269 [INFO] validating manifest of FreeMasen/cargo-upstall on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FreeMasen/cargo-upstall on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FreeMasen/cargo-upstall [INFO] finished frobbing FreeMasen/cargo-upstall [INFO] frobbed toml for FreeMasen/cargo-upstall written to work/ex/clippy-test-run/sources/stable/gh/FreeMasen/cargo-upstall/Cargo.toml [INFO] started frobbing FreeMasen/cargo-upstall [INFO] finished frobbing FreeMasen/cargo-upstall [INFO] frobbed toml for FreeMasen/cargo-upstall written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/cargo-upstall/Cargo.toml [INFO] crate FreeMasen/cargo-upstall has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FreeMasen/cargo-upstall against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FreeMasen/cargo-upstall:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ccc25397c52b24a2e5e4286d01d5241ab532f60d05ffae01c029e8f48851496a [INFO] running `"docker" "start" "-a" "ccc25397c52b24a2e5e4286d01d5241ab532f60d05ffae01c029e8f48851496a"` [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking docopt v1.0.0 [INFO] [stderr] Checking cargo-upstall v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/manifest.rs:60:44 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn from_v1_entry(key: &str, value: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/manifest.rs:62:44 [INFO] [stderr] | [INFO] [stderr] 62 | let mut name_parts = key.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/manifest.rs:85:50 [INFO] [stderr] | [INFO] [stderr] 85 | let mut source_parts = full_source.split("+"); [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/manifest.rs:93:48 [INFO] [stderr] | [INFO] [stderr] 93 | let mut url_parts = full_url.split("#").map(|s| s.to_string()); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/manifest.rs:60:44 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn from_v1_entry(key: &str, value: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/manifest.rs:62:44 [INFO] [stderr] | [INFO] [stderr] 62 | let mut name_parts = key.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/manifest.rs:85:50 [INFO] [stderr] | [INFO] [stderr] 85 | let mut source_parts = full_source.split("+"); [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/manifest.rs:93:48 [INFO] [stderr] | [INFO] [stderr] 93 | let mut url_parts = full_url.split("#").map(|s| s.to_string()); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:88:8 [INFO] [stderr] | [INFO] [stderr] 88 | if args.flag_features.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.flag_features.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:129:12 [INFO] [stderr] | [INFO] [stderr] 129 | if &command.version >= max { [INFO] [stderr] | ----------------^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `command.version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:156:30 [INFO] [stderr] | [INFO] [stderr] 156 | fn get_max_version(versions: &Vec, max: &Option) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Version]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | versions.into_iter().filter_map(|v| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | if v <= &max { [INFO] [stderr] | ^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | versions.into_iter().max().map(|v| v.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `versions.into_iter().max().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | versions.into_iter().max().map(|v| v.clone()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:88:8 [INFO] [stderr] | [INFO] [stderr] 88 | if args.flag_features.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.flag_features.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:129:12 [INFO] [stderr] | [INFO] [stderr] 129 | if &command.version >= max { [INFO] [stderr] | ----------------^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `command.version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:156:30 [INFO] [stderr] | [INFO] [stderr] 156 | fn get_max_version(versions: &Vec, max: &Option) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Version]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | versions.into_iter().filter_map(|v| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | if v <= &max { [INFO] [stderr] | ^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | versions.into_iter().max().map(|v| v.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `versions.into_iter().max().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | versions.into_iter().max().map(|v| v.clone()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.15s [INFO] running `"docker" "inspect" "ccc25397c52b24a2e5e4286d01d5241ab532f60d05ffae01c029e8f48851496a"` [INFO] running `"docker" "rm" "-f" "ccc25397c52b24a2e5e4286d01d5241ab532f60d05ffae01c029e8f48851496a"` [INFO] [stdout] ccc25397c52b24a2e5e4286d01d5241ab532f60d05ffae01c029e8f48851496a