[INFO] updating cached repository FreeFull/ngaro-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FreeFull/ngaro-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FreeFull/ngaro-rs" "work/ex/clippy-test-run/sources/stable/gh/FreeFull/ngaro-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FreeFull/ngaro-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FreeFull/ngaro-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeFull/ngaro-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeFull/ngaro-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f016d8512c4532aa8b2132a8a14c86945df29856 [INFO] sha for GitHub repo FreeFull/ngaro-rs: f016d8512c4532aa8b2132a8a14c86945df29856 [INFO] validating manifest of FreeFull/ngaro-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FreeFull/ngaro-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FreeFull/ngaro-rs [INFO] finished frobbing FreeFull/ngaro-rs [INFO] frobbed toml for FreeFull/ngaro-rs written to work/ex/clippy-test-run/sources/stable/gh/FreeFull/ngaro-rs/Cargo.toml [INFO] started frobbing FreeFull/ngaro-rs [INFO] finished frobbing FreeFull/ngaro-rs [INFO] frobbed toml for FreeFull/ngaro-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeFull/ngaro-rs/Cargo.toml [INFO] crate FreeFull/ngaro-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FreeFull/ngaro-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FreeFull/ngaro-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5cc4be0c4586f0d5ca377fc9b27085386b2a1df2ba1c6f7442dc516e9eb54388 [INFO] running `"docker" "start" "-a" "5cc4be0c4586f0d5ca377fc9b27085386b2a1df2ba1c6f7442dc516e9eb54388"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Compiling serde_derive_internals v0.22.0 [INFO] [stderr] Compiling serde_derive v1.0.34 [INFO] [stderr] Checking docopt v0.8.3 [INFO] [stderr] Checking ngaro-rs v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/devices.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | keyboard: Keyboard { stdin: stdin }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stdin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] --> src/devices.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | keyboard: Keyboard { stdin: stdin }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stdin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cpu.rs:298:23 [INFO] [stderr] | [INFO] [stderr] 298 | const NAMES: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cpu.rs:298:33 [INFO] [stderr] | [INFO] [stderr] 298 | const NAMES: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cpu.rs:298:23 [INFO] [stderr] | [INFO] [stderr] 298 | const NAMES: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cpu.rs:298:33 [INFO] [stderr] | [INFO] [stderr] 298 | const NAMES: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/cpu.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | None => return $rval, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 133 | self.ip = get_memory!(self, self.ip, panic!("Jump out of bounds.")) - 1; [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/cpu.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | None => return $rval, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 133 | self.ip = get_memory!(self, self.ip, panic!("Jump out of bounds.")) - 1; [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Empty` [INFO] [stderr] --> src/cpu.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | Empty, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Empty` [INFO] [stderr] --> src/cpu.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | Empty, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cpu.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | self.ports.get_mut(0).map(|x| *x = 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = self.ports.get_mut(0) { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cpu.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | self.ports.get_mut(0).map(|x| *x = 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = self.ports.get_mut(0) { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cpu.rs:268:21 [INFO] [stderr] | [INFO] [stderr] 268 | self.ports.get_mut(port as usize).map(|x| *x = 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = self.ports.get_mut(port as usize) { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cpu.rs:272:21 [INFO] [stderr] | [INFO] [stderr] 272 | self.ports.get_mut(port as usize).map(|x| *x = data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = self.ports.get_mut(port as usize) { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cpu.rs:268:21 [INFO] [stderr] | [INFO] [stderr] 268 | self.ports.get_mut(port as usize).map(|x| *x = 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = self.ports.get_mut(port as usize) { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cpu.rs:272:21 [INFO] [stderr] | [INFO] [stderr] 272 | self.ports.get_mut(port as usize).map(|x| *x = data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = self.ports.get_mut(port as usize) { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/devices.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | -11 => { *data = termion::terminal_size().unwrap().0 as i32 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(termion::terminal_size().unwrap().0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/devices.rs:52:46 [INFO] [stderr] | [INFO] [stderr] 52 | -12 => { *data = termion::terminal_size().unwrap().1 as i32 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(termion::terminal_size().unwrap().1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/devices.rs:70:38 [INFO] [stderr] | [INFO] [stderr] 70 | self.stdin.read_u8().map(|x| x as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/devices.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | -11 => { *data = termion::terminal_size().unwrap().0 as i32 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(termion::terminal_size().unwrap().0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/devices.rs:52:46 [INFO] [stderr] | [INFO] [stderr] 52 | -12 => { *data = termion::terminal_size().unwrap().1 as i32 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(termion::terminal_size().unwrap().1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/devices.rs:70:38 [INFO] [stderr] | [INFO] [stderr] 70 | self.stdin.read_u8().map(|x| x as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match action { [INFO] [stderr] 67 | | A::Wait => if devices.do_io(&mut cpu) { break; }, [INFO] [stderr] 68 | | _ => {} [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ help: try this: `if let A::Wait = action { if devices.do_io(&mut cpu) { break; } }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match action { [INFO] [stderr] 67 | | A::Wait => if devices.do_io(&mut cpu) { break; }, [INFO] [stderr] 68 | | _ => {} [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ help: try this: `if let A::Wait = action { if devices.do_io(&mut cpu) { break; } }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.46s [INFO] running `"docker" "inspect" "5cc4be0c4586f0d5ca377fc9b27085386b2a1df2ba1c6f7442dc516e9eb54388"` [INFO] running `"docker" "rm" "-f" "5cc4be0c4586f0d5ca377fc9b27085386b2a1df2ba1c6f7442dc516e9eb54388"` [INFO] [stdout] 5cc4be0c4586f0d5ca377fc9b27085386b2a1df2ba1c6f7442dc516e9eb54388