[INFO] updating cached repository FredericDesgreniers/advent_of_code_rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FredericDesgreniers/advent_of_code_rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FredericDesgreniers/advent_of_code_rs" "work/ex/clippy-test-run/sources/stable/gh/FredericDesgreniers/advent_of_code_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FredericDesgreniers/advent_of_code_rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FredericDesgreniers/advent_of_code_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FredericDesgreniers/advent_of_code_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FredericDesgreniers/advent_of_code_rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 431d46277d54c93ce73689c6198d3261d6c0216b [INFO] sha for GitHub repo FredericDesgreniers/advent_of_code_rs: 431d46277d54c93ce73689c6198d3261d6c0216b [INFO] validating manifest of FredericDesgreniers/advent_of_code_rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FredericDesgreniers/advent_of_code_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FredericDesgreniers/advent_of_code_rs [INFO] finished frobbing FredericDesgreniers/advent_of_code_rs [INFO] frobbed toml for FredericDesgreniers/advent_of_code_rs written to work/ex/clippy-test-run/sources/stable/gh/FredericDesgreniers/advent_of_code_rs/Cargo.toml [INFO] started frobbing FredericDesgreniers/advent_of_code_rs [INFO] finished frobbing FredericDesgreniers/advent_of_code_rs [INFO] frobbed toml for FredericDesgreniers/advent_of_code_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FredericDesgreniers/advent_of_code_rs/Cargo.toml [INFO] crate FredericDesgreniers/advent_of_code_rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FredericDesgreniers/advent_of_code_rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FredericDesgreniers/advent_of_code_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8560687fe6e66ab565dc91fcb5f97ad3948faf9102e68475c24a9df8a9bb2571 [INFO] running `"docker" "start" "-a" "8560687fe6e66ab565dc91fcb5f97ad3948faf9102e68475c24a9df8a9bb2571"` [INFO] [stderr] Checking rand v0.6.1 [INFO] [stderr] Checking advent_of_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Repeat`, `SetParameter` [INFO] [stderr] --> src/lib.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | use gif::{Encoder, Repeat, SetParameter}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `rusttype::Point` [INFO] [stderr] --> src/lib.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use rusttype::Point; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Index` [INFO] [stderr] --> src/lib.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::ops::Index; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Repeat`, `SetParameter` [INFO] [stderr] --> src/lib.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | use gif::{Encoder, Repeat, SetParameter}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `rusttype::Point` [INFO] [stderr] --> src/lib.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use rusttype::Point; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Index` [INFO] [stderr] --> src/lib.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::ops::Index; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:40 [INFO] [stderr] | [INFO] [stderr] 132 | .layout(text, scale, point(x as f32, y as f32 + metrics.ascent)) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:50 [INFO] [stderr] | [INFO] [stderr] 132 | .layout(text, scale, point(x as f32, y as f32 + metrics.ascent)) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:40 [INFO] [stderr] | [INFO] [stderr] 132 | .layout(text, scale, point(x as f32, y as f32 + metrics.ascent)) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:50 [INFO] [stderr] | [INFO] [stderr] 132 | .layout(text, scale, point(x as f32, y as f32 + metrics.ascent)) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day5.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | const INPUT: &'static str = include_str!("../../day5_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day2.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | const INPUT: &'static str = include_str!("../../day2_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day6.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | const INPUT: &'static str = include_str!("../../day6_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `num_traits::real::Real` [INFO] [stderr] --> src/bin/day5.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use num_traits::real::Real; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/day5.rs:7:6 [INFO] [stderr] | [INFO] [stderr] 7 | let mut input = INPUT.chars().filter(|c| c.is_alphabetic()).collect_vec(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/day5.rs:9:35 [INFO] [stderr] | [INFO] [stderr] 9 | let units = (0..26).map(|x| (x + 'a' as u8) as char); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: variable `bestLen` should have a snake case name such as `best_len` [INFO] [stderr] --> src/bin/day5.rs:11:6 [INFO] [stderr] | [INFO] [stderr] 11 | let mut bestLen = ::std::usize::MAX; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/bin/day5.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | let mut input = input.iter().filter(|&&c| { [INFO] [stderr] | _________________________^ [INFO] [stderr] 15 | | c.to_ascii_lowercase() != unit [INFO] [stderr] 16 | | }).map(|&c| c).collect_vec(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 14 | let mut input = input.iter().filter(|&&c| { [INFO] [stderr] 15 | c.to_ascii_lowercase() != unit [INFO] [stderr] 16 | }).cloned().collect_vec(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable `leftC` should have a snake case name such as `left_c` [INFO] [stderr] --> src/bin/day5.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | let leftC = input[i]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `rightC` should have a snake case name such as `right_c` [INFO] [stderr] --> src/bin/day5.rs:22:8 [INFO] [stderr] | [INFO] [stderr] 22 | let rightC = input[i + 1]; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `num_traits::real::Real` [INFO] [stderr] --> src/bin/day6.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use num_traits::real::Real; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day6.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | const INPUT: &'static str = include_str!("../../day6_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused label `'x` [INFO] [stderr] --> src/bin/day6.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | 'x: for x in 0..SIZE { [INFO] [stderr] | _________^ [INFO] [stderr] 27 | | let mut total_distance = 0; [INFO] [stderr] 28 | | [INFO] [stderr] 29 | | for point in points.iter() { [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused import: `num_traits::real::Real` [INFO] [stderr] --> src/bin/day6.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use num_traits::real::Real; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused label `'x` [INFO] [stderr] --> src/bin/day6.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | 'x: for x in 0..SIZE { [INFO] [stderr] | _________^ [INFO] [stderr] 27 | | let mut total_distance = 0; [INFO] [stderr] 28 | | [INFO] [stderr] 29 | | for point in points.iter() { [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day7.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | const INPUT: &'static str = include_str!("../../day7_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/day7.rs:105:11 [INFO] [stderr] | [INFO] [stderr] 105 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 106 | | if let Some(value) = call_stack.pop() { [INFO] [stderr] 107 | | stalled = false; [INFO] [stderr] 108 | | worker.current_value = Some(value.clone()); [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 105 | } else if let Some(value) = call_stack.pop() { [INFO] [stderr] 106 | stalled = false; [INFO] [stderr] 107 | worker.current_value = Some(value.clone()); [INFO] [stderr] 108 | //println!("{}", value.c); [INFO] [stderr] 109 | worker.time_left = setup_time + (value.c as usize - 'A' as usize); [INFO] [stderr] 110 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/bin/day7.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | for (i, worker) in &mut workers.iter_mut().enumerate() { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day7.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | const INPUT: &'static str = include_str!("../../day7_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/day7.rs:105:11 [INFO] [stderr] | [INFO] [stderr] 105 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 106 | | if let Some(value) = call_stack.pop() { [INFO] [stderr] 107 | | stalled = false; [INFO] [stderr] 108 | | worker.current_value = Some(value.clone()); [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 105 | } else if let Some(value) = call_stack.pop() { [INFO] [stderr] 106 | stalled = false; [INFO] [stderr] 107 | worker.current_value = Some(value.clone()); [INFO] [stderr] 108 | //println!("{}", value.c); [INFO] [stderr] 109 | worker.time_left = setup_time + (value.c as usize - 'A' as usize); [INFO] [stderr] 110 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/bin/day7.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | let keys = run_map.keys().map(|c| *c).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `run_map.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/bin/day7.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | for (i, worker) in &mut workers.iter_mut().enumerate() { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day4.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | const INPUT: &'static str = include_str!("../../day4_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day5.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | const INPUT: &'static str = include_str!("../../day5_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/bin/day7.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | let keys = run_map.keys().map(|c| *c).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `run_map.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/day4.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let mut inputs = INPUT [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/bin/day4.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | u32::cmp(&b.get(0).map(|v| *v.1).unwrap_or(Default::default()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `b.get(0).map(|v| *v.1).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day1.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("../../freq_deltas.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/bin/day4.rs:96:23 [INFO] [stderr] | [INFO] [stderr] 96 | &a.get(0).map(|v| *v.1).unwrap_or(Default::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `a.get(0).map(|v| *v.1).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused import: `num_traits::real::Real` [INFO] [stderr] --> src/bin/day5.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use num_traits::real::Real; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day2.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | const INPUT: &'static str = include_str!("../../day2_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/day5.rs:7:6 [INFO] [stderr] | [INFO] [stderr] 7 | let mut input = INPUT.chars().filter(|c| c.is_alphabetic()).collect_vec(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/day5.rs:9:35 [INFO] [stderr] | [INFO] [stderr] 9 | let units = (0..26).map(|x| (x + 'a' as u8) as char); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: variable `bestLen` should have a snake case name such as `best_len` [INFO] [stderr] --> src/bin/day5.rs:11:6 [INFO] [stderr] | [INFO] [stderr] 11 | let mut bestLen = ::std::usize::MAX; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/bin/day5.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | let mut input = input.iter().filter(|&&c| { [INFO] [stderr] | _________________________^ [INFO] [stderr] 15 | | c.to_ascii_lowercase() != unit [INFO] [stderr] 16 | | }).map(|&c| c).collect_vec(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 14 | let mut input = input.iter().filter(|&&c| { [INFO] [stderr] 15 | c.to_ascii_lowercase() != unit [INFO] [stderr] 16 | }).cloned().collect_vec(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable `leftC` should have a snake case name such as `left_c` [INFO] [stderr] --> src/bin/day5.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | let leftC = input[i]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `rightC` should have a snake case name such as `right_c` [INFO] [stderr] --> src/bin/day5.rs:22:8 [INFO] [stderr] | [INFO] [stderr] 22 | let rightC = input[i + 1]; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day4.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | const INPUT: &'static str = include_str!("../../day4_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/day4.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let mut inputs = INPUT [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/bin/day4.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | u32::cmp(&b.get(0).map(|v| *v.1).unwrap_or(Default::default()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `b.get(0).map(|v| *v.1).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/bin/day4.rs:96:23 [INFO] [stderr] | [INFO] [stderr] 96 | &a.get(0).map(|v| *v.1).unwrap_or(Default::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `a.get(0).map(|v| *v.1).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day1.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("../../freq_deltas.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `gif::Encoder` [INFO] [stderr] --> src/bin/day3.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use gif::Encoder; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::borrow::Cow` [INFO] [stderr] --> src/bin/day3.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::borrow::Cow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day3.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | const INPUT: &'static str = include_str!("../../day3_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `update_info` [INFO] [stderr] --> src/bin/day3.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | let mut update_info = false; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_update_info` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/day3.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let mut image = File::create("day3_timelapse.gif").unwrap(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/day3.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let mut update_info = false; [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bin/day3.rs:139:33 [INFO] [stderr] | [INFO] [stderr] 139 | let middle_width = (width as f32 * progress_percent) as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bin/day3.rs:174:33 [INFO] [stderr] | [INFO] [stderr] 174 | let middle_width = (width as f32 * overlap_percent) as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `gif::Encoder` [INFO] [stderr] --> src/bin/day3.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use gif::Encoder; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::borrow::Cow` [INFO] [stderr] --> src/bin/day3.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::borrow::Cow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day3.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | const INPUT: &'static str = include_str!("../../day3_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `update_info` [INFO] [stderr] --> src/bin/day3.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | let mut update_info = false; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_update_info` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/day3.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let mut image = File::create("day3_timelapse.gif").unwrap(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/day3.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let mut update_info = false; [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bin/day3.rs:139:33 [INFO] [stderr] | [INFO] [stderr] 139 | let middle_width = (width as f32 * progress_percent) as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/bin/day3.rs:174:33 [INFO] [stderr] | [INFO] [stderr] 174 | let middle_width = (width as f32 * overlap_percent) as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.39s [INFO] running `"docker" "inspect" "8560687fe6e66ab565dc91fcb5f97ad3948faf9102e68475c24a9df8a9bb2571"` [INFO] running `"docker" "rm" "-f" "8560687fe6e66ab565dc91fcb5f97ad3948faf9102e68475c24a9df8a9bb2571"` [INFO] [stdout] 8560687fe6e66ab565dc91fcb5f97ad3948faf9102e68475c24a9df8a9bb2571