[INFO] updating cached repository Freaky/simplepass [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Freaky/simplepass [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Freaky/simplepass" "work/ex/clippy-test-run/sources/stable/gh/Freaky/simplepass"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Freaky/simplepass'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Freaky/simplepass" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Freaky/simplepass"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Freaky/simplepass'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e780f8733cae782e61a7832d9b56d6bc057c4f74 [INFO] sha for GitHub repo Freaky/simplepass: e780f8733cae782e61a7832d9b56d6bc057c4f74 [INFO] validating manifest of Freaky/simplepass on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Freaky/simplepass on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Freaky/simplepass [INFO] finished frobbing Freaky/simplepass [INFO] frobbed toml for Freaky/simplepass written to work/ex/clippy-test-run/sources/stable/gh/Freaky/simplepass/Cargo.toml [INFO] started frobbing Freaky/simplepass [INFO] finished frobbing Freaky/simplepass [INFO] frobbed toml for Freaky/simplepass written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Freaky/simplepass/Cargo.toml [INFO] crate Freaky/simplepass has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Freaky/simplepass against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Freaky/simplepass:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 21fbcc561e5a6131cc6c057b24836981c12c832003710166e016c59c4f2aefdc [INFO] running `"docker" "start" "-a" "21fbcc561e5a6131cc6c057b24836981c12c832003710166e016c59c4f2aefdc"` [INFO] [stderr] Compiling proc-macro2 v0.4.11 [INFO] [stderr] Compiling quote v0.6.6 [INFO] [stderr] Compiling syn v0.14.8 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking simplepass v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / repeat_with(|| rng.choose(&dict).expect("dictionary shouldn't be empty")) [INFO] [stderr] 54 | | .take(opts.length) [INFO] [stderr] 55 | | .map(|s| *s) [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 53 | repeat_with(|| rng.choose(&dict).expect("dictionary shouldn't be empty")) [INFO] [stderr] 54 | .take(opts.length).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / repeat_with(|| rng.choose(&dict).expect("dictionary shouldn't be empty")) [INFO] [stderr] 54 | | .take(opts.length) [INFO] [stderr] 55 | | .map(|s| *s) [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 53 | repeat_with(|| rng.choose(&dict).expect("dictionary shouldn't be empty")) [INFO] [stderr] 54 | .take(opts.length).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.82s [INFO] running `"docker" "inspect" "21fbcc561e5a6131cc6c057b24836981c12c832003710166e016c59c4f2aefdc"` [INFO] running `"docker" "rm" "-f" "21fbcc561e5a6131cc6c057b24836981c12c832003710166e016c59c4f2aefdc"` [INFO] [stdout] 21fbcc561e5a6131cc6c057b24836981c12c832003710166e016c59c4f2aefdc