[INFO] updating cached repository Floppy/ruby-version-badger [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Floppy/ruby-version-badger [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Floppy/ruby-version-badger" "work/ex/clippy-test-run/sources/stable/gh/Floppy/ruby-version-badger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Floppy/ruby-version-badger'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Floppy/ruby-version-badger" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Floppy/ruby-version-badger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Floppy/ruby-version-badger'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e94cf103ecb5c2a7c3942c2c94d819402f3b1c8d [INFO] sha for GitHub repo Floppy/ruby-version-badger: e94cf103ecb5c2a7c3942c2c94d819402f3b1c8d [INFO] validating manifest of Floppy/ruby-version-badger on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Floppy/ruby-version-badger on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Floppy/ruby-version-badger [INFO] finished frobbing Floppy/ruby-version-badger [INFO] frobbed toml for Floppy/ruby-version-badger written to work/ex/clippy-test-run/sources/stable/gh/Floppy/ruby-version-badger/Cargo.toml [INFO] started frobbing Floppy/ruby-version-badger [INFO] finished frobbing Floppy/ruby-version-badger [INFO] frobbed toml for Floppy/ruby-version-badger written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Floppy/ruby-version-badger/Cargo.toml [INFO] crate Floppy/ruby-version-badger has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Floppy/ruby-version-badger against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Floppy/ruby-version-badger:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ad1d7345d9a2aeabf89b7cccf1d33ecfffedfad8c90c93533724b5f7fb68c038 [INFO] running `"docker" "start" "-a" "ad1d7345d9a2aeabf89b7cccf1d33ecfffedfad8c90c93533724b5f7fb68c038"` [INFO] [stderr] warning: unused manifest key: package.target [INFO] [stderr] Checking serde_json v1.0.10 [INFO] [stderr] Checking openssl-sys v0.9.27 [INFO] [stderr] Checking regex v0.2.6 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking hyper v0.11.21 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking mount v0.3.0 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking staticfile v0.4.0 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking ruby-version-badger v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return Ok(docs[0].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(docs[0].clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/github.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return Ok(resp.status().is_success()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(resp.status().is_success())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/github.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return Ok(file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ruby.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / return github::exists( [INFO] [stderr] 7 | | user, [INFO] [stderr] 8 | | repo, [INFO] [stderr] 9 | | &"master".to_string(), [INFO] [stderr] 10 | | &"Gemfile".to_string() [INFO] [stderr] 11 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 6 | github::exists( [INFO] [stderr] 7 | user, [INFO] [stderr] 8 | repo, [INFO] [stderr] 9 | &"master".to_string(), [INFO] [stderr] 10 | &"Gemfile".to_string() [INFO] [stderr] 11 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ruby.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return "ruby".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"ruby".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ruby.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return Ok(version.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(version.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rust.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / return github::exists( [INFO] [stderr] 7 | | user, [INFO] [stderr] 8 | | repo, [INFO] [stderr] 9 | | &"master".to_string(), [INFO] [stderr] 10 | | &"Cargo.toml".to_string() [INFO] [stderr] 11 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 6 | github::exists( [INFO] [stderr] 7 | user, [INFO] [stderr] 8 | repo, [INFO] [stderr] 9 | &"master".to_string(), [INFO] [stderr] 10 | &"Cargo.toml".to_string() [INFO] [stderr] 11 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rust.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return "rust".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"rust".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rust.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return Ok(version.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(version.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / return github::exists( [INFO] [stderr] 7 | | user, [INFO] [stderr] 8 | | repo, [INFO] [stderr] 9 | | &"master".to_string(), [INFO] [stderr] 10 | | &"package.json".to_string() [INFO] [stderr] 11 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 6 | github::exists( [INFO] [stderr] 7 | user, [INFO] [stderr] 8 | repo, [INFO] [stderr] 9 | &"master".to_string(), [INFO] [stderr] 10 | &"package.json".to_string() [INFO] [stderr] 11 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return "rust".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"rust".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return Ok(version.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(version.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return Ok(docs[0].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(docs[0].clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/github.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return Ok(resp.status().is_success()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(resp.status().is_success())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/github.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return Ok(file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ruby.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / return github::exists( [INFO] [stderr] 7 | | user, [INFO] [stderr] 8 | | repo, [INFO] [stderr] 9 | | &"master".to_string(), [INFO] [stderr] 10 | | &"Gemfile".to_string() [INFO] [stderr] 11 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 6 | github::exists( [INFO] [stderr] 7 | user, [INFO] [stderr] 8 | repo, [INFO] [stderr] 9 | &"master".to_string(), [INFO] [stderr] 10 | &"Gemfile".to_string() [INFO] [stderr] 11 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ruby.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return "ruby".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"ruby".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ruby.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return Ok(version.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(version.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rust.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / return github::exists( [INFO] [stderr] 7 | | user, [INFO] [stderr] 8 | | repo, [INFO] [stderr] 9 | | &"master".to_string(), [INFO] [stderr] 10 | | &"Cargo.toml".to_string() [INFO] [stderr] 11 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 6 | github::exists( [INFO] [stderr] 7 | user, [INFO] [stderr] 8 | repo, [INFO] [stderr] 9 | &"master".to_string(), [INFO] [stderr] 10 | &"Cargo.toml".to_string() [INFO] [stderr] 11 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rust.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return "rust".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"rust".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rust.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return Ok(version.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(version.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / return github::exists( [INFO] [stderr] 7 | | user, [INFO] [stderr] 8 | | repo, [INFO] [stderr] 9 | | &"master".to_string(), [INFO] [stderr] 10 | | &"package.json".to_string() [INFO] [stderr] 11 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 6 | github::exists( [INFO] [stderr] 7 | user, [INFO] [stderr] 8 | repo, [INFO] [stderr] 9 | &"master".to_string(), [INFO] [stderr] 10 | &"package.json".to_string() [INFO] [stderr] 11 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return "rust".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"rust".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return Ok(version.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(version.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `version` is never read [INFO] [stderr] --> src/ruby.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let mut version = "unknown".to_string(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `version` is never read [INFO] [stderr] --> src/rust.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let mut version = "unknown".to_string(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `version` is never read [INFO] [stderr] --> src/node.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut version = "unknown".to_string(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `version` is never read [INFO] [stderr] --> src/ruby.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let mut version = "unknown".to_string(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `version` is never read [INFO] [stderr] --> src/rust.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let mut version = "unknown".to_string(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `version` is never read [INFO] [stderr] --> src/node.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut version = "unknown".to_string(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | env::var("PORT").unwrap_or("3000".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "3000".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn exists(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:3:36 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn exists(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:3:53 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn exists(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:3:72 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn exists(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function is never used: `language` [INFO] [stderr] --> src/config.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn language(lang: String) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | env::var("PORT").unwrap_or("3000".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "3000".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn get(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn get(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:9:50 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn get(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:9:69 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn get(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruby.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn detected(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruby.rs:5:38 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn detected(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruby.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn version(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruby.rs:18:37 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn version(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruby.rs:33:24 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn colour(version: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn exists(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:3:36 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn exists(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:3:53 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn exists(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:3:72 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn exists(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rust.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn detected(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rust.rs:5:38 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn detected(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rust.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn version(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rust.rs:18:37 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn version(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn get(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn get(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:9:50 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn get(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/github.rs:9:69 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn get(user: &String, repo: &String, branch: &String, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rust.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn colour(version: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruby.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn detected(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruby.rs:5:38 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn detected(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruby.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn version(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruby.rs:18:37 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn version(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruby.rs:33:24 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn colour(version: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/node.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn detected(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/node.rs:5:38 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn detected(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/node.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn version(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/node.rs:17:37 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn version(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rust.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn detected(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rust.rs:5:38 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn detected(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rust.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn version(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rust.rs:18:37 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn version(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/node.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn colour(version: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | env_logger::init(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rust.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn colour(version: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/node.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn detected(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/node.rs:5:38 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn detected(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/node.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn version(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/node.rs:17:37 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn version(user: &String, repo: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/node.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn colour(version: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | env_logger::init(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.73s [INFO] running `"docker" "inspect" "ad1d7345d9a2aeabf89b7cccf1d33ecfffedfad8c90c93533724b5f7fb68c038"` [INFO] running `"docker" "rm" "-f" "ad1d7345d9a2aeabf89b7cccf1d33ecfffedfad8c90c93533724b5f7fb68c038"` [INFO] [stdout] ad1d7345d9a2aeabf89b7cccf1d33ecfffedfad8c90c93533724b5f7fb68c038