[INFO] updating cached repository FlixCoder/EvoResNN [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FlixCoder/EvoResNN [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FlixCoder/EvoResNN" "work/ex/clippy-test-run/sources/stable/gh/FlixCoder/EvoResNN"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FlixCoder/EvoResNN'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FlixCoder/EvoResNN" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FlixCoder/EvoResNN"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FlixCoder/EvoResNN'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b5d3825ca2213850060ed3d722795e99d96d6e0f [INFO] sha for GitHub repo FlixCoder/EvoResNN: b5d3825ca2213850060ed3d722795e99d96d6e0f [INFO] validating manifest of FlixCoder/EvoResNN on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FlixCoder/EvoResNN on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FlixCoder/EvoResNN [INFO] finished frobbing FlixCoder/EvoResNN [INFO] frobbed toml for FlixCoder/EvoResNN written to work/ex/clippy-test-run/sources/stable/gh/FlixCoder/EvoResNN/Cargo.toml [INFO] started frobbing FlixCoder/EvoResNN [INFO] finished frobbing FlixCoder/EvoResNN [INFO] frobbed toml for FlixCoder/EvoResNN written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FlixCoder/EvoResNN/Cargo.toml [INFO] crate FlixCoder/EvoResNN has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FlixCoder/EvoResNN against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FlixCoder/EvoResNN:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9b598091afd0574bb3b27b77229926053e1634cbaa90e87841bdc389b9382136 [INFO] running `"docker" "start" "-a" "9b598091afd0574bb3b27b77229926053e1634cbaa90e87841bdc389b9382136"` [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking cfg-if v0.1.4 [INFO] [stderr] Checking lazy_static v1.0.1 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Compiling serde v1.0.68 [INFO] [stderr] Checking itoa v0.4.1 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking dtoa v0.4.2 [INFO] [stderr] Compiling proc-macro2 v0.4.6 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Checking rayon v0.9.0 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Checking serde_json v1.0.22 [INFO] [stderr] Compiling serde_derive v1.0.68 [INFO] [stderr] Checking ernn v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:117:54 [INFO] [stderr] | [INFO] [stderr] 117 | NN { generation: 0, blocks: 0, num_inputs: inputs, hidden_size: hidden_size, num_outputs: outputs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hidden_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:118:61 [INFO] [stderr] | [INFO] [stderr] 118 | hid_act: hidden_activation, out_act: output_activation, layers: layers } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:117:54 [INFO] [stderr] | [INFO] [stderr] 117 | NN { generation: 0, blocks: 0, num_inputs: inputs, hidden_size: hidden_size, num_outputs: outputs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hidden_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:118:61 [INFO] [stderr] | [INFO] [stderr] 118 | hid_act: hidden_activation, out_act: output_activation, layers: layers } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:117:54 [INFO] [stderr] | [INFO] [stderr] 117 | NN { generation: 0, blocks: 0, num_inputs: inputs, hidden_size: hidden_size, num_outputs: outputs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hidden_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:118:61 [INFO] [stderr] | [INFO] [stderr] 118 | hid_act: hidden_activation, out_act: output_activation, layers: layers } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:322:7 [INFO] [stderr] | [INFO] [stderr] 322 | { [INFO] [stderr] | _________________________^ [INFO] [stderr] 323 | | if rng.gen::() < 0.5 [INFO] [stderr] 324 | | { //random if stay at current weight or take father's/mother's [INFO] [stderr] 325 | | node[weight_index] = layer2val; [INFO] [stderr] 326 | | } [INFO] [stderr] 327 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 322 | if rng.gen::() < 0.5 [INFO] [stderr] 323 | { //random if stay at current weight or take father's/mother's [INFO] [stderr] 324 | node[weight_index] = layer2val; [INFO] [stderr] 325 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:322:7 [INFO] [stderr] | [INFO] [stderr] 322 | { [INFO] [stderr] | _________________________^ [INFO] [stderr] 323 | | if rng.gen::() < 0.5 [INFO] [stderr] 324 | | { //random if stay at current weight or take father's/mother's [INFO] [stderr] 325 | | node[weight_index] = layer2val; [INFO] [stderr] 326 | | } [INFO] [stderr] 327 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 322 | if rng.gen::() < 0.5 [INFO] [stderr] 323 | { //random if stay at current weight or take father's/mother's [INFO] [stderr] 324 | node[weight_index] = layer2val; [INFO] [stderr] 325 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:772:5 [INFO] [stderr] | [INFO] [stderr] 772 | { [INFO] [stderr] | _________________^ [INFO] [stderr] 773 | | if r1.1.is_nan() { if r2.1.is_nan() { Ordering::Equal } else { Ordering::Greater } } else { Ordering::Less } [INFO] [stderr] 774 | | } [INFO] [stderr] | |_________________^ help: try: `if r1.1.is_nan() { if r2.1.is_nan() { Ordering::Equal } else { Ordering::Greater } } else { Ordering::Less }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:772:5 [INFO] [stderr] | [INFO] [stderr] 772 | { [INFO] [stderr] | _________________^ [INFO] [stderr] 773 | | if r1.1.is_nan() { if r2.1.is_nan() { Ordering::Equal } else { Ordering::Greater } } else { Ordering::Less } [INFO] [stderr] 774 | | } [INFO] [stderr] | |_________________^ help: try: `if r1.1.is_nan() { if r2.1.is_nan() { Ordering::Equal } else { Ordering::Greater } } else { Ordering::Less }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:322:7 [INFO] [stderr] | [INFO] [stderr] 322 | { [INFO] [stderr] | _________________________^ [INFO] [stderr] 323 | | if rng.gen::() < 0.5 [INFO] [stderr] 324 | | { //random if stay at current weight or take father's/mother's [INFO] [stderr] 325 | | node[weight_index] = layer2val; [INFO] [stderr] 326 | | } [INFO] [stderr] 327 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 322 | if rng.gen::() < 0.5 [INFO] [stderr] 323 | { //random if stay at current weight or take father's/mother's [INFO] [stderr] 324 | node[weight_index] = layer2val; [INFO] [stderr] 325 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:772:5 [INFO] [stderr] | [INFO] [stderr] 772 | { [INFO] [stderr] | _________________^ [INFO] [stderr] 773 | | if r1.1.is_nan() { if r2.1.is_nan() { Ordering::Equal } else { Ordering::Greater } } else { Ordering::Less } [INFO] [stderr] 774 | | } [INFO] [stderr] | |_________________^ help: try: `if r1.1.is_nan() { if r2.1.is_nan() { Ordering::Equal } else { Ordering::Greater } } else { Ordering::Less }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:90:4 [INFO] [stderr] | [INFO] [stderr] 90 | let mut init_std_scale = 2.0; //He init [INFO] [stderr] | _____________^ [INFO] [stderr] 91 | | if hidden_activation == Activation::SELU { init_std_scale = 1.0; } //MSRA / Xavier init [INFO] [stderr] | |______________________________________________________________________________^ help: it is more idiomatic to write: `let init_std_scale = if hidden_activation == Activation::SELU { 1.0 } else { 2.0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:92:52 [INFO] [stderr] | [INFO] [stderr] 92 | let normal = Normal::new(0.0, (init_std_scale / prev_layer_size as f64).sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(prev_layer_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | for i in 0..prev_layer_size+1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=prev_layer_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:151:3 [INFO] [stderr] | [INFO] [stderr] 151 | serde_json::to_string(self).ok().expect("Encoding JSON failed!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | let network:NN = serde_json::from_str(encoded).ok().expect("Decoding JSON failed!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:172:8 [INFO] [stderr] | [INFO] [stderr] 172 | if k == 1.0 || rng.gen::() < k [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(k - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:172:8 [INFO] [stderr] | [INFO] [stderr] 172 | if k == 1.0 || rng.gen::() < k [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:181:6 [INFO] [stderr] | [INFO] [stderr] 181 | let act; [INFO] [stderr] | _____________________^ [INFO] [stderr] 182 | | if layer_index == self.layers.len()-1 //output layer [INFO] [stderr] 183 | | { act = self.out_act; } [INFO] [stderr] 184 | | else { act = self.hid_act; } [INFO] [stderr] | |________________________________________________^ help: it is more idiomatic to write: `let act = if layer_index == self.layers.len()-1 { self.out_act } else { self.hid_act };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the loop variable `node_index` is used to index `layer` [INFO] [stderr] --> src/lib.rs:301:23 [INFO] [stderr] | [INFO] [stderr] 301 | for node_index in 0..layer.len() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 301 | for (node_index, ) in layer.iter_mut().enumerate() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is used to index `node` [INFO] [stderr] --> src/lib.rs:304:26 [INFO] [stderr] | [INFO] [stderr] 304 | for weight_index in 0..node.len() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 304 | for (weight_index, ) in node.iter_mut().enumerate() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:317:10 [INFO] [stderr] | [INFO] [stderr] 317 | if prob_avg == 1.0 || (prob_avg != 0.0 && rng.gen::() < prob_avg) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(prob_avg - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:317:10 [INFO] [stderr] | [INFO] [stderr] 317 | if prob_avg == 1.0 || (prob_avg != 0.0 && rng.gen::() < prob_avg) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:394:3 [INFO] [stderr] | [INFO] [stderr] 394 | let mut init_std_scale = 2.0; //He init [INFO] [stderr] | _________^ [INFO] [stderr] 395 | | if self.hid_act == Activation::SELU { init_std_scale = 1.0; } //MSRA / Xavier init [INFO] [stderr] | |_____________________________________________________________________^ help: it is more idiomatic to write: `let init_std_scale = if self.hid_act == Activation::SELU { 1.0 } else { 2.0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the loop variable `node_index` is only used to index `layer`. [INFO] [stderr] --> src/lib.rs:401:22 [INFO] [stderr] | [INFO] [stderr] 401 | for node_index in 0..layer.len() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 401 | for in &mut layer [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is used to index `node` [INFO] [stderr] --> src/lib.rs:404:25 [INFO] [stderr] | [INFO] [stderr] 404 | for weight_index in 0..node.len() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 404 | for (weight_index, ) in node.iter_mut().enumerate() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `node_index` is only used to index `layer`. [INFO] [stderr] --> src/lib.rs:420:22 [INFO] [stderr] | [INFO] [stderr] 420 | for node_index in 0..layer.len() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 420 | for in &mut layer [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is only used to index `node`. [INFO] [stderr] --> src/lib.rs:423:25 [INFO] [stderr] | [INFO] [stderr] 423 | for weight_index in 0..node.len() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 423 | for in &mut node [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:508:27 [INFO] [stderr] | [INFO] [stderr] 508 | fn modified_dotprod(node: &Vec, values: &Vec) -> f64 [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:508:46 [INFO] [stderr] | [INFO] [stderr] 508 | fn modified_dotprod(node: &Vec, values: &Vec) -> f64 [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:562:3 [INFO] [stderr] | [INFO] [stderr] 562 | serde_json::to_string(&self.nets).ok().expect("Encoding JSON failed!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:568:15 [INFO] [stderr] | [INFO] [stderr] 568 | self.nets = serde_json::from_str(encoded).ok().expect("Decoding JSON failed!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:633:2 [INFO] [stderr] | [INFO] [stderr] 633 | pub fn optimize(&mut self, generations:u32, population:u32, survival:u32, bad_survival:u32, prob_avg:f64, prob_mut:f64, [INFO] [stderr] | _____^ [INFO] [stderr] 634 | | prob_new:f64, prob_block:f64, prob_op:f64, op_range:f64) -> f64 [INFO] [stderr] 635 | | { [INFO] [stderr] 636 | | //optimize for "generations" generations [INFO] [stderr] ... | [INFO] [stderr] 647 | | self.nets[0].1 [INFO] [stderr] 648 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:651:2 [INFO] [stderr] | [INFO] [stderr] 651 | pub fn optimize_par(&mut self, generations:u32, population:u32, survival:u32, bad_survival:u32, prob_avg:f64, prob_mut:f64, [INFO] [stderr] | _____^ [INFO] [stderr] 652 | | prob_new:f64, prob_block:f64, prob_op:f64, op_range:f64) -> f64 [INFO] [stderr] 653 | | where T:Sync [INFO] [stderr] 654 | | { [INFO] [stderr] ... | [INFO] [stderr] 666 | | self.nets[0].1 [INFO] [stderr] 667 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:703:2 [INFO] [stderr] | [INFO] [stderr] 703 | fn populate(&self, size:usize, prob_avg:f64, prob_mut:f64, prob_new:f64, prob_block:f64, prob_op:f64, op_range:f64) -> Vec<(NN, f64)> [INFO] [stderr] | _____^ [INFO] [stderr] 704 | | { [INFO] [stderr] 705 | | let mut rng = rand::thread_rng(); [INFO] [stderr] 706 | | let len = self.nets.len(); [INFO] [stderr] ... | [INFO] [stderr] 725 | | newpop [INFO] [stderr] 726 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ernn`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:90:4 [INFO] [stderr] | [INFO] [stderr] 90 | let mut init_std_scale = 2.0; //He init [INFO] [stderr] | _____________^ [INFO] [stderr] 91 | | if hidden_activation == Activation::SELU { init_std_scale = 1.0; } //MSRA / Xavier init [INFO] [stderr] | |______________________________________________________________________________^ help: it is more idiomatic to write: `let init_std_scale = if hidden_activation == Activation::SELU { 1.0 } else { 2.0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:92:52 [INFO] [stderr] | [INFO] [stderr] 92 | let normal = Normal::new(0.0, (init_std_scale / prev_layer_size as f64).sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(prev_layer_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | for i in 0..prev_layer_size+1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=prev_layer_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:151:3 [INFO] [stderr] | [INFO] [stderr] 151 | serde_json::to_string(self).ok().expect("Encoding JSON failed!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | let network:NN = serde_json::from_str(encoded).ok().expect("Decoding JSON failed!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:172:8 [INFO] [stderr] | [INFO] [stderr] 172 | if k == 1.0 || rng.gen::() < k [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(k - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:172:8 [INFO] [stderr] | [INFO] [stderr] 172 | if k == 1.0 || rng.gen::() < k [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:181:6 [INFO] [stderr] | [INFO] [stderr] 181 | let act; [INFO] [stderr] | _____________________^ [INFO] [stderr] 182 | | if layer_index == self.layers.len()-1 //output layer [INFO] [stderr] 183 | | { act = self.out_act; } [INFO] [stderr] 184 | | else { act = self.hid_act; } [INFO] [stderr] | |________________________________________________^ help: it is more idiomatic to write: `let act = if layer_index == self.layers.len()-1 { self.out_act } else { self.hid_act };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the loop variable `node_index` is used to index `layer` [INFO] [stderr] --> src/lib.rs:301:23 [INFO] [stderr] | [INFO] [stderr] 301 | for node_index in 0..layer.len() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 301 | for (node_index, ) in layer.iter_mut().enumerate() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is used to index `node` [INFO] [stderr] --> src/lib.rs:304:26 [INFO] [stderr] | [INFO] [stderr] 304 | for weight_index in 0..node.len() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 304 | for (weight_index, ) in node.iter_mut().enumerate() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:317:10 [INFO] [stderr] | [INFO] [stderr] 317 | if prob_avg == 1.0 || (prob_avg != 0.0 && rng.gen::() < prob_avg) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(prob_avg - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:317:10 [INFO] [stderr] | [INFO] [stderr] 317 | if prob_avg == 1.0 || (prob_avg != 0.0 && rng.gen::() < prob_avg) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:394:3 [INFO] [stderr] | [INFO] [stderr] 394 | let mut init_std_scale = 2.0; //He init [INFO] [stderr] | _________^ [INFO] [stderr] 395 | | if self.hid_act == Activation::SELU { init_std_scale = 1.0; } //MSRA / Xavier init [INFO] [stderr] | |_____________________________________________________________________^ help: it is more idiomatic to write: `let init_std_scale = if self.hid_act == Activation::SELU { 1.0 } else { 2.0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the loop variable `node_index` is only used to index `layer`. [INFO] [stderr] --> src/lib.rs:401:22 [INFO] [stderr] | [INFO] [stderr] 401 | for node_index in 0..layer.len() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 401 | for in &mut layer [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is used to index `node` [INFO] [stderr] --> src/lib.rs:404:25 [INFO] [stderr] | [INFO] [stderr] 404 | for weight_index in 0..node.len() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 404 | for (weight_index, ) in node.iter_mut().enumerate() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `node_index` is only used to index `layer`. [INFO] [stderr] --> src/lib.rs:420:22 [INFO] [stderr] | [INFO] [stderr] 420 | for node_index in 0..layer.len() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 420 | for in &mut layer [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is only used to index `node`. [INFO] [stderr] --> src/lib.rs:423:25 [INFO] [stderr] | [INFO] [stderr] 423 | for weight_index in 0..node.len() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 423 | for in &mut node [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:508:27 [INFO] [stderr] | [INFO] [stderr] 508 | fn modified_dotprod(node: &Vec, values: &Vec) -> f64 [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:508:46 [INFO] [stderr] | [INFO] [stderr] 508 | fn modified_dotprod(node: &Vec, values: &Vec) -> f64 [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:562:3 [INFO] [stderr] | [INFO] [stderr] 562 | serde_json::to_string(&self.nets).ok().expect("Encoding JSON failed!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:568:15 [INFO] [stderr] | [INFO] [stderr] 568 | self.nets = serde_json::from_str(encoded).ok().expect("Decoding JSON failed!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:633:2 [INFO] [stderr] | [INFO] [stderr] 633 | pub fn optimize(&mut self, generations:u32, population:u32, survival:u32, bad_survival:u32, prob_avg:f64, prob_mut:f64, [INFO] [stderr] | _____^ [INFO] [stderr] 634 | | prob_new:f64, prob_block:f64, prob_op:f64, op_range:f64) -> f64 [INFO] [stderr] 635 | | { [INFO] [stderr] 636 | | //optimize for "generations" generations [INFO] [stderr] ... | [INFO] [stderr] 647 | | self.nets[0].1 [INFO] [stderr] 648 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:651:2 [INFO] [stderr] | [INFO] [stderr] 651 | pub fn optimize_par(&mut self, generations:u32, population:u32, survival:u32, bad_survival:u32, prob_avg:f64, prob_mut:f64, [INFO] [stderr] | _____^ [INFO] [stderr] 652 | | prob_new:f64, prob_block:f64, prob_op:f64, op_range:f64) -> f64 [INFO] [stderr] 653 | | where T:Sync [INFO] [stderr] 654 | | { [INFO] [stderr] ... | [INFO] [stderr] 666 | | self.nets[0].1 [INFO] [stderr] 667 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:703:2 [INFO] [stderr] | [INFO] [stderr] 703 | fn populate(&self, size:usize, prob_avg:f64, prob_mut:f64, prob_new:f64, prob_block:f64, prob_op:f64, op_range:f64) -> Vec<(NN, f64)> [INFO] [stderr] | _____^ [INFO] [stderr] 704 | | { [INFO] [stderr] 705 | | let mut rng = rand::thread_rng(); [INFO] [stderr] 706 | | let len = self.nets.len(); [INFO] [stderr] ... | [INFO] [stderr] 725 | | newpop [INFO] [stderr] 726 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:90:4 [INFO] [stderr] | [INFO] [stderr] 90 | let mut init_std_scale = 2.0; //He init [INFO] [stderr] | _____________^ [INFO] [stderr] 91 | | if hidden_activation == Activation::SELU { init_std_scale = 1.0; } //MSRA / Xavier init [INFO] [stderr] | |______________________________________________________________________________^ help: it is more idiomatic to write: `let init_std_scale = if hidden_activation == Activation::SELU { 1.0 } else { 2.0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:92:52 [INFO] [stderr] | [INFO] [stderr] 92 | let normal = Normal::new(0.0, (init_std_scale / prev_layer_size as f64).sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(prev_layer_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | for i in 0..prev_layer_size+1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=prev_layer_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:151:3 [INFO] [stderr] | [INFO] [stderr] 151 | serde_json::to_string(self).ok().expect("Encoding JSON failed!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | let network:NN = serde_json::from_str(encoded).ok().expect("Decoding JSON failed!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:172:8 [INFO] [stderr] | [INFO] [stderr] 172 | if k == 1.0 || rng.gen::() < k [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(k - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:172:8 [INFO] [stderr] | [INFO] [stderr] 172 | if k == 1.0 || rng.gen::() < k [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:181:6 [INFO] [stderr] | [INFO] [stderr] 181 | let act; [INFO] [stderr] | _____________________^ [INFO] [stderr] 182 | | if layer_index == self.layers.len()-1 //output layer [INFO] [stderr] 183 | | { act = self.out_act; } [INFO] [stderr] 184 | | else { act = self.hid_act; } [INFO] [stderr] | |________________________________________________^ help: it is more idiomatic to write: `let act = if layer_index == self.layers.len()-1 { self.out_act } else { self.hid_act };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: Could not compile `ernn`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the loop variable `node_index` is used to index `layer` [INFO] [stderr] --> src/lib.rs:301:23 [INFO] [stderr] | [INFO] [stderr] 301 | for node_index in 0..layer.len() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 301 | for (node_index, ) in layer.iter_mut().enumerate() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is used to index `node` [INFO] [stderr] --> src/lib.rs:304:26 [INFO] [stderr] | [INFO] [stderr] 304 | for weight_index in 0..node.len() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 304 | for (weight_index, ) in node.iter_mut().enumerate() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:317:10 [INFO] [stderr] | [INFO] [stderr] 317 | if prob_avg == 1.0 || (prob_avg != 0.0 && rng.gen::() < prob_avg) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(prob_avg - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:317:10 [INFO] [stderr] | [INFO] [stderr] 317 | if prob_avg == 1.0 || (prob_avg != 0.0 && rng.gen::() < prob_avg) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:394:3 [INFO] [stderr] | [INFO] [stderr] 394 | let mut init_std_scale = 2.0; //He init [INFO] [stderr] | _________^ [INFO] [stderr] 395 | | if self.hid_act == Activation::SELU { init_std_scale = 1.0; } //MSRA / Xavier init [INFO] [stderr] | |_____________________________________________________________________^ help: it is more idiomatic to write: `let init_std_scale = if self.hid_act == Activation::SELU { 1.0 } else { 2.0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the loop variable `node_index` is only used to index `layer`. [INFO] [stderr] --> src/lib.rs:401:22 [INFO] [stderr] | [INFO] [stderr] 401 | for node_index in 0..layer.len() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 401 | for in &mut layer [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is used to index `node` [INFO] [stderr] --> src/lib.rs:404:25 [INFO] [stderr] | [INFO] [stderr] 404 | for weight_index in 0..node.len() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 404 | for (weight_index, ) in node.iter_mut().enumerate() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `node_index` is only used to index `layer`. [INFO] [stderr] --> src/lib.rs:420:22 [INFO] [stderr] | [INFO] [stderr] 420 | for node_index in 0..layer.len() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 420 | for in &mut layer [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is only used to index `node`. [INFO] [stderr] --> src/lib.rs:423:25 [INFO] [stderr] | [INFO] [stderr] 423 | for weight_index in 0..node.len() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 423 | for in &mut node [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:508:27 [INFO] [stderr] | [INFO] [stderr] 508 | fn modified_dotprod(node: &Vec, values: &Vec) -> f64 [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:508:46 [INFO] [stderr] | [INFO] [stderr] 508 | fn modified_dotprod(node: &Vec, values: &Vec) -> f64 [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:562:3 [INFO] [stderr] | [INFO] [stderr] 562 | serde_json::to_string(&self.nets).ok().expect("Encoding JSON failed!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:568:15 [INFO] [stderr] | [INFO] [stderr] 568 | self.nets = serde_json::from_str(encoded).ok().expect("Decoding JSON failed!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:633:2 [INFO] [stderr] | [INFO] [stderr] 633 | pub fn optimize(&mut self, generations:u32, population:u32, survival:u32, bad_survival:u32, prob_avg:f64, prob_mut:f64, [INFO] [stderr] | _____^ [INFO] [stderr] 634 | | prob_new:f64, prob_block:f64, prob_op:f64, op_range:f64) -> f64 [INFO] [stderr] 635 | | { [INFO] [stderr] 636 | | //optimize for "generations" generations [INFO] [stderr] ... | [INFO] [stderr] 647 | | self.nets[0].1 [INFO] [stderr] 648 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:651:2 [INFO] [stderr] | [INFO] [stderr] 651 | pub fn optimize_par(&mut self, generations:u32, population:u32, survival:u32, bad_survival:u32, prob_avg:f64, prob_mut:f64, [INFO] [stderr] | _____^ [INFO] [stderr] 652 | | prob_new:f64, prob_block:f64, prob_op:f64, op_range:f64) -> f64 [INFO] [stderr] 653 | | where T:Sync [INFO] [stderr] 654 | | { [INFO] [stderr] ... | [INFO] [stderr] 666 | | self.nets[0].1 [INFO] [stderr] 667 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:703:2 [INFO] [stderr] | [INFO] [stderr] 703 | fn populate(&self, size:usize, prob_avg:f64, prob_mut:f64, prob_new:f64, prob_block:f64, prob_op:f64, op_range:f64) -> Vec<(NN, f64)> [INFO] [stderr] | _____^ [INFO] [stderr] 704 | | { [INFO] [stderr] 705 | | let mut rng = rand::thread_rng(); [INFO] [stderr] 706 | | let len = self.nets.len(); [INFO] [stderr] ... | [INFO] [stderr] 725 | | newpop [INFO] [stderr] 726 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ernn`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9b598091afd0574bb3b27b77229926053e1634cbaa90e87841bdc389b9382136"` [INFO] running `"docker" "rm" "-f" "9b598091afd0574bb3b27b77229926053e1634cbaa90e87841bdc389b9382136"` [INFO] [stdout] 9b598091afd0574bb3b27b77229926053e1634cbaa90e87841bdc389b9382136