[INFO] updating cached repository Fitzsimmons/subreaper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Fitzsimmons/subreaper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Fitzsimmons/subreaper" "work/ex/clippy-test-run/sources/stable/gh/Fitzsimmons/subreaper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Fitzsimmons/subreaper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Fitzsimmons/subreaper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fitzsimmons/subreaper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fitzsimmons/subreaper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 21a73e4517e4a433cb76918dbac2ba685ce55fbb [INFO] sha for GitHub repo Fitzsimmons/subreaper: 21a73e4517e4a433cb76918dbac2ba685ce55fbb [INFO] validating manifest of Fitzsimmons/subreaper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Fitzsimmons/subreaper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Fitzsimmons/subreaper [INFO] finished frobbing Fitzsimmons/subreaper [INFO] frobbed toml for Fitzsimmons/subreaper written to work/ex/clippy-test-run/sources/stable/gh/Fitzsimmons/subreaper/Cargo.toml [INFO] started frobbing Fitzsimmons/subreaper [INFO] finished frobbing Fitzsimmons/subreaper [INFO] frobbed toml for Fitzsimmons/subreaper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fitzsimmons/subreaper/Cargo.toml [INFO] crate Fitzsimmons/subreaper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Fitzsimmons/subreaper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Fitzsimmons/subreaper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1eca17075d305a5c6f502359b45b089b71ec5264b1d12ba4b2929ec223805b5d [INFO] running `"docker" "start" "-a" "1eca17075d305a5c6f502359b45b089b71ec5264b1d12ba4b2929ec223805b5d"` [INFO] [stderr] Checking subreaper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | grandchild_pid: grandchild_pid [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `grandchild_pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | grandchild_pid: grandchild_pid [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `grandchild_pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | let grandchild_pid: i32 = pid_string.parse::().ok().expect("couldn't parse pid from child's output"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | let grandchild_pid: i32 = pid_string.parse::().ok().expect("couldn't parse pid from child's output"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.02s [INFO] running `"docker" "inspect" "1eca17075d305a5c6f502359b45b089b71ec5264b1d12ba4b2929ec223805b5d"` [INFO] running `"docker" "rm" "-f" "1eca17075d305a5c6f502359b45b089b71ec5264b1d12ba4b2929ec223805b5d"` [INFO] [stdout] 1eca17075d305a5c6f502359b45b089b71ec5264b1d12ba4b2929ec223805b5d