[INFO] updating cached repository Fingel/rideprofile [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Fingel/rideprofile [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Fingel/rideprofile" "work/ex/clippy-test-run/sources/stable/gh/Fingel/rideprofile"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Fingel/rideprofile'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Fingel/rideprofile" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fingel/rideprofile"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fingel/rideprofile'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c0786c315e7cbd532007cf67373ad642af940310 [INFO] sha for GitHub repo Fingel/rideprofile: c0786c315e7cbd532007cf67373ad642af940310 [INFO] validating manifest of Fingel/rideprofile on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Fingel/rideprofile on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Fingel/rideprofile [INFO] finished frobbing Fingel/rideprofile [INFO] frobbed toml for Fingel/rideprofile written to work/ex/clippy-test-run/sources/stable/gh/Fingel/rideprofile/Cargo.toml [INFO] started frobbing Fingel/rideprofile [INFO] finished frobbing Fingel/rideprofile [INFO] frobbed toml for Fingel/rideprofile written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fingel/rideprofile/Cargo.toml [INFO] crate Fingel/rideprofile has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Fingel/rideprofile against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Fingel/rideprofile:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3ef1ca7495de17d63129f2effb651f5f2266b8c99965b46838909b15d5a264be [INFO] running `"docker" "start" "-a" "3ef1ca7495de17d63129f2effb651f5f2266b8c99965b46838909b15d5a264be"` [INFO] [stderr] Compiling bzip2-sys v0.1.5 [INFO] [stderr] Checking msdos_time v0.1.5 [INFO] [stderr] Checking xmltree v0.4.0 [INFO] [stderr] Checking miniz-sys v0.1.9 [INFO] [stderr] Checking flate2 v0.2.19 [INFO] [stderr] Checking bzip2 v0.3.2 [INFO] [stderr] Checking zip v0.2.3 [INFO] [stderr] Checking ride_profile v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | ele: ele, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ele` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | ele: ele, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ele` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return r * c; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `r * c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return title; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | return points; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return ele; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ele` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:129:16 [INFO] [stderr] | [INFO] [stderr] 129 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 130 | | if point.ele > points[idx - 1].ele { [INFO] [stderr] 131 | | ele += point.ele - points[idx - 1].ele; [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | } else if point.ele > points[idx - 1].ele { [INFO] [stderr] 130 | ele += point.ele - points[idx - 1].ele; [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | return d; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return r * c; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `r * c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return title; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | return points; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return ele; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ele` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:129:16 [INFO] [stderr] | [INFO] [stderr] 129 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 130 | | if point.ele > points[idx - 1].ele { [INFO] [stderr] 131 | | ele += point.ele - points[idx - 1].ele; [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | } else if point.ele > points[idx - 1].ele { [INFO] [stderr] 130 | ele += point.ele - points[idx - 1].ele; [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | return d; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let ref path = args[1]; [INFO] [stderr] | ----^^^^^^^^----------- help: try: `let path = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | let ref children = gpx_element [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | let children = &gpx_element [INFO] [stderr] 92 | .get_child("trk") [INFO] [stderr] 93 | .expect("not a vlaid gpx") [INFO] [stderr] 94 | .get_child("trkseg") [INFO] [stderr] 95 | .expect("not a valid gpx") [INFO] [stderr] 96 | .children; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:111:30 [INFO] [stderr] | [INFO] [stderr] 111 | lat: child.attributes.get("lat").unwrap().parse().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&child.attributes["lat"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:112:30 [INFO] [stderr] | [INFO] [stderr] 112 | lon: child.attributes.get("lon").unwrap().parse().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&child.attributes["lon"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:120:25 [INFO] [stderr] | [INFO] [stderr] 120 | fn get_duration(points: &Vec) -> Duration { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:124:26 [INFO] [stderr] | [INFO] [stderr] 124 | fn get_elevation(points: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let ref path = args[1]; [INFO] [stderr] | ----^^^^^^^^----------- help: try: `let path = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:138:25 [INFO] [stderr] | [INFO] [stderr] 138 | fn get_distance(points: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | d = d + distance(&point, &points[idx - 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `d += distance(&point, &points[idx - 1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | let ref children = gpx_element [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | let children = &gpx_element [INFO] [stderr] 92 | .get_child("trk") [INFO] [stderr] 93 | .expect("not a vlaid gpx") [INFO] [stderr] 94 | .get_child("trkseg") [INFO] [stderr] 95 | .expect("not a valid gpx") [INFO] [stderr] 96 | .children; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:111:30 [INFO] [stderr] | [INFO] [stderr] 111 | lat: child.attributes.get("lat").unwrap().parse().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&child.attributes["lat"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:112:30 [INFO] [stderr] | [INFO] [stderr] 112 | lon: child.attributes.get("lon").unwrap().parse().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&child.attributes["lon"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:120:25 [INFO] [stderr] | [INFO] [stderr] 120 | fn get_duration(points: &Vec) -> Duration { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:124:26 [INFO] [stderr] | [INFO] [stderr] 124 | fn get_elevation(points: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:138:25 [INFO] [stderr] | [INFO] [stderr] 138 | fn get_distance(points: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | d = d + distance(&point, &points[idx - 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `d += distance(&point, &points[idx - 1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.78s [INFO] running `"docker" "inspect" "3ef1ca7495de17d63129f2effb651f5f2266b8c99965b46838909b15d5a264be"` [INFO] running `"docker" "rm" "-f" "3ef1ca7495de17d63129f2effb651f5f2266b8c99965b46838909b15d5a264be"` [INFO] [stdout] 3ef1ca7495de17d63129f2effb651f5f2266b8c99965b46838909b15d5a264be