[INFO] updating cached repository FeliciousX/rust-2048 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FeliciousX/rust-2048 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FeliciousX/rust-2048" "work/ex/clippy-test-run/sources/stable/gh/FeliciousX/rust-2048"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FeliciousX/rust-2048'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FeliciousX/rust-2048" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FeliciousX/rust-2048"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FeliciousX/rust-2048'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f1ac76c6fd1c1bee9bbe9744848fb89752bd0614 [INFO] sha for GitHub repo FeliciousX/rust-2048: f1ac76c6fd1c1bee9bbe9744848fb89752bd0614 [INFO] validating manifest of FeliciousX/rust-2048 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FeliciousX/rust-2048 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FeliciousX/rust-2048 [INFO] finished frobbing FeliciousX/rust-2048 [INFO] frobbed toml for FeliciousX/rust-2048 written to work/ex/clippy-test-run/sources/stable/gh/FeliciousX/rust-2048/Cargo.toml [INFO] started frobbing FeliciousX/rust-2048 [INFO] finished frobbing FeliciousX/rust-2048 [INFO] frobbed toml for FeliciousX/rust-2048 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FeliciousX/rust-2048/Cargo.toml [INFO] crate FeliciousX/rust-2048 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FeliciousX/rust-2048 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FeliciousX/rust-2048:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83837b35a69025e92b5d55e251681e8e551a6145bc03c1a6b88bf00b182d1b18 [INFO] running `"docker" "start" "-a" "83837b35a69025e92b5d55e251681e8e551a6145bc03c1a6b88bf00b182d1b18"` [INFO] [stderr] Checking 2048_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/settings.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/settings.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/settings.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/settings.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/main.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `choice` [INFO] [stderr] --> src/app.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let choice = console::get_instruction(); [INFO] [stderr] | ^^^^^^ help: consider using `_choice` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/console.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | for i in 0..42 { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/console.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | for i in 0..42 { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player1` [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let player1 = player::Player::new(&name); [INFO] [stderr] | ^^^^^^^ help: consider using `_player1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `settings` [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let settings = settings::Settings::new(4, 4); [INFO] [stderr] | ^^^^^^^^ help: consider using `_settings` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/player.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `score` [INFO] [stderr] --> src/player.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | score: i32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `steps` [INFO] [stderr] --> src/player.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | steps: i32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `width` [INFO] [stderr] --> src/settings.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | width: i16, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `height` [INFO] [stderr] --> src/settings.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | height: i16, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Board` [INFO] [stderr] --> src/board.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | struct Board; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `tiles` [INFO] [stderr] --> src/tiles.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | struct tiles; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/console.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / io::stdin().read_line(&mut name) [INFO] [stderr] 20 | | .ok() [INFO] [stderr] 21 | | .expect("Failed to read name"); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/console.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / io::stdin().read_line(&mut instruction) [INFO] [stderr] 36 | | .ok() [INFO] [stderr] 37 | | .expect("Failed to read instruction"); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: type `tiles` should have a camel case name such as `Tiles` [INFO] [stderr] --> src/tiles.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | struct tiles; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/main.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `choice` [INFO] [stderr] --> src/app.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let choice = console::get_instruction(); [INFO] [stderr] | ^^^^^^ help: consider using `_choice` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/console.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | for i in 0..42 { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/console.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | for i in 0..42 { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player1` [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let player1 = player::Player::new(&name); [INFO] [stderr] | ^^^^^^^ help: consider using `_player1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `settings` [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let settings = settings::Settings::new(4, 4); [INFO] [stderr] | ^^^^^^^^ help: consider using `_settings` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/player.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `score` [INFO] [stderr] --> src/player.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | score: i32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `steps` [INFO] [stderr] --> src/player.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | steps: i32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `width` [INFO] [stderr] --> src/settings.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | width: i16, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `height` [INFO] [stderr] --> src/settings.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | height: i16, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Board` [INFO] [stderr] --> src/board.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | struct Board; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `tiles` [INFO] [stderr] --> src/tiles.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | struct tiles; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/console.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / io::stdin().read_line(&mut name) [INFO] [stderr] 20 | | .ok() [INFO] [stderr] 21 | | .expect("Failed to read name"); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/console.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / io::stdin().read_line(&mut instruction) [INFO] [stderr] 36 | | .ok() [INFO] [stderr] 37 | | .expect("Failed to read instruction"); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: type `tiles` should have a camel case name such as `Tiles` [INFO] [stderr] --> src/tiles.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | struct tiles; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "83837b35a69025e92b5d55e251681e8e551a6145bc03c1a6b88bf00b182d1b18"` [INFO] running `"docker" "rm" "-f" "83837b35a69025e92b5d55e251681e8e551a6145bc03c1a6b88bf00b182d1b18"` [INFO] [stdout] 83837b35a69025e92b5d55e251681e8e551a6145bc03c1a6b88bf00b182d1b18