[INFO] updating cached repository FauxFaux/quad-image [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FauxFaux/quad-image [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FauxFaux/quad-image" "work/ex/clippy-test-run/sources/stable/gh/FauxFaux/quad-image"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FauxFaux/quad-image'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FauxFaux/quad-image" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FauxFaux/quad-image"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FauxFaux/quad-image'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0dea575cba77e420258106dba3749cfbca1bb8a4 [INFO] sha for GitHub repo FauxFaux/quad-image: 0dea575cba77e420258106dba3749cfbca1bb8a4 [INFO] validating manifest of FauxFaux/quad-image on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FauxFaux/quad-image on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FauxFaux/quad-image [INFO] finished frobbing FauxFaux/quad-image [INFO] frobbed toml for FauxFaux/quad-image written to work/ex/clippy-test-run/sources/stable/gh/FauxFaux/quad-image/Cargo.toml [INFO] started frobbing FauxFaux/quad-image [INFO] finished frobbing FauxFaux/quad-image [INFO] frobbed toml for FauxFaux/quad-image written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FauxFaux/quad-image/Cargo.toml [INFO] crate FauxFaux/quad-image has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FauxFaux/quad-image against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FauxFaux/quad-image:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 759bf9be6ec0d07995fde95df5d8cfb7bf99fc635d21e99689d66cf4cad27084 [INFO] running `"docker" "start" "-a" "759bf9be6ec0d07995fde95df5d8cfb7bf99fc635d21e99689d66cf4cad27084"` [INFO] [stderr] Checking ascii v0.8.7 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking kamadak-exif v0.3.1 [INFO] [stderr] Compiling libsqlite3-sys v0.10.0 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking buf_redux v0.8.1 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking gzip-header v0.2.0 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Compiling mime_guess v1.8.6 [INFO] [stderr] Checking hmac v0.7.0 [INFO] [stderr] Checking tempfile-fast v0.2.4 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking tiny_http v0.6.0 [INFO] [stderr] Checking multipart v0.15.4 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking rouille v3.0.0 [INFO] [stderr] Checking rusqlite v0.15.0 [INFO] [stderr] Checking quad-image v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ingest.rs:286:24 [INFO] [stderr] | [INFO] [stderr] 286 | const FILES: [&'static [u8]; 9] = [ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gallery.rs:97:44 [INFO] [stderr] | [INFO] [stderr] 97 | i64(since_the_epoch.as_secs() * 1000 + since_the_epoch.subsec_nanos() as u64 / 1_000_000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_the_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gallery.rs:97:44 [INFO] [stderr] | [INFO] [stderr] 97 | i64(since_the_epoch.as_secs() * 1000 + since_the_epoch.subsec_nanos() as u64 / 1_000_000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_the_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: replacing an `Option` with `None` [INFO] [stderr] --> src/main.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | let params = match post_input!(request, { [INFO] [stderr] | ________________________^ [INFO] [stderr] 55 | | image: Vec, [INFO] [stderr] 56 | | return_json: Option, [INFO] [stderr] 57 | | }) { [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mem_replace_option_with_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ingest.rs:270:30 [INFO] [stderr] | [INFO] [stderr] 270 | diff += ((e.data[c] as f64) - (a.data[c] as f64)).abs() / 256. / 4.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(e.data[c])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ingest.rs:270:51 [INFO] [stderr] | [INFO] [stderr] 270 | diff += ((e.data[c] as f64) - (a.data[c] as f64)).abs() / 256. / 4.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(a.data[c])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:278:46 [INFO] [stderr] | [INFO] [stderr] 278 | rouille::log(&request, io::stdout(), || { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 279 | | if let Some(e) = request.remove_prefix("/e") { [INFO] [stderr] 280 | | return rouille::match_assets(&e, "e"); [INFO] [stderr] 281 | | } [INFO] [stderr] ... | [INFO] [stderr] 302 | | ) [INFO] [stderr] 303 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ingest.rs:275:17 [INFO] [stderr] | [INFO] [stderr] 275 | diff /= (w * h) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(w * h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `rot` is used to index `FILES` [INFO] [stderr] --> src/ingest.rs:298:20 [INFO] [stderr] | [INFO] [stderr] 298 | for rot in 2..=8 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 298 | for (rot, ) in FILES.iter().enumerate().skip(2) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: replacing an `Option` with `None` [INFO] [stderr] --> src/main.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | let params = match post_input!(request, { [INFO] [stderr] | ________________________^ [INFO] [stderr] 55 | | image: Vec, [INFO] [stderr] 56 | | return_json: Option, [INFO] [stderr] 57 | | }) { [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mem_replace_option_with_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:278:46 [INFO] [stderr] | [INFO] [stderr] 278 | rouille::log(&request, io::stdout(), || { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 279 | | if let Some(e) = request.remove_prefix("/e") { [INFO] [stderr] 280 | | return rouille::match_assets(&e, "e"); [INFO] [stderr] 281 | | } [INFO] [stderr] ... | [INFO] [stderr] 302 | | ) [INFO] [stderr] 303 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 52.36s [INFO] running `"docker" "inspect" "759bf9be6ec0d07995fde95df5d8cfb7bf99fc635d21e99689d66cf4cad27084"` [INFO] running `"docker" "rm" "-f" "759bf9be6ec0d07995fde95df5d8cfb7bf99fc635d21e99689d66cf4cad27084"` [INFO] [stdout] 759bf9be6ec0d07995fde95df5d8cfb7bf99fc635d21e99689d66cf4cad27084