[INFO] updating cached repository FauxFaux/netzact [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FauxFaux/netzact [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FauxFaux/netzact" "work/ex/clippy-test-run/sources/stable/gh/FauxFaux/netzact"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FauxFaux/netzact'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FauxFaux/netzact" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FauxFaux/netzact"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FauxFaux/netzact'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a28019672a0d95ed4c28d0acd345e70260dabf6f [INFO] sha for GitHub repo FauxFaux/netzact: a28019672a0d95ed4c28d0acd345e70260dabf6f [INFO] validating manifest of FauxFaux/netzact on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FauxFaux/netzact on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FauxFaux/netzact [INFO] finished frobbing FauxFaux/netzact [INFO] frobbed toml for FauxFaux/netzact written to work/ex/clippy-test-run/sources/stable/gh/FauxFaux/netzact/Cargo.toml [INFO] started frobbing FauxFaux/netzact [INFO] finished frobbing FauxFaux/netzact [INFO] frobbed toml for FauxFaux/netzact written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FauxFaux/netzact/Cargo.toml [INFO] crate FauxFaux/netzact has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FauxFaux/netzact against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FauxFaux/netzact:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3df15ff11f9d24eeb88992919d3dc86cbca864c4da723973ed08e4393916aecd [INFO] running `"docker" "start" "-a" "3df15ff11f9d24eeb88992919d3dc86cbca864c4da723973ed08e4393916aecd"` [INFO] [stderr] Compiling proc-macro2 v0.4.20 [INFO] [stderr] Checking dns-lookup v1.0.0 [INFO] [stderr] Checking memchr v2.1.0 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking netzact v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/netlink/tcp.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/netlink/tcp.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/expr/mod.rs:205:24 [INFO] [stderr] | [INFO] [stderr] 205 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 206 | | if list.contains(&Expression::Yes) { [INFO] [stderr] 207 | | Expression::Yes [INFO] [stderr] 208 | | } else { [INFO] [stderr] 209 | | AnyOf(list) [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 205 | } else if list.contains(&Expression::Yes) { [INFO] [stderr] 206 | Expression::Yes [INFO] [stderr] 207 | } else { [INFO] [stderr] 208 | AnyOf(list) [INFO] [stderr] 209 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/expr/mod.rs:205:24 [INFO] [stderr] | [INFO] [stderr] 205 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 206 | | if list.contains(&Expression::Yes) { [INFO] [stderr] 207 | | Expression::Yes [INFO] [stderr] 208 | | } else { [INFO] [stderr] 209 | | AnyOf(list) [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 205 | } else if list.contains(&Expression::Yes) { [INFO] [stderr] 206 | Expression::Yes [INFO] [stderr] 207 | } else { [INFO] [stderr] 208 | AnyOf(list) [INFO] [stderr] 209 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:296:17 [INFO] [stderr] | [INFO] [stderr] 296 | writeln!(stdout); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:326:35 [INFO] [stderr] | [INFO] [stderr] 326 | fn proto_order(proto: &SockProtocol) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `SockProtocol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | writeln!(stdout); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:296:17 [INFO] [stderr] | [INFO] [stderr] 296 | writeln!(stdout); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:326:35 [INFO] [stderr] | [INFO] [stderr] 326 | fn proto_order(proto: &SockProtocol) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `SockProtocol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | writeln!(stdout); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.79s [INFO] running `"docker" "inspect" "3df15ff11f9d24eeb88992919d3dc86cbca864c4da723973ed08e4393916aecd"` [INFO] running `"docker" "rm" "-f" "3df15ff11f9d24eeb88992919d3dc86cbca864c4da723973ed08e4393916aecd"` [INFO] [stdout] 3df15ff11f9d24eeb88992919d3dc86cbca864c4da723973ed08e4393916aecd