[INFO] updating cached repository FauxFaux/biggur
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/FauxFaux/biggur
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/FauxFaux/biggur" "work/ex/clippy-test-run/sources/stable/gh/FauxFaux/biggur"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FauxFaux/biggur'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/FauxFaux/biggur" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FauxFaux/biggur"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FauxFaux/biggur'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e1435822a5b657dba8af81b9856132c458078a09
[INFO] sha for GitHub repo FauxFaux/biggur: e1435822a5b657dba8af81b9856132c458078a09
[INFO] validating manifest of FauxFaux/biggur on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of FauxFaux/biggur on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing FauxFaux/biggur
[INFO] finished frobbing FauxFaux/biggur
[INFO] frobbed toml for FauxFaux/biggur written to work/ex/clippy-test-run/sources/stable/gh/FauxFaux/biggur/Cargo.toml
[INFO] started frobbing FauxFaux/biggur
[INFO] finished frobbing FauxFaux/biggur
[INFO] frobbed toml for FauxFaux/biggur written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FauxFaux/biggur/Cargo.toml
[INFO] crate FauxFaux/biggur has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting FauxFaux/biggur against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FauxFaux/biggur:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d9720e47b23169f2ef5146ca6a2a12b6a2b57718e0d24e4dd4c8c405066390f2
[INFO] running `"docker" "start" "-a" "d9720e47b23169f2ef5146ca6a2a12b6a2b57718e0d24e4dd4c8c405066390f2"`
[INFO] [stderr]    Compiling libsqlite3-sys v0.10.0
[INFO] [stderr]     Checking tokio-threadpool v0.1.8
[INFO] [stderr]    Compiling syn v0.15.19
[INFO] [stderr]     Checking tiny_http v0.6.0
[INFO] [stderr]     Checking pretty_env_logger v0.2.5
[INFO] [stderr]     Checking tokio-fs v0.1.4
[INFO] [stderr]     Checking tokio v0.1.11
[INFO] [stderr]    Compiling synstructure v0.10.1
[INFO] [stderr]    Compiling serde_derive v1.0.80
[INFO] [stderr]     Checking hyper v0.12.14
[INFO] [stderr]    Compiling failure_derive v0.1.3
[INFO] [stderr]     Checking failure v0.1.3
[INFO] [stderr]     Checking hyper-tls v0.3.1
[INFO] [stderr]     Checking rouille v2.2.0
[INFO] [stderr]     Checking reqwest v0.9.4
[INFO] [stderr]     Checking rusqlite v0.15.0
[INFO] [stderr]     Checking r2d2_sqlite v0.7.0
[INFO] [stderr]     Checking biggur v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused variable: `req`
[INFO] [stderr]   --> src/main.rs:34:44
[INFO] [stderr]    |
[INFO] [stderr] 34 |     rouille::start_server("0.0.0.0:5812", |req| unimplemented!());
[INFO] [stderr]    |                                            ^^^ help: consider using `_req` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `app`
[INFO] [stderr]   --> src/main.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let app = r2d2_sqlite::SqliteConnectionManager::file("biggur.db");
[INFO] [stderr]    |         ^^^ help: consider using `_app` instead
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/cache.rs:83:33
[INFO] [stderr]    |
[INFO] [stderr] 83 |     let body = body.as_object().ok_or(err_msg("root wasn't object"))?;
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("root wasn't object"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/cache.rs:90:25
[INFO] [stderr]    |
[INFO] [stderr] 90 |     Ok(body.get("data").ok_or(err_msg("data absent"))?)
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("data absent"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/whole.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |                 .into_iter()
[INFO] [stderr]    |                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:36:18
[INFO] [stderr]    |
[INFO] [stderr] 36 |                 .ok_or(err_msg("data should be array"))?
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("data should be array"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:46:39
[INFO] [stderr]    |
[INFO] [stderr] 46 |         let album = album.as_object().ok_or(err_msg("non-object item"))?;
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("non-object item"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:51:14
[INFO] [stderr]    |
[INFO] [stderr] 51 |             .ok_or(err_msg("id is mandatory"))?;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("id is mandatory"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:68:14
[INFO] [stderr]    |
[INFO] [stderr] 68 |             .ok_or(err_msg("images but no images_count"))?;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("images but no images_count"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:84:18
[INFO] [stderr]    |
[INFO] [stderr] 84 |                 .ok_or(err_msg("album images must be an array"))?
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("album images must be an array"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:82:18
[INFO] [stderr]    |
[INFO] [stderr] 82 |                 .ok_or(err_msg("album must contain images"))?
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("album must contain images"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:80:18
[INFO] [stderr]    |
[INFO] [stderr] 80 |                 .ok_or(err_msg("album must be an object"))?
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("album must be an object"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:99:14
[INFO] [stderr]    |
[INFO] [stderr] 99 |             .ok_or(err_msg("id is mandatory"))?;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("id is mandatory"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/whole.rs:104:14
[INFO] [stderr]     |
[INFO] [stderr] 104 |             .ok_or(err_msg("title is mandatory"))?;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("title is mandatory"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/whole.rs:106:52
[INFO] [stderr]     |
[INFO] [stderr] 106 |         let images: Result<Vec<_>, Error> = images.into_iter().map(map_img).collect();
[INFO] [stderr]     |                                                    ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/whole.rs:129:22
[INFO] [stderr]     |
[INFO] [stderr] 129 |                     .ok_or(err_msg("link must be a string"))?,
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("link must be a string"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/whole.rs:127:22
[INFO] [stderr]     |
[INFO] [stderr] 127 |                     .ok_or(err_msg("image must have link"))?
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("image must have link"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/whole.rs:133:18
[INFO] [stderr]     |
[INFO] [stderr] 133 |                 .ok_or(err_msg("size is always present"))?,
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("size is always present"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/whole.rs:149:28
[INFO] [stderr]     |
[INFO] [stderr] 149 |     Ok(&url[url.rfind('.').ok_or(err_msg("no dot"))? + 1..])
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("no dot"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `req`
[INFO] [stderr]   --> src/main.rs:34:44
[INFO] [stderr]    |
[INFO] [stderr] 34 |     rouille::start_server("0.0.0.0:5812", |req| unimplemented!());
[INFO] [stderr]    |                                            ^^^ help: consider using `_req` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `app`
[INFO] [stderr]   --> src/main.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let app = r2d2_sqlite::SqliteConnectionManager::file("biggur.db");
[INFO] [stderr]    |         ^^^ help: consider using `_app` instead
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/cache.rs:83:33
[INFO] [stderr]    |
[INFO] [stderr] 83 |     let body = body.as_object().ok_or(err_msg("root wasn't object"))?;
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("root wasn't object"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/cache.rs:90:25
[INFO] [stderr]    |
[INFO] [stderr] 90 |     Ok(body.get("data").ok_or(err_msg("data absent"))?)
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("data absent"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/whole.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |                 .into_iter()
[INFO] [stderr]    |                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:36:18
[INFO] [stderr]    |
[INFO] [stderr] 36 |                 .ok_or(err_msg("data should be array"))?
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("data should be array"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:46:39
[INFO] [stderr]    |
[INFO] [stderr] 46 |         let album = album.as_object().ok_or(err_msg("non-object item"))?;
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("non-object item"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:51:14
[INFO] [stderr]    |
[INFO] [stderr] 51 |             .ok_or(err_msg("id is mandatory"))?;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("id is mandatory"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:68:14
[INFO] [stderr]    |
[INFO] [stderr] 68 |             .ok_or(err_msg("images but no images_count"))?;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("images but no images_count"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:84:18
[INFO] [stderr]    |
[INFO] [stderr] 84 |                 .ok_or(err_msg("album images must be an array"))?
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("album images must be an array"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:82:18
[INFO] [stderr]    |
[INFO] [stderr] 82 |                 .ok_or(err_msg("album must contain images"))?
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("album must contain images"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:80:18
[INFO] [stderr]    |
[INFO] [stderr] 80 |                 .ok_or(err_msg("album must be an object"))?
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("album must be an object"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/whole.rs:99:14
[INFO] [stderr]    |
[INFO] [stderr] 99 |             .ok_or(err_msg("id is mandatory"))?;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("id is mandatory"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/whole.rs:104:14
[INFO] [stderr]     |
[INFO] [stderr] 104 |             .ok_or(err_msg("title is mandatory"))?;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("title is mandatory"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/whole.rs:106:52
[INFO] [stderr]     |
[INFO] [stderr] 106 |         let images: Result<Vec<_>, Error> = images.into_iter().map(map_img).collect();
[INFO] [stderr]     |                                                    ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/whole.rs:129:22
[INFO] [stderr]     |
[INFO] [stderr] 129 |                     .ok_or(err_msg("link must be a string"))?,
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("link must be a string"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/whole.rs:127:22
[INFO] [stderr]     |
[INFO] [stderr] 127 |                     .ok_or(err_msg("image must have link"))?
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("image must have link"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/whole.rs:133:18
[INFO] [stderr]     |
[INFO] [stderr] 133 |                 .ok_or(err_msg("size is always present"))?,
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("size is always present"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/whole.rs:149:28
[INFO] [stderr]     |
[INFO] [stderr] 149 |     Ok(&url[url.rfind('.').ok_or(err_msg("no dot"))? + 1..])
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("no dot"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 05s
[INFO] running `"docker" "inspect" "d9720e47b23169f2ef5146ca6a2a12b6a2b57718e0d24e4dd4c8c405066390f2"`
[INFO] running `"docker" "rm" "-f" "d9720e47b23169f2ef5146ca6a2a12b6a2b57718e0d24e4dd4c8c405066390f2"`
[INFO] [stdout] d9720e47b23169f2ef5146ca6a2a12b6a2b57718e0d24e4dd4c8c405066390f2