[INFO] updating cached repository FTV-Subtil/rs_http_worker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FTV-Subtil/rs_http_worker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FTV-Subtil/rs_http_worker" "work/ex/clippy-test-run/sources/stable/gh/FTV-Subtil/rs_http_worker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FTV-Subtil/rs_http_worker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FTV-Subtil/rs_http_worker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FTV-Subtil/rs_http_worker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FTV-Subtil/rs_http_worker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3aeeb696ebbb713f2dd5f6267b1e2ea31e9d0f03 [INFO] sha for GitHub repo FTV-Subtil/rs_http_worker: 3aeeb696ebbb713f2dd5f6267b1e2ea31e9d0f03 [INFO] validating manifest of FTV-Subtil/rs_http_worker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FTV-Subtil/rs_http_worker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FTV-Subtil/rs_http_worker [INFO] finished frobbing FTV-Subtil/rs_http_worker [INFO] frobbed toml for FTV-Subtil/rs_http_worker written to work/ex/clippy-test-run/sources/stable/gh/FTV-Subtil/rs_http_worker/Cargo.toml [INFO] started frobbing FTV-Subtil/rs_http_worker [INFO] finished frobbing FTV-Subtil/rs_http_worker [INFO] frobbed toml for FTV-Subtil/rs_http_worker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FTV-Subtil/rs_http_worker/Cargo.toml [INFO] crate FTV-Subtil/rs_http_worker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FTV-Subtil/rs_http_worker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FTV-Subtil/rs_http_worker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 508f4af5e38b02352a364486f3fcf2856bd7f26d4afae215d5b7b113648f4d74 [INFO] running `"docker" "start" "-a" "508f4af5e38b02352a364486f3fcf2856bd7f26d4afae215d5b7b113648f4d74"` [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking backtrace-sys v0.1.24 [INFO] [stderr] Checking openssl v0.10.15 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling amq-protocol-types v1.0.0 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Compiling handlebars v1.1.0 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking crossbeam-deque v0.6.2 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking simple_logger v1.0.1 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking amq-protocol-codegen v1.0.1 [INFO] [stderr] Checking native-tls v0.2.2 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking hyper v0.12.17 [INFO] [stderr] Compiling amq-protocol v1.0.0 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking lapin-async v0.15.0 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking lapin-futures v0.15.0 [INFO] [stderr] Checking amqp_worker v0.2.2 [INFO] [stderr] Checking http_worker v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: All variants have the same postfix: `Param` [INFO] [stderr] --> src/message.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / enum Parameter { [INFO] [stderr] 13 | | #[serde(rename = "string")] [INFO] [stderr] 14 | | StringParam{id: String, default: Option, value: Option}, [INFO] [stderr] 15 | | #[serde(rename = "paths")] [INFO] [stderr] ... | [INFO] [stderr] 18 | | RequirementParam{id: String, default: Option, value: Option}, [INFO] [stderr] 19 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message.rs:120:7 [INFO] [stderr] | [INFO] [stderr] 120 | return Err(MessageError::RuntimeError("bad input message".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MessageError::RuntimeError("bad input message".to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Param` [INFO] [stderr] --> src/message.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / enum Parameter { [INFO] [stderr] 13 | | #[serde(rename = "string")] [INFO] [stderr] 14 | | StringParam{id: String, default: Option, value: Option}, [INFO] [stderr] 15 | | #[serde(rename = "paths")] [INFO] [stderr] ... | [INFO] [stderr] 18 | | RequirementParam{id: String, default: Option, value: Option}, [INFO] [stderr] 19 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message.rs:120:7 [INFO] [stderr] | [INFO] [stderr] 120 | return Err(MessageError::RuntimeError("bad input message".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MessageError::RuntimeError("bad input message".to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/message.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | fn get_parameter(params: &Vec, key: &str) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Parameter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/message.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / match param { [INFO] [stderr] 35 | | Parameter::StringParam{id, default, value} => { [INFO] [stderr] 36 | | if id == key { [INFO] [stderr] 37 | | if let Some(ref v) = value { [INFO] [stderr] ... | [INFO] [stderr] 44 | | _ => {} [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let Parameter::StringParam{id, default, value} = param { [INFO] [stderr] 35 | if id == key { [INFO] [stderr] 36 | if let Some(ref v) = value { [INFO] [stderr] 37 | return Some(v.clone()) [INFO] [stderr] 38 | } else { [INFO] [stderr] 39 | return default.clone() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/message.rs:50:31 [INFO] [stderr] | [INFO] [stderr] 50 | fn check_requirements(params: &Vec) -> Result<(), MessageError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Parameter]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/message.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / match param { [INFO] [stderr] 53 | | Parameter::RequirementParam{id, value, ..} => { [INFO] [stderr] 54 | | if id == "requirements" { [INFO] [stderr] 55 | | if let Some(Requirement{paths: Some(paths)}) = value { [INFO] [stderr] ... | [INFO] [stderr] 65 | | _ => {} [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 52 | if let Parameter::RequirementParam{id, value, ..} = param { [INFO] [stderr] 53 | if id == "requirements" { [INFO] [stderr] 54 | if let Some(Requirement{paths: Some(paths)}) = value { [INFO] [stderr] 55 | for ref path in paths.iter() { [INFO] [stderr] 56 | let p = Path::new(path); [INFO] [stderr] 57 | if !p.exists() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/message.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | for ref path in paths.iter() { [INFO] [stderr] | ^^^^^^^^ ------------ help: try: `let path = &paths.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/message.rs:105:10 [INFO] [stderr] | [INFO] [stderr] 105 | if !(status == StatusCode::OK) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `status != StatusCode::OK` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:29:10 [INFO] [stderr] | [INFO] [stderr] 29 | if let Ok(_)= env::var("VERBOSE") { [INFO] [stderr] | ___- ^^^^^ [INFO] [stderr] 30 | | simple_logger::init_with_level(Level::Debug).unwrap(); [INFO] [stderr] 31 | | } else { [INFO] [stderr] 32 | | simple_logger::init_with_level(Level::Warn).unwrap(); [INFO] [stderr] 33 | | } [INFO] [stderr] | |___- help: try this: `if env::var("VERBOSE").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/message.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | fn get_parameter(params: &Vec, key: &str) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Parameter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/message.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / match param { [INFO] [stderr] 35 | | Parameter::StringParam{id, default, value} => { [INFO] [stderr] 36 | | if id == key { [INFO] [stderr] 37 | | if let Some(ref v) = value { [INFO] [stderr] ... | [INFO] [stderr] 44 | | _ => {} [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let Parameter::StringParam{id, default, value} = param { [INFO] [stderr] 35 | if id == key { [INFO] [stderr] 36 | if let Some(ref v) = value { [INFO] [stderr] 37 | return Some(v.clone()) [INFO] [stderr] 38 | } else { [INFO] [stderr] 39 | return default.clone() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/message.rs:50:31 [INFO] [stderr] | [INFO] [stderr] 50 | fn check_requirements(params: &Vec) -> Result<(), MessageError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Parameter]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/message.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / match param { [INFO] [stderr] 53 | | Parameter::RequirementParam{id, value, ..} => { [INFO] [stderr] 54 | | if id == "requirements" { [INFO] [stderr] 55 | | if let Some(Requirement{paths: Some(paths)}) = value { [INFO] [stderr] ... | [INFO] [stderr] 65 | | _ => {} [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 52 | if let Parameter::RequirementParam{id, value, ..} = param { [INFO] [stderr] 53 | if id == "requirements" { [INFO] [stderr] 54 | if let Some(Requirement{paths: Some(paths)}) = value { [INFO] [stderr] 55 | for ref path in paths.iter() { [INFO] [stderr] 56 | let p = Path::new(path); [INFO] [stderr] 57 | if !p.exists() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/message.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | for ref path in paths.iter() { [INFO] [stderr] | ^^^^^^^^ ------------ help: try: `let path = &paths.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/message.rs:105:10 [INFO] [stderr] | [INFO] [stderr] 105 | if !(status == StatusCode::OK) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `status != StatusCode::OK` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:29:10 [INFO] [stderr] | [INFO] [stderr] 29 | if let Ok(_)= env::var("VERBOSE") { [INFO] [stderr] | ___- ^^^^^ [INFO] [stderr] 30 | | simple_logger::init_with_level(Level::Debug).unwrap(); [INFO] [stderr] 31 | | } else { [INFO] [stderr] 32 | | simple_logger::init_with_level(Level::Warn).unwrap(); [INFO] [stderr] 33 | | } [INFO] [stderr] | |___- help: try this: `if env::var("VERBOSE").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 29s [INFO] running `"docker" "inspect" "508f4af5e38b02352a364486f3fcf2856bd7f26d4afae215d5b7b113648f4d74"` [INFO] running `"docker" "rm" "-f" "508f4af5e38b02352a364486f3fcf2856bd7f26d4afae215d5b7b113648f4d74"` [INFO] [stdout] 508f4af5e38b02352a364486f3fcf2856bd7f26d4afae215d5b7b113648f4d74