[INFO] updating cached repository FTV-Subtil/dash_manifest_worker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FTV-Subtil/dash_manifest_worker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FTV-Subtil/dash_manifest_worker" "work/ex/clippy-test-run/sources/stable/gh/FTV-Subtil/dash_manifest_worker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FTV-Subtil/dash_manifest_worker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FTV-Subtil/dash_manifest_worker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FTV-Subtil/dash_manifest_worker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FTV-Subtil/dash_manifest_worker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bd61fc83623f4360d5c11bd147aea20bb4a33910 [INFO] sha for GitHub repo FTV-Subtil/dash_manifest_worker: bd61fc83623f4360d5c11bd147aea20bb4a33910 [INFO] validating manifest of FTV-Subtil/dash_manifest_worker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FTV-Subtil/dash_manifest_worker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FTV-Subtil/dash_manifest_worker [INFO] finished frobbing FTV-Subtil/dash_manifest_worker [INFO] frobbed toml for FTV-Subtil/dash_manifest_worker written to work/ex/clippy-test-run/sources/stable/gh/FTV-Subtil/dash_manifest_worker/Cargo.toml [INFO] started frobbing FTV-Subtil/dash_manifest_worker [INFO] finished frobbing FTV-Subtil/dash_manifest_worker [INFO] frobbed toml for FTV-Subtil/dash_manifest_worker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FTV-Subtil/dash_manifest_worker/Cargo.toml [INFO] crate FTV-Subtil/dash_manifest_worker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FTV-Subtil/dash_manifest_worker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FTV-Subtil/dash_manifest_worker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9e8dd4825c8a8ef556796b28efd6dcc5fc8bcbf364b0df0cb1df40a8237229a4 [INFO] running `"docker" "start" "-a" "9e8dd4825c8a8ef556796b28efd6dcc5fc8bcbf364b0df0cb1df40a8237229a4"` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling memchr v1.0.2 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking yaserde v0.3.3 [INFO] [stderr] Compiling yaserde_derive v0.3.5 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking amq-protocol-types v0.20.0 [INFO] [stderr] Checking handlebars v0.27.0 [INFO] [stderr] Compiling nom v3.2.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking amq-protocol-codegen v0.27.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Compiling amq-protocol v0.19.1 [INFO] [stderr] Checking tokio-core v0.1.13 [INFO] [stderr] Checking hyper v0.12.14 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Compiling lapin-async v0.10.0 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking lapin-futures v0.10.0 [INFO] [stderr] Checking amqp_worker v0.1.4 [INFO] [stderr] Checking dash_manifest_worker v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message.rs:68:7 [INFO] [stderr] | [INFO] [stderr] 68 | return Err(MessageError::RuntimeError("bad input message".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MessageError::RuntimeError("bad input message".to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message.rs:68:7 [INFO] [stderr] | [INFO] [stderr] 68 | return Err(MessageError::RuntimeError("bad input message".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MessageError::RuntimeError("bad input message".to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/message.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | fn get_parameter(params: &Vec, key: &str) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Parameter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:30:10 [INFO] [stderr] | [INFO] [stderr] 30 | if let Ok(_)= env::var("VERBOSE") { [INFO] [stderr] | ___- ^^^^^ [INFO] [stderr] 31 | | simple_logger::init_with_level(Level::Debug).unwrap(); [INFO] [stderr] 32 | | } else { [INFO] [stderr] 33 | | simple_logger::init_with_level(Level::Warn).unwrap(); [INFO] [stderr] 34 | | } [INFO] [stderr] | |___- help: try this: `if env::var("VERBOSE").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/message.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | fn get_parameter(params: &Vec, key: &str) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Parameter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:30:10 [INFO] [stderr] | [INFO] [stderr] 30 | if let Ok(_)= env::var("VERBOSE") { [INFO] [stderr] | ___- ^^^^^ [INFO] [stderr] 31 | | simple_logger::init_with_level(Level::Debug).unwrap(); [INFO] [stderr] 32 | | } else { [INFO] [stderr] 33 | | simple_logger::init_with_level(Level::Warn).unwrap(); [INFO] [stderr] 34 | | } [INFO] [stderr] | |___- help: try this: `if env::var("VERBOSE").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 38s [INFO] running `"docker" "inspect" "9e8dd4825c8a8ef556796b28efd6dcc5fc8bcbf364b0df0cb1df40a8237229a4"` [INFO] running `"docker" "rm" "-f" "9e8dd4825c8a8ef556796b28efd6dcc5fc8bcbf364b0df0cb1df40a8237229a4"` [INFO] [stdout] 9e8dd4825c8a8ef556796b28efd6dcc5fc8bcbf364b0df0cb1df40a8237229a4