[INFO] updating cached repository FHMS-ITS/Xim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FHMS-ITS/Xim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FHMS-ITS/Xim" "work/ex/clippy-test-run/sources/stable/gh/FHMS-ITS/Xim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FHMS-ITS/Xim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FHMS-ITS/Xim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FHMS-ITS/Xim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FHMS-ITS/Xim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0ac78b2eac3d76d18a5b4baa1a3106eb26dee2c3 [INFO] sha for GitHub repo FHMS-ITS/Xim: 0ac78b2eac3d76d18a5b4baa1a3106eb26dee2c3 [INFO] validating manifest of FHMS-ITS/Xim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FHMS-ITS/Xim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FHMS-ITS/Xim [INFO] finished frobbing FHMS-ITS/Xim [INFO] frobbed toml for FHMS-ITS/Xim written to work/ex/clippy-test-run/sources/stable/gh/FHMS-ITS/Xim/Cargo.toml [INFO] started frobbing FHMS-ITS/Xim [INFO] finished frobbing FHMS-ITS/Xim [INFO] frobbed toml for FHMS-ITS/Xim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FHMS-ITS/Xim/Cargo.toml [INFO] crate FHMS-ITS/Xim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FHMS-ITS/Xim against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FHMS-ITS/Xim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14a2cc1baec8dfdf1ee16b31e252edf854e39e79b34e29a3d110aa6c216c23f7 [INFO] running `"docker" "start" "-a" "14a2cc1baec8dfdf1ee16b31e252edf854e39e79b34e29a3d110aa6c216c23f7"` [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking chan v0.1.19 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking docopt v0.8.1 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking chan-signal v0.3.1 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking xim v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controller.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controller.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/view.rs:152:66 [INFO] [stderr] | [INFO] [stderr] 152 | write!(stdout, "{}{}", Goto(offset_width as u16 + 4, 1), "0 1 2 3 4 5 6 7 8 9 a b c d e f")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/view.rs:179:160 [INFO] [stderr] | [INFO] [stderr] 179 | write!(stdout, "{}{}", Goto(hex_area.origin.0 + ((index % 16) as u16) * 3 - 1, hex_area.origin.1 + ((index - self.scroll_start) / 16) as u16), "|").unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vim.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Binary` [INFO] [stderr] --> src/vim.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | Binary, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/controller.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | / pub fn transition(&mut self, key: Key) -> bool { [INFO] [stderr] 218 | | use termion::event::Key::{Alt, Char, Esc, Delete, Backspace, Left, Right, Up, Down, Insert, Ctrl}; [INFO] [stderr] 219 | | [INFO] [stderr] 220 | | // TODO: Quickfix for tmux [INFO] [stderr] ... | [INFO] [stderr] 601 | | run [INFO] [stderr] 602 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/controller.rs:263:56 [INFO] [stderr] | [INFO] [stderr] 263 | self.yank = Some(self.model.buffer[self.model.get_index()..self.model.get_index() + 1].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.model.get_index()..=self.model.get_index()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/controller.rs:290:56 [INFO] [stderr] | [INFO] [stderr] 290 | self.yank = Some(self.model.buffer[self.model.get_index()..self.model.get_index() + 1].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.model.get_index()..=self.model.get_index()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/controller.rs:504:60 [INFO] [stderr] | [INFO] [stderr] 504 | self.yank = Some(self.model.buffer[start.into()..usize::from(end) + 1].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.into()..=usize::from(end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/controller.rs:527:60 [INFO] [stderr] | [INFO] [stderr] 527 | self.yank = Some(self.model.buffer[start.into()..usize::from(end) + 1].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.into()..=usize::from(end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `model::Model` [INFO] [stderr] --> src/model.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Model { [INFO] [stderr] 20 | | Model { [INFO] [stderr] 21 | | path: "".into(), [INFO] [stderr] 22 | | caret: Caret::Offset(UsizeMax::new(0, 0)), [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for model::Model { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/view.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | let lines = (start/16..end/16 + 1).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(start/16..=end/16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/history.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | if !(self.done.len() > 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.done.len() <= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking quickcheck v0.4.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controller.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controller.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/view.rs:152:66 [INFO] [stderr] | [INFO] [stderr] 152 | write!(stdout, "{}{}", Goto(offset_width as u16 + 4, 1), "0 1 2 3 4 5 6 7 8 9 a b c d e f")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/view.rs:179:160 [INFO] [stderr] | [INFO] [stderr] 179 | write!(stdout, "{}{}", Goto(hex_area.origin.0 + ((index % 16) as u16) * 3 - 1, hex_area.origin.1 + ((index - self.scroll_start) / 16) as u16), "|").unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vim.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Binary` [INFO] [stderr] --> src/vim.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | Binary, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/controller.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | / pub fn transition(&mut self, key: Key) -> bool { [INFO] [stderr] 218 | | use termion::event::Key::{Alt, Char, Esc, Delete, Backspace, Left, Right, Up, Down, Insert, Ctrl}; [INFO] [stderr] 219 | | [INFO] [stderr] 220 | | // TODO: Quickfix for tmux [INFO] [stderr] ... | [INFO] [stderr] 601 | | run [INFO] [stderr] 602 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/controller.rs:263:56 [INFO] [stderr] | [INFO] [stderr] 263 | self.yank = Some(self.model.buffer[self.model.get_index()..self.model.get_index() + 1].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.model.get_index()..=self.model.get_index()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/controller.rs:290:56 [INFO] [stderr] | [INFO] [stderr] 290 | self.yank = Some(self.model.buffer[self.model.get_index()..self.model.get_index() + 1].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.model.get_index()..=self.model.get_index()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/controller.rs:504:60 [INFO] [stderr] | [INFO] [stderr] 504 | self.yank = Some(self.model.buffer[start.into()..usize::from(end) + 1].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.into()..=usize::from(end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/controller.rs:527:60 [INFO] [stderr] | [INFO] [stderr] 527 | self.yank = Some(self.model.buffer[start.into()..usize::from(end) + 1].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.into()..=usize::from(end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `model::Model` [INFO] [stderr] --> src/model.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Model { [INFO] [stderr] 20 | | Model { [INFO] [stderr] 21 | | path: "".into(), [INFO] [stderr] 22 | | caret: Caret::Offset(UsizeMax::new(0, 0)), [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for model::Model { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/model.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | model.edit(start, end, &new); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/view.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | let lines = (start/16..end/16 + 1).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(start/16..=end/16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/history.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | if !(self.done.len() > 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.done.len() <= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.59s [INFO] running `"docker" "inspect" "14a2cc1baec8dfdf1ee16b31e252edf854e39e79b34e29a3d110aa6c216c23f7"` [INFO] running `"docker" "rm" "-f" "14a2cc1baec8dfdf1ee16b31e252edf854e39e79b34e29a3d110aa6c216c23f7"` [INFO] [stdout] 14a2cc1baec8dfdf1ee16b31e252edf854e39e79b34e29a3d110aa6c216c23f7