[INFO] updating cached repository FGRibreau/alfred-crates [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FGRibreau/alfred-crates [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FGRibreau/alfred-crates" "work/ex/clippy-test-run/sources/stable/gh/FGRibreau/alfred-crates"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FGRibreau/alfred-crates'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FGRibreau/alfred-crates" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FGRibreau/alfred-crates"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FGRibreau/alfred-crates'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 129433c0f2437255741d856ef935c1977bf19c62 [INFO] sha for GitHub repo FGRibreau/alfred-crates: 129433c0f2437255741d856ef935c1977bf19c62 [INFO] validating manifest of FGRibreau/alfred-crates on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FGRibreau/alfred-crates on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FGRibreau/alfred-crates [INFO] finished frobbing FGRibreau/alfred-crates [INFO] frobbed toml for FGRibreau/alfred-crates written to work/ex/clippy-test-run/sources/stable/gh/FGRibreau/alfred-crates/Cargo.toml [INFO] started frobbing FGRibreau/alfred-crates [INFO] finished frobbing FGRibreau/alfred-crates [INFO] frobbed toml for FGRibreau/alfred-crates written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FGRibreau/alfred-crates/Cargo.toml [INFO] crate FGRibreau/alfred-crates has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FGRibreau/alfred-crates against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/FGRibreau/alfred-crates:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e81093b2d72c6b037fcd18becf61a1490bfb3b7aa2a8a5951ca88be2bba2a2b8 [INFO] running `"docker" "start" "-a" "e81093b2d72c6b037fcd18becf61a1490bfb3b7aa2a8a5951ca88be2bba2a2b8"` [INFO] [stderr] Compiling libz-sys v1.0.12 [INFO] [stderr] Compiling curl-sys v0.3.7 [INFO] [stderr] Checking clap v2.20.0 [INFO] [stderr] Checking xml-rs v0.3.5 [INFO] [stderr] Compiling openssl-sys v0.9.6 [INFO] [stderr] Checking curl v0.4.4 [INFO] [stderr] Checking crates-io v0.5.0 [INFO] [stderr] Checking alfred-crates v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:14 [INFO] [stderr] | [INFO] [stderr] 9 | const HOST: &'static str = "https://crates.io"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | return (); [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/main.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:44:211 [INFO] [stderr] | [INFO] [stderr] 44 | println!("<![CDATA[{}]]>", HOST, escaped_name,escaped_name, escape_str_pcdata(&krate.description.clone().unwrap_or(String::from("")))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:14 [INFO] [stderr] | [INFO] [stderr] 9 | const HOST: &'static str = "https://crates.io"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | return (); [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/main.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:44:211 [INFO] [stderr] | [INFO] [stderr] 44 | println!("<![CDATA[{}]]>", HOST, escaped_name,escaped_name, escape_str_pcdata(&krate.description.clone().unwrap_or(String::from("")))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 11s [INFO] running `"docker" "inspect" "e81093b2d72c6b037fcd18becf61a1490bfb3b7aa2a8a5951ca88be2bba2a2b8"` [INFO] running `"docker" "rm" "-f" "e81093b2d72c6b037fcd18becf61a1490bfb3b7aa2a8a5951ca88be2bba2a2b8"` [INFO] [stdout] e81093b2d72c6b037fcd18becf61a1490bfb3b7aa2a8a5951ca88be2bba2a2b8