[INFO] updating cached repository ExcaliburZero/resolution-prover [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ExcaliburZero/resolution-prover [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ExcaliburZero/resolution-prover" "work/ex/clippy-test-run/sources/stable/gh/ExcaliburZero/resolution-prover"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ExcaliburZero/resolution-prover'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ExcaliburZero/resolution-prover" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ExcaliburZero/resolution-prover"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ExcaliburZero/resolution-prover'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c454965052a2cbd6167c5bbb3791ae766cb9fb7e [INFO] sha for GitHub repo ExcaliburZero/resolution-prover: c454965052a2cbd6167c5bbb3791ae766cb9fb7e [INFO] validating manifest of ExcaliburZero/resolution-prover on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ExcaliburZero/resolution-prover on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ExcaliburZero/resolution-prover [INFO] finished frobbing ExcaliburZero/resolution-prover [INFO] frobbed toml for ExcaliburZero/resolution-prover written to work/ex/clippy-test-run/sources/stable/gh/ExcaliburZero/resolution-prover/Cargo.toml [INFO] started frobbing ExcaliburZero/resolution-prover [INFO] finished frobbing ExcaliburZero/resolution-prover [INFO] frobbed toml for ExcaliburZero/resolution-prover written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ExcaliburZero/resolution-prover/Cargo.toml [INFO] crate ExcaliburZero/resolution-prover has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ExcaliburZero/resolution-prover against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ExcaliburZero/resolution-prover:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6db511f0bd025ce823d444269e9684a4a7aa58f5891025827e49dea6e828c635 [INFO] running `"docker" "start" "-a" "6db511f0bd025ce823d444269e9684a4a7aa58f5891025827e49dea6e828c635"` [INFO] [stderr] Checking multimap v0.4.0 [INFO] [stderr] Checking resolution-prover v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/clauses.rs:172:46 [INFO] [stderr] | [INFO] [stderr] 172 | (Proposition::And(c, d), e) => [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/clauses.rs:177:45 [INFO] [stderr] | [INFO] [stderr] 177 | (c, Proposition::And(d, e)) => [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/clauses.rs:172:46 [INFO] [stderr] | [INFO] [stderr] 172 | (Proposition::And(c, d), e) => [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/clauses.rs:177:45 [INFO] [stderr] | [INFO] [stderr] 177 | (c, Proposition::And(d, e)) => [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/resolution.rs:72:16 [INFO] [stderr] | [INFO] [stderr] 72 | if next.parts.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `next.parts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/resolution.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | parts: all_parts.iter() [INFO] [stderr] | ________________^ [INFO] [stderr] 108 | | .map(|p| p.clone()) [INFO] [stderr] | |_______________________________^ help: Consider calling the dedicated `cloned` method: `all_parts.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/resolution.rs:72:16 [INFO] [stderr] | [INFO] [stderr] 72 | if next.parts.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `next.parts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/resolution.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | parts: all_parts.iter() [INFO] [stderr] | ________________^ [INFO] [stderr] 108 | | .map(|p| p.clone()) [INFO] [stderr] | |_______________________________^ help: Consider calling the dedicated `cloned` method: `all_parts.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.09s [INFO] running `"docker" "inspect" "6db511f0bd025ce823d444269e9684a4a7aa58f5891025827e49dea6e828c635"` [INFO] running `"docker" "rm" "-f" "6db511f0bd025ce823d444269e9684a4a7aa58f5891025827e49dea6e828c635"` [INFO] [stdout] 6db511f0bd025ce823d444269e9684a4a7aa58f5891025827e49dea6e828c635