[INFO] updating cached repository EvilRobotOverlord/mnist-dataset-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/EvilRobotOverlord/mnist-dataset-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/EvilRobotOverlord/mnist-dataset-rust" "work/ex/clippy-test-run/sources/stable/gh/EvilRobotOverlord/mnist-dataset-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/EvilRobotOverlord/mnist-dataset-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/EvilRobotOverlord/mnist-dataset-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EvilRobotOverlord/mnist-dataset-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EvilRobotOverlord/mnist-dataset-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d7b48065345e32b3a432e72cc77512b86f513d3c [INFO] sha for GitHub repo EvilRobotOverlord/mnist-dataset-rust: d7b48065345e32b3a432e72cc77512b86f513d3c [INFO] validating manifest of EvilRobotOverlord/mnist-dataset-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of EvilRobotOverlord/mnist-dataset-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing EvilRobotOverlord/mnist-dataset-rust [INFO] finished frobbing EvilRobotOverlord/mnist-dataset-rust [INFO] frobbed toml for EvilRobotOverlord/mnist-dataset-rust written to work/ex/clippy-test-run/sources/stable/gh/EvilRobotOverlord/mnist-dataset-rust/Cargo.toml [INFO] started frobbing EvilRobotOverlord/mnist-dataset-rust [INFO] finished frobbing EvilRobotOverlord/mnist-dataset-rust [INFO] frobbed toml for EvilRobotOverlord/mnist-dataset-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EvilRobotOverlord/mnist-dataset-rust/Cargo.toml [INFO] crate EvilRobotOverlord/mnist-dataset-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting EvilRobotOverlord/mnist-dataset-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/EvilRobotOverlord/mnist-dataset-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1ee717ff8a25c789aec082cfd94c987caf5ce463eff8b1e71efa9d609b3c3c0d [INFO] running `"docker" "start" "-a" "1ee717ff8a25c789aec082cfd94c987caf5ce463eff8b1e71efa9d609b3c3c0d"` [INFO] [stderr] Compiling ndarray v0.11.2 [INFO] [stderr] Checking xattr v0.2.1 [INFO] [stderr] Checking filetime v0.2.1 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking tar v0.4.15 [INFO] [stderr] Checking mnist-dataset-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/read.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / let height; [INFO] [stderr] 41 | | [INFO] [stderr] 42 | | if one_d { [INFO] [stderr] 43 | | width = source.read_uint()? * source.read_uint()?; [INFO] [stderr] ... | [INFO] [stderr] 47 | | height = source.read_uint()?; [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let height = if one_d { ..; 1 } else { ..; source.read_uint()? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/write.rs:51:45 [INFO] [stderr] | [INFO] [stderr] 51 | self.dest.write_u64::(n as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | self.dest.write(&ARRAY_HEADER)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | self.dest.write(data)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mnist-dataset-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/read.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / let height; [INFO] [stderr] 41 | | [INFO] [stderr] 42 | | if one_d { [INFO] [stderr] 43 | | width = source.read_uint()? * source.read_uint()?; [INFO] [stderr] ... | [INFO] [stderr] 47 | | height = source.read_uint()?; [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let height = if one_d { ..; 1 } else { ..; source.read_uint()? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/write.rs:51:45 [INFO] [stderr] | [INFO] [stderr] 51 | self.dest.write_u64::(n as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | self.dest.write(&ARRAY_HEADER)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | self.dest.write(data)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mnist-dataset-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1ee717ff8a25c789aec082cfd94c987caf5ce463eff8b1e71efa9d609b3c3c0d"` [INFO] running `"docker" "rm" "-f" "1ee717ff8a25c789aec082cfd94c987caf5ce463eff8b1e71efa9d609b3c3c0d"` [INFO] [stdout] 1ee717ff8a25c789aec082cfd94c987caf5ce463eff8b1e71efa9d609b3c3c0d