[INFO] updating cached repository ErnWong/rust-wasm-experiment-wavesim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ErnWong/rust-wasm-experiment-wavesim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ErnWong/rust-wasm-experiment-wavesim" "work/ex/clippy-test-run/sources/stable/gh/ErnWong/rust-wasm-experiment-wavesim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ErnWong/rust-wasm-experiment-wavesim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ErnWong/rust-wasm-experiment-wavesim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ErnWong/rust-wasm-experiment-wavesim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ErnWong/rust-wasm-experiment-wavesim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d411cd93c2aa6fa39ad926006cfd8e8e21f63077 [INFO] sha for GitHub repo ErnWong/rust-wasm-experiment-wavesim: d411cd93c2aa6fa39ad926006cfd8e8e21f63077 [INFO] validating manifest of ErnWong/rust-wasm-experiment-wavesim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ErnWong/rust-wasm-experiment-wavesim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ErnWong/rust-wasm-experiment-wavesim [INFO] finished frobbing ErnWong/rust-wasm-experiment-wavesim [INFO] frobbed toml for ErnWong/rust-wasm-experiment-wavesim written to work/ex/clippy-test-run/sources/stable/gh/ErnWong/rust-wasm-experiment-wavesim/Cargo.toml [INFO] started frobbing ErnWong/rust-wasm-experiment-wavesim [INFO] finished frobbing ErnWong/rust-wasm-experiment-wavesim [INFO] frobbed toml for ErnWong/rust-wasm-experiment-wavesim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ErnWong/rust-wasm-experiment-wavesim/Cargo.toml [INFO] crate ErnWong/rust-wasm-experiment-wavesim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ErnWong/rust-wasm-experiment-wavesim against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ErnWong/rust-wasm-experiment-wavesim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 37f7f292877c0e7f2c94cc18d947bb3b033e6098a9d89e4230ace1862d15f235 [INFO] running `"docker" "start" "-a" "37f7f292877c0e7f2c94cc18d947bb3b033e6098a9d89e4230ace1862d15f235"` [INFO] [stderr] Checking rust-wasm-test-wavesim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:25:19 [INFO] [stderr] | [INFO] [stderr] 25 | DataRow { padded_data: padded_data } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `padded_data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:225:53 [INFO] [stderr] | [INFO] [stderr] 225 | fn put(&mut self, x: i32, y: i32, r: u8, g: u8, b: u8) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | let i = (x + y * width) * 4; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:25:19 [INFO] [stderr] | [INFO] [stderr] 25 | DataRow { padded_data: padded_data } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `padded_data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:225:53 [INFO] [stderr] | [INFO] [stderr] 225 | fn put(&mut self, x: i32, y: i32, r: u8, g: u8, b: u8) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | let i = (x + y * width) * 4; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:334:5 [INFO] [stderr] | [INFO] [stderr] 334 | return ptr as *mut c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr as *mut c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | let mut solver = unsafe { &mut *solver_ptr }; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | let mut solver = unsafe { &mut *solver_ptr }; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | let mut solver = unsafe { &mut *solver_ptr }; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `data_row` [INFO] [stderr] --> src/lib.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..size [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for (i, ) in data_row.iter_mut().enumerate().take(size) [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | fn to_raw_ptr(&mut self) -> *mut T [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/lib.rs:237:21 [INFO] [stderr] | [INFO] [stderr] 237 | self.buffer[i + 0] = r; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4 * i` [INFO] [stderr] --> src/lib.rs:247:25 [INFO] [stderr] | [INFO] [stderr] 247 | self.buffer[4 * i + 0] = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:297:37 [INFO] [stderr] | [INFO] [stderr] 297 | let mut solver = unsafe { &mut *solver_ptr }; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:299:25 [INFO] [stderr] | [INFO] [stderr] 299 | let dt = duration / (divides as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(divides)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:311:37 [INFO] [stderr] | [INFO] [stderr] 311 | let mut solver = unsafe { &mut *solver_ptr }; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:318:37 [INFO] [stderr] | [INFO] [stderr] 318 | let mut solver = unsafe { &mut *solver_ptr }; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:321:53 [INFO] [stderr] | [INFO] [stderr] 321 | let buffer = unsafe { slice::from_raw_parts_mut(buffer_ptr, buffer_bytes) }; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-wasm-test-wavesim`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:334:5 [INFO] [stderr] | [INFO] [stderr] 334 | return ptr as *mut c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr as *mut c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | let mut solver = unsafe { &mut *solver_ptr }; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | let mut solver = unsafe { &mut *solver_ptr }; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | let mut solver = unsafe { &mut *solver_ptr }; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `data_row` [INFO] [stderr] --> src/lib.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..size [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for (i, ) in data_row.iter_mut().enumerate().take(size) [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | fn to_raw_ptr(&mut self) -> *mut T [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/lib.rs:237:21 [INFO] [stderr] | [INFO] [stderr] 237 | self.buffer[i + 0] = r; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4 * i` [INFO] [stderr] --> src/lib.rs:247:25 [INFO] [stderr] | [INFO] [stderr] 247 | self.buffer[4 * i + 0] = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:297:37 [INFO] [stderr] | [INFO] [stderr] 297 | let mut solver = unsafe { &mut *solver_ptr }; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:299:25 [INFO] [stderr] | [INFO] [stderr] 299 | let dt = duration / (divides as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(divides)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:311:37 [INFO] [stderr] | [INFO] [stderr] 311 | let mut solver = unsafe { &mut *solver_ptr }; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:318:37 [INFO] [stderr] | [INFO] [stderr] 318 | let mut solver = unsafe { &mut *solver_ptr }; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:321:53 [INFO] [stderr] | [INFO] [stderr] 321 | let buffer = unsafe { slice::from_raw_parts_mut(buffer_ptr, buffer_bytes) }; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-wasm-test-wavesim`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "37f7f292877c0e7f2c94cc18d947bb3b033e6098a9d89e4230ace1862d15f235"` [INFO] running `"docker" "rm" "-f" "37f7f292877c0e7f2c94cc18d947bb3b033e6098a9d89e4230ace1862d15f235"` [INFO] [stdout] 37f7f292877c0e7f2c94cc18d947bb3b033e6098a9d89e4230ace1862d15f235