[INFO] updating cached repository ErikUggeldahl/RustGameOfLife [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ErikUggeldahl/RustGameOfLife [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ErikUggeldahl/RustGameOfLife" "work/ex/clippy-test-run/sources/stable/gh/ErikUggeldahl/RustGameOfLife"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ErikUggeldahl/RustGameOfLife'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ErikUggeldahl/RustGameOfLife" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ErikUggeldahl/RustGameOfLife"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ErikUggeldahl/RustGameOfLife'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e65424c911c1878b4aa01af81d89763e48e4ecf [INFO] sha for GitHub repo ErikUggeldahl/RustGameOfLife: 8e65424c911c1878b4aa01af81d89763e48e4ecf [INFO] validating manifest of ErikUggeldahl/RustGameOfLife on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ErikUggeldahl/RustGameOfLife on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ErikUggeldahl/RustGameOfLife [INFO] finished frobbing ErikUggeldahl/RustGameOfLife [INFO] frobbed toml for ErikUggeldahl/RustGameOfLife written to work/ex/clippy-test-run/sources/stable/gh/ErikUggeldahl/RustGameOfLife/Cargo.toml [INFO] started frobbing ErikUggeldahl/RustGameOfLife [INFO] finished frobbing ErikUggeldahl/RustGameOfLife [INFO] frobbed toml for ErikUggeldahl/RustGameOfLife written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ErikUggeldahl/RustGameOfLife/Cargo.toml [INFO] crate ErikUggeldahl/RustGameOfLife has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ErikUggeldahl/RustGameOfLife against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ErikUggeldahl/RustGameOfLife:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8eb2ac39ade21b41e04355a66ab30cc40ec632bc30e90bf785a246e6af23b2a8 [INFO] running `"docker" "start" "-a" "8eb2ac39ade21b41e04355a66ab30cc40ec632bc30e90bf785a246e6af23b2a8"` [INFO] [stderr] Checking 20150720_next_life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:30:10 [INFO] [stderr] | [INFO] [stderr] 30 | grid: initial_state.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*initial_state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | if self.grid[y][x] { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `self.grid[y][x]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:30:10 [INFO] [stderr] | [INFO] [stderr] 30 | grid: initial_state.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*initial_state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | if self.grid[y][x] { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `self.grid[y][x]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:62:3 [INFO] [stderr] | [INFO] [stderr] 62 | match self.occupied(coord) { [INFO] [stderr] | _________^ [INFO] [stderr] 63 | | true => match neighbours { [INFO] [stderr] 64 | | 2 | 3 => true, [INFO] [stderr] 65 | | _ => false [INFO] [stderr] 66 | | }, [INFO] [stderr] 67 | | false => if neighbours == 3 { true } else { false } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 62 | if self.occupied(coord) { match neighbours { [INFO] [stderr] 63 | 2 | 3 => true, [INFO] [stderr] 64 | _ => false [INFO] [stderr] 65 | } } else { if neighbours == 3 { true } else { false } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | false => if neighbours == 3 { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `neighbours == 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:62:3 [INFO] [stderr] | [INFO] [stderr] 62 | match self.occupied(coord) { [INFO] [stderr] | _________^ [INFO] [stderr] 63 | | true => match neighbours { [INFO] [stderr] 64 | | 2 | 3 => true, [INFO] [stderr] 65 | | _ => false [INFO] [stderr] 66 | | }, [INFO] [stderr] 67 | | false => if neighbours == 3 { true } else { false } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 62 | if self.occupied(coord) { match neighbours { [INFO] [stderr] 63 | 2 | 3 => true, [INFO] [stderr] 64 | _ => false [INFO] [stderr] 65 | } } else { if neighbours == 3 { true } else { false } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | false => if neighbours == 3 { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `neighbours == 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "8eb2ac39ade21b41e04355a66ab30cc40ec632bc30e90bf785a246e6af23b2a8"` [INFO] running `"docker" "rm" "-f" "8eb2ac39ade21b41e04355a66ab30cc40ec632bc30e90bf785a246e6af23b2a8"` [INFO] [stdout] 8eb2ac39ade21b41e04355a66ab30cc40ec632bc30e90bf785a246e6af23b2a8