[INFO] updating cached repository EricEisaman/hello-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/EricEisaman/hello-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/EricEisaman/hello-rust" "work/ex/clippy-test-run/sources/stable/gh/EricEisaman/hello-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/EricEisaman/hello-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/EricEisaman/hello-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EricEisaman/hello-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EricEisaman/hello-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ac8a29d4ef2dab9fb0ae886f0401959a0440b0a5 [INFO] sha for GitHub repo EricEisaman/hello-rust: ac8a29d4ef2dab9fb0ae886f0401959a0440b0a5 [INFO] validating manifest of EricEisaman/hello-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of EricEisaman/hello-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing EricEisaman/hello-rust [INFO] finished frobbing EricEisaman/hello-rust [INFO] frobbed toml for EricEisaman/hello-rust written to work/ex/clippy-test-run/sources/stable/gh/EricEisaman/hello-rust/Cargo.toml [INFO] started frobbing EricEisaman/hello-rust [INFO] finished frobbing EricEisaman/hello-rust [INFO] frobbed toml for EricEisaman/hello-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EricEisaman/hello-rust/Cargo.toml [INFO] crate EricEisaman/hello-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting EricEisaman/hello-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/EricEisaman/hello-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b360efbf86bf4425b6930b250273fdbcabd52826a5093c46692c4d67de923845 [INFO] running `"docker" "start" "-a" "b360efbf86bf4425b6930b250273fdbcabd52826a5093c46692c4d67de923845"` [INFO] [stderr] Checking hello_cargo v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | let y: f64 = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | let y: f64 = a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | t = t - x * (y-a)*(y-a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `t -= x * (y-a)*(y-a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | x = 2.0 * x; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `x *= 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | t = t - x * (y-a)*(y-a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `t -= x * (y-a)*(y-a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | x = 2.0 * x; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `x *= 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.07s [INFO] running `"docker" "inspect" "b360efbf86bf4425b6930b250273fdbcabd52826a5093c46692c4d67de923845"` [INFO] running `"docker" "rm" "-f" "b360efbf86bf4425b6930b250273fdbcabd52826a5093c46692c4d67de923845"` [INFO] [stdout] b360efbf86bf4425b6930b250273fdbcabd52826a5093c46692c4d67de923845