[INFO] updating cached repository EngelEatos/rust_duplicatefinder
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/EngelEatos/rust_duplicatefinder
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/EngelEatos/rust_duplicatefinder" "work/ex/clippy-test-run/sources/stable/gh/EngelEatos/rust_duplicatefinder"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/EngelEatos/rust_duplicatefinder'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/EngelEatos/rust_duplicatefinder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EngelEatos/rust_duplicatefinder"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EngelEatos/rust_duplicatefinder'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d0276fa02e469bb080d1fc1e86795911c269e133
[INFO] sha for GitHub repo EngelEatos/rust_duplicatefinder: d0276fa02e469bb080d1fc1e86795911c269e133
[INFO] validating manifest of EngelEatos/rust_duplicatefinder on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of EngelEatos/rust_duplicatefinder on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing EngelEatos/rust_duplicatefinder
[INFO] finished frobbing EngelEatos/rust_duplicatefinder
[INFO] frobbed toml for EngelEatos/rust_duplicatefinder written to work/ex/clippy-test-run/sources/stable/gh/EngelEatos/rust_duplicatefinder/Cargo.toml
[INFO] started frobbing EngelEatos/rust_duplicatefinder
[INFO] finished frobbing EngelEatos/rust_duplicatefinder
[INFO] frobbed toml for EngelEatos/rust_duplicatefinder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EngelEatos/rust_duplicatefinder/Cargo.toml
[INFO] crate EngelEatos/rust_duplicatefinder has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting EngelEatos/rust_duplicatefinder against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/EngelEatos/rust_duplicatefinder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 851794ba5c36db78867881d9a80cfad14f589f1a6d4435a70f392dabc736dcf6
[INFO] running `"docker" "start" "-a" "851794ba5c36db78867881d9a80cfad14f589f1a6d4435a70f392dabc736dcf6"`
[INFO] [stderr]     Checking filebuffer v0.2.0
[INFO] [stderr]     Checking generic-array v0.9.0
[INFO] [stderr]     Checking crypto-mac v0.5.1
[INFO] [stderr]     Checking digest v0.7.1
[INFO] [stderr]     Checking blake2 v0.7.0
[INFO] [stderr]     Checking duplicatefinder v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 |     return strs.join("");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `strs.join("")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/main.rs:36:36
[INFO] [stderr]    |
[INFO] [stderr] 36 |         dict.entry(metadata.len()).or_insert(Vec::new()).push(file.path());
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]   --> src/main.rs:68:27
[INFO] [stderr]    |
[INFO] [stderr] 68 |     for (_size, paths) in files {
[INFO] [stderr]    |                           ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 68 |     for paths in files.values() {
[INFO] [stderr]    |         ^^^^^    ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/main.rs:78:36
[INFO] [stderr]    |
[INFO] [stderr] 78 |             duplicates.entry(hash).or_insert(Vec::new()).push(path.to_path_buf());
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 |     return strs.join("");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `strs.join("")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/main.rs:36:36
[INFO] [stderr]    |
[INFO] [stderr] 36 |         dict.entry(metadata.len()).or_insert(Vec::new()).push(file.path());
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]   --> src/main.rs:68:27
[INFO] [stderr]    |
[INFO] [stderr] 68 |     for (_size, paths) in files {
[INFO] [stderr]    |                           ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 68 |     for paths in files.values() {
[INFO] [stderr]    |         ^^^^^    ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/main.rs:78:36
[INFO] [stderr]    |
[INFO] [stderr] 78 |             duplicates.entry(hash).or_insert(Vec::new()).push(path.to_path_buf());
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.05s
[INFO] running `"docker" "inspect" "851794ba5c36db78867881d9a80cfad14f589f1a6d4435a70f392dabc736dcf6"`
[INFO] running `"docker" "rm" "-f" "851794ba5c36db78867881d9a80cfad14f589f1a6d4435a70f392dabc736dcf6"`
[INFO] [stdout] 851794ba5c36db78867881d9a80cfad14f589f1a6d4435a70f392dabc736dcf6