[INFO] updating cached repository Emmatipate/jack-compiler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Emmatipate/jack-compiler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Emmatipate/jack-compiler" "work/ex/clippy-test-run/sources/stable/gh/Emmatipate/jack-compiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Emmatipate/jack-compiler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Emmatipate/jack-compiler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Emmatipate/jack-compiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Emmatipate/jack-compiler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c68a530d80639bfd2fd68ca0bf7472c428655395 [INFO] sha for GitHub repo Emmatipate/jack-compiler: c68a530d80639bfd2fd68ca0bf7472c428655395 [INFO] validating manifest of Emmatipate/jack-compiler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Emmatipate/jack-compiler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Emmatipate/jack-compiler [INFO] finished frobbing Emmatipate/jack-compiler [INFO] frobbed toml for Emmatipate/jack-compiler written to work/ex/clippy-test-run/sources/stable/gh/Emmatipate/jack-compiler/Cargo.toml [INFO] started frobbing Emmatipate/jack-compiler [INFO] finished frobbing Emmatipate/jack-compiler [INFO] frobbed toml for Emmatipate/jack-compiler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Emmatipate/jack-compiler/Cargo.toml [INFO] crate Emmatipate/jack-compiler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Emmatipate/jack-compiler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Emmatipate/jack-compiler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 21cfa0f2c2855aee7e35b31600c4f5ddbf94c0c6795b7c091ee780426d7f5674 [INFO] running `"docker" "start" "-a" "21cfa0f2c2855aee7e35b31600c4f5ddbf94c0c6795b7c091ee780426d7f5674"` [INFO] [stderr] Checking jackcompiler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return skip_result; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `skip_result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | / return match &*name { [INFO] [stderr] 209 | | "class" => Some(Keyword::Class), [INFO] [stderr] 210 | | "method" => Some(Keyword::Method), [INFO] [stderr] 211 | | "function" => Some(Keyword::Function), [INFO] [stderr] ... | [INFO] [stderr] 230 | | _ => None, [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 208 | match &*name { [INFO] [stderr] 209 | "class" => Some(Keyword::Class), [INFO] [stderr] 210 | "method" => Some(Keyword::Method), [INFO] [stderr] 211 | "function" => Some(Keyword::Function), [INFO] [stderr] 212 | "constructor" => Some(Keyword::Constructor), [INFO] [stderr] 213 | "int" => Some(Keyword::Int), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | return buf.parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/jack_analyzer.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | / match self.pos_of_next_token() { [INFO] [stderr] 171 | | Some(_) => true, [INFO] [stderr] 172 | | None => false, [INFO] [stderr] 173 | | } [INFO] [stderr] | |_________^ help: try this: `self.pos_of_next_token().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return skip_result; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `skip_result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | / return match &*name { [INFO] [stderr] 209 | | "class" => Some(Keyword::Class), [INFO] [stderr] 210 | | "method" => Some(Keyword::Method), [INFO] [stderr] 211 | | "function" => Some(Keyword::Function), [INFO] [stderr] ... | [INFO] [stderr] 230 | | _ => None, [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 208 | match &*name { [INFO] [stderr] 209 | "class" => Some(Keyword::Class), [INFO] [stderr] 210 | "method" => Some(Keyword::Method), [INFO] [stderr] 211 | "function" => Some(Keyword::Function), [INFO] [stderr] 212 | "constructor" => Some(Keyword::Constructor), [INFO] [stderr] 213 | "int" => Some(Keyword::Int), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | return buf.parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/jack_analyzer.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table.rs:58:36 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn define(&mut self, name: &String, t: &String, k: Kind) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table.rs:58:48 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn define(&mut self, name: &String, t: &String, k: Kind) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table.rs:92:33 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn kind_of(&self, name: &String) -> Kind { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbol_table.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | self.function_symbols.get(name).unwrap().kind [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.function_symbols[name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbol_table.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | self.class_symbols.get(name).unwrap().kind [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.class_symbols[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table.rs:102:33 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn type_of(&self, name: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbol_table.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | self.function_symbols.get(name).unwrap().type_name.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.function_symbols[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbol_table.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | self.class_symbols.get(name).unwrap().type_name.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.class_symbols[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table.rs:110:34 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn index_of(&self, name: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbol_table.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | self.function_symbols.get(name).unwrap().index [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.function_symbols[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbol_table.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | self.class_symbols.get(name).unwrap().index [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.class_symbols[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/jack_analyzer.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | / match self.pos_of_next_token() { [INFO] [stderr] 171 | | Some(_) => true, [INFO] [stderr] 172 | | None => false, [INFO] [stderr] 173 | | } [INFO] [stderr] | |_________^ help: try this: `self.pos_of_next_token().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table.rs:58:36 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn define(&mut self, name: &String, t: &String, k: Kind) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table.rs:58:48 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn define(&mut self, name: &String, t: &String, k: Kind) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table.rs:92:33 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn kind_of(&self, name: &String) -> Kind { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbol_table.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | self.function_symbols.get(name).unwrap().kind [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.function_symbols[name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbol_table.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | self.class_symbols.get(name).unwrap().kind [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.class_symbols[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table.rs:102:33 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn type_of(&self, name: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbol_table.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | self.function_symbols.get(name).unwrap().type_name.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.function_symbols[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbol_table.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | self.class_symbols.get(name).unwrap().type_name.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.class_symbols[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table.rs:110:34 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn index_of(&self, name: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbol_table.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | self.function_symbols.get(name).unwrap().index [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.function_symbols[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/symbol_table.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | self.class_symbols.get(name).unwrap().index [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.class_symbols[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.39s [INFO] running `"docker" "inspect" "21cfa0f2c2855aee7e35b31600c4f5ddbf94c0c6795b7c091ee780426d7f5674"` [INFO] running `"docker" "rm" "-f" "21cfa0f2c2855aee7e35b31600c4f5ddbf94c0c6795b7c091ee780426d7f5674"` [INFO] [stdout] 21cfa0f2c2855aee7e35b31600c4f5ddbf94c0c6795b7c091ee780426d7f5674