[INFO] updating cached repository Emmatipate/duck-duck-swim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Emmatipate/duck-duck-swim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Emmatipate/duck-duck-swim" "work/ex/clippy-test-run/sources/stable/gh/Emmatipate/duck-duck-swim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Emmatipate/duck-duck-swim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Emmatipate/duck-duck-swim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Emmatipate/duck-duck-swim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Emmatipate/duck-duck-swim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3b1431472f942b9d10dec0bc38c3e66fcedb88dd [INFO] sha for GitHub repo Emmatipate/duck-duck-swim: 3b1431472f942b9d10dec0bc38c3e66fcedb88dd [INFO] validating manifest of Emmatipate/duck-duck-swim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Emmatipate/duck-duck-swim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Emmatipate/duck-duck-swim [INFO] finished frobbing Emmatipate/duck-duck-swim [INFO] frobbed toml for Emmatipate/duck-duck-swim written to work/ex/clippy-test-run/sources/stable/gh/Emmatipate/duck-duck-swim/Cargo.toml [INFO] started frobbing Emmatipate/duck-duck-swim [INFO] finished frobbing Emmatipate/duck-duck-swim [INFO] frobbed toml for Emmatipate/duck-duck-swim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Emmatipate/duck-duck-swim/Cargo.toml [INFO] crate Emmatipate/duck-duck-swim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Emmatipate/duck-duck-swim against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Emmatipate/duck-duck-swim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a999e6fc197e236e086052db2596ded38e6c700eead0c4fc15d7ffa68731d2d7 [INFO] running `"docker" "start" "-a" "a999e6fc197e236e086052db2596ded38e6c700eead0c4fc15d7ffa68731d2d7"` [INFO] [stderr] Compiling serde v0.8.20 [INFO] [stderr] Compiling xml-rs v0.3.5 [INFO] [stderr] Checking gfx_core v0.4.0 [INFO] [stderr] Checking memmap v0.2.3 [INFO] [stderr] Checking pulse v0.5.3 [INFO] [stderr] Checking enum_primitive v0.1.0 [INFO] [stderr] Checking nalgebra v0.9.0 [INFO] [stderr] Checking specs v0.7.0 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Compiling wayland-scanner v0.5.11 [INFO] [stderr] Compiling gl_generator v0.5.2 [INFO] [stderr] Compiling wayland-client v0.5.12 [INFO] [stderr] Compiling serde_json v0.8.4 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling glutin v0.6.2 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.5.11 [INFO] [stderr] Checking wayland-kbd v0.3.6 [INFO] [stderr] Checking wayland-window v0.2.3 [INFO] [stderr] Checking gfx_device_gl v0.11.2 [INFO] [stderr] Checking gfx v0.12.2 [INFO] [stderr] Checking gfx_window_glutin v0.12.0 [INFO] [stderr] Checking pegasus v0.2.0 [INFO] [stderr] Checking duck_duck_swim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | aspect: aspect, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `aspect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | pso: pso, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | pipelines: pipelines, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pipelines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | aspect: aspect, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `aspect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | pso: pso, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | pipelines: pipelines, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pipelines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | const CODE_VS: &'static[u8] = include_bytes!("shader/sprite.vert"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | const CODE_FS: &'static[u8] = include_bytes!("shader/sprite.frag"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:122:49 [INFO] [stderr] | [INFO] [stderr] 122 | fn start(self, plan: &mut pegasus::Planner) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | const CODE_VS: &'static[u8] = include_bytes!("shader/sprite.vert"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | const CODE_FS: &'static[u8] = include_bytes!("shader/sprite.frag"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:122:49 [INFO] [stderr] | [INFO] [stderr] 122 | fn start(self, plan: &mut pegasus::Planner) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: reference to uninitialized memory [INFO] [stderr] --> src/main.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / gfx_defines! { [INFO] [stderr] 22 | | vertex Vertex { [INFO] [stderr] 23 | | pos: [f32; 2] = "a_Pos", [INFO] [stderr] 24 | | uv: [f32; 2] = "a_UV", [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::invalid_ref)] on by default [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | for ref mut sprite in iter { [INFO] [stderr] | ^^^^^^^^^^^^^^ ---- help: try: `let sprite = &mut iter;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | let ref mut pipe = self.pipelines[sprite.gpu_data_index]; [INFO] [stderr] | ----^^^^^^^^^^^^----------------------------------------- help: try: `let pipe = &mut self.pipelines[sprite.gpu_data_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:164:24 [INFO] [stderr] | [INFO] [stderr] 164 | pipe.pos = sprite.pos.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `sprite.pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:210:14 [INFO] [stderr] | [INFO] [stderr] 210 | pos: [0.0, 0.0].into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `[0.0, 0.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `duck_duck_swim`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: reference to uninitialized memory [INFO] [stderr] --> src/main.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / gfx_defines! { [INFO] [stderr] 22 | | vertex Vertex { [INFO] [stderr] 23 | | pos: [f32; 2] = "a_Pos", [INFO] [stderr] 24 | | uv: [f32; 2] = "a_UV", [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::invalid_ref)] on by default [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | for ref mut sprite in iter { [INFO] [stderr] | ^^^^^^^^^^^^^^ ---- help: try: `let sprite = &mut iter;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | let ref mut pipe = self.pipelines[sprite.gpu_data_index]; [INFO] [stderr] | ----^^^^^^^^^^^^----------------------------------------- help: try: `let pipe = &mut self.pipelines[sprite.gpu_data_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:164:24 [INFO] [stderr] | [INFO] [stderr] 164 | pipe.pos = sprite.pos.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `sprite.pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:210:14 [INFO] [stderr] | [INFO] [stderr] 210 | pos: [0.0, 0.0].into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `[0.0, 0.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `duck_duck_swim`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a999e6fc197e236e086052db2596ded38e6c700eead0c4fc15d7ffa68731d2d7"` [INFO] running `"docker" "rm" "-f" "a999e6fc197e236e086052db2596ded38e6c700eead0c4fc15d7ffa68731d2d7"` [INFO] [stdout] a999e6fc197e236e086052db2596ded38e6c700eead0c4fc15d7ffa68731d2d7