[INFO] updating cached repository EmilOhlsson/issue-manager [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/EmilOhlsson/issue-manager [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/EmilOhlsson/issue-manager" "work/ex/clippy-test-run/sources/stable/gh/EmilOhlsson/issue-manager"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/EmilOhlsson/issue-manager'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/EmilOhlsson/issue-manager" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EmilOhlsson/issue-manager"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EmilOhlsson/issue-manager'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1b1102d1db03cc83448b6d5f9c1ef6b8a3199cd2 [INFO] sha for GitHub repo EmilOhlsson/issue-manager: 1b1102d1db03cc83448b6d5f9c1ef6b8a3199cd2 [INFO] validating manifest of EmilOhlsson/issue-manager on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of EmilOhlsson/issue-manager on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing EmilOhlsson/issue-manager [INFO] finished frobbing EmilOhlsson/issue-manager [INFO] frobbed toml for EmilOhlsson/issue-manager written to work/ex/clippy-test-run/sources/stable/gh/EmilOhlsson/issue-manager/Cargo.toml [INFO] started frobbing EmilOhlsson/issue-manager [INFO] finished frobbing EmilOhlsson/issue-manager [INFO] frobbed toml for EmilOhlsson/issue-manager written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EmilOhlsson/issue-manager/Cargo.toml [INFO] crate EmilOhlsson/issue-manager has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting EmilOhlsson/issue-manager against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/EmilOhlsson/issue-manager:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a1c2f5c05f4791d13ebda39bdd228bbc50c73d322640da82825969e289cd966 [INFO] running `"docker" "start" "-a" "3a1c2f5c05f4791d13ebda39bdd228bbc50c73d322640da82825969e289cd966"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Compiling openssl-sys v0.9.28 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling cmake v0.1.30 [INFO] [stderr] Compiling curl-sys v0.4.2 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.7.1 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking hyper v0.11.25 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking git2 v0.7.1 [INFO] [stderr] Checking issue-handler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git_server.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | protocol: protocol, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git_server.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | protocol: protocol, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol` [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git_server.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | api: api, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `api` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/git_server.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | api: api, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `api` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/git_server.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | Ok(String::from(git_remote.url().ok_or(IMError::new( [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 65 | | &format!("No url associated with {}", remote), [INFO] [stderr] 66 | | ))?)) [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | Ok(String::from(git_remote.url().ok_or_else(|| IMError::new( [INFO] [stderr] 65 | &format!("No url associated with {}", remote), [INFO] [stderr] 66 | ))?)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/git_server.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | .filter(|s| s.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/git_server.rs:79:33 [INFO] [stderr] | [INFO] [stderr] 79 | let server = *ts.get(1).ok_or(IMError::new("Could not parse server"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IMError::new("Could not parse server"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/git_server.rs:80:32 [INFO] [stderr] | [INFO] [stderr] 80 | let group = *ts.get(2).ok_or(IMError::new("Could not parse group"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IMError::new("Could not parse group"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/git_server.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | (*ts.get(3).ok_or(IMError::new("Could not parse project"))?).replace(".git", ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IMError::new("Could not parse project"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/git_server.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / if let &Some(ref key) = &server.key { [INFO] [stderr] 123 | | match server.protocol { [INFO] [stderr] 124 | | GitProtocol::GitHub => request.header(Authorization(Token { [INFO] [stderr] 125 | | token: key.to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 128 | | }; [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | if let Some(ref key) = server.key { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/git_server.rs:147:22 [INFO] [stderr] | [INFO] [stderr] 147 | .map(|i| IMIssue::GitHub(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `IMIssue::GitHub` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/git_server.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | .map(|i| IMIssue::GitLab(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `IMIssue::GitLab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/git_server.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | Ok(String::from(git_remote.url().ok_or(IMError::new( [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 65 | | &format!("No url associated with {}", remote), [INFO] [stderr] 66 | | ))?)) [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | Ok(String::from(git_remote.url().ok_or_else(|| IMError::new( [INFO] [stderr] 65 | &format!("No url associated with {}", remote), [INFO] [stderr] 66 | ))?)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/git_server.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | .filter(|s| s.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/git_server.rs:79:33 [INFO] [stderr] | [INFO] [stderr] 79 | let server = *ts.get(1).ok_or(IMError::new("Could not parse server"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IMError::new("Could not parse server"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/git_server.rs:80:32 [INFO] [stderr] | [INFO] [stderr] 80 | let group = *ts.get(2).ok_or(IMError::new("Could not parse group"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IMError::new("Could not parse group"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/git_server.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | (*ts.get(3).ok_or(IMError::new("Could not parse project"))?).replace(".git", ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IMError::new("Could not parse project"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/git_server.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / if let &Some(ref key) = &server.key { [INFO] [stderr] 123 | | match server.protocol { [INFO] [stderr] 124 | | GitProtocol::GitHub => request.header(Authorization(Token { [INFO] [stderr] 125 | | token: key.to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 128 | | }; [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | if let Some(ref key) = server.key { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/git_server.rs:147:22 [INFO] [stderr] | [INFO] [stderr] 147 | .map(|i| IMIssue::GitHub(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `IMIssue::GitHub` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/git_server.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | .map(|i| IMIssue::GitLab(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `IMIssue::GitLab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 15s [INFO] running `"docker" "inspect" "3a1c2f5c05f4791d13ebda39bdd228bbc50c73d322640da82825969e289cd966"` [INFO] running `"docker" "rm" "-f" "3a1c2f5c05f4791d13ebda39bdd228bbc50c73d322640da82825969e289cd966"` [INFO] [stdout] 3a1c2f5c05f4791d13ebda39bdd228bbc50c73d322640da82825969e289cd966