[INFO] updating cached repository Ekleog/todiff
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Ekleog/todiff
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Ekleog/todiff" "work/ex/clippy-test-run/sources/stable/gh/Ekleog/todiff"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ekleog/todiff'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Ekleog/todiff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ekleog/todiff"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ekleog/todiff'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 278bb65016cb524fa2af65bbf085c178f18a43ee
[INFO] sha for GitHub repo Ekleog/todiff: 278bb65016cb524fa2af65bbf085c178f18a43ee
[INFO] validating manifest of Ekleog/todiff on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Ekleog/todiff on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Ekleog/todiff
[INFO] removed 0 missing tests
[INFO] finished frobbing Ekleog/todiff
[INFO] frobbed toml for Ekleog/todiff written to work/ex/clippy-test-run/sources/stable/gh/Ekleog/todiff/Cargo.toml
[INFO] started frobbing Ekleog/todiff
[INFO] removed 0 missing tests
[INFO] finished frobbing Ekleog/todiff
[INFO] frobbed toml for Ekleog/todiff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ekleog/todiff/Cargo.toml
[INFO] crate Ekleog/todiff has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Ekleog/todiff against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Ekleog/todiff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7ca45302cf68707c92bfd9df51442a21562b43d43f4813b406462f178bd4a550
[INFO] running `"docker" "start" "-a" "7ca45302cf68707c92bfd9df51442a21562b43d43f4813b406462f178bd4a550"`
[INFO] [stderr]     Checking todo-txt v1.2.0
[INFO] [stderr]     Checking todiff v0.6.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/compute_changes.rs:319:9
[INFO] [stderr]     |
[INFO] [stderr] 319 |         allowed_divergence: allowed_divergence,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_divergence`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/compute_changes.rs:343:17
[INFO] [stderr]     |
[INFO] [stderr] 343 |                 delta: delta,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `delta`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/compute_changes.rs:385:17
[INFO] [stderr]     |
[INFO] [stderr] 385 |                 orig: orig,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `orig`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/compute_changes.rs:422:17
[INFO] [stderr]     |
[INFO] [stderr] 422 |                 orig: orig,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `orig`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/compute_changes.rs:319:9
[INFO] [stderr]     |
[INFO] [stderr] 319 |         allowed_divergence: allowed_divergence,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_divergence`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/compute_changes.rs:343:17
[INFO] [stderr]     |
[INFO] [stderr] 343 |                 delta: delta,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `delta`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/compute_changes.rs:385:17
[INFO] [stderr]     |
[INFO] [stderr] 385 |                 orig: orig,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `orig`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/compute_changes.rs:422:17
[INFO] [stderr]     |
[INFO] [stderr] 422 |                 orig: orig,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `orig`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/compute_changes.rs:134:9
[INFO] [stderr]     |
[INFO] [stderr] 134 | /         match (from.due_date, from.threshold_date) {
[INFO] [stderr] 135 | |             (Some(from_due), Some(from_thresh)) => {
[INFO] [stderr] 136 | |                 let delta = from_due.signed_duration_since(from_thresh);
[INFO] [stderr] 137 | |                 new_task.threshold_date = new_task.due_date.map(|d| d - delta);
[INFO] [stderr] 138 | |             }
[INFO] [stderr] 139 | |             _ => {}
[INFO] [stderr] 140 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 134 |         if let (Some(from_due), Some(from_thresh)) = (from.due_date, from.threshold_date) {
[INFO] [stderr] 135 |     let delta = from_due.signed_duration_since(from_thresh);
[INFO] [stderr] 136 |     new_task.threshold_date = new_task.due_date.map(|d| d - delta);
[INFO] [stderr] 137 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/compute_changes.rs:143:12
[INFO] [stderr]     |
[INFO] [stderr] 143 |       if let Some(_) = from_finish {
[INFO] [stderr]     |  _____-      ^^^^^^^
[INFO] [stderr] 144 | |         new_task.create_date = from_finish;
[INFO] [stderr] 145 | |     }
[INFO] [stderr]     | |_____- help: try this: `if from_finish.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/compute_changes.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 | /     let mut done_finished_at = false;
[INFO] [stderr] 157 | |     if (from.finished == false)
[INFO] [stderr] 158 | |         && to.finished == true
[INFO] [stderr] 159 | |         && from.finish_date.is_none()
[INFO] [stderr] ...   |
[INFO] [stderr] 163 | |         done_finished_at = true;
[INFO] [stderr] 164 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 156 |     let <mut> done_finished_at = if (from.finished == false)
[INFO] [stderr] 157 |         && to.finished == true
[INFO] [stderr] 158 |         && from.finish_date.is_none()
[INFO] [stderr] 159 |         && to.finish_date.is_some() { ..; true } else { false };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/compute_changes.rs:157:8
[INFO] [stderr]     |
[INFO] [stderr] 157 |     if (from.finished == false)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!from.finished`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/compute_changes.rs:158:12
[INFO] [stderr]     |
[INFO] [stderr] 158 |         && to.finished == true
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `to.finished`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/compute_changes.rs:192:9
[INFO] [stderr]     |
[INFO] [stderr] 192 | /         let from_prio;
[INFO] [stderr] 193 | |         if from.priority < 26 {
[INFO] [stderr] 194 | |             from_prio = Some((b'A' + from.priority) as char);
[INFO] [stderr] 195 | |         } else {
[INFO] [stderr] 196 | |             from_prio = None;
[INFO] [stderr] 197 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let from_prio = if from.priority < 26 { Some((b'A' + from.priority) as char) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/compute_changes.rs:198:9
[INFO] [stderr]     |
[INFO] [stderr] 198 | /         let to_prio;
[INFO] [stderr] 199 | |         if to.priority < 26 {
[INFO] [stderr] 200 | |             to_prio = Some((b'A' + to.priority) as char);
[INFO] [stderr] 201 | |         } else {
[INFO] [stderr] 202 | |             to_prio = None;
[INFO] [stderr] 203 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let to_prio = if to.priority < 26 { Some((b'A' + to.priority) as char) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/display_changes.rs:134:49
[INFO] [stderr]     |
[INFO] [stderr] 134 | fn display_changes(colorize: bool, chgs_for_me: &Vec<Changes>) -> String {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^ help: change this to: `&[Changes]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/display_changes.rs:137:10
[INFO] [stderr]     |
[INFO] [stderr] 137 |         .into_iter()
[INFO] [stderr]     |          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/merge_changes.rs:23:36
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 t1.into_iter().map(|x| f(x)).collect(),
[INFO] [stderr]    |                                    ^^^^^^^^ help: remove closure as shown: `f`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/merge_changes.rs:24:36
[INFO] [stderr]    |
[INFO] [stderr] 24 |                 t2.into_iter().map(|x| f(x)).collect(),
[INFO] [stderr]    |                                    ^^^^^^^^ help: remove closure as shown: `f`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/merge_changes.rs:80:32
[INFO] [stderr]    |
[INFO] [stderr] 80 | pub fn merge_successful(merge: &Vec<MergeResult<Task>>) -> bool {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[MergeResult<Task>]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/stable_marriage.rs:16:18
[INFO] [stderr]    |
[INFO] [stderr] 16 |         targets: &Vec<Woman<Self>>,
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^ help: change this to: `&[Woman<Self>]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/compute_changes.rs:134:9
[INFO] [stderr]     |
[INFO] [stderr] 134 | /         match (from.due_date, from.threshold_date) {
[INFO] [stderr] 135 | |             (Some(from_due), Some(from_thresh)) => {
[INFO] [stderr] 136 | |                 let delta = from_due.signed_duration_since(from_thresh);
[INFO] [stderr] 137 | |                 new_task.threshold_date = new_task.due_date.map(|d| d - delta);
[INFO] [stderr] 138 | |             }
[INFO] [stderr] 139 | |             _ => {}
[INFO] [stderr] 140 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 134 |         if let (Some(from_due), Some(from_thresh)) = (from.due_date, from.threshold_date) {
[INFO] [stderr] 135 |     let delta = from_due.signed_duration_since(from_thresh);
[INFO] [stderr] 136 |     new_task.threshold_date = new_task.due_date.map(|d| d - delta);
[INFO] [stderr] 137 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/compute_changes.rs:143:12
[INFO] [stderr]     |
[INFO] [stderr] 143 |       if let Some(_) = from_finish {
[INFO] [stderr]     |  _____-      ^^^^^^^
[INFO] [stderr] 144 | |         new_task.create_date = from_finish;
[INFO] [stderr] 145 | |     }
[INFO] [stderr]     | |_____- help: try this: `if from_finish.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/compute_changes.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 | /     let mut done_finished_at = false;
[INFO] [stderr] 157 | |     if (from.finished == false)
[INFO] [stderr] 158 | |         && to.finished == true
[INFO] [stderr] 159 | |         && from.finish_date.is_none()
[INFO] [stderr] ...   |
[INFO] [stderr] 163 | |         done_finished_at = true;
[INFO] [stderr] 164 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 156 |     let <mut> done_finished_at = if (from.finished == false)
[INFO] [stderr] 157 |         && to.finished == true
[INFO] [stderr] 158 |         && from.finish_date.is_none()
[INFO] [stderr] 159 |         && to.finish_date.is_some() { ..; true } else { false };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/compute_changes.rs:157:8
[INFO] [stderr]     |
[INFO] [stderr] 157 |     if (from.finished == false)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!from.finished`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/compute_changes.rs:158:12
[INFO] [stderr]     |
[INFO] [stderr] 158 |         && to.finished == true
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `to.finished`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/compute_changes.rs:192:9
[INFO] [stderr]     |
[INFO] [stderr] 192 | /         let from_prio;
[INFO] [stderr] 193 | |         if from.priority < 26 {
[INFO] [stderr] 194 | |             from_prio = Some((b'A' + from.priority) as char);
[INFO] [stderr] 195 | |         } else {
[INFO] [stderr] 196 | |             from_prio = None;
[INFO] [stderr] 197 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let from_prio = if from.priority < 26 { Some((b'A' + from.priority) as char) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/compute_changes.rs:198:9
[INFO] [stderr]     |
[INFO] [stderr] 198 | /         let to_prio;
[INFO] [stderr] 199 | |         if to.priority < 26 {
[INFO] [stderr] 200 | |             to_prio = Some((b'A' + to.priority) as char);
[INFO] [stderr] 201 | |         } else {
[INFO] [stderr] 202 | |             to_prio = None;
[INFO] [stderr] 203 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let to_prio = if to.priority < 26 { Some((b'A' + to.priority) as char) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/display_changes.rs:134:49
[INFO] [stderr]     |
[INFO] [stderr] 134 | fn display_changes(colorize: bool, chgs_for_me: &Vec<Changes>) -> String {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^ help: change this to: `&[Changes]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/display_changes.rs:137:10
[INFO] [stderr]     |
[INFO] [stderr] 137 |         .into_iter()
[INFO] [stderr]     |          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/merge_changes.rs:23:36
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 t1.into_iter().map(|x| f(x)).collect(),
[INFO] [stderr]    |                                    ^^^^^^^^ help: remove closure as shown: `f`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/merge_changes.rs:24:36
[INFO] [stderr]    |
[INFO] [stderr] 24 |                 t2.into_iter().map(|x| f(x)).collect(),
[INFO] [stderr]    |                                    ^^^^^^^^ help: remove closure as shown: `f`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/merge_changes.rs:80:32
[INFO] [stderr]    |
[INFO] [stderr] 80 | pub fn merge_successful(merge: &Vec<MergeResult<Task>>) -> bool {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[MergeResult<Task>]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/stable_marriage.rs:16:18
[INFO] [stderr]    |
[INFO] [stderr] 16 |         targets: &Vec<Woman<Self>>,
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^ help: change this to: `&[Woman<Self>]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/stable_marriage.rs:169:13
[INFO] [stderr]     |
[INFO] [stderr] 169 |             self.0[*x].iter().position(|j| j == y).is_some()
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `position(|j| j == y).is_some()` with `any(|j| j == y)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/todiff-merge.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return if success { 0 } else { 1 };
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if success { 0 } else { 1 }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/bin/todiff-merge.rs:12:33
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let file = File::open(path).expect(&format!("Unable to open file ‘{}’", path));
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open file ‘{}’", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/bin/todiff-merge.rs:16:25
[INFO] [stderr]    |
[INFO] [stderr] 16 |         let line = line.expect(&format!("Unable to read file ‘{}’", path));
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to read file ‘{}’", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/bin/todiff-merge.rs:17:40
[INFO] [stderr]    |
[INFO] [stderr] 17 |           res.push(Task::from_str(&line).expect(&format!(
[INFO] [stderr]    |  ________________________________________^
[INFO] [stderr] 18 | |             "Unable to parse line in file ‘{}’:\n{}",
[INFO] [stderr] 19 | |             path, line
[INFO] [stderr] 20 | |         )));
[INFO] [stderr]    | |__________^ help: try this: `unwrap_or_else(|_| panic!("Unable to parse line in file ‘{}’:\n{}", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/bin/todiff-merge.rs:68:36
[INFO] [stderr]    |
[INFO] [stderr] 68 |         fs::write(current, output).expect(&format!("Unable to write to file ‘{}’", current));
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to write to file ‘{}’", current))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/todiff-merge.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return if success { 0 } else { 1 };
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if success { 0 } else { 1 }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/bin/todiff-merge.rs:12:33
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let file = File::open(path).expect(&format!("Unable to open file ‘{}’", path));
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open file ‘{}’", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/bin/todiff-merge.rs:16:25
[INFO] [stderr]    |
[INFO] [stderr] 16 |         let line = line.expect(&format!("Unable to read file ‘{}’", path));
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to read file ‘{}’", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/bin/todiff-merge.rs:17:40
[INFO] [stderr]    |
[INFO] [stderr] 17 |           res.push(Task::from_str(&line).expect(&format!(
[INFO] [stderr]    |  ________________________________________^
[INFO] [stderr] 18 | |             "Unable to parse line in file ‘{}’:\n{}",
[INFO] [stderr] 19 | |             path, line
[INFO] [stderr] 20 | |         )));
[INFO] [stderr]    | |__________^ help: try this: `unwrap_or_else(|_| panic!("Unable to parse line in file ‘{}’:\n{}", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/bin/todiff-merge.rs:68:36
[INFO] [stderr]    |
[INFO] [stderr] 68 |         fs::write(current, output).expect(&format!("Unable to write to file ‘{}’", current));
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to write to file ‘{}’", current))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:23:33
[INFO] [stderr]    |
[INFO] [stderr] 23 |     let file = File::open(path).expect(&format!("Unable to open file ‘{}’", path));
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open file ‘{}’", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:27:25
[INFO] [stderr]    |
[INFO] [stderr] 27 |         let line = line.expect(&format!("Unable to read file ‘{}’", path));
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to read file ‘{}’", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:28:40
[INFO] [stderr]    |
[INFO] [stderr] 28 |           res.push(Task::from_str(&line).expect(&format!(
[INFO] [stderr]    |  ________________________________________^
[INFO] [stderr] 29 | |             "Unable to parse line in file ‘{}’:\n{}",
[INFO] [stderr] 30 | |             path, line
[INFO] [stderr] 31 | |         )));
[INFO] [stderr]    | |__________^ help: try this: `unwrap_or_else(|_| panic!("Unable to parse line in file ‘{}’:\n{}", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:23:33
[INFO] [stderr]    |
[INFO] [stderr] 23 |     let file = File::open(path).expect(&format!("Unable to open file ‘{}’", path));
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open file ‘{}’", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:27:25
[INFO] [stderr]    |
[INFO] [stderr] 27 |         let line = line.expect(&format!("Unable to read file ‘{}’", path));
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to read file ‘{}’", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:28:40
[INFO] [stderr]    |
[INFO] [stderr] 28 |           res.push(Task::from_str(&line).expect(&format!(
[INFO] [stderr]    |  ________________________________________^
[INFO] [stderr] 29 | |             "Unable to parse line in file ‘{}’:\n{}",
[INFO] [stderr] 30 | |             path, line
[INFO] [stderr] 31 | |         )));
[INFO] [stderr]    | |__________^ help: try this: `unwrap_or_else(|_| panic!("Unable to parse line in file ‘{}’:\n{}", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 12.89s
[INFO] running `"docker" "inspect" "7ca45302cf68707c92bfd9df51442a21562b43d43f4813b406462f178bd4a550"`
[INFO] running `"docker" "rm" "-f" "7ca45302cf68707c92bfd9df51442a21562b43d43f4813b406462f178bd4a550"`
[INFO] [stdout] 7ca45302cf68707c92bfd9df51442a21562b43d43f4813b406462f178bd4a550