[INFO] updating cached repository Eirik0/addr_gen
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Eirik0/addr_gen
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Eirik0/addr_gen" "work/ex/clippy-test-run/sources/stable/gh/Eirik0/addr_gen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Eirik0/addr_gen'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Eirik0/addr_gen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Eirik0/addr_gen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Eirik0/addr_gen'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f08f3b0b52b15475a840017ecad6a4a27723ebd1
[INFO] sha for GitHub repo Eirik0/addr_gen: f08f3b0b52b15475a840017ecad6a4a27723ebd1
[INFO] validating manifest of Eirik0/addr_gen on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Eirik0/addr_gen on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Eirik0/addr_gen
[INFO] finished frobbing Eirik0/addr_gen
[INFO] frobbed toml for Eirik0/addr_gen written to work/ex/clippy-test-run/sources/stable/gh/Eirik0/addr_gen/Cargo.toml
[INFO] started frobbing Eirik0/addr_gen
[INFO] finished frobbing Eirik0/addr_gen
[INFO] frobbed toml for Eirik0/addr_gen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Eirik0/addr_gen/Cargo.toml
[INFO] crate Eirik0/addr_gen has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Eirik0/addr_gen against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Eirik0/addr_gen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ca735a2a996de4cc9c8a81b74ad9d31679a5d344cd49e784ad7bb7f1d0517488
[INFO] running `"docker" "start" "-a" "ca735a2a996de4cc9c8a81b74ad9d31679a5d344cd49e784ad7bb7f1d0517488"`
[INFO] [stderr]     Checking addr_gen v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: digit groups should be smaller
[INFO] [stderr]  --> src/secp256k1.rs:6:20
[INFO] [stderr]   |
[INFO] [stderr] 6 | const P_D1: u128 = 0xFFFFFFFF_FFFFFFFF_FFFFFFFE_FFFFFC2F;
[INFO] [stderr]   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFE_FFFF_FC2F`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::large_digit_groups)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
[INFO] [stderr] 
[INFO] [stderr] warning: digit groups should be smaller
[INFO] [stderr]  --> src/secp256k1.rs:7:28
[INFO] [stderr]   |
[INFO] [stderr] 7 | const P_MINUS_2_D1: u128 = 0xFFFFFFFF_FFFFFFFF_FFFFFFFE_FFFFFC2D;
[INFO] [stderr]   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFE_FFFF_FC2D`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
[INFO] [stderr] 
[INFO] [stderr] warning: digit groups should be smaller
[INFO] [stderr]  --> src/secp256k1.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |     d0: 0xFFFFFFFF_FFFFFFFF_FFFFFFFF_FFFFFFFF,
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
[INFO] [stderr] 
[INFO] [stderr] warning: digit groups should be smaller
[INFO] [stderr]   --> src/secp256k1.rs:19:33
[INFO] [stderr]    |
[INFO] [stderr] 19 | const TWO_POW_256_MOD_P: u128 = 0x1_000003D1;
[INFO] [stderr]    |                                 ^^^^^^^^^^^^ help: consider: `0x0001_0000_03D1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/secp256k1.rs:151:23
[INFO] [stderr]     |
[INFO] [stderr] 151 |         while flag != 0x100000000 {
[INFO] [stderr]     |                       ^^^^^^^^^^^ help: consider: `0x0001_0000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/u256.rs:5:29
[INFO] [stderr]   |
[INFO] [stderr] 5 | const MAX_U128_LEFT: u128 = 0xFFFFFFFFFFFFFFFF0000000000000000;
[INFO] [stderr]   |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_0000_0000_0000_0000`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/u256.rs:6:30
[INFO] [stderr]   |
[INFO] [stderr] 6 | const MAX_U128_RIGHT: u128 = 0x0000000000000000FFFFFFFFFFFFFFFF;
[INFO] [stderr]   |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000_FFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/u256.rs:7:30
[INFO] [stderr]   |
[INFO] [stderr] 7 | const FIRST_BIT_FLAG: u128 = 0x80000000000000000000000000000000;
[INFO] [stderr]   |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000_0000_0000_0000_0000`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/u256.rs:17:32
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub const MAX_U128: u128 = 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF;
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: digit groups should be smaller
[INFO] [stderr]  --> src/secp256k1.rs:6:20
[INFO] [stderr]   |
[INFO] [stderr] 6 | const P_D1: u128 = 0xFFFFFFFF_FFFFFFFF_FFFFFFFE_FFFFFC2F;
[INFO] [stderr]   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFE_FFFF_FC2F`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::large_digit_groups)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
[INFO] [stderr] 
[INFO] [stderr] warning: digit groups should be smaller
[INFO] [stderr]  --> src/secp256k1.rs:7:28
[INFO] [stderr]   |
[INFO] [stderr] 7 | const P_MINUS_2_D1: u128 = 0xFFFFFFFF_FFFFFFFF_FFFFFFFE_FFFFFC2D;
[INFO] [stderr]   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFE_FFFF_FC2D`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
[INFO] [stderr] 
[INFO] [stderr] warning: digit groups should be smaller
[INFO] [stderr]  --> src/secp256k1.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |     d0: 0xFFFFFFFF_FFFFFFFF_FFFFFFFF_FFFFFFFF,
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
[INFO] [stderr] 
[INFO] [stderr] warning: digit groups should be smaller
[INFO] [stderr]   --> src/secp256k1.rs:19:33
[INFO] [stderr]    |
[INFO] [stderr] 19 | const TWO_POW_256_MOD_P: u128 = 0x1_000003D1;
[INFO] [stderr]    |                                 ^^^^^^^^^^^^ help: consider: `0x0001_0000_03D1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/secp256k1.rs:151:23
[INFO] [stderr]     |
[INFO] [stderr] 151 |         while flag != 0x100000000 {
[INFO] [stderr]     |                       ^^^^^^^^^^^ help: consider: `0x0001_0000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/secp256k1.rs:304:13
[INFO] [stderr]     |
[INFO] [stderr] 304 |         d0: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: digit groups should be smaller
[INFO] [stderr]    --> src/secp256k1.rs:305:13
[INFO] [stderr]     |
[INFO] [stderr] 305 |         d1: 0xFFFFFFFF_FFFFFFFF_FFFFFFFE_FFFFFC2E,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFE_FFFF_FC2E`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/secp256k1.rs:308:13
[INFO] [stderr]     |
[INFO] [stderr] 308 |         d0: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: digit groups should be smaller
[INFO] [stderr]    --> src/secp256k1.rs:309:13
[INFO] [stderr]     |
[INFO] [stderr] 309 |         d1: 0xFFFFFFFF_FFFFFFFF_FFFFFFFE_FFFFFC2D,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFE_FFFF_FC2D`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/u256.rs:5:29
[INFO] [stderr]   |
[INFO] [stderr] 5 | const MAX_U128_LEFT: u128 = 0xFFFFFFFFFFFFFFFF0000000000000000;
[INFO] [stderr]   |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_0000_0000_0000_0000`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/u256.rs:6:30
[INFO] [stderr]   |
[INFO] [stderr] 6 | const MAX_U128_RIGHT: u128 = 0x0000000000000000FFFFFFFFFFFFFFFF;
[INFO] [stderr]   |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000_FFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/u256.rs:7:30
[INFO] [stderr]   |
[INFO] [stderr] 7 | const FIRST_BIT_FLAG: u128 = 0x80000000000000000000000000000000;
[INFO] [stderr]   |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000_0000_0000_0000_0000`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/u256.rs:17:32
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub const MAX_U128: u128 = 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF;
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/u256.rs:380:13
[INFO] [stderr]     |
[INFO] [stderr] 380 |             0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFE,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFE`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/u256.rs:381:13
[INFO] [stderr]     |
[INFO] [stderr] 381 |             0x00000000000000000000000000000001,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000_0000_0000_0000_0001`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: digit groups should be smaller
[INFO] [stderr]    --> src/u256.rs:435:17
[INFO] [stderr]     |
[INFO] [stderr] 435 |             d0: 0xFFFFFFFF_FFFFFFFF_FFFFFFFF_FFFFFFFF,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
[INFO] [stderr] 
[INFO] [stderr] warning: digit groups should be smaller
[INFO] [stderr]    --> src/u256.rs:436:17
[INFO] [stderr]     |
[INFO] [stderr] 436 |             d1: 0xFFFFFFFF_FFFFFFFF_FFFFFFFE_FFFFFC2F,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF_FFFF_FFFE_FFFF_FC2F`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/u256.rs:28:31
[INFO] [stderr]    |
[INFO] [stderr] 28 |     fn parse_hex_digit(digit: &u8) -> Result<u128, U256ParseError> {
[INFO] [stderr]    |                               ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change
[INFO] [stderr]   --> src/u256.rs:30:40
[INFO] [stderr]    |
[INFO] [stderr] 30 |             nibble @ b'A'...b'F' => Ok((nibble + 10 - b'A') as u128),
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(nibble + 10 - b'A')`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change
[INFO] [stderr]   --> src/u256.rs:31:40
[INFO] [stderr]    |
[INFO] [stderr] 31 |             nibble @ b'a'...b'f' => Ok((nibble + 10 - b'a') as u128),
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(nibble + 10 - b'a')`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change
[INFO] [stderr]   --> src/u256.rs:32:40
[INFO] [stderr]    |
[INFO] [stderr] 32 |             nibble @ b'0'...b'9' => Ok((nibble - b'0') as u128),
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(nibble - b'0')`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `hex_digits`.
[INFO] [stderr]   --> src/u256.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for i in 0..hex_digits.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for <item> in &hex_digits {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `bytes`
[INFO] [stderr]   --> src/u256.rs:87:18
[INFO] [stderr]    |
[INFO] [stderr] 87 |         for i in 0..64 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 87 |         for (i, <item>) in bytes.iter().enumerate().take(64) {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/u256.rs:113:36
[INFO] [stderr]     |
[INFO] [stderr] 113 |     pub fn base64_to_base58(bytes: &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]     |                                    ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/u256.rs:122:26
[INFO] [stderr]     |
[INFO] [stderr] 122 |                     n += (bytes[i_64] as u32) << shift;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[i_64])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `base58_digits`.
[INFO] [stderr]    --> src/u256.rs:149:18
[INFO] [stderr]     |
[INFO] [stderr] 149 |         for i in 0..base58_digits.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 149 |         for <item> in &mut base58_digits {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/u256.rs:28:31
[INFO] [stderr]    |
[INFO] [stderr] 28 |     fn parse_hex_digit(digit: &u8) -> Result<u128, U256ParseError> {
[INFO] [stderr]    |                               ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change
[INFO] [stderr]   --> src/u256.rs:30:40
[INFO] [stderr]    |
[INFO] [stderr] 30 |             nibble @ b'A'...b'F' => Ok((nibble + 10 - b'A') as u128),
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(nibble + 10 - b'A')`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change
[INFO] [stderr]   --> src/u256.rs:31:40
[INFO] [stderr]    |
[INFO] [stderr] 31 |             nibble @ b'a'...b'f' => Ok((nibble + 10 - b'a') as u128),
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(nibble + 10 - b'a')`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change
[INFO] [stderr]   --> src/u256.rs:32:40
[INFO] [stderr]    |
[INFO] [stderr] 32 |             nibble @ b'0'...b'9' => Ok((nibble - b'0') as u128),
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(nibble - b'0')`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `hex_digits`.
[INFO] [stderr]   --> src/u256.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for i in 0..hex_digits.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for <item> in &hex_digits {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `bytes`
[INFO] [stderr]   --> src/u256.rs:87:18
[INFO] [stderr]    |
[INFO] [stderr] 87 |         for i in 0..64 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 87 |         for (i, <item>) in bytes.iter().enumerate().take(64) {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/u256.rs:113:36
[INFO] [stderr]     |
[INFO] [stderr] 113 |     pub fn base64_to_base58(bytes: &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]     |                                    ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/u256.rs:122:26
[INFO] [stderr]     |
[INFO] [stderr] 122 |                     n += (bytes[i_64] as u32) << shift;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[i_64])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `base58_digits`.
[INFO] [stderr]    --> src/u256.rs:149:18
[INFO] [stderr]     |
[INFO] [stderr] 149 |         for i in 0..base58_digits.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 149 |         for <item> in &mut base58_digits {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.39s
[INFO] running `"docker" "inspect" "ca735a2a996de4cc9c8a81b74ad9d31679a5d344cd49e784ad7bb7f1d0517488"`
[INFO] running `"docker" "rm" "-f" "ca735a2a996de4cc9c8a81b74ad9d31679a5d344cd49e784ad7bb7f1d0517488"`
[INFO] [stdout] ca735a2a996de4cc9c8a81b74ad9d31679a5d344cd49e784ad7bb7f1d0517488