[INFO] updating cached repository Ecnavda/exes_and_ohs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ecnavda/exes_and_ohs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ecnavda/exes_and_ohs" "work/ex/clippy-test-run/sources/stable/gh/Ecnavda/exes_and_ohs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ecnavda/exes_and_ohs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ecnavda/exes_and_ohs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ecnavda/exes_and_ohs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ecnavda/exes_and_ohs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dc485a10152d1875418bd2e3c2d88e6dd72141d5 [INFO] sha for GitHub repo Ecnavda/exes_and_ohs: dc485a10152d1875418bd2e3c2d88e6dd72141d5 [INFO] validating manifest of Ecnavda/exes_and_ohs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ecnavda/exes_and_ohs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ecnavda/exes_and_ohs [INFO] finished frobbing Ecnavda/exes_and_ohs [INFO] frobbed toml for Ecnavda/exes_and_ohs written to work/ex/clippy-test-run/sources/stable/gh/Ecnavda/exes_and_ohs/Cargo.toml [INFO] started frobbing Ecnavda/exes_and_ohs [INFO] finished frobbing Ecnavda/exes_and_ohs [INFO] frobbed toml for Ecnavda/exes_and_ohs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ecnavda/exes_and_ohs/Cargo.toml [INFO] crate Ecnavda/exes_and_ohs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ecnavda/exes_and_ohs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Ecnavda/exes_and_ohs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb8a8bd325328708d5208caa8b98b891d63c115e0ec7381e8dc2a251296d8426 [INFO] running `"docker" "start" "-a" "eb8a8bd325328708d5208caa8b98b891d63c115e0ec7381e8dc2a251296d8426"` [INFO] [stderr] Checking exes_and_ohs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable `Xs` should have a snake case name such as `xs` [INFO] [stderr] --> src/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let mut Xs = 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `Os` should have a snake case name such as `os` [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let mut Os = 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | 'x' | 'X' => Xs = Xs + 1, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `Xs += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | 'o' | 'O' => Os = Os + 1, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `Os += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / if Xs == Os { [INFO] [stderr] 35 | | return true; [INFO] [stderr] 36 | | } else { [INFO] [stderr] 37 | | return false; [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return Xs == Os` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable `Xs` should have a snake case name such as `xs` [INFO] [stderr] --> src/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let mut Xs = 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `Os` should have a snake case name such as `os` [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let mut Os = 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | 'x' | 'X' => Xs = Xs + 1, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `Xs += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | 'o' | 'O' => Os = Os + 1, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `Os += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / if Xs == Os { [INFO] [stderr] 35 | | return true; [INFO] [stderr] 36 | | } else { [INFO] [stderr] 37 | | return false; [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return Xs == Os` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.15s [INFO] running `"docker" "inspect" "eb8a8bd325328708d5208caa8b98b891d63c115e0ec7381e8dc2a251296d8426"` [INFO] running `"docker" "rm" "-f" "eb8a8bd325328708d5208caa8b98b891d63c115e0ec7381e8dc2a251296d8426"` [INFO] [stdout] eb8a8bd325328708d5208caa8b98b891d63c115e0ec7381e8dc2a251296d8426