[INFO] updating cached repository ELD/advent-of-code-2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ELD/advent-of-code-2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ELD/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/ELD/advent-of-code-2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ELD/advent-of-code-2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ELD/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ELD/advent-of-code-2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ELD/advent-of-code-2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5e3640592e7e1b572e265edd6eea343914613435
[INFO] sha for GitHub repo ELD/advent-of-code-2018: 5e3640592e7e1b572e265edd6eea343914613435
[INFO] validating manifest of ELD/advent-of-code-2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ELD/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ELD/advent-of-code-2018
[INFO] finished frobbing ELD/advent-of-code-2018
[INFO] frobbed toml for ELD/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/ELD/advent-of-code-2018/Cargo.toml
[INFO] started frobbing ELD/advent-of-code-2018
[INFO] finished frobbing ELD/advent-of-code-2018
[INFO] frobbed toml for ELD/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ELD/advent-of-code-2018/Cargo.toml
[INFO] crate ELD/advent-of-code-2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ELD/advent-of-code-2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ELD/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d366bdd711b0aecb83bc4499d4cdf86dc790dcf5d13b475798052be35be03b08
[INFO] running `"docker" "start" "-a" "d366bdd711b0aecb83bc4499d4cdf86dc790dcf5d13b475798052be35be03b08"`
[INFO] [stderr]     Checking advent-of-code-2018 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]  --> src/day1.rs:6:25
[INFO] [stderr]   |
[INFO] [stderr] 6 |     parse_input().iter().fold(0, |acc, x| acc + x)
[INFO] [stderr]   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/day1.rs:30:17
[INFO] [stderr]    |
[INFO] [stderr] 30 |     input.split("\n").map(|x| x.parse::<i32>().unwrap()).collect::<Vec<i32>>()
[INFO] [stderr]    |                 ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/day2.rs:49:17
[INFO] [stderr]    |
[INFO] [stderr] 49 |     input.split("\n").map(|s| s.to_string()).collect::<Vec<String>>()
[INFO] [stderr]    |                 ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day3.rs:96:23
[INFO] [stderr]    |
[INFO] [stderr] 96 | fn setup_grid(claims: &Vec<Claim>) -> Grid {
[INFO] [stderr]    |                       ^^^^^^^^^^^ help: change this to: `&[Claim]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `logs`.
[INFO] [stderr]   --> src/day4.rs:94:26
[INFO] [stderr]    |
[INFO] [stderr] 94 |                 for j in i + 1..logs.len() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 94 |                 for <item> in logs.iter().skip(i + 1) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/day4.rs:96:32
[INFO] [stderr]    |
[INFO] [stderr] 96 |                           if let Some(_) = caps.name("guard_id") {
[INFO] [stderr]    |  _________________________-      ^^^^^^^
[INFO] [stderr] 97 | |                             break;
[INFO] [stderr] 98 | |                         }
[INFO] [stderr]    | |_________________________- help: try this: `if caps.name("guard_id").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/day4.rs:120:14
[INFO] [stderr]     |
[INFO] [stderr] 120 |             .or_insert(Vec::new());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/day4.rs:130:12
[INFO] [stderr]     |
[INFO] [stderr] 130 |         if log.1.len() < 1 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `log.1.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]  --> src/day1.rs:6:25
[INFO] [stderr]   |
[INFO] [stderr] 6 |     parse_input().iter().fold(0, |acc, x| acc + x)
[INFO] [stderr]   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/day1.rs:30:17
[INFO] [stderr]    |
[INFO] [stderr] 30 |     input.split("\n").map(|x| x.parse::<i32>().unwrap()).collect::<Vec<i32>>()
[INFO] [stderr]    |                 ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/day2.rs:49:17
[INFO] [stderr]    |
[INFO] [stderr] 49 |     input.split("\n").map(|s| s.to_string()).collect::<Vec<String>>()
[INFO] [stderr]    |                 ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day3.rs:96:23
[INFO] [stderr]    |
[INFO] [stderr] 96 | fn setup_grid(claims: &Vec<Claim>) -> Grid {
[INFO] [stderr]    |                       ^^^^^^^^^^^ help: change this to: `&[Claim]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `logs`.
[INFO] [stderr]   --> src/day4.rs:94:26
[INFO] [stderr]    |
[INFO] [stderr] 94 |                 for j in i + 1..logs.len() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 94 |                 for <item> in logs.iter().skip(i + 1) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/day4.rs:96:32
[INFO] [stderr]    |
[INFO] [stderr] 96 |                           if let Some(_) = caps.name("guard_id") {
[INFO] [stderr]    |  _________________________-      ^^^^^^^
[INFO] [stderr] 97 | |                             break;
[INFO] [stderr] 98 | |                         }
[INFO] [stderr]    | |_________________________- help: try this: `if caps.name("guard_id").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/day4.rs:120:14
[INFO] [stderr]     |
[INFO] [stderr] 120 |             .or_insert(Vec::new());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/day4.rs:130:12
[INFO] [stderr]     |
[INFO] [stderr] 130 |         if log.1.len() < 1 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `log.1.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.36s
[INFO] running `"docker" "inspect" "d366bdd711b0aecb83bc4499d4cdf86dc790dcf5d13b475798052be35be03b08"`
[INFO] running `"docker" "rm" "-f" "d366bdd711b0aecb83bc4499d4cdf86dc790dcf5d13b475798052be35be03b08"`
[INFO] [stdout] d366bdd711b0aecb83bc4499d4cdf86dc790dcf5d13b475798052be35be03b08