[INFO] updating cached repository ELCHILEN0/memcached [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ELCHILEN0/memcached [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ELCHILEN0/memcached" "work/ex/clippy-test-run/sources/stable/gh/ELCHILEN0/memcached"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ELCHILEN0/memcached'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ELCHILEN0/memcached" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ELCHILEN0/memcached"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ELCHILEN0/memcached'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f0291bdddd050b2cb46014e1364a435f48ed7c50 [INFO] sha for GitHub repo ELCHILEN0/memcached: f0291bdddd050b2cb46014e1364a435f48ed7c50 [INFO] validating manifest of ELCHILEN0/memcached on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ELCHILEN0/memcached on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ELCHILEN0/memcached [INFO] finished frobbing ELCHILEN0/memcached [INFO] frobbed toml for ELCHILEN0/memcached written to work/ex/clippy-test-run/sources/stable/gh/ELCHILEN0/memcached/Cargo.toml [INFO] started frobbing ELCHILEN0/memcached [INFO] finished frobbing ELCHILEN0/memcached [INFO] frobbed toml for ELCHILEN0/memcached written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ELCHILEN0/memcached/Cargo.toml [INFO] crate ELCHILEN0/memcached has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ELCHILEN0/memcached against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ELCHILEN0/memcached:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3bd04435b2fb25e8ee269c7bc9f1db24167001c01565dc03445433b6c9a20995 [INFO] running `"docker" "start" "-a" "3bd04435b2fb25e8ee269c7bc9f1db24167001c01565dc03445433b6c9a20995"` [INFO] [stderr] Checking memcached v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/cache.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | capacity: capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/cache.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | storage_structure: storage_structure, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `storage_structure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/cache.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | replacement_policy: replacement_policy, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `replacement_policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/key.rs:9:15 [INFO] [stderr] | [INFO] [stderr] 9 | Key { item: item } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/value.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/data_entry.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/data_entry.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/cache.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | capacity: capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/cache.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | storage_structure: storage_structure, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `storage_structure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/cache.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | replacement_policy: replacement_policy, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `replacement_policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/key.rs:9:15 [INFO] [stderr] | [INFO] [stderr] 9 | Key { item: item } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/value.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/data_entry.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/data_entry.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `packet::MemPacket` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use packet::MemPacket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet.rs:142:32 [INFO] [stderr] | [INFO] [stderr] 142 | total_body_length: 0x00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | opaque: 0x00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet.rs:144:18 [INFO] [stderr] | [INFO] [stderr] 144 | cas: 0x0000000000000000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Clock`, `LRU` [INFO] [stderr] --> src/main.rs:12:57 [INFO] [stderr] | [INFO] [stderr] 12 | use cache::replacement_policy::{CacheReplacementPolicy, LRU, Clock, LFU}; [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cache/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod cache; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/commands/set.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | response.header.with_cas(0x0000000000000001); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `packet::MemPacket` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use packet::MemPacket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet.rs:142:32 [INFO] [stderr] | [INFO] [stderr] 142 | total_body_length: 0x00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | opaque: 0x00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet.rs:144:18 [INFO] [stderr] | [INFO] [stderr] 144 | cas: 0x0000000000000000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Clock`, `LRU` [INFO] [stderr] --> src/main.rs:12:57 [INFO] [stderr] | [INFO] [stderr] 12 | use cache::replacement_policy::{CacheReplacementPolicy, LRU, Clock, LFU}; [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cache/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod cache; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/commands/set.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | response.header.with_cas(0x0000000000000001); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/commands/set.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(val) => { [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `index` [INFO] [stderr] --> src/cache/storage_structure.rs:95:29 [INFO] [stderr] | [INFO] [stderr] 95 | fn set_index(&mut self, index: usize, entry: DataEntry) -> (usize, Option) { [INFO] [stderr] | ^^^^^ help: consider using `_index` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `entry` [INFO] [stderr] --> src/cache/storage_structure.rs:95:43 [INFO] [stderr] | [INFO] [stderr] 95 | fn set_index(&mut self, index: usize, entry: DataEntry) -> (usize, Option) { [INFO] [stderr] | ^^^^^ help: consider using `_entry` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/command.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let mut extra_bytes: Vec = Vec::new(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_bytes` [INFO] [stderr] --> src/packet.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn from_bytes(bytes: &[u8]) -> MemPacket { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `has_key` [INFO] [stderr] --> src/packet.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn has_key(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `inc_cas` [INFO] [stderr] --> src/cache/value.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn inc_cas(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `KeyNotFound` [INFO] [stderr] --> src/cache/error.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | KeyNotFound, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | k_len = ((bytes[2] as u16) << 8) + ((bytes[2] as u16) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bytes[2] as u16)` [INFO] [stderr] --> src/packet.rs:17:44 [INFO] [stderr] | [INFO] [stderr] 17 | k_len = ((bytes[2] as u16) << 8) + ((bytes[2] as u16) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:17:45 [INFO] [stderr] | [INFO] [stderr] 17 | k_len = ((bytes[2] as u16) << 8) + ((bytes[2] as u16) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | v_len = ((bytes[8] as u32) << 24) + ((bytes[9] as u32) << 16) + ((bytes[10] as u32) << 8) + ((bytes[0] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:18:46 [INFO] [stderr] | [INFO] [stderr] 18 | v_len = ((bytes[8] as u32) << 24) + ((bytes[9] as u32) << 16) + ((bytes[10] as u32) << 8) + ((bytes[0] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:18:74 [INFO] [stderr] | [INFO] [stderr] 18 | v_len = ((bytes[8] as u32) << 24) + ((bytes[9] as u32) << 16) + ((bytes[10] as u32) << 8) + ((bytes[0] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[10])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bytes[0] as u32)` [INFO] [stderr] --> src/packet.rs:18:101 [INFO] [stderr] | [INFO] [stderr] 18 | v_len = ((bytes[8] as u32) << 24) + ((bytes[9] as u32) << 16) + ((bytes[10] as u32) << 8) + ((bytes[0] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:18:102 [INFO] [stderr] | [INFO] [stderr] 18 | v_len = ((bytes[8] as u32) << 24) + ((bytes[9] as u32) << 16) + ((bytes[10] as u32) << 8) + ((bytes[0] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:38:26 [INFO] [stderr] | [INFO] [stderr] 38 | status: ((bytes[6] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bytes[7] as u16)` [INFO] [stderr] --> src/packet.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | + ((bytes[7] as u16) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:39:28 [INFO] [stderr] | [INFO] [stderr] 39 | + ((bytes[7] as u16) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | opaque: ((bytes[12] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[12])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | + ((bytes[13] as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[13])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | + ((bytes[14] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[14])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bytes[15] as u32)` [INFO] [stderr] --> src/packet.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | + ((bytes[15] as u32) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | + ((bytes[15] as u32) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[15])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | cas: ((bytes[16] as u64) << 56) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | + ((bytes[17] as u64) << 48) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[17])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | + ((bytes[17] as u64) << 40) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[17])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | + ((bytes[19] as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[19])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | + ((bytes[20] as u64) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[20])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:50:28 [INFO] [stderr] | [INFO] [stderr] 50 | + ((bytes[21] as u64) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[21])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | + ((bytes[22] as u64) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[22])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bytes[23] as u64)` [INFO] [stderr] --> src/packet.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | + ((bytes[23] as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | + ((bytes[23] as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[23])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/commands/set.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(val) => { [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `index` [INFO] [stderr] --> src/cache/storage_structure.rs:95:29 [INFO] [stderr] | [INFO] [stderr] 95 | fn set_index(&mut self, index: usize, entry: DataEntry) -> (usize, Option) { [INFO] [stderr] | ^^^^^ help: consider using `_index` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `entry` [INFO] [stderr] --> src/cache/storage_structure.rs:95:43 [INFO] [stderr] | [INFO] [stderr] 95 | fn set_index(&mut self, index: usize, entry: DataEntry) -> (usize, Option) { [INFO] [stderr] | ^^^^^ help: consider using `_entry` instead [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/packet.rs:88:39 [INFO] [stderr] | [INFO] [stderr] 88 | self.header.key_length > 0 && self.key.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.key.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/packet.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | self.header.extras_length > 0 && self.extras.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.extras.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:96:41 [INFO] [stderr] | [INFO] [stderr] 96 | self.header.total_body_length - self.header.key_length as u32 - self.header.extras_length as u32 > 0 && self.value.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.header.key_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:96:73 [INFO] [stderr] | [INFO] [stderr] 96 | self.header.total_body_length - self.header.key_length as u32 - self.header.extras_length as u32 > 0 && self.value.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.header.extras_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/packet.rs:96:113 [INFO] [stderr] | [INFO] [stderr] 96 | self.header.total_body_length - self.header.key_length as u32 - self.header.extras_length as u32 > 0 && self.value.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:169:49 [INFO] [stderr] | [INFO] [stderr] 169 | self.total_body_length = value_length + (self.key_length as u32) + (self.extras_length as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.key_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:169:76 [INFO] [stderr] | [INFO] [stderr] 169 | self.total_body_length = value_length + (self.key_length as u32) + (self.extras_length as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.extras_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.key_length` [INFO] [stderr] --> src/packet.rs:185:19 [INFO] [stderr] | [INFO] [stderr] 185 | out.push(((self.key_length >> 0) & 0xFF) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.status` [INFO] [stderr] --> src/packet.rs:190:19 [INFO] [stderr] | [INFO] [stderr] 190 | out.push(((self.status >> 0) & 0xFF) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.total_body_length` [INFO] [stderr] --> src/packet.rs:195:19 [INFO] [stderr] | [INFO] [stderr] 195 | out.push(((self.total_body_length >> 0) & 0xFF) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.opaque` [INFO] [stderr] --> src/packet.rs:200:19 [INFO] [stderr] | [INFO] [stderr] 200 | out.push(((self.opaque >> 0) & 0xFF) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.cas` [INFO] [stderr] --> src/packet.rs:209:19 [INFO] [stderr] | [INFO] [stderr] 209 | out.push(((self.cas >> 0) & 0xFF) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in self.data.clone().into_iter().enumerate()` or similar iterators [INFO] [stderr] --> src/cache/storage_structure.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | for entry in self.data.clone().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/cache/storage_structure.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / match self.get(key) { [INFO] [stderr] 114 | | Some(_) => true, [INFO] [stderr] 115 | | None => false [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ help: try this: `self.get(key).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cache/replacement_policy.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | if self.referenced_list.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.referenced_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cache/replacement_policy.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | self.frequency_list[index] = self.frequency_list[index] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.frequency_list[index] += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cache/replacement_policy.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | if self.frequency_list.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.frequency_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/command.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let mut extra_bytes: Vec = Vec::new(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in self.frequency_list.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/cache/replacement_policy.rs:133:26 [INFO] [stderr] | [INFO] [stderr] 133 | for frequency in self.frequency_list.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_bytes` [INFO] [stderr] --> src/packet.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn from_bytes(bytes: &[u8]) -> MemPacket { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `has_key` [INFO] [stderr] --> src/packet.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn has_key(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `inc_cas` [INFO] [stderr] --> src/cache/value.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn inc_cas(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `KeyNotFound` [INFO] [stderr] --> src/cache/error.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | KeyNotFound, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | k_len = ((bytes[2] as u16) << 8) + ((bytes[2] as u16) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bytes[2] as u16)` [INFO] [stderr] --> src/packet.rs:17:44 [INFO] [stderr] | [INFO] [stderr] 17 | k_len = ((bytes[2] as u16) << 8) + ((bytes[2] as u16) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:17:45 [INFO] [stderr] | [INFO] [stderr] 17 | k_len = ((bytes[2] as u16) << 8) + ((bytes[2] as u16) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | v_len = ((bytes[8] as u32) << 24) + ((bytes[9] as u32) << 16) + ((bytes[10] as u32) << 8) + ((bytes[0] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:18:46 [INFO] [stderr] | [INFO] [stderr] 18 | v_len = ((bytes[8] as u32) << 24) + ((bytes[9] as u32) << 16) + ((bytes[10] as u32) << 8) + ((bytes[0] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:18:74 [INFO] [stderr] | [INFO] [stderr] 18 | v_len = ((bytes[8] as u32) << 24) + ((bytes[9] as u32) << 16) + ((bytes[10] as u32) << 8) + ((bytes[0] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[10])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bytes[0] as u32)` [INFO] [stderr] --> src/packet.rs:18:101 [INFO] [stderr] | [INFO] [stderr] 18 | v_len = ((bytes[8] as u32) << 24) + ((bytes[9] as u32) << 16) + ((bytes[10] as u32) << 8) + ((bytes[0] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:18:102 [INFO] [stderr] | [INFO] [stderr] 18 | v_len = ((bytes[8] as u32) << 24) + ((bytes[9] as u32) << 16) + ((bytes[10] as u32) << 8) + ((bytes[0] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:38:26 [INFO] [stderr] | [INFO] [stderr] 38 | status: ((bytes[6] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bytes[7] as u16)` [INFO] [stderr] --> src/packet.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | + ((bytes[7] as u16) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:39:28 [INFO] [stderr] | [INFO] [stderr] 39 | + ((bytes[7] as u16) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | opaque: ((bytes[12] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[12])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | + ((bytes[13] as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[13])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | + ((bytes[14] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[14])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bytes[15] as u32)` [INFO] [stderr] --> src/packet.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | + ((bytes[15] as u32) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | + ((bytes[15] as u32) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[15])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | cas: ((bytes[16] as u64) << 56) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | + ((bytes[17] as u64) << 48) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[17])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | + ((bytes[17] as u64) << 40) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[17])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | + ((bytes[19] as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[19])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | + ((bytes[20] as u64) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[20])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:50:28 [INFO] [stderr] | [INFO] [stderr] 50 | + ((bytes[21] as u64) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[21])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | + ((bytes[22] as u64) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[22])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bytes[23] as u64)` [INFO] [stderr] --> src/packet.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | + ((bytes[23] as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | + ((bytes[23] as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[23])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/packet.rs:88:39 [INFO] [stderr] | [INFO] [stderr] 88 | self.header.key_length > 0 && self.key.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.key.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/packet.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | self.header.extras_length > 0 && self.extras.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.extras.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:96:41 [INFO] [stderr] | [INFO] [stderr] 96 | self.header.total_body_length - self.header.key_length as u32 - self.header.extras_length as u32 > 0 && self.value.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.header.key_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:96:73 [INFO] [stderr] | [INFO] [stderr] 96 | self.header.total_body_length - self.header.key_length as u32 - self.header.extras_length as u32 > 0 && self.value.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.header.extras_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/packet.rs:96:113 [INFO] [stderr] | [INFO] [stderr] 96 | self.header.total_body_length - self.header.key_length as u32 - self.header.extras_length as u32 > 0 && self.value.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match command::parse_command(string, &mut cache) { [INFO] [stderr] 32 | | Some(response) => { [INFO] [stderr] 33 | | println!("{:?}", response.header); [INFO] [stderr] 34 | | println!("{:?}", response); [INFO] [stderr] ... | [INFO] [stderr] 40 | | None => {}, [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | if let Some(response) = command::parse_command(string, &mut cache) { [INFO] [stderr] 32 | println!("{:?}", response.header); [INFO] [stderr] 33 | println!("{:?}", response); [INFO] [stderr] 34 | [INFO] [stderr] 35 | let _ = stream.write(response.bytes().as_slice()); [INFO] [stderr] 36 | let _ = stream.write(b"\r\n"); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:169:49 [INFO] [stderr] | [INFO] [stderr] 169 | self.total_body_length = value_length + (self.key_length as u32) + (self.extras_length as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.key_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:169:76 [INFO] [stderr] | [INFO] [stderr] 169 | self.total_body_length = value_length + (self.key_length as u32) + (self.extras_length as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.extras_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.key_length` [INFO] [stderr] --> src/packet.rs:185:19 [INFO] [stderr] | [INFO] [stderr] 185 | out.push(((self.key_length >> 0) & 0xFF) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.status` [INFO] [stderr] --> src/packet.rs:190:19 [INFO] [stderr] | [INFO] [stderr] 190 | out.push(((self.status >> 0) & 0xFF) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.total_body_length` [INFO] [stderr] --> src/packet.rs:195:19 [INFO] [stderr] | [INFO] [stderr] 195 | out.push(((self.total_body_length >> 0) & 0xFF) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.opaque` [INFO] [stderr] --> src/packet.rs:200:19 [INFO] [stderr] | [INFO] [stderr] 200 | out.push(((self.opaque >> 0) & 0xFF) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.cas` [INFO] [stderr] --> src/packet.rs:209:19 [INFO] [stderr] | [INFO] [stderr] 209 | out.push(((self.cas >> 0) & 0xFF) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in self.data.clone().into_iter().enumerate()` or similar iterators [INFO] [stderr] --> src/cache/storage_structure.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | for entry in self.data.clone().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/cache/storage_structure.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / match self.get(key) { [INFO] [stderr] 114 | | Some(_) => true, [INFO] [stderr] 115 | | None => false [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ help: try this: `self.get(key).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cache/replacement_policy.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | if self.referenced_list.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.referenced_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cache/replacement_policy.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | self.frequency_list[index] = self.frequency_list[index] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.frequency_list[index] += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cache/replacement_policy.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | if self.frequency_list.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.frequency_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in self.frequency_list.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/cache/replacement_policy.rs:133:26 [INFO] [stderr] | [INFO] [stderr] 133 | for frequency in self.frequency_list.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match command::parse_command(string, &mut cache) { [INFO] [stderr] 32 | | Some(response) => { [INFO] [stderr] 33 | | println!("{:?}", response.header); [INFO] [stderr] 34 | | println!("{:?}", response); [INFO] [stderr] ... | [INFO] [stderr] 40 | | None => {}, [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | if let Some(response) = command::parse_command(string, &mut cache) { [INFO] [stderr] 32 | println!("{:?}", response.header); [INFO] [stderr] 33 | println!("{:?}", response); [INFO] [stderr] 34 | [INFO] [stderr] 35 | let _ = stream.write(response.bytes().as_slice()); [INFO] [stderr] 36 | let _ = stream.write(b"\r\n"); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.28s [INFO] running `"docker" "inspect" "3bd04435b2fb25e8ee269c7bc9f1db24167001c01565dc03445433b6c9a20995"` [INFO] running `"docker" "rm" "-f" "3bd04435b2fb25e8ee269c7bc9f1db24167001c01565dc03445433b6c9a20995"` [INFO] [stdout] 3bd04435b2fb25e8ee269c7bc9f1db24167001c01565dc03445433b6c9a20995