[INFO] updating cached repository EFulmer/aoc-2017-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/EFulmer/aoc-2017-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/EFulmer/aoc-2017-rust" "work/ex/clippy-test-run/sources/stable/gh/EFulmer/aoc-2017-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/EFulmer/aoc-2017-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/EFulmer/aoc-2017-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EFulmer/aoc-2017-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EFulmer/aoc-2017-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 38dfc0b58851fb1f5258773bd1f887216ce46b71 [INFO] sha for GitHub repo EFulmer/aoc-2017-rust: 38dfc0b58851fb1f5258773bd1f887216ce46b71 [INFO] validating manifest of EFulmer/aoc-2017-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of EFulmer/aoc-2017-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing EFulmer/aoc-2017-rust [INFO] finished frobbing EFulmer/aoc-2017-rust [INFO] frobbed toml for EFulmer/aoc-2017-rust written to work/ex/clippy-test-run/sources/stable/gh/EFulmer/aoc-2017-rust/Cargo.toml [INFO] started frobbing EFulmer/aoc-2017-rust [INFO] finished frobbing EFulmer/aoc-2017-rust [INFO] frobbed toml for EFulmer/aoc-2017-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EFulmer/aoc-2017-rust/Cargo.toml [INFO] crate EFulmer/aoc-2017-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting EFulmer/aoc-2017-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/EFulmer/aoc-2017-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d420e3983f54bb315686cc6389f1c6b669f02dfe248823763614296c0b45352d [INFO] running `"docker" "start" "-a" "d420e3983f54bb315686cc6389f1c6b669f02dfe248823763614296c0b45352d"` [INFO] [stderr] Checking advent-of-code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `passphrases` [INFO] [stderr] --> src/main.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | let passphrases = text.lines(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_passphrases` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `unique_count` is never read [INFO] [stderr] --> src/main.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut unique_count = 0; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `passphrases` [INFO] [stderr] --> src/main.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | let passphrases = text.lines(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_passphrases` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `unique_count` is never read [INFO] [stderr] --> src/main.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut unique_count = 0; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | let rest = numbers.get(1..).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `numbers[1..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | let (first, last) = numbers.get(1..).unwrap().split_at(numbers.get(1..).unwrap().len() / 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `numbers[1..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:35:60 [INFO] [stderr] | [INFO] [stderr] 35 | let (first, last) = numbers.get(1..).unwrap().split_at(numbers.get(1..).unwrap().len() / 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `numbers[1..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:83:26 [INFO] [stderr] | [INFO] [stderr] 83 | fn all_pairs(v: &Vec) -> Vec<(T, T)> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | fn day_4_helper(input: &String, check_anagrams: bool) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | let rest = numbers.get(1..).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `numbers[1..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | let (first, last) = numbers.get(1..).unwrap().split_at(numbers.get(1..).unwrap().len() / 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `numbers[1..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:35:60 [INFO] [stderr] | [INFO] [stderr] 35 | let (first, last) = numbers.get(1..).unwrap().split_at(numbers.get(1..).unwrap().len() / 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `numbers[1..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:83:26 [INFO] [stderr] | [INFO] [stderr] 83 | fn all_pairs(v: &Vec) -> Vec<(T, T)> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | fn day_4_helper(input: &String, check_anagrams: bool) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.70s [INFO] running `"docker" "inspect" "d420e3983f54bb315686cc6389f1c6b669f02dfe248823763614296c0b45352d"` [INFO] running `"docker" "rm" "-f" "d420e3983f54bb315686cc6389f1c6b669f02dfe248823763614296c0b45352d"` [INFO] [stdout] d420e3983f54bb315686cc6389f1c6b669f02dfe248823763614296c0b45352d