[INFO] updating cached repository Dynisious/the_brass [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Dynisious/the_brass [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Dynisious/the_brass" "work/ex/clippy-test-run/sources/stable/gh/Dynisious/the_brass"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Dynisious/the_brass'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Dynisious/the_brass" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dynisious/the_brass"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dynisious/the_brass'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ff007fe968cb18722aac7a391fc22b1098ab699b [INFO] sha for GitHub repo Dynisious/the_brass: ff007fe968cb18722aac7a391fc22b1098ab699b [INFO] validating manifest of Dynisious/the_brass on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Dynisious/the_brass on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Dynisious/the_brass [INFO] finished frobbing Dynisious/the_brass [INFO] frobbed toml for Dynisious/the_brass written to work/ex/clippy-test-run/sources/stable/gh/Dynisious/the_brass/Cargo.toml [INFO] started frobbing Dynisious/the_brass [INFO] finished frobbing Dynisious/the_brass [INFO] frobbed toml for Dynisious/the_brass written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dynisious/the_brass/Cargo.toml [INFO] crate Dynisious/the_brass has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Dynisious/the_brass against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Dynisious/the_brass:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 308e2878ec3c59aa888929ee5540bcbd14e23d38ac9d5b299588bb529adc3269 [INFO] running `"docker" "start" "-a" "308e2878ec3c59aa888929ee5540bcbd14e23d38ac9d5b299588bb529adc3269"` [INFO] [stderr] Checking the_brass v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FuelError` [INFO] [stderr] --> src/game/combat/ships/ship_error.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | FuelError, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ShieldError` [INFO] [stderr] --> src/game/combat/ships/ship_error.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | ShieldError, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `HullError` [INFO] [stderr] --> src/game/combat/ships/ship_error.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | HullError [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn new(attack: Attack, smallest_target: ShipSize) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `valid_target` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn valid_target(&self, target_size: ShipSize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `same_target` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn same_target(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn new(parralel_attacks: UInt, damage_per_attack: DamagePoint) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `merge` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn merge(&mut self, other: Self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sum_damage` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn sum_damage(&self) -> DamagePoint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `same_damage` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn same_damage(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_parts` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | pub unsafe fn from_parts(attacks: Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn new(mut attacks: Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_attack` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | pub fn add_attack(&mut self, attack: TargetedAttack) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_attacks` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:196:5 [INFO] [stderr] | [INFO] [stderr] 196 | pub fn add_attacks(&mut self, attacks: &[TargetedAttack]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | pub fn iter(&self) -> ::std::slice::Iter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter_mut` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | pub fn iter_mut(&mut self) -> ::std::slice::IterMut { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear_used_attacks` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn clear_used_attacks(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_parts` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub unsafe fn from_parts(ship_size_class: ShipSize, fuel_capacity: UInt, [INFO] [stderr] 58 | | fuel_use: UInt, max_hull: UInt, shield_capacity: UInt, shield_recovery: UInt, [INFO] [stderr] 59 | | cargo_capacity: Mass, attacks: ReducedAttacks) -> Self { [INFO] [stderr] 60 | | Self { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / pub fn new(ship_size_class: ShipSize, fuel_capacity: UInt, fuel_use: UInt, [INFO] [stderr] 82 | | hull_points: UInt, shield_points: UInt, shield_recovery: UInt, [INFO] [stderr] 83 | | cargo_capacity: Mass, attacks: ReducedAttacks) -> Result { [INFO] [stderr] 84 | | //Check that fuel use is not greater than fuel capacity. [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_fuel_capacity` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn set_fuel_capacity(&mut self, val: FuelUnit) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_fuel_use` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn get_fuel_use(&self) -> FuelUnit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_fuel_use` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn set_fuel_use(&mut self, val: FuelUnit) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_shield_capacity` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn set_shield_capacity(&mut self, val: ShieldPoint) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_shield_recovery` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | pub fn get_shield_recovery(&self) -> ShieldPoint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_shield_recovery` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | pub fn set_shield_recovery(&mut self, val: ShieldPoint) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `can_target` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | pub fn can_target(&self, target: &Self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `loaded` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn loaded(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `unload_overflow` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | pub fn unload_overflow(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `unload` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | pub fn unload(&mut self, name: &String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game/combat/ships/ship.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new(template: Rc, fuel_units: FuelUnit, [INFO] [stderr] 55 | | hull_points: HullPoint, shield_points: ShieldPoint) -> Result { [INFO] [stderr] 56 | | //Check that fuel is not greater than fuel capacity. [INFO] [stderr] 57 | | if fuel_units > template.get_fuel_capacity() { [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_template` [INFO] [stderr] --> src/game/combat/ships/ship.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn set_template(&mut self, val: Rc) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_fuel_units` [INFO] [stderr] --> src/game/combat/ships/ship.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn get_fuel_units(&self) -> FuelUnit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_fuel_units` [INFO] [stderr] --> src/game/combat/ships/ship.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn set_fuel_units(&mut self, val: FuelUnit) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_hull_points` [INFO] [stderr] --> src/game/combat/ships/ship.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn get_hull_points(&self) -> HullPoint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_hull_points` [INFO] [stderr] --> src/game/combat/ships/ship.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn set_hull_points(&mut self, val: HullPoint) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_shield_points` [INFO] [stderr] --> src/game/combat/ships/ship.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn get_shield_points(&self) -> ShieldPoint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_shield_points` [INFO] [stderr] --> src/game/combat/ships/ship.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn set_shield_points(&mut self, val: ShieldPoint) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_alive` [INFO] [stderr] --> src/game/combat/ships/ship.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn is_alive(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `regenerate_shields` [INFO] [stderr] --> src/game/combat/ships/ship.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn regenerate_shields(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `simulate_damage` [INFO] [stderr] --> src/game/combat/ships/ship.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | pub fn simulate_damage(&mut self, mut damage: DamagePoint) -> (HullPoint, ShieldPoint, DamagePoint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `resolve_damage` [INFO] [stderr] --> src/game/combat/ships/ship.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | pub fn resolve_damage(&mut self, damage: DamagePoint) -> DamagePoint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `resolve_attacks` [INFO] [stderr] --> src/game/combat/ships/ship.rs:228:5 [INFO] [stderr] | [INFO] [stderr] 228 | pub fn resolve_attacks(&mut self, attacks: &mut ReducedAttacks) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_alive` [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_alive(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `regenerate_shields` [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn regenerate_shields(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `resolve_damage` [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn resolve_damage(&mut self, mut damage: DamagePoint) -> DamagePoint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `resolve_attacks` [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn resolve_attacks(&mut self, attacks: &mut ReducedAttacks) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_attacks` [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn get_attacks(&self) -> ReducedAttacks { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unaware` [INFO] [stderr] --> src/game/factions.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | Unaware, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Neutral` [INFO] [stderr] --> src/game/factions.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | Neutral, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Friendly` [INFO] [stderr] --> src/game/factions.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Friendly, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Enemy` [INFO] [stderr] --> src/game/factions.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | Enemy [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_parts` [INFO] [stderr] --> src/game/factions.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub unsafe fn from_parts(first: Faction, second: Faction) -> FactionPair { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game/factions.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn new(first: Faction, second: Faction) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_game_factions` [INFO] [stderr] --> src/game/factions.rs:97:1 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn get_game_factions() -> &'static mut (Vec, HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/combat/ships/attacks.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn sum_damage(&self) -> DamagePoint { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/combat/ships/attacks.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn same_damage(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/combat/ships/attacks.rs:122:38 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn same_damage(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FuelError` [INFO] [stderr] --> src/game/combat/ships/ship_error.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | FuelError, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ShieldError` [INFO] [stderr] --> src/game/combat/ships/ship_error.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | ShieldError, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `HullError` [INFO] [stderr] --> src/game/combat/ships/ship_error.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | HullError [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn new(attack: Attack, smallest_target: ShipSize) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `valid_target` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn valid_target(&self, target_size: ShipSize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `same_target` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn same_target(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn new(parralel_attacks: UInt, damage_per_attack: DamagePoint) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `merge` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn merge(&mut self, other: Self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sum_damage` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn sum_damage(&self) -> DamagePoint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `same_damage` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn same_damage(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_parts` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | pub unsafe fn from_parts(attacks: Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn new(mut attacks: Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_attack` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | pub fn add_attack(&mut self, attack: TargetedAttack) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_attacks` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:196:5 [INFO] [stderr] | [INFO] [stderr] 196 | pub fn add_attacks(&mut self, attacks: &[TargetedAttack]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | pub fn iter(&self) -> ::std::slice::Iter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter_mut` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | pub fn iter_mut(&mut self) -> ::std::slice::IterMut { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear_used_attacks` [INFO] [stderr] --> src/game/combat/ships/attacks.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn clear_used_attacks(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_parts` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub unsafe fn from_parts(ship_size_class: ShipSize, fuel_capacity: UInt, [INFO] [stderr] 58 | | fuel_use: UInt, max_hull: UInt, shield_capacity: UInt, shield_recovery: UInt, [INFO] [stderr] 59 | | cargo_capacity: Mass, attacks: ReducedAttacks) -> Self { [INFO] [stderr] 60 | | Self { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / pub fn new(ship_size_class: ShipSize, fuel_capacity: UInt, fuel_use: UInt, [INFO] [stderr] 82 | | hull_points: UInt, shield_points: UInt, shield_recovery: UInt, [INFO] [stderr] 83 | | cargo_capacity: Mass, attacks: ReducedAttacks) -> Result { [INFO] [stderr] 84 | | //Check that fuel use is not greater than fuel capacity. [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_fuel_capacity` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn set_fuel_capacity(&mut self, val: FuelUnit) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_fuel_use` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn get_fuel_use(&self) -> FuelUnit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_fuel_use` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn set_fuel_use(&mut self, val: FuelUnit) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_shield_capacity` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn set_shield_capacity(&mut self, val: ShieldPoint) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_shield_recovery` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | pub fn get_shield_recovery(&self) -> ShieldPoint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_shield_recovery` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | pub fn set_shield_recovery(&mut self, val: ShieldPoint) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `can_target` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | pub fn can_target(&self, target: &Self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `loaded` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn loaded(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `unload_overflow` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | pub fn unload_overflow(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `unload` [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | pub fn unload(&mut self, name: &String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game/combat/ships/ship.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new(template: Rc, fuel_units: FuelUnit, [INFO] [stderr] 55 | | hull_points: HullPoint, shield_points: ShieldPoint) -> Result { [INFO] [stderr] 56 | | //Check that fuel is not greater than fuel capacity. [INFO] [stderr] 57 | | if fuel_units > template.get_fuel_capacity() { [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_template` [INFO] [stderr] --> src/game/combat/ships/ship.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn set_template(&mut self, val: Rc) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_fuel_units` [INFO] [stderr] --> src/game/combat/ships/ship.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn get_fuel_units(&self) -> FuelUnit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_fuel_units` [INFO] [stderr] --> src/game/combat/ships/ship.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn set_fuel_units(&mut self, val: FuelUnit) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_hull_points` [INFO] [stderr] --> src/game/combat/ships/ship.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn get_hull_points(&self) -> HullPoint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_hull_points` [INFO] [stderr] --> src/game/combat/ships/ship.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn set_hull_points(&mut self, val: HullPoint) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_shield_points` [INFO] [stderr] --> src/game/combat/ships/ship.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn get_shield_points(&self) -> ShieldPoint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_shield_points` [INFO] [stderr] --> src/game/combat/ships/ship.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn set_shield_points(&mut self, val: ShieldPoint) -> Result<(), ShipError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_alive` [INFO] [stderr] --> src/game/combat/ships/ship.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn is_alive(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `regenerate_shields` [INFO] [stderr] --> src/game/combat/ships/ship.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn regenerate_shields(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `simulate_damage` [INFO] [stderr] --> src/game/combat/ships/ship.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | pub fn simulate_damage(&mut self, mut damage: DamagePoint) -> (HullPoint, ShieldPoint, DamagePoint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `resolve_damage` [INFO] [stderr] --> src/game/combat/ships/ship.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | pub fn resolve_damage(&mut self, damage: DamagePoint) -> DamagePoint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `resolve_attacks` [INFO] [stderr] --> src/game/combat/ships/ship.rs:228:5 [INFO] [stderr] | [INFO] [stderr] 228 | pub fn resolve_attacks(&mut self, attacks: &mut ReducedAttacks) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_alive` [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_alive(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `regenerate_shields` [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn regenerate_shields(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `resolve_damage` [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn resolve_damage(&mut self, mut damage: DamagePoint) -> DamagePoint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `resolve_attacks` [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn resolve_attacks(&mut self, attacks: &mut ReducedAttacks) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_attacks` [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn get_attacks(&self) -> ReducedAttacks { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unaware` [INFO] [stderr] --> src/game/factions.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | Unaware, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Neutral` [INFO] [stderr] --> src/game/factions.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | Neutral, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Friendly` [INFO] [stderr] --> src/game/factions.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Friendly, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Enemy` [INFO] [stderr] --> src/game/factions.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | Enemy [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_game_factions` [INFO] [stderr] --> src/game/factions.rs:97:1 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn get_game_factions() -> &'static mut (Vec, HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub unsafe fn from_parts(ship_size_class: ShipSize, fuel_capacity: UInt, [INFO] [stderr] 58 | | fuel_use: UInt, max_hull: UInt, shield_capacity: UInt, shield_recovery: UInt, [INFO] [stderr] 59 | | cargo_capacity: Mass, attacks: ReducedAttacks) -> Self { [INFO] [stderr] 60 | | Self { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / pub fn new(ship_size_class: ShipSize, fuel_capacity: UInt, fuel_use: UInt, [INFO] [stderr] 82 | | hull_points: UInt, shield_points: UInt, shield_recovery: UInt, [INFO] [stderr] 83 | | cargo_capacity: Mass, attacks: ReducedAttacks) -> Result { [INFO] [stderr] 84 | | //Check that fuel use is not greater than fuel capacity. [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/combat/ships/attacks.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn sum_damage(&self) -> DamagePoint { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/combat/ships/attacks.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn same_damage(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/combat/ships/attacks.rs:122:38 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn same_damage(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:301:36 [INFO] [stderr] | [INFO] [stderr] 301 | pub fn unload(&mut self, name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:332:33 [INFO] [stderr] | [INFO] [stderr] 332 | pub fn get(&mut self, name: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:381:16 [INFO] [stderr] | [INFO] [stderr] 381 | }).map_err(|e| Ok(e) [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:385:19 [INFO] [stderr] | [INFO] [stderr] 385 | ).map_err(|e| Err(e)) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `Err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/game/combat/ships/ship.rs:281:34 [INFO] [stderr] | [INFO] [stderr] 281 | pub fn build_game_ship(typename: &String, faction: factions::Faction) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:84:35 [INFO] [stderr] | [INFO] [stderr] 84 | remaining_hull += simulation.0 as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(simulation.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:86:37 [INFO] [stderr] | [INFO] [stderr] 86 | remaining_shield += simulation.1 as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(simulation.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:99:31 [INFO] [stderr] | [INFO] [stderr] 99 | remaining_hull += self.average_ship.get_hull_points() as u64 * unattacked as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.average_ship.get_hull_points())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:99:76 [INFO] [stderr] | [INFO] [stderr] 99 | remaining_hull += self.average_ship.get_hull_points() as u64 * unattacked as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(unattacked)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:101:33 [INFO] [stderr] | [INFO] [stderr] 101 | remaining_shield += self.average_ship.get_shield_points() as u64 * unattacked as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.average_ship.get_shield_points())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:101:80 [INFO] [stderr] | [INFO] [stderr] 101 | remaining_shield += self.average_ship.get_shield_points() as u64 * unattacked as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(unattacked)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:104:65 [INFO] [stderr] | [INFO] [stderr] 104 | self.average_ship.set_hull_points((remaining_hull / self.number as u64) as HullPoint).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:106:69 [INFO] [stderr] | [INFO] [stderr] 106 | self.average_ship.set_shield_points((remaining_shield / self.number as u64) as ShieldPoint).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/factions.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn as_u64(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: casting from `*const game::factions::FactionPair` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/game/factions.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | *(self as *const FactionPair as *const u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub unsafe fn from_parts(ship_size_class: ShipSize, fuel_capacity: UInt, [INFO] [stderr] 58 | | fuel_use: UInt, max_hull: UInt, shield_capacity: UInt, shield_recovery: UInt, [INFO] [stderr] 59 | | cargo_capacity: Mass, attacks: ReducedAttacks) -> Self { [INFO] [stderr] 60 | | Self { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/game/factions.rs:71:1 [INFO] [stderr] | [INFO] [stderr] 71 | / impl Hash for FactionPair { [INFO] [stderr] 72 | | fn hash(&self, state: &mut T) { [INFO] [stderr] 73 | | state.write_u64(self.as_u64()) [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/game/factions.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Debug, PartialEq, Eq, Copy, Clone)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / pub fn new(ship_size_class: ShipSize, fuel_capacity: UInt, fuel_use: UInt, [INFO] [stderr] 82 | | hull_points: UInt, shield_points: UInt, shield_recovery: UInt, [INFO] [stderr] 83 | | cargo_capacity: Mass, attacks: ReducedAttacks) -> Result { [INFO] [stderr] 84 | | //Check that fuel use is not greater than fuel capacity. [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if let Ok(_) = io::stdin().read_line(&mut line) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 50 | | line = line.trim().parse().unwrap(); [INFO] [stderr] 51 | | [INFO] [stderr] 52 | | if line.split(' ').next().unwrap().to_lowercase() == "kill" { [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________- help: try this: `if io::stdin().read_line(&mut line).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:301:36 [INFO] [stderr] | [INFO] [stderr] 301 | pub fn unload(&mut self, name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:332:33 [INFO] [stderr] | [INFO] [stderr] 332 | pub fn get(&mut self, name: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:381:16 [INFO] [stderr] | [INFO] [stderr] 381 | }).map_err(|e| Ok(e) [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/game/combat/ships/ship_template.rs:385:19 [INFO] [stderr] | [INFO] [stderr] 385 | ).map_err(|e| Err(e)) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `Err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/game/combat/ships/ship.rs:281:34 [INFO] [stderr] | [INFO] [stderr] 281 | pub fn build_game_ship(typename: &String, faction: factions::Faction) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:84:35 [INFO] [stderr] | [INFO] [stderr] 84 | remaining_hull += simulation.0 as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(simulation.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:86:37 [INFO] [stderr] | [INFO] [stderr] 86 | remaining_shield += simulation.1 as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(simulation.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:99:31 [INFO] [stderr] | [INFO] [stderr] 99 | remaining_hull += self.average_ship.get_hull_points() as u64 * unattacked as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.average_ship.get_hull_points())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:99:76 [INFO] [stderr] | [INFO] [stderr] 99 | remaining_hull += self.average_ship.get_hull_points() as u64 * unattacked as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(unattacked)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:101:33 [INFO] [stderr] | [INFO] [stderr] 101 | remaining_shield += self.average_ship.get_shield_points() as u64 * unattacked as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.average_ship.get_shield_points())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:101:80 [INFO] [stderr] | [INFO] [stderr] 101 | remaining_shield += self.average_ship.get_shield_points() as u64 * unattacked as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(unattacked)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Could not compile `the_brass`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:104:65 [INFO] [stderr] | [INFO] [stderr] 104 | self.average_ship.set_hull_points((remaining_hull / self.number as u64) as HullPoint).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game/combat/ships/reduced_ship.rs:106:69 [INFO] [stderr] | [INFO] [stderr] 106 | self.average_ship.set_shield_points((remaining_shield / self.number as u64) as ShieldPoint).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/factions.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn as_u64(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: casting from `*const game::factions::FactionPair` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/game/factions.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | *(self as *const FactionPair as *const u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/game/factions.rs:71:1 [INFO] [stderr] | [INFO] [stderr] 71 | / impl Hash for FactionPair { [INFO] [stderr] 72 | | fn hash(&self, state: &mut T) { [INFO] [stderr] 73 | | state.write_u64(self.as_u64()) [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/game/factions.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Debug, PartialEq, Eq, Copy, Clone)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if let Ok(_) = io::stdin().read_line(&mut line) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 50 | | line = line.trim().parse().unwrap(); [INFO] [stderr] 51 | | [INFO] [stderr] 52 | | if line.split(' ').next().unwrap().to_lowercase() == "kill" { [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________- help: try this: `if io::stdin().read_line(&mut line).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `the_brass`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "308e2878ec3c59aa888929ee5540bcbd14e23d38ac9d5b299588bb529adc3269"` [INFO] running `"docker" "rm" "-f" "308e2878ec3c59aa888929ee5540bcbd14e23d38ac9d5b299588bb529adc3269"` [INFO] [stdout] 308e2878ec3c59aa888929ee5540bcbd14e23d38ac9d5b299588bb529adc3269