[INFO] updating cached repository DuoSRX/sen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DuoSRX/sen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DuoSRX/sen" "work/ex/clippy-test-run/sources/stable/gh/DuoSRX/sen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DuoSRX/sen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DuoSRX/sen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DuoSRX/sen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DuoSRX/sen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6bacb47a2883e21b9c59f522873bb904a614a776 [INFO] sha for GitHub repo DuoSRX/sen: 6bacb47a2883e21b9c59f522873bb904a614a776 [INFO] validating manifest of DuoSRX/sen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DuoSRX/sen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DuoSRX/sen [INFO] finished frobbing DuoSRX/sen [INFO] frobbed toml for DuoSRX/sen written to work/ex/clippy-test-run/sources/stable/gh/DuoSRX/sen/Cargo.toml [INFO] started frobbing DuoSRX/sen [INFO] finished frobbing DuoSRX/sen [INFO] frobbed toml for DuoSRX/sen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DuoSRX/sen/Cargo.toml [INFO] crate DuoSRX/sen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DuoSRX/sen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DuoSRX/sen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 48c47459760f981578908b310924b20a51a6958a8cbe4b7baf6fcbfcc10bb62c [INFO] running `"docker" "start" "-a" "48c47459760f981578908b310924b20a51a6958a8cbe4b7baf6fcbfcc10bb62c"` [INFO] [stderr] Checking sen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cartridge.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:466:20 [INFO] [stderr] | [INFO] [stderr] 466 | MemoryAM { address: address } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:471:20 [INFO] [stderr] | [INFO] [stderr] 471 | MemoryAM { address: address } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:476:20 [INFO] [stderr] | [INFO] [stderr] 476 | MemoryAM { address: address } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:483:20 [INFO] [stderr] | [INFO] [stderr] 483 | MemoryAM { address: address } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:490:20 [INFO] [stderr] | [INFO] [stderr] 490 | MemoryAM { address: address } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | cartridge: cartridge, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cartridge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | ppu: ppu, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ppu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | controller: controller, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `controller` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ppu.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | cartridge: cartridge, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cartridge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cartridge.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:466:20 [INFO] [stderr] | [INFO] [stderr] 466 | MemoryAM { address: address } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:471:20 [INFO] [stderr] | [INFO] [stderr] 471 | MemoryAM { address: address } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:476:20 [INFO] [stderr] | [INFO] [stderr] 476 | MemoryAM { address: address } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:483:20 [INFO] [stderr] | [INFO] [stderr] 483 | MemoryAM { address: address } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:490:20 [INFO] [stderr] | [INFO] [stderr] 490 | MemoryAM { address: address } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | cartridge: cartridge, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cartridge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | ppu: ppu, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ppu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | controller: controller, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `controller` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ppu.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | cartridge: cartridge, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cartridge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:24:32 [INFO] [stderr] | [INFO] [stderr] 24 | pub const CARRY_FLAG: u8 = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:25:32 [INFO] [stderr] | [INFO] [stderr] 25 | pub const ZERO_FLAG: u8 = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:26:32 [INFO] [stderr] | [INFO] [stderr] 26 | pub const INTERRUPT_FLAG: u8 = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:27:32 [INFO] [stderr] | [INFO] [stderr] 27 | pub const DECIMAL_FLAG: u8 = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:28:32 [INFO] [stderr] | [INFO] [stderr] 28 | pub const BREAK4_FLAG: u8 = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:29:32 [INFO] [stderr] | [INFO] [stderr] 29 | pub const BREAK5_FLAG: u8 = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | pub const OVERFLOW_FLAG: u8 = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | pub const NEGATIVE_FLAG: u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu.rs:503:9 [INFO] [stderr] | [INFO] [stderr] 503 | return p [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | return self.ram.load(address); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.ram.load(address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | return self.ppu.load(0x2000 + address % 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.ppu.load(0x2000 + address % 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | return self.controller.load(address); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.controller.load(address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return self.cartridge.prg[address as usize & 0x7FFF]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cartridge.prg[address as usize & 0x7FFF]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return self.cartridge.prg[address as usize & 0x3FFF]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cartridge.prg[address as usize & 0x3FFF]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | 0x666666, 0x002A88, 0x1412A7, 0x3B00A4, 0x5C007E, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0066_6666` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | 0x666666, 0x002A88, 0x1412A7, 0x3B00A4, 0x5C007E, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_2A88` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | 0x666666, 0x002A88, 0x1412A7, 0x3B00A4, 0x5C007E, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0014_12A7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | 0x666666, 0x002A88, 0x1412A7, 0x3B00A4, 0x5C007E, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x003B_00A4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:14:45 [INFO] [stderr] | [INFO] [stderr] 14 | 0x666666, 0x002A88, 0x1412A7, 0x3B00A4, 0x5C007E, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x005C_007E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | 0x6E0040, 0x6C0600, 0x561D00, 0x333500, 0x0B4800, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x006E_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | 0x6E0040, 0x6C0600, 0x561D00, 0x333500, 0x0B4800, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x006C_0600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | 0x6E0040, 0x6C0600, 0x561D00, 0x333500, 0x0B4800, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0056_1D00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:15:35 [INFO] [stderr] | [INFO] [stderr] 15 | 0x6E0040, 0x6C0600, 0x561D00, 0x333500, 0x0B4800, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0033_3500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:15:45 [INFO] [stderr] | [INFO] [stderr] 15 | 0x6E0040, 0x6C0600, 0x561D00, 0x333500, 0x0B4800, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x000B_4800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | 0x005200, 0x004F08, 0x00404D, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_5200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | 0x005200, 0x004F08, 0x00404D, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_4F08` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | 0x005200, 0x004F08, 0x00404D, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_404D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:16:35 [INFO] [stderr] | [INFO] [stderr] 16 | 0x005200, 0x004F08, 0x00404D, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:16:45 [INFO] [stderr] | [INFO] [stderr] 16 | 0x005200, 0x004F08, 0x00404D, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | 0x000000, 0xADADAD, 0x155FD9, 0x4240FF, 0x7527FE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | 0x000000, 0xADADAD, 0x155FD9, 0x4240FF, 0x7527FE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00AD_ADAD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | 0x000000, 0xADADAD, 0x155FD9, 0x4240FF, 0x7527FE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0015_5FD9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:17:35 [INFO] [stderr] | [INFO] [stderr] 17 | 0x000000, 0xADADAD, 0x155FD9, 0x4240FF, 0x7527FE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0042_40FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:17:45 [INFO] [stderr] | [INFO] [stderr] 17 | 0x000000, 0xADADAD, 0x155FD9, 0x4240FF, 0x7527FE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0075_27FE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | 0xA01ACC, 0xB71E7B, 0xB53120, 0x994E00, 0x6B6D00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00A0_1ACC` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | 0xA01ACC, 0xB71E7B, 0xB53120, 0x994E00, 0x6B6D00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00B7_1E7B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | 0xA01ACC, 0xB71E7B, 0xB53120, 0x994E00, 0x6B6D00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00B5_3120` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:18:35 [INFO] [stderr] | [INFO] [stderr] 18 | 0xA01ACC, 0xB71E7B, 0xB53120, 0x994E00, 0x6B6D00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0099_4E00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:18:45 [INFO] [stderr] | [INFO] [stderr] 18 | 0xA01ACC, 0xB71E7B, 0xB53120, 0x994E00, 0x6B6D00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x006B_6D00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | 0x388700, 0x0C9300, 0x008F32, 0x007C8D, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0038_8700` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | 0x388700, 0x0C9300, 0x008F32, 0x007C8D, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x000C_9300` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | 0x388700, 0x0C9300, 0x008F32, 0x007C8D, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_8F32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | 0x388700, 0x0C9300, 0x008F32, 0x007C8D, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_7C8D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | 0x388700, 0x0C9300, 0x008F32, 0x007C8D, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | 0x000000, 0x000000, 0xFFFEFF, 0x64B0FF, 0x9290FF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | 0x000000, 0x000000, 0xFFFEFF, 0x64B0FF, 0x9290FF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | 0x000000, 0x000000, 0xFFFEFF, 0x64B0FF, 0x9290FF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FEFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:20:35 [INFO] [stderr] | [INFO] [stderr] 20 | 0x000000, 0x000000, 0xFFFEFF, 0x64B0FF, 0x9290FF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0064_B0FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:20:45 [INFO] [stderr] | [INFO] [stderr] 20 | 0x000000, 0x000000, 0xFFFEFF, 0x64B0FF, 0x9290FF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0092_90FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | 0xC676FF, 0xF36AFF, 0xFE6ECC, 0xFE8170, 0xEA9E22, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00C6_76FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | 0xC676FF, 0xF36AFF, 0xFE6ECC, 0xFE8170, 0xEA9E22, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00F3_6AFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | 0xC676FF, 0xF36AFF, 0xFE6ECC, 0xFE8170, 0xEA9E22, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FE_6ECC` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | 0xC676FF, 0xF36AFF, 0xFE6ECC, 0xFE8170, 0xEA9E22, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FE_8170` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | 0xC676FF, 0xF36AFF, 0xFE6ECC, 0xFE8170, 0xEA9E22, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00EA_9E22` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | 0xBCBE00, 0x88D800, 0x5CE430, 0x45E082, 0x48CDDE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00BC_BE00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | 0xBCBE00, 0x88D800, 0x5CE430, 0x45E082, 0x48CDDE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0088_D800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | 0xBCBE00, 0x88D800, 0x5CE430, 0x45E082, 0x48CDDE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x005C_E430` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:22:35 [INFO] [stderr] | [INFO] [stderr] 22 | 0xBCBE00, 0x88D800, 0x5CE430, 0x45E082, 0x48CDDE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0045_E082` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:22:45 [INFO] [stderr] | [INFO] [stderr] 22 | 0xBCBE00, 0x88D800, 0x5CE430, 0x45E082, 0x48CDDE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0048_CDDE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | 0x4F4F4F, 0x000000, 0x000000, 0xFFFEFF, 0xC0DFFF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x004F_4F4F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | 0x4F4F4F, 0x000000, 0x000000, 0xFFFEFF, 0xC0DFFF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | 0x4F4F4F, 0x000000, 0x000000, 0xFFFEFF, 0xC0DFFF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:23:35 [INFO] [stderr] | [INFO] [stderr] 23 | 0x4F4F4F, 0x000000, 0x000000, 0xFFFEFF, 0xC0DFFF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FEFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:23:45 [INFO] [stderr] | [INFO] [stderr] 23 | 0x4F4F4F, 0x000000, 0x000000, 0xFFFEFF, 0xC0DFFF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00C0_DFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | 0xD3D2FF, 0xE8C8FF, 0xFBC2FF, 0xFEC4EA, 0xFECCC5, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00D3_D2FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:24:15 [INFO] [stderr] | [INFO] [stderr] 24 | 0xD3D2FF, 0xE8C8FF, 0xFBC2FF, 0xFEC4EA, 0xFECCC5, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00E8_C8FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | 0xD3D2FF, 0xE8C8FF, 0xFBC2FF, 0xFEC4EA, 0xFECCC5, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FB_C2FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:24:35 [INFO] [stderr] | [INFO] [stderr] 24 | 0xD3D2FF, 0xE8C8FF, 0xFBC2FF, 0xFEC4EA, 0xFECCC5, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FE_C4EA` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:24:45 [INFO] [stderr] | [INFO] [stderr] 24 | 0xD3D2FF, 0xE8C8FF, 0xFBC2FF, 0xFEC4EA, 0xFECCC5, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FE_CCC5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | 0xF7D8A5, 0xE4E594, 0xCFEF96, 0xBDF4AB, 0xB3F3CC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00F7_D8A5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:25:15 [INFO] [stderr] | [INFO] [stderr] 25 | 0xF7D8A5, 0xE4E594, 0xCFEF96, 0xBDF4AB, 0xB3F3CC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00E4_E594` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | 0xF7D8A5, 0xE4E594, 0xCFEF96, 0xBDF4AB, 0xB3F3CC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00CF_EF96` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:25:35 [INFO] [stderr] | [INFO] [stderr] 25 | 0xF7D8A5, 0xE4E594, 0xCFEF96, 0xBDF4AB, 0xB3F3CC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00BD_F4AB` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:25:45 [INFO] [stderr] | [INFO] [stderr] 25 | 0xF7D8A5, 0xE4E594, 0xCFEF96, 0xBDF4AB, 0xB3F3CC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00B3_F3CC` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | 0xB5EBF2, 0xB8B8B8, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00B5_EBF2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | 0xB5EBF2, 0xB8B8B8, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00B8_B8B8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | 0xB5EBF2, 0xB8B8B8, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:26:35 [INFO] [stderr] | [INFO] [stderr] 26 | 0xB5EBF2, 0xB8B8B8, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ppu.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | return buff; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `buff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ppu.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | return value [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:24:32 [INFO] [stderr] | [INFO] [stderr] 24 | pub const CARRY_FLAG: u8 = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:25:32 [INFO] [stderr] | [INFO] [stderr] 25 | pub const ZERO_FLAG: u8 = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:26:32 [INFO] [stderr] | [INFO] [stderr] 26 | pub const INTERRUPT_FLAG: u8 = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:27:32 [INFO] [stderr] | [INFO] [stderr] 27 | pub const DECIMAL_FLAG: u8 = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:28:32 [INFO] [stderr] | [INFO] [stderr] 28 | pub const BREAK4_FLAG: u8 = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:29:32 [INFO] [stderr] | [INFO] [stderr] 29 | pub const BREAK5_FLAG: u8 = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | pub const OVERFLOW_FLAG: u8 = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | pub const NEGATIVE_FLAG: u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu.rs:503:9 [INFO] [stderr] | [INFO] [stderr] 503 | return p [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | return self.ram.load(address); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.ram.load(address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | return self.ppu.load(0x2000 + address % 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.ppu.load(0x2000 + address % 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | return self.controller.load(address); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.controller.load(address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return self.cartridge.prg[address as usize & 0x7FFF]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cartridge.prg[address as usize & 0x7FFF]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return self.cartridge.prg[address as usize & 0x3FFF]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cartridge.prg[address as usize & 0x3FFF]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | 0x666666, 0x002A88, 0x1412A7, 0x3B00A4, 0x5C007E, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0066_6666` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | 0x666666, 0x002A88, 0x1412A7, 0x3B00A4, 0x5C007E, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_2A88` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | 0x666666, 0x002A88, 0x1412A7, 0x3B00A4, 0x5C007E, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0014_12A7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | 0x666666, 0x002A88, 0x1412A7, 0x3B00A4, 0x5C007E, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x003B_00A4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:14:45 [INFO] [stderr] | [INFO] [stderr] 14 | 0x666666, 0x002A88, 0x1412A7, 0x3B00A4, 0x5C007E, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x005C_007E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | 0x6E0040, 0x6C0600, 0x561D00, 0x333500, 0x0B4800, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x006E_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | 0x6E0040, 0x6C0600, 0x561D00, 0x333500, 0x0B4800, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x006C_0600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | 0x6E0040, 0x6C0600, 0x561D00, 0x333500, 0x0B4800, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0056_1D00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:15:35 [INFO] [stderr] | [INFO] [stderr] 15 | 0x6E0040, 0x6C0600, 0x561D00, 0x333500, 0x0B4800, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0033_3500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:15:45 [INFO] [stderr] | [INFO] [stderr] 15 | 0x6E0040, 0x6C0600, 0x561D00, 0x333500, 0x0B4800, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x000B_4800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | 0x005200, 0x004F08, 0x00404D, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_5200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | 0x005200, 0x004F08, 0x00404D, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_4F08` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | 0x005200, 0x004F08, 0x00404D, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_404D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:16:35 [INFO] [stderr] | [INFO] [stderr] 16 | 0x005200, 0x004F08, 0x00404D, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:16:45 [INFO] [stderr] | [INFO] [stderr] 16 | 0x005200, 0x004F08, 0x00404D, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | 0x000000, 0xADADAD, 0x155FD9, 0x4240FF, 0x7527FE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | 0x000000, 0xADADAD, 0x155FD9, 0x4240FF, 0x7527FE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00AD_ADAD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | 0x000000, 0xADADAD, 0x155FD9, 0x4240FF, 0x7527FE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0015_5FD9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:17:35 [INFO] [stderr] | [INFO] [stderr] 17 | 0x000000, 0xADADAD, 0x155FD9, 0x4240FF, 0x7527FE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0042_40FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:17:45 [INFO] [stderr] | [INFO] [stderr] 17 | 0x000000, 0xADADAD, 0x155FD9, 0x4240FF, 0x7527FE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0075_27FE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | 0xA01ACC, 0xB71E7B, 0xB53120, 0x994E00, 0x6B6D00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00A0_1ACC` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | 0xA01ACC, 0xB71E7B, 0xB53120, 0x994E00, 0x6B6D00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00B7_1E7B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | 0xA01ACC, 0xB71E7B, 0xB53120, 0x994E00, 0x6B6D00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00B5_3120` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:18:35 [INFO] [stderr] | [INFO] [stderr] 18 | 0xA01ACC, 0xB71E7B, 0xB53120, 0x994E00, 0x6B6D00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0099_4E00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:18:45 [INFO] [stderr] | [INFO] [stderr] 18 | 0xA01ACC, 0xB71E7B, 0xB53120, 0x994E00, 0x6B6D00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x006B_6D00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | 0x388700, 0x0C9300, 0x008F32, 0x007C8D, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0038_8700` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | 0x388700, 0x0C9300, 0x008F32, 0x007C8D, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x000C_9300` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | 0x388700, 0x0C9300, 0x008F32, 0x007C8D, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_8F32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | 0x388700, 0x0C9300, 0x008F32, 0x007C8D, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_7C8D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | 0x388700, 0x0C9300, 0x008F32, 0x007C8D, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | 0x000000, 0x000000, 0xFFFEFF, 0x64B0FF, 0x9290FF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | 0x000000, 0x000000, 0xFFFEFF, 0x64B0FF, 0x9290FF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | 0x000000, 0x000000, 0xFFFEFF, 0x64B0FF, 0x9290FF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FEFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:20:35 [INFO] [stderr] | [INFO] [stderr] 20 | 0x000000, 0x000000, 0xFFFEFF, 0x64B0FF, 0x9290FF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0064_B0FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:20:45 [INFO] [stderr] | [INFO] [stderr] 20 | 0x000000, 0x000000, 0xFFFEFF, 0x64B0FF, 0x9290FF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0092_90FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | 0xC676FF, 0xF36AFF, 0xFE6ECC, 0xFE8170, 0xEA9E22, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00C6_76FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | 0xC676FF, 0xF36AFF, 0xFE6ECC, 0xFE8170, 0xEA9E22, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00F3_6AFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | 0xC676FF, 0xF36AFF, 0xFE6ECC, 0xFE8170, 0xEA9E22, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FE_6ECC` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | 0xC676FF, 0xF36AFF, 0xFE6ECC, 0xFE8170, 0xEA9E22, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FE_8170` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | 0xC676FF, 0xF36AFF, 0xFE6ECC, 0xFE8170, 0xEA9E22, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00EA_9E22` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | 0xBCBE00, 0x88D800, 0x5CE430, 0x45E082, 0x48CDDE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00BC_BE00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | 0xBCBE00, 0x88D800, 0x5CE430, 0x45E082, 0x48CDDE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0088_D800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | 0xBCBE00, 0x88D800, 0x5CE430, 0x45E082, 0x48CDDE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x005C_E430` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:22:35 [INFO] [stderr] | [INFO] [stderr] 22 | 0xBCBE00, 0x88D800, 0x5CE430, 0x45E082, 0x48CDDE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0045_E082` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:22:45 [INFO] [stderr] | [INFO] [stderr] 22 | 0xBCBE00, 0x88D800, 0x5CE430, 0x45E082, 0x48CDDE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0048_CDDE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | 0x4F4F4F, 0x000000, 0x000000, 0xFFFEFF, 0xC0DFFF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x004F_4F4F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | 0x4F4F4F, 0x000000, 0x000000, 0xFFFEFF, 0xC0DFFF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | 0x4F4F4F, 0x000000, 0x000000, 0xFFFEFF, 0xC0DFFF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:23:35 [INFO] [stderr] | [INFO] [stderr] 23 | 0x4F4F4F, 0x000000, 0x000000, 0xFFFEFF, 0xC0DFFF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FEFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:23:45 [INFO] [stderr] | [INFO] [stderr] 23 | 0x4F4F4F, 0x000000, 0x000000, 0xFFFEFF, 0xC0DFFF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00C0_DFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | 0xD3D2FF, 0xE8C8FF, 0xFBC2FF, 0xFEC4EA, 0xFECCC5, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00D3_D2FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:24:15 [INFO] [stderr] | [INFO] [stderr] 24 | 0xD3D2FF, 0xE8C8FF, 0xFBC2FF, 0xFEC4EA, 0xFECCC5, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00E8_C8FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | 0xD3D2FF, 0xE8C8FF, 0xFBC2FF, 0xFEC4EA, 0xFECCC5, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FB_C2FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:24:35 [INFO] [stderr] | [INFO] [stderr] 24 | 0xD3D2FF, 0xE8C8FF, 0xFBC2FF, 0xFEC4EA, 0xFECCC5, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FE_C4EA` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:24:45 [INFO] [stderr] | [INFO] [stderr] 24 | 0xD3D2FF, 0xE8C8FF, 0xFBC2FF, 0xFEC4EA, 0xFECCC5, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FE_CCC5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | 0xF7D8A5, 0xE4E594, 0xCFEF96, 0xBDF4AB, 0xB3F3CC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00F7_D8A5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:25:15 [INFO] [stderr] | [INFO] [stderr] 25 | 0xF7D8A5, 0xE4E594, 0xCFEF96, 0xBDF4AB, 0xB3F3CC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00E4_E594` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | 0xF7D8A5, 0xE4E594, 0xCFEF96, 0xBDF4AB, 0xB3F3CC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00CF_EF96` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:25:35 [INFO] [stderr] | [INFO] [stderr] 25 | 0xF7D8A5, 0xE4E594, 0xCFEF96, 0xBDF4AB, 0xB3F3CC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00BD_F4AB` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:25:45 [INFO] [stderr] | [INFO] [stderr] 25 | 0xF7D8A5, 0xE4E594, 0xCFEF96, 0xBDF4AB, 0xB3F3CC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00B3_F3CC` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | 0xB5EBF2, 0xB8B8B8, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00B5_EBF2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | 0xB5EBF2, 0xB8B8B8, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00B8_B8B8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | 0xB5EBF2, 0xB8B8B8, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ppu.rs:26:35 [INFO] [stderr] | [INFO] [stderr] 26 | 0xB5EBF2, 0xB8B8B8, 0x000000, 0x000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ppu.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | return buff; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `buff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ppu.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | return value [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `controller::Controller` [INFO] [stderr] --> src/controller.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | Controller { [INFO] [stderr] 15 | | // buttons: [false; 8], [INFO] [stderr] 16 | | buttons: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:143:27 [INFO] [stderr] | [INFO] [stderr] 143 | self.cycle += CYCLES_PER_INSTRUCTION[instruction as usize] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(CYCLES_PER_INSTRUCTION[instruction as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `controller::Controller` [INFO] [stderr] --> src/controller.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | Controller { [INFO] [stderr] 15 | | // buttons: [false; 8], [INFO] [stderr] 16 | | buttons: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | self.ram.load(address) as u16 | (self.ram.load(address + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram.load(address))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:373:41 [INFO] [stderr] | [INFO] [stderr] 373 | self.ram.load(address) as u16 | (self.ram.load(address + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram.load(address + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:381:9 [INFO] [stderr] | [INFO] [stderr] 381 | self.ram.load(address as u16) as u16 | (self.ram.load((address + 1) as u16) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram.load(address as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:381:48 [INFO] [stderr] | [INFO] [stderr] 381 | self.ram.load(address as u16) as u16 | (self.ram.load((address + 1) as u16) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram.load((address + 1) as u16))` [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:143:27 [INFO] [stderr] | [INFO] [stderr] 143 | self.cycle += CYCLES_PER_INSTRUCTION[instruction as usize] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(CYCLES_PER_INSTRUCTION[instruction as usize])` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:411:17 [INFO] [stderr] | [INFO] [stderr] 411 | let a = self.load_byte_and_inc_pc() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.load_byte_and_inc_pc())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:412:17 [INFO] [stderr] | [INFO] [stderr] 412 | let b = self.load_byte_and_inc_pc() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.load_byte_and_inc_pc())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:419:33 [INFO] [stderr] | [INFO] [stderr] 419 | self.store_byte(0x100 + stack_pointer as u16, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stack_pointer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:425:33 [INFO] [stderr] | [INFO] [stderr] 425 | self.store_word(0x100 + stack_pointer as u16, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stack_pointer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:431:43 [INFO] [stderr] | [INFO] [stderr] 431 | let byte = self.load_byte(0x100 + stack_pointer as u16 + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stack_pointer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:438:43 [INFO] [stderr] | [INFO] [stderr] 438 | let word = self.load_word(0x100 + stack_pointer as u16 + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stack_pointer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:451:29 [INFO] [stderr] | [INFO] [stderr] 451 | MemoryAM { address: address as u16 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:456:29 [INFO] [stderr] | [INFO] [stderr] 456 | MemoryAM { address: address as u16 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | self.ram.load(address) as u16 | (self.ram.load(address + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram.load(address))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:373:41 [INFO] [stderr] | [INFO] [stderr] 373 | self.ram.load(address) as u16 | (self.ram.load(address + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram.load(address + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:381:9 [INFO] [stderr] | [INFO] [stderr] 381 | self.ram.load(address as u16) as u16 | (self.ram.load((address + 1) as u16) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram.load(address as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:381:48 [INFO] [stderr] | [INFO] [stderr] 381 | self.ram.load(address as u16) as u16 | (self.ram.load((address + 1) as u16) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram.load((address + 1) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:411:17 [INFO] [stderr] | [INFO] [stderr] 411 | let a = self.load_byte_and_inc_pc() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.load_byte_and_inc_pc())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:412:17 [INFO] [stderr] | [INFO] [stderr] 412 | let b = self.load_byte_and_inc_pc() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.load_byte_and_inc_pc())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:419:33 [INFO] [stderr] | [INFO] [stderr] 419 | self.store_byte(0x100 + stack_pointer as u16, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stack_pointer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:425:33 [INFO] [stderr] | [INFO] [stderr] 425 | self.store_word(0x100 + stack_pointer as u16, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stack_pointer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:431:43 [INFO] [stderr] | [INFO] [stderr] 431 | let byte = self.load_byte(0x100 + stack_pointer as u16 + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stack_pointer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:461:29 [INFO] [stderr] | [INFO] [stderr] 461 | MemoryAM { address: address as u16 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(address)` [INFO] [stderr] | [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:438:43 [INFO] [stderr] | [INFO] [stderr] 438 | let word = self.load_word(0x100 + stack_pointer as u16 + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stack_pointer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:451:29 [INFO] [stderr] | [INFO] [stderr] 451 | MemoryAM { address: address as u16 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(address)` [INFO] [stderr] | [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:470:64 [INFO] [stderr] | [INFO] [stderr] 470 | let address = self.load_word_and_inc_pc().wrapping_add(self.x as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:475:64 [INFO] [stderr] | [INFO] [stderr] 475 | let address = self.load_word_and_inc_pc().wrapping_add(self.y as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.y)` [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:456:29 [INFO] [stderr] | [INFO] [stderr] 456 | MemoryAM { address: address as u16 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:461:29 [INFO] [stderr] | [INFO] [stderr] 461 | MemoryAM { address: address as u16 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(address)` [INFO] [stderr] | [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:482:48 [INFO] [stderr] | [INFO] [stderr] 482 | let address = self.load_word_zero_page(target as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(target)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:489:48 [INFO] [stderr] | [INFO] [stderr] 489 | let address = self.load_word_zero_page(target as u16).wrapping_add(self.y as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(target)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] [INFO] [stderr] --> src/cpu.rs:470:64 [INFO] [stderr] | [INFO] [stderr] 470 | let address = self.load_word_and_inc_pc().wrapping_add(self.x as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] --> src/cpu.rs:489:76 [INFO] [stderr] | [INFO] [stderr] 489 | let address = self.load_word_zero_page(target as u16).wrapping_add(self.y as u16); [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:475:64 [INFO] [stderr] | [INFO] [stderr] 475 | let address = self.load_word_and_inc_pc().wrapping_add(self.y as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:482:48 [INFO] [stderr] | [INFO] [stderr] 482 | let address = self.load_word_zero_page(target as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(target)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:489:48 [INFO] [stderr] | [INFO] [stderr] 489 | let address = self.load_word_zero_page(target as u16).wrapping_add(self.y as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(target)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:489:76 [INFO] [stderr] | [INFO] [stderr] 489 | let address = self.load_word_zero_page(target as u16).wrapping_add(self.y as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:517:20 [INFO] [stderr] | [INFO] [stderr] 517 | self.pc += to_skip as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(to_skip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:517:20 [INFO] [stderr] | [INFO] [stderr] 517 | self.pc += to_skip as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(to_skip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:523:26 [INFO] [stderr] | [INFO] [stderr] 523 | let mut result = value as u32 + self.a as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:523:41 [INFO] [stderr] | [INFO] [stderr] 523 | let mut result = value as u32 + self.a as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(result as u8)` [INFO] [stderr] --> src/cpu.rs:534:18 [INFO] [stderr] | [INFO] [stderr] 534 | self.a = (result as u8) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:539:26 [INFO] [stderr] | [INFO] [stderr] 539 | let mut result = (value as u32).wrapping_sub(self.a as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:539:54 [INFO] [stderr] | [INFO] [stderr] 539 | let mut result = (value as u32).wrapping_sub(self.a as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(result as u8)` [INFO] [stderr] --> src/cpu.rs:550:18 [INFO] [stderr] | [INFO] [stderr] 550 | self.a = (result as u8) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `val` [INFO] [stderr] --> src/cpu.rs:556:24 [INFO] [stderr] | [INFO] [stderr] 556 | am.store(self, val & 0xFF); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `val` [INFO] [stderr] --> src/cpu.rs:562:24 [INFO] [stderr] | [INFO] [stderr] 562 | am.store(self, val & 0xFF); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:523:26 [INFO] [stderr] | [INFO] [stderr] 523 | let mut result = value as u32 + self.a as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:523:41 [INFO] [stderr] | [INFO] [stderr] 523 | let mut result = value as u32 + self.a as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(result as u8)` [INFO] [stderr] --> src/cpu.rs:534:18 [INFO] [stderr] | [INFO] [stderr] 534 | self.a = (result as u8) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:539:26 [INFO] [stderr] | [INFO] [stderr] 539 | let mut result = (value as u32).wrapping_sub(self.a as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:539:54 [INFO] [stderr] | [INFO] [stderr] 539 | let mut result = (value as u32).wrapping_sub(self.a as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(result as u8)` [INFO] [stderr] --> src/cpu.rs:550:18 [INFO] [stderr] | [INFO] [stderr] 550 | self.a = (result as u8) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `val` [INFO] [stderr] --> src/cpu.rs:556:24 [INFO] [stderr] | [INFO] [stderr] 556 | am.store(self, val & 0xFF); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `val` [INFO] [stderr] --> src/cpu.rs:562:24 [INFO] [stderr] | [INFO] [stderr] 562 | am.store(self, val & 0xFF); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:740:20 [INFO] [stderr] | [INFO] [stderr] 740 | self.pc = ((high as u16) << 8) | low as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:740:42 [INFO] [stderr] | [INFO] [stderr] 740 | self.pc = ((high as u16) << 8) | low as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:843:24 [INFO] [stderr] | [INFO] [stderr] 843 | self.pc = (self.pc as i32 + byte as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(self.pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:843:41 [INFO] [stderr] | [INFO] [stderr] 843 | self.pc = (self.pc as i32 + byte as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | self.dma(value as u16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:740:20 [INFO] [stderr] | [INFO] [stderr] 740 | self.pc = ((high as u16) << 8) | low as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:740:42 [INFO] [stderr] | [INFO] [stderr] 740 | self.pc = ((high as u16) << 8) | low as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `memory::Ram` [INFO] [stderr] --> src/memory.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new() -> Ram { [INFO] [stderr] 94 | | Ram { val: vec![0; 0xFFFF] } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | Tiles::Tiles8(self.index as u16 | ppu.sprite_pattern_table_address()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | let mut address: u16 = self.index as u16 & !1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:843:24 [INFO] [stderr] | [INFO] [stderr] 843 | self.pc = (self.pc as i32 + byte as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(self.pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:843:41 [INFO] [stderr] | [INFO] [stderr] 843 | self.pc = (self.pc as i32 + byte as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/ppu.rs:177:20 [INFO] [stderr] | [INFO] [stderr] 177 | panic!("Reading VRam at 0x{:04x} is not valid!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | let address = self.regs.oam_address as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs.oam_address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:239:23 [INFO] [stderr] | [INFO] [stderr] 239 | let address = self.regs.oam_address as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs.oam_address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:258:63 [INFO] [stderr] | [INFO] [stderr] 258 | self.regs.address = (self.regs.address & 0xFF) | ((address as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:261:64 [INFO] [stderr] | [INFO] [stderr] 261 | self.regs.address = (self.regs.address & 0xFF00) | (address as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:323:24 [INFO] [stderr] | [INFO] [stderr] 323 | let x_offset = x as u16 / 8; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:329:20 [INFO] [stderr] | [INFO] [stderr] 329 | let tile = self.vram_load(tile_address) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.vram_load(tile_address))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:331:40 [INFO] [stderr] | [INFO] [stderr] 331 | let mut offset = (tile << 4) + y2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(y2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:352:40 [INFO] [stderr] | [INFO] [stderr] 352 | let palette_address = 0x3F00 + color as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(color)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/ppu.rs:374:31 [INFO] [stderr] | [INFO] [stderr] 374 | let on_scanline = !(self.scanline < sprite.y as u16) && (self.scanline < sprite.y as u16 + 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.scanline >= sprite.y as u16 && (self.scanline < sprite.y as u16 + 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:373:43 [INFO] [stderr] | [INFO] [stderr] 373 | let in_box = x >= sprite.x && (x as u16) < sprite.x as u16 + size as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:373:56 [INFO] [stderr] | [INFO] [stderr] 373 | let in_box = x >= sprite.x && (x as u16) < sprite.x as u16 + size as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(sprite.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:373:74 [INFO] [stderr] | [INFO] [stderr] 373 | let in_box = x >= sprite.x && (x as u16) < sprite.x as u16 + size as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:374:49 [INFO] [stderr] | [INFO] [stderr] 374 | let on_scanline = !(self.scanline < sprite.y as u16) && (self.scanline < sprite.y as u16 + 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(sprite.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:374:86 [INFO] [stderr] | [INFO] [stderr] 374 | let on_scanline = !(self.scanline < sprite.y as u16) && (self.scanline < sprite.y as u16 + 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(sprite.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:388:56 [INFO] [stderr] | [INFO] [stderr] 388 | let mut offset = (tile << 4) + sprite_y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(sprite_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:404:48 [INFO] [stderr] | [INFO] [stderr] 404 | let palette_address = 0x3F00 + color as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(color)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(y * 256 + x) * 3` [INFO] [stderr] --> src/ppu.rs:416:28 [INFO] [stderr] | [INFO] [stderr] 416 | self.frame_content[((y * 256 + x) * 3 + 0) as usize] = color as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | self.dma(value as u16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:427:32 [INFO] [stderr] | [INFO] [stderr] 427 | self.set_pixel(x as u32, scanline as u32, c); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:427:42 [INFO] [stderr] | [INFO] [stderr] 427 | self.set_pixel(x as u32, scanline as u32, c); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(scanline)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:429:32 [INFO] [stderr] | [INFO] [stderr] 429 | self.set_pixel(x as u32, scanline as u32, 0); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:429:42 [INFO] [stderr] | [INFO] [stderr] 429 | self.set_pixel(x as u32, scanline as u32, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(scanline)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ppu.rs:433:17 [INFO] [stderr] | [INFO] [stderr] 433 | / match self.get_sprite_pixel(x, background) { [INFO] [stderr] 434 | | Some(color) => self.set_pixel(x as u32, scanline as u32, color), [INFO] [stderr] 435 | | _ => () [INFO] [stderr] 436 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(color) = self.get_sprite_pixel(x, background) { self.set_pixel(x as u32, scanline as u32, color) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:434:51 [INFO] [stderr] | [INFO] [stderr] 434 | Some(color) => self.set_pixel(x as u32, scanline as u32, color), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:434:61 [INFO] [stderr] | [INFO] [stderr] 434 | Some(color) => self.set_pixel(x as u32, scanline as u32, color), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(scanline)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: incompatible bit mask: `_ | 128` can never be equal to `0` [INFO] [stderr] --> src/ppu.rs:457:20 [INFO] [stderr] | [INFO] [stderr] 457 | if (self.regs.control | 0x80) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::bad_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `memory::Ram` [INFO] [stderr] --> src/memory.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new() -> Ram { [INFO] [stderr] 94 | | Ram { val: vec![0; 0xFFFF] } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | Tiles::Tiles8(self.index as u16 | ppu.sprite_pattern_table_address()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | let mut address: u16 = self.index as u16 & !1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/ppu.rs:177:20 [INFO] [stderr] | [INFO] [stderr] 177 | panic!("Reading VRam at 0x{:04x} is not valid!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | let address = self.regs.oam_address as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs.oam_address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:239:23 [INFO] [stderr] | [INFO] [stderr] 239 | let address = self.regs.oam_address as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs.oam_address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:258:63 [INFO] [stderr] | [INFO] [stderr] 258 | self.regs.address = (self.regs.address & 0xFF) | ((address as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:261:64 [INFO] [stderr] | [INFO] [stderr] 261 | self.regs.address = (self.regs.address & 0xFF00) | (address as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Could not compile `sen`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:323:24 [INFO] [stderr] | [INFO] [stderr] 323 | let x_offset = x as u16 / 8; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:329:20 [INFO] [stderr] | [INFO] [stderr] 329 | let tile = self.vram_load(tile_address) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.vram_load(tile_address))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:331:40 [INFO] [stderr] | [INFO] [stderr] 331 | let mut offset = (tile << 4) + y2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(y2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:352:40 [INFO] [stderr] | [INFO] [stderr] 352 | let palette_address = 0x3F00 + color as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(color)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/ppu.rs:374:31 [INFO] [stderr] | [INFO] [stderr] 374 | let on_scanline = !(self.scanline < sprite.y as u16) && (self.scanline < sprite.y as u16 + 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.scanline >= sprite.y as u16 && (self.scanline < sprite.y as u16 + 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:373:43 [INFO] [stderr] | [INFO] [stderr] 373 | let in_box = x >= sprite.x && (x as u16) < sprite.x as u16 + size as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:373:56 [INFO] [stderr] | [INFO] [stderr] 373 | let in_box = x >= sprite.x && (x as u16) < sprite.x as u16 + size as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(sprite.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:373:74 [INFO] [stderr] | [INFO] [stderr] 373 | let in_box = x >= sprite.x && (x as u16) < sprite.x as u16 + size as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:374:49 [INFO] [stderr] | [INFO] [stderr] 374 | let on_scanline = !(self.scanline < sprite.y as u16) && (self.scanline < sprite.y as u16 + 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(sprite.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:374:86 [INFO] [stderr] | [INFO] [stderr] 374 | let on_scanline = !(self.scanline < sprite.y as u16) && (self.scanline < sprite.y as u16 + 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(sprite.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:388:56 [INFO] [stderr] | [INFO] [stderr] 388 | let mut offset = (tile << 4) + sprite_y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(sprite_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:404:48 [INFO] [stderr] | [INFO] [stderr] 404 | let palette_address = 0x3F00 + color as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(color)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(y * 256 + x) * 3` [INFO] [stderr] --> src/ppu.rs:416:28 [INFO] [stderr] | [INFO] [stderr] 416 | self.frame_content[((y * 256 + x) * 3 + 0) as usize] = color as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:427:32 [INFO] [stderr] | [INFO] [stderr] 427 | self.set_pixel(x as u32, scanline as u32, c); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:427:42 [INFO] [stderr] | [INFO] [stderr] 427 | self.set_pixel(x as u32, scanline as u32, c); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(scanline)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:429:32 [INFO] [stderr] | [INFO] [stderr] 429 | self.set_pixel(x as u32, scanline as u32, 0); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:429:42 [INFO] [stderr] | [INFO] [stderr] 429 | self.set_pixel(x as u32, scanline as u32, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(scanline)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ppu.rs:433:17 [INFO] [stderr] | [INFO] [stderr] 433 | / match self.get_sprite_pixel(x, background) { [INFO] [stderr] 434 | | Some(color) => self.set_pixel(x as u32, scanline as u32, color), [INFO] [stderr] 435 | | _ => () [INFO] [stderr] 436 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(color) = self.get_sprite_pixel(x, background) { self.set_pixel(x as u32, scanline as u32, color) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:434:51 [INFO] [stderr] | [INFO] [stderr] 434 | Some(color) => self.set_pixel(x as u32, scanline as u32, color), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ppu.rs:434:61 [INFO] [stderr] | [INFO] [stderr] 434 | Some(color) => self.set_pixel(x as u32, scanline as u32, color), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(scanline)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: incompatible bit mask: `_ | 128` can never be equal to `0` [INFO] [stderr] --> src/ppu.rs:457:20 [INFO] [stderr] | [INFO] [stderr] 457 | if (self.regs.control | 0x80) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::bad_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sen`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "48c47459760f981578908b310924b20a51a6958a8cbe4b7baf6fcbfcc10bb62c"` [INFO] running `"docker" "rm" "-f" "48c47459760f981578908b310924b20a51a6958a8cbe4b7baf6fcbfcc10bb62c"` [INFO] [stdout] 48c47459760f981578908b310924b20a51a6958a8cbe4b7baf6fcbfcc10bb62c