[INFO] updating cached repository DuoSRX/puce [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DuoSRX/puce [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DuoSRX/puce" "work/ex/clippy-test-run/sources/stable/gh/DuoSRX/puce"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DuoSRX/puce'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DuoSRX/puce" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DuoSRX/puce"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DuoSRX/puce'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 554adad6ddc3b48cbbb6051570cdcbc18960824a [INFO] sha for GitHub repo DuoSRX/puce: 554adad6ddc3b48cbbb6051570cdcbc18960824a [INFO] validating manifest of DuoSRX/puce on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DuoSRX/puce on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DuoSRX/puce [INFO] finished frobbing DuoSRX/puce [INFO] frobbed toml for DuoSRX/puce written to work/ex/clippy-test-run/sources/stable/gh/DuoSRX/puce/Cargo.toml [INFO] started frobbing DuoSRX/puce [INFO] finished frobbing DuoSRX/puce [INFO] frobbed toml for DuoSRX/puce written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DuoSRX/puce/Cargo.toml [INFO] crate DuoSRX/puce has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DuoSRX/puce against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DuoSRX/puce:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4faaec92ab1c18f527eaf8e871d102d4d66288b851fda11ae0fccf854ea2746a [INFO] running `"docker" "start" "-a" "4faaec92ab1c18f527eaf8e871d102d4d66288b851fda11ae0fccf854ea2746a"` [INFO] [stderr] Checking puce v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/audio.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | Audio { device: device } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | mem: mem,//vec![0; 0x1000], [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cpu.rs:220:29 [INFO] [stderr] | [INFO] [stderr] 220 | let i = self.i as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/audio.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | Audio { device: device } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | mem: mem,//vec![0; 0x1000], [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cpu.rs:220:29 [INFO] [stderr] | [INFO] [stderr] 220 | let i = self.i as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `thread`, `time` [INFO] [stderr] --> src/main.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | use std::{env, time, thread}; [INFO] [stderr] | ^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `thread`, `time` [INFO] [stderr] --> src/main.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | use std::{env, time, thread}; [INFO] [stderr] | ^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:134:35 [INFO] [stderr] | [INFO] [stderr] 134 | let res = self.regs[x] as u16 + self.regs[y] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[x])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:134:57 [INFO] [stderr] | [INFO] [stderr] 134 | let res = self.regs[x] as u16 + self.regs[y] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[y])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:163:47 [INFO] [stderr] | [INFO] [stderr] 163 | 0xB => self.pc = nnn.wrapping_add(self.regs[0] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:170:25 [INFO] [stderr] | [INFO] [stderr] 170 | let x = self.regs[x] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:171:25 [INFO] [stderr] | [INFO] [stderr] 171 | let y = self.regs[y] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[y])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:172:30 [INFO] [stderr] | [INFO] [stderr] 172 | let height = n as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:217:58 [INFO] [stderr] | [INFO] [stderr] 217 | 0x1E => self.i = self.i.wrapping_add(self.regs[x] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:218:38 [INFO] [stderr] | [INFO] [stderr] 218 | 0x29 => self.i = self.regs[x] as u16 * 5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu.rs:227:39 [INFO] [stderr] | [INFO] [stderr] 227 | for offset in 0..(x+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu.rs:233:39 [INFO] [stderr] | [INFO] [stderr] 233 | for offset in 0..(x+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:248:18 [INFO] [stderr] | [INFO] [stderr] 248 | let hi = self.mem[address as usize] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[address as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:249:18 [INFO] [stderr] | [INFO] [stderr] 249 | let lo = self.mem[address as usize + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[address as usize + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:134:35 [INFO] [stderr] | [INFO] [stderr] 134 | let res = self.regs[x] as u16 + self.regs[y] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[x])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:134:57 [INFO] [stderr] | [INFO] [stderr] 134 | let res = self.regs[x] as u16 + self.regs[y] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[y])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:163:47 [INFO] [stderr] | [INFO] [stderr] 163 | 0xB => self.pc = nnn.wrapping_add(self.regs[0] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:170:25 [INFO] [stderr] | [INFO] [stderr] 170 | let x = self.regs[x] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:171:25 [INFO] [stderr] | [INFO] [stderr] 171 | let y = self.regs[y] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[y])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:172:30 [INFO] [stderr] | [INFO] [stderr] 172 | let height = n as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:217:58 [INFO] [stderr] | [INFO] [stderr] 217 | 0x1E => self.i = self.i.wrapping_add(self.regs[x] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:218:38 [INFO] [stderr] | [INFO] [stderr] 218 | 0x29 => self.i = self.regs[x] as u16 * 5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu.rs:227:39 [INFO] [stderr] | [INFO] [stderr] 227 | for offset in 0..(x+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu.rs:233:39 [INFO] [stderr] | [INFO] [stderr] 233 | for offset in 0..(x+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:248:18 [INFO] [stderr] | [INFO] [stderr] 248 | let hi = self.mem[address as usize] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[address as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:249:18 [INFO] [stderr] | [INFO] [stderr] 249 | let lo = self.mem[address as usize + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[address as usize + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.18s [INFO] running `"docker" "inspect" "4faaec92ab1c18f527eaf8e871d102d4d66288b851fda11ae0fccf854ea2746a"` [INFO] running `"docker" "rm" "-f" "4faaec92ab1c18f527eaf8e871d102d4d66288b851fda11ae0fccf854ea2746a"` [INFO] [stdout] 4faaec92ab1c18f527eaf8e871d102d4d66288b851fda11ae0fccf854ea2746a