[INFO] updating cached repository Dragan1810/Hello-Rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Dragan1810/Hello-Rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Dragan1810/Hello-Rust" "work/ex/clippy-test-run/sources/stable/gh/Dragan1810/Hello-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Dragan1810/Hello-Rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Dragan1810/Hello-Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dragan1810/Hello-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dragan1810/Hello-Rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f4410a2be95efe9f3b26051bba6e7dfab7685b2f [INFO] sha for GitHub repo Dragan1810/Hello-Rust: f4410a2be95efe9f3b26051bba6e7dfab7685b2f [INFO] validating manifest of Dragan1810/Hello-Rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Dragan1810/Hello-Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Dragan1810/Hello-Rust [INFO] finished frobbing Dragan1810/Hello-Rust [INFO] frobbed toml for Dragan1810/Hello-Rust written to work/ex/clippy-test-run/sources/stable/gh/Dragan1810/Hello-Rust/Cargo.toml [INFO] started frobbing Dragan1810/Hello-Rust [INFO] finished frobbing Dragan1810/Hello-Rust [INFO] frobbed toml for Dragan1810/Hello-Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dragan1810/Hello-Rust/Cargo.toml [INFO] crate Dragan1810/Hello-Rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Dragan1810/Hello-Rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Dragan1810/Hello-Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 18650b2c9a6d9a5aacf107637b01d0ae49eb52b3952870007eff20330a5ad9c0 [INFO] running `"docker" "start" "-a" "18650b2c9a6d9a5aacf107637b01d0ae49eb52b3952870007eff20330a5ad9c0"` [INFO] [stderr] Checking start_world v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:4 [INFO] [stderr] | [INFO] [stderr] 7 | (game_coords as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coords)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | [x,y,BLOCK_SIZE*(width as f64),BLOCK_SIZE*(height as f64)], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:40:55 [INFO] [stderr] | [INFO] [stderr] 40 | [x,y,BLOCK_SIZE*(width as f64),BLOCK_SIZE*(height as f64)], [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn opposite(&self) -> Direction { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match dir { [INFO] [stderr] 67 | | Some(d) => self.direction = d, [INFO] [stderr] 68 | | None => (), [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { self.direction = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match dir { [INFO] [stderr] 106 | | Some(d) => moving_dir = d, [INFO] [stderr] 107 | | None => {} [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { moving_dir = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | for block in &self.body { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:4 [INFO] [stderr] | [INFO] [stderr] 7 | (game_coords as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coords)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | [x,y,BLOCK_SIZE*(width as f64),BLOCK_SIZE*(height as f64)], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:40:55 [INFO] [stderr] | [INFO] [stderr] 40 | [x,y,BLOCK_SIZE*(width as f64),BLOCK_SIZE*(height as f64)], [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn opposite(&self) -> Direction { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match dir { [INFO] [stderr] 67 | | Some(d) => self.direction = d, [INFO] [stderr] 68 | | None => (), [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { self.direction = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match dir { [INFO] [stderr] 106 | | Some(d) => moving_dir = d, [INFO] [stderr] 107 | | None => {} [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { moving_dir = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | for block in &self.body { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.38s [INFO] running `"docker" "inspect" "18650b2c9a6d9a5aacf107637b01d0ae49eb52b3952870007eff20330a5ad9c0"` [INFO] running `"docker" "rm" "-f" "18650b2c9a6d9a5aacf107637b01d0ae49eb52b3952870007eff20330a5ad9c0"` [INFO] [stdout] 18650b2c9a6d9a5aacf107637b01d0ae49eb52b3952870007eff20330a5ad9c0