[INFO] updating cached repository Dracyr/rust_regnbr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Dracyr/rust_regnbr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Dracyr/rust_regnbr" "work/ex/clippy-test-run/sources/stable/gh/Dracyr/rust_regnbr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Dracyr/rust_regnbr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Dracyr/rust_regnbr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dracyr/rust_regnbr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dracyr/rust_regnbr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7693dc9f9c0913238bfdcb1fb50b79050c516c30 [INFO] sha for GitHub repo Dracyr/rust_regnbr: 7693dc9f9c0913238bfdcb1fb50b79050c516c30 [INFO] validating manifest of Dracyr/rust_regnbr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Dracyr/rust_regnbr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Dracyr/rust_regnbr [INFO] finished frobbing Dracyr/rust_regnbr [INFO] frobbed toml for Dracyr/rust_regnbr written to work/ex/clippy-test-run/sources/stable/gh/Dracyr/rust_regnbr/Cargo.toml [INFO] started frobbing Dracyr/rust_regnbr [INFO] finished frobbing Dracyr/rust_regnbr [INFO] frobbed toml for Dracyr/rust_regnbr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dracyr/rust_regnbr/Cargo.toml [INFO] crate Dracyr/rust_regnbr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Dracyr/rust_regnbr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Dracyr/rust_regnbr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83b4360157257e6e56eee414bc5442fac28ca77b1bd3ec4141ddee96a90d15b4 [INFO] running `"docker" "start" "-a" "83b4360157257e6e56eee414bc5442fac28ca77b1bd3ec4141ddee96a90d15b4"` [INFO] [stderr] Checking rust_regnbr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 28 | | if find_duplicate(arg1) { println!("Dubbletter") } else { println!("Ej dubblett") }; [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ help: try: `if find_duplicate(arg1) { println!("Dubbletter") } else { println!("Ej dubblett") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:23:35 [INFO] [stderr] | [INFO] [stderr] 23 | } else if arg1 == "Rgn01.txt" { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 24 | | println!("Dubbletter"); [INFO] [stderr] 25 | | } else if arg1 == "Rgn02.txt" { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | } else if arg1 == "Rgn00.txt" { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 22 | | println!("Dubbletter"); [INFO] [stderr] 23 | | } else if arg1 == "Rgn01.txt" { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_regnbr`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 28 | | if find_duplicate(arg1) { println!("Dubbletter") } else { println!("Ej dubblett") }; [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ help: try: `if find_duplicate(arg1) { println!("Dubbletter") } else { println!("Ej dubblett") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:23:35 [INFO] [stderr] | [INFO] [stderr] 23 | } else if arg1 == "Rgn01.txt" { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 24 | | println!("Dubbletter"); [INFO] [stderr] 25 | | } else if arg1 == "Rgn02.txt" { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | } else if arg1 == "Rgn00.txt" { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 22 | | println!("Dubbletter"); [INFO] [stderr] 23 | | } else if arg1 == "Rgn01.txt" { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_regnbr`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "83b4360157257e6e56eee414bc5442fac28ca77b1bd3ec4141ddee96a90d15b4"` [INFO] running `"docker" "rm" "-f" "83b4360157257e6e56eee414bc5442fac28ca77b1bd3ec4141ddee96a90d15b4"` [INFO] [stdout] 83b4360157257e6e56eee414bc5442fac28ca77b1bd3ec4141ddee96a90d15b4