[INFO] updating cached repository Dooskington/Rostige-Schlange [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Dooskington/Rostige-Schlange [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Dooskington/Rostige-Schlange" "work/ex/clippy-test-run/sources/stable/gh/Dooskington/Rostige-Schlange"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Dooskington/Rostige-Schlange'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Dooskington/Rostige-Schlange" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dooskington/Rostige-Schlange"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dooskington/Rostige-Schlange'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8661151e86b549c3e7ab58b9d0213575066515a6 [INFO] sha for GitHub repo Dooskington/Rostige-Schlange: 8661151e86b549c3e7ab58b9d0213575066515a6 [INFO] validating manifest of Dooskington/Rostige-Schlange on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Dooskington/Rostige-Schlange on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Dooskington/Rostige-Schlange [INFO] finished frobbing Dooskington/Rostige-Schlange [INFO] frobbed toml for Dooskington/Rostige-Schlange written to work/ex/clippy-test-run/sources/stable/gh/Dooskington/Rostige-Schlange/Cargo.toml [INFO] started frobbing Dooskington/Rostige-Schlange [INFO] finished frobbing Dooskington/Rostige-Schlange [INFO] frobbed toml for Dooskington/Rostige-Schlange written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dooskington/Rostige-Schlange/Cargo.toml [INFO] crate Dooskington/Rostige-Schlange has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Dooskington/Rostige-Schlange against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Dooskington/Rostige-Schlange:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5c2cc751faa0eb95a872df65f6d32e16693c276fd43ae90ce33ff17f58ff672 [INFO] running `"docker" "start" "-a" "d5c2cc751faa0eb95a872df65f6d32e16693c276fd43ae90ce33ff17f58ff672"` [INFO] [stderr] Compiling rand v0.3.18 [INFO] [stderr] Compiling x11-dl v2.17.1 [INFO] [stderr] Checking memmap v0.6.1 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Compiling wayland-scanner v0.12.4 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking wayland-sys v0.12.4 [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling wayland-client v0.12.4 [INFO] [stderr] Compiling wayland-protocols v0.12.4 [INFO] [stderr] Compiling gl v0.7.0 [INFO] [stderr] Compiling glutin v0.11.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking wayland-kbd v0.13.0 [INFO] [stderr] Checking wayland-window v0.13.2 [INFO] [stderr] Checking winit v0.9.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking schlange v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/gfx.rs:334:17 [INFO] [stderr] | [INFO] [stderr] 334 | let b: f32 = cell.color.b; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/gfx.rs:334:17 [INFO] [stderr] | [INFO] [stderr] 334 | let b: f32 = cell.color.b; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gfx.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | const VS_SRC: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gfx.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | const FS_SRC: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gfx.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | return shader_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `shader_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:230:12 [INFO] [stderr] | [INFO] [stderr] 230 | } else if game.state == GameState::GameOver { [INFO] [stderr] | ____________^ [INFO] [stderr] 231 | | if is_key_pressed(input_man, VirtualKeyCode::Space) { [INFO] [stderr] 232 | | reset_game(game); [INFO] [stderr] 233 | | } [INFO] [stderr] 234 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 230 | } else if game.state == GameState::GameOver && is_key_pressed(input_man, VirtualKeyCode::Space) { [INFO] [stderr] 231 | reset_game(game); [INFO] [stderr] 232 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gfx.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | const VS_SRC: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gfx.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | const FS_SRC: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gfx.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | return shader_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `shader_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:230:12 [INFO] [stderr] | [INFO] [stderr] 230 | } else if game.state == GameState::GameOver { [INFO] [stderr] | ____________^ [INFO] [stderr] 231 | | if is_key_pressed(input_man, VirtualKeyCode::Space) { [INFO] [stderr] 232 | | reset_game(game); [INFO] [stderr] 233 | | } [INFO] [stderr] 234 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 230 | } else if game.state == GameState::GameOver && is_key_pressed(input_man, VirtualKeyCode::Space) { [INFO] [stderr] 231 | reset_game(game); [INFO] [stderr] 232 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable `fps` is assigned to, but never used [INFO] [stderr] --> src/main.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | let mut fps: u32 = 0; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_fps` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `fps` is never read [INFO] [stderr] --> src/main.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | fps = fps_counter; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `fps` is assigned to, but never used [INFO] [stderr] --> src/main.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | let mut fps: u32 = 0; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_fps` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `fps` is never read [INFO] [stderr] --> src/main.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | fps = fps_counter; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `vao_id` [INFO] [stderr] --> src/gfx.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | vao_id: GLuint, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `COLOR_BLACK` [INFO] [stderr] --> src/gfx.rs:398:1 [INFO] [stderr] | [INFO] [stderr] 398 | pub const COLOR_BLACK: Color = Color { r: 0.0, g: 0.0, b: 0.0, a: 1.0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `COLOR_GRAY` [INFO] [stderr] --> src/gfx.rs:400:1 [INFO] [stderr] | [INFO] [stderr] 400 | pub const COLOR_GRAY: Color = Color { r: 0.4, g: 0.4, b: 0.4, a: 1.0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `COLOR_RED` [INFO] [stderr] --> src/gfx.rs:401:1 [INFO] [stderr] | [INFO] [stderr] 401 | pub const COLOR_RED: Color = Color { r: 1.0, g: 0.0, b: 0.0, a: 1.0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `COLOR_BLUE` [INFO] [stderr] --> src/gfx.rs:403:1 [INFO] [stderr] | [INFO] [stderr] 403 | pub const COLOR_BLUE: Color = Color { r: 0.0, g: 0.0, b: 1.0, a: 1.0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:294:33 [INFO] [stderr] | [INFO] [stderr] 294 | let mut status: GLint = gl::TRUE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:296:22 [INFO] [stderr] | [INFO] [stderr] 296 | if status == (gl::FALSE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:329:26 [INFO] [stderr] | [INFO] [stderr] 329 | let u: f32 = sprite_col as f32 * sprite_width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(sprite_col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:330:26 [INFO] [stderr] | [INFO] [stderr] 330 | let v: f32 = sprite_row as f32 * sprite_height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(sprite_row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:416:16 [INFO] [stderr] | [INFO] [stderr] 416 | r: r as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:417:16 [INFO] [stderr] | [INFO] [stderr] 417 | g: g as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:418:16 [INFO] [stderr] | [INFO] [stderr] 418 | b: b as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:419:16 [INFO] [stderr] | [INFO] [stderr] 419 | a: a as f32 / 255.0 [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/input.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match event { [INFO] [stderr] 45 | | Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 46 | | WindowEvent::Closed => { window.is_close_requested = true; }, [INFO] [stderr] 47 | | WindowEvent::Resized(w, h) => { println!("Resize to {}, {}", w, h); gfx::resize_window(window, w, h); }, [INFO] [stderr] ... | [INFO] [stderr] 51 | | _ => () [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 45 | WindowEvent::Closed => { window.is_close_requested = true; }, [INFO] [stderr] 46 | WindowEvent::Resized(w, h) => { println!("Resize to {}, {}", w, h); gfx::resize_window(window, w, h); }, [INFO] [stderr] 47 | WindowEvent::KeyboardInput { input, .. } => { input::process_key_input(input_man, &input); }, [INFO] [stderr] 48 | _ => () [INFO] [stderr] 49 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: field is never used: `vao_id` [INFO] [stderr] --> src/gfx.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | vao_id: GLuint, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `COLOR_BLACK` [INFO] [stderr] --> src/gfx.rs:398:1 [INFO] [stderr] | [INFO] [stderr] 398 | pub const COLOR_BLACK: Color = Color { r: 0.0, g: 0.0, b: 0.0, a: 1.0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `COLOR_GRAY` [INFO] [stderr] --> src/gfx.rs:400:1 [INFO] [stderr] | [INFO] [stderr] 400 | pub const COLOR_GRAY: Color = Color { r: 0.4, g: 0.4, b: 0.4, a: 1.0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `COLOR_RED` [INFO] [stderr] --> src/gfx.rs:401:1 [INFO] [stderr] | [INFO] [stderr] 401 | pub const COLOR_RED: Color = Color { r: 1.0, g: 0.0, b: 0.0, a: 1.0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `COLOR_BLUE` [INFO] [stderr] --> src/gfx.rs:403:1 [INFO] [stderr] | [INFO] [stderr] 403 | pub const COLOR_BLUE: Color = Color { r: 0.0, g: 0.0, b: 1.0, a: 1.0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stderr] --> src/main.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn new() -> Game { [INFO] [stderr] 76 | | let initial_snake_position: Coordinates = Coordinates::new(15, 8); [INFO] [stderr] 77 | | [INFO] [stderr] 78 | | Game { [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | impl Default for Game { [INFO] [stderr] 75 | fn default() -> Self { [INFO] [stderr] 76 | Self::new() [INFO] [stderr] 77 | } [INFO] [stderr] 78 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `update` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:136:20 [INFO] [stderr] | [INFO] [stderr] 136 | update(&mut input_man, &mut game); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `segments_cloned`. [INFO] [stderr] --> src/main.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | for i in 1..segments_cloned.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 205 | for in segments_cloned.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:294:33 [INFO] [stderr] | [INFO] [stderr] 294 | let mut status: GLint = gl::TRUE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:296:22 [INFO] [stderr] | [INFO] [stderr] 296 | if status == (gl::FALSE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:329:26 [INFO] [stderr] | [INFO] [stderr] 329 | let u: f32 = sprite_col as f32 * sprite_width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(sprite_col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:330:26 [INFO] [stderr] | [INFO] [stderr] 330 | let v: f32 = sprite_row as f32 * sprite_height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(sprite_row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:416:16 [INFO] [stderr] | [INFO] [stderr] 416 | r: r as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:417:16 [INFO] [stderr] | [INFO] [stderr] 417 | g: g as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:418:16 [INFO] [stderr] | [INFO] [stderr] 418 | b: b as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:419:16 [INFO] [stderr] | [INFO] [stderr] 419 | a: a as f32 / 255.0 [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/input.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match event { [INFO] [stderr] 45 | | Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 46 | | WindowEvent::Closed => { window.is_close_requested = true; }, [INFO] [stderr] 47 | | WindowEvent::Resized(w, h) => { println!("Resize to {}, {}", w, h); gfx::resize_window(window, w, h); }, [INFO] [stderr] ... | [INFO] [stderr] 51 | | _ => () [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 45 | WindowEvent::Closed => { window.is_close_requested = true; }, [INFO] [stderr] 46 | WindowEvent::Resized(w, h) => { println!("Resize to {}, {}", w, h); gfx::resize_window(window, w, h); }, [INFO] [stderr] 47 | WindowEvent::KeyboardInput { input, .. } => { input::process_key_input(input_man, &input); }, [INFO] [stderr] 48 | _ => () [INFO] [stderr] 49 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stderr] --> src/main.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn new() -> Game { [INFO] [stderr] 76 | | let initial_snake_position: Coordinates = Coordinates::new(15, 8); [INFO] [stderr] 77 | | [INFO] [stderr] 78 | | Game { [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | impl Default for Game { [INFO] [stderr] 75 | fn default() -> Self { [INFO] [stderr] 76 | Self::new() [INFO] [stderr] 77 | } [INFO] [stderr] 78 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `update` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:136:20 [INFO] [stderr] | [INFO] [stderr] 136 | update(&mut input_man, &mut game); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `segments_cloned`. [INFO] [stderr] --> src/main.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | for i in 1..segments_cloned.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 205 | for in segments_cloned.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 04s [INFO] running `"docker" "inspect" "d5c2cc751faa0eb95a872df65f6d32e16693c276fd43ae90ce33ff17f58ff672"` [INFO] running `"docker" "rm" "-f" "d5c2cc751faa0eb95a872df65f6d32e16693c276fd43ae90ce33ff17f58ff672"` [INFO] [stdout] d5c2cc751faa0eb95a872df65f6d32e16693c276fd43ae90ce33ff17f58ff672