[INFO] updating cached repository Don42/pixelflut-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Don42/pixelflut-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Don42/pixelflut-rs" "work/ex/clippy-test-run/sources/stable/gh/Don42/pixelflut-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Don42/pixelflut-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Don42/pixelflut-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Don42/pixelflut-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Don42/pixelflut-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e6c8a7edb915c30fc8603672b56b820e6af03399 [INFO] sha for GitHub repo Don42/pixelflut-rs: e6c8a7edb915c30fc8603672b56b820e6af03399 [INFO] validating manifest of Don42/pixelflut-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Don42/pixelflut-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Don42/pixelflut-rs [INFO] finished frobbing Don42/pixelflut-rs [INFO] frobbed toml for Don42/pixelflut-rs written to work/ex/clippy-test-run/sources/stable/gh/Don42/pixelflut-rs/Cargo.toml [INFO] started frobbing Don42/pixelflut-rs [INFO] finished frobbing Don42/pixelflut-rs [INFO] frobbed toml for Don42/pixelflut-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Don42/pixelflut-rs/Cargo.toml [INFO] crate Don42/pixelflut-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Don42/pixelflut-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Don42/pixelflut-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8b3cd51e08ba1a5ab68aa46880ea98be1b5101f5abd8c99ebab6e44c819a7508 [INFO] running `"docker" "start" "-a" "8b3cd51e08ba1a5ab68aa46880ea98be1b5101f5abd8c99ebab6e44c819a7508"` [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking piston2d-graphics v0.18.1 [INFO] [stderr] Compiling glutin v0.6.2 [INFO] [stderr] Checking x11-dl v2.17.0 [INFO] [stderr] Checking pistoncore-window v0.23.0 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking wayland-sys v0.5.11 [INFO] [stderr] Checking wayland-client v0.5.12 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking pistoncore-event_loop v0.26.0 [INFO] [stderr] Checking piston v0.26.0 [INFO] [stderr] Checking wayland-window v0.2.3 [INFO] [stderr] Checking wayland-kbd v0.3.6 [INFO] [stderr] Checking piston2d-opengl_graphics v0.35.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.31.0 [INFO] [stderr] Checking pixelflut-rs v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/canvas.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | frame_buffer: frame_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/canvas.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | frame_buffer: frame_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/pixelflut.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | fb.put_pixel((pixel.x as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/pixelflut.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | (pixel.y as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/pixelflut.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | (self.x as u32) < width && (self.y as u32) < height [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/pixelflut.rs:55:36 [INFO] [stderr] | [INFO] [stderr] 55 | (self.x as u32) < width && (self.y as u32) < height [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/pixelflut.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | fb.put_pixel((pixel.x as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(pixel.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/pixelflut.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | (pixel.y as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(pixel.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canvas.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | fn update(&mut self, _: &UpdateArgs) {} [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/server/mod.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | Err(_) => panic!("Connection failed"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / while let Ok(cmd) = rx.recv() { [INFO] [stderr] 32 | | match cmd { [INFO] [stderr] 33 | | Command::Shutdown => { [INFO] [stderr] 34 | | println!("Shutting down"); [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pixelflut-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/pixelflut.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | fb.put_pixel((pixel.x as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/pixelflut.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | (pixel.y as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/pixelflut.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | (self.x as u32) < width && (self.y as u32) < height [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/pixelflut.rs:55:36 [INFO] [stderr] | [INFO] [stderr] 55 | (self.x as u32) < width && (self.y as u32) < height [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/pixelflut.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | fb.put_pixel((pixel.x as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(pixel.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/pixelflut.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | (pixel.y as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(pixel.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canvas.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | fn update(&mut self, _: &UpdateArgs) {} [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/server/mod.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | Err(_) => panic!("Connection failed"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / while let Ok(cmd) = rx.recv() { [INFO] [stderr] 32 | | match cmd { [INFO] [stderr] 33 | | Command::Shutdown => { [INFO] [stderr] 34 | | println!("Shutting down"); [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pixelflut-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8b3cd51e08ba1a5ab68aa46880ea98be1b5101f5abd8c99ebab6e44c819a7508"` [INFO] running `"docker" "rm" "-f" "8b3cd51e08ba1a5ab68aa46880ea98be1b5101f5abd8c99ebab6e44c819a7508"` [INFO] [stdout] 8b3cd51e08ba1a5ab68aa46880ea98be1b5101f5abd8c99ebab6e44c819a7508