[INFO] updating cached repository DomWilliams0/awful-file-browser
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/DomWilliams0/awful-file-browser
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/DomWilliams0/awful-file-browser" "work/ex/clippy-test-run/sources/stable/gh/DomWilliams0/awful-file-browser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DomWilliams0/awful-file-browser'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/DomWilliams0/awful-file-browser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DomWilliams0/awful-file-browser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DomWilliams0/awful-file-browser'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c11c967ea8441e850c11f1d4ce1f36748fbe3902
[INFO] sha for GitHub repo DomWilliams0/awful-file-browser: c11c967ea8441e850c11f1d4ce1f36748fbe3902
[INFO] validating manifest of DomWilliams0/awful-file-browser on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of DomWilliams0/awful-file-browser on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing DomWilliams0/awful-file-browser
[INFO] finished frobbing DomWilliams0/awful-file-browser
[INFO] frobbed toml for DomWilliams0/awful-file-browser written to work/ex/clippy-test-run/sources/stable/gh/DomWilliams0/awful-file-browser/Cargo.toml
[INFO] started frobbing DomWilliams0/awful-file-browser
[INFO] finished frobbing DomWilliams0/awful-file-browser
[INFO] frobbed toml for DomWilliams0/awful-file-browser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DomWilliams0/awful-file-browser/Cargo.toml
[INFO] crate DomWilliams0/awful-file-browser has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting DomWilliams0/awful-file-browser against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DomWilliams0/awful-file-browser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3a912a64351f47d480ec3834a74b55f622d7d1fab2ec8b7ad2116da2a8bd8738
[INFO] running `"docker" "start" "-a" "3a912a64351f47d480ec3834a74b55f622d7d1fab2ec8b7ad2116da2a8bd8738"`
[INFO] [stderr]     Checking awful-file-browser v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:57:24
[INFO] [stderr]    |
[INFO] [stderr] 57 |                        file_type: file_type,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_type`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:57:24
[INFO] [stderr]    |
[INFO] [stderr] 57 |                        file_type: file_type,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_type`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:85:13
[INFO] [stderr]    |
[INFO] [stderr] 85 |             return Err(AwfulError::Args("Directory does not exist"));
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(AwfulError::Args("Directory does not exist"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:103:34
[INFO] [stderr]     |
[INFO] [stderr] 103 |                      Err(err) => return Err(err),
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:85:13
[INFO] [stderr]    |
[INFO] [stderr] 85 |             return Err(AwfulError::Args("Directory does not exist"));
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(AwfulError::Args("Directory does not exist"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:103:34
[INFO] [stderr]     |
[INFO] [stderr] 103 |                      Err(err) => return Err(err),
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ui/repl.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             fb: fb,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `fb`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:53:12
[INFO] [stderr]    |
[INFO] [stderr] 53 |            ui: ui,
[INFO] [stderr]    |            ^^^^^^ help: replace it with: `ui`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ui/repl.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             fb: fb,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `fb`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:53:12
[INFO] [stderr]    |
[INFO] [stderr] 53 |            ui: ui,
[INFO] [stderr]    |            ^^^^^^ help: replace it with: `ui`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/ui/gui/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | mod gui {}
[INFO] [stderr]   | ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/ui/gui/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | mod gui {}
[INFO] [stderr]   | ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:14:33
[INFO] [stderr]    |
[INFO] [stderr] 14 |     match parse_args().and_then(|c| run(c)) {
[INFO] [stderr]    |                                 ^^^^^^^^^^ help: remove closure as shown: `run`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:14:33
[INFO] [stderr]    |
[INFO] [stderr] 14 |     match parse_args().and_then(|c| run(c)) {
[INFO] [stderr]    |                                 ^^^^^^^^^^ help: remove closure as shown: `run`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.76s
[INFO] running `"docker" "inspect" "3a912a64351f47d480ec3834a74b55f622d7d1fab2ec8b7ad2116da2a8bd8738"`
[INFO] running `"docker" "rm" "-f" "3a912a64351f47d480ec3834a74b55f622d7d1fab2ec8b7ad2116da2a8bd8738"`
[INFO] [stdout] 3a912a64351f47d480ec3834a74b55f622d7d1fab2ec8b7ad2116da2a8bd8738