[INFO] updating cached repository DomParfitt/gamdev
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/DomParfitt/gamdev
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/DomParfitt/gamdev" "work/ex/clippy-test-run/sources/stable/gh/DomParfitt/gamdev"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DomParfitt/gamdev'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/DomParfitt/gamdev" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DomParfitt/gamdev"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DomParfitt/gamdev'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d7225a837526dbe085c0ebf171e4acffab213554
[INFO] sha for GitHub repo DomParfitt/gamdev: d7225a837526dbe085c0ebf171e4acffab213554
[INFO] validating manifest of DomParfitt/gamdev on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of DomParfitt/gamdev on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing DomParfitt/gamdev
[INFO] finished frobbing DomParfitt/gamdev
[INFO] frobbed toml for DomParfitt/gamdev written to work/ex/clippy-test-run/sources/stable/gh/DomParfitt/gamdev/Cargo.toml
[INFO] started frobbing DomParfitt/gamdev
[INFO] finished frobbing DomParfitt/gamdev
[INFO] frobbed toml for DomParfitt/gamdev written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DomParfitt/gamdev/Cargo.toml
[INFO] crate DomParfitt/gamdev has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting DomParfitt/gamdev against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DomParfitt/gamdev:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a51af648671eee3f74fe3113bd12945a3bf0f41d1d8c0ea2ec8ed31453e52863
[INFO] running `"docker" "start" "-a" "a51af648671eee3f74fe3113bd12945a3bf0f41d1d8c0ea2ec8ed31453e52863"`
[INFO] [stderr]     Checking png v0.9.0
[INFO] [stderr]     Checking gfx_core v0.7.2
[INFO] [stderr]    Compiling gfx_gl v0.4.0
[INFO] [stderr]    Compiling gl v0.6.5
[INFO] [stderr]     Checking pistoncore-input v0.19.0
[INFO] [stderr]     Checking wayland-window v0.7.0
[INFO] [stderr]     Checking winit v0.7.6
[INFO] [stderr]     Checking image v0.15.0
[INFO] [stderr]     Checking glutin v0.9.2
[INFO] [stderr]     Checking pistoncore-window v0.28.0
[INFO] [stderr]     Checking pistoncore-event_loop v0.33.0
[INFO] [stderr]     Checking piston v0.33.0
[INFO] [stderr]     Checking pistoncore-glutin_window v0.39.1
[INFO] [stderr]     Checking gfx v0.16.3
[INFO] [stderr]     Checking gfx_device_gl v0.14.6
[INFO] [stderr]     Checking piston-gfx_texture v0.26.0
[INFO] [stderr]     Checking piston2d-gfx_graphics v0.43.0
[INFO] [stderr]     Checking piston_window v0.70.0
[INFO] [stderr]     Checking game v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `core::GameEntity`
[INFO] [stderr]  --> src/core/player.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use core::GameEntity;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `core::GameObject`
[INFO] [stderr]  --> src/core/player.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use core::GameObject;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `core::GameObject`
[INFO] [stderr]  --> src/core/enemy.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use core::GameObject;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `core::GameEntity`
[INFO] [stderr]  --> src/core/player.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use core::GameEntity;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `core::GameObject`
[INFO] [stderr]  --> src/core/player.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use core::GameObject;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `core::GameObject`
[INFO] [stderr]  --> src/core/enemy.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use core::GameObject;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `other`
[INFO] [stderr]   --> src/core/enemy.rs:96:46
[INFO] [stderr]    |
[INFO] [stderr] 96 |     fn check_collision<C: Collidable>(&self, other: C) -> bool {
[INFO] [stderr]    |                                              ^^^^^ help: consider using `_other` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `other`
[INFO] [stderr]    --> src/core/enemy.rs:102:46
[INFO] [stderr]     |
[INFO] [stderr] 102 |     fn check_collision<C: Collidable>(&self, other: C) -> bool {
[INFO] [stderr]     |                                              ^^^^^ help: consider using `_other` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `context`
[INFO] [stderr]   --> src/core/obstacle.rs:32:22
[INFO] [stderr]    |
[INFO] [stderr] 32 |     fn render(&self, context: Context, graphics: &mut G2d) {
[INFO] [stderr]    |                      ^^^^^^^ help: consider using `_context` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `graphics`
[INFO] [stderr]   --> src/core/obstacle.rs:32:40
[INFO] [stderr]    |
[INFO] [stderr] 32 |     fn render(&self, context: Context, graphics: &mut G2d) {
[INFO] [stderr]    |                                        ^^^^^^^^ help: consider using `_graphics` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `other`
[INFO] [stderr]   --> src/core/obstacle.rs:38:46
[INFO] [stderr]    |
[INFO] [stderr] 38 |     fn check_collision<C: Collidable>(&self, other: C) -> bool {
[INFO] [stderr]    |                                              ^^^^^ help: consider using `_other` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `other`
[INFO] [stderr]   --> src/core/obstacle.rs:44:46
[INFO] [stderr]    |
[INFO] [stderr] 44 |     fn check_collision<C: Collidable>(&self, other: C) -> bool {
[INFO] [stderr]    |                                              ^^^^^ help: consider using `_other` instead
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `core::gamestate::GameState`
[INFO] [stderr]   --> src/core/gamestate.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn new() -> Self {
[INFO] [stderr] 19 | |         GameState {
[INFO] [stderr] 20 | |             player: Player::new(),
[INFO] [stderr] 21 | |             enemies: vec!(Enemy::new()),
[INFO] [stderr] 22 | |             obstacles: vec!(Obstacle::new()),
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 17 | impl Default for core::gamestate::GameState {
[INFO] [stderr] 18 |     fn default() -> Self {
[INFO] [stderr] 19 |         Self::new()
[INFO] [stderr] 20 |     }
[INFO] [stderr] 21 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/core/gamestate.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 | /         match button{
[INFO] [stderr] 28 | |             Button::Keyboard(key) => {
[INFO] [stderr] 29 | |                 match key {
[INFO] [stderr] 30 | |                     Key::Up => {
[INFO] [stderr] ...  |
[INFO] [stderr] 39 | |             _ => {},
[INFO] [stderr] 40 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 27 |         if let Button::Keyboard(key) = button {
[INFO] [stderr] 28 |     match key {
[INFO] [stderr] 29 |         Key::Up => {
[INFO] [stderr] 30 |             self.player.jump();
[INFO] [stderr] 31 |         },
[INFO] [stderr] 32 |         Key::Down => {},
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `core::player::Player`
[INFO] [stderr]   --> src/core/player.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     pub fn new() -> Self {
[INFO] [stderr] 26 | |         Player {
[INFO] [stderr] 27 | |             position: Position::from((200.0, 300.0)),
[INFO] [stderr] 28 | |             size: Size::from((100.0, 100.0)),
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |         }
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 23 | impl Default for core::player::Player {
[INFO] [stderr] 24 |     fn default() -> Self {
[INFO] [stderr] 25 |         Self::new()
[INFO] [stderr] 26 |     }
[INFO] [stderr] 27 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/core/player.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 | /         match button {
[INFO] [stderr] 42 | |             Button::Keyboard(Key::Up) => {
[INFO] [stderr] 43 | |                 self.jump();
[INFO] [stderr] 44 | |             }
[INFO] [stderr] 45 | |             _ => {}
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 41 |         if let Button::Keyboard(Key::Up) = button {
[INFO] [stderr] 42 |     self.jump();
[INFO] [stderr] 43 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/core/player.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 |         self.jump_height = self.jump_height + 10.0;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.jump_height += 10.0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]   --> src/core/player.rs:66:16
[INFO] [stderr]    |
[INFO] [stderr] 66 |             if self.jump_pause <= 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]    = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.jump_pause == 0 instead
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/core/player.rs:67:17
[INFO] [stderr]    |
[INFO] [stderr] 67 |                 self.jump_height = self.jump_height - 10.0;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.jump_height -= 10.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/core/player.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |                 self.jump_pause = self.jump_pause - 1;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.jump_pause -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/core/player.rs:90:9
[INFO] [stderr]    |
[INFO] [stderr] 90 | /         let mut color = [0.0, 0.0, 0.0, 1.0];
[INFO] [stderr] 91 | |         if self.has_collided {
[INFO] [stderr] 92 | |             color = [0.0, 0.0, 1.0, 1.0];
[INFO] [stderr] 93 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> color = if self.has_collided { [0.0, 0.0, 1.0, 1.0] } else { [0.0, 0.0, 0.0, 1.0] };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `core::enemy::Enemy`
[INFO] [stderr]   --> src/core/enemy.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     pub fn new() -> Self {
[INFO] [stderr] 21 | |         Enemy {
[INFO] [stderr] 22 | |             position: Position::from((700.0, 300.0)),
[INFO] [stderr] 23 | |             size: Size::from((100.0, 100.0)),
[INFO] [stderr] 24 | |             has_collided: false,
[INFO] [stderr] 25 | |         }
[INFO] [stderr] 26 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 19 | impl Default for core::enemy::Enemy {
[INFO] [stderr] 20 |     fn default() -> Self {
[INFO] [stderr] 21 |         Self::new()
[INFO] [stderr] 22 |     }
[INFO] [stderr] 23 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `core::obstacle::Obstacle`
[INFO] [stderr]   --> src/core/obstacle.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn new() -> Self {
[INFO] [stderr] 19 | |         Obstacle {
[INFO] [stderr] 20 | |             position: Position::from((10.0, 10.0)),
[INFO] [stderr] 21 | |             size: Size::from((10.0, 10.0)),
[INFO] [stderr] 22 | |         }
[INFO] [stderr] 23 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 17 | impl Default for core::obstacle::Obstacle {
[INFO] [stderr] 18 |     fn default() -> Self {
[INFO] [stderr] 19 |         Self::new()
[INFO] [stderr] 20 |     }
[INFO] [stderr] 21 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `core::GameObject`
[INFO] [stderr]   --> src/core/mod.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     pub fn new() -> Self {
[INFO] [stderr] 22 | |         GameObject::from(vec!(0.0, 0.0, 0.0, 0.0))
[INFO] [stderr] 23 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `game`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unused variable: `other`
[INFO] [stderr]   --> src/core/enemy.rs:96:46
[INFO] [stderr]    |
[INFO] [stderr] 96 |     fn check_collision<C: Collidable>(&self, other: C) -> bool {
[INFO] [stderr]    |                                              ^^^^^ help: consider using `_other` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `other`
[INFO] [stderr]    --> src/core/enemy.rs:102:46
[INFO] [stderr]     |
[INFO] [stderr] 102 |     fn check_collision<C: Collidable>(&self, other: C) -> bool {
[INFO] [stderr]     |                                              ^^^^^ help: consider using `_other` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `context`
[INFO] [stderr]   --> src/core/obstacle.rs:32:22
[INFO] [stderr]    |
[INFO] [stderr] 32 |     fn render(&self, context: Context, graphics: &mut G2d) {
[INFO] [stderr]    |                      ^^^^^^^ help: consider using `_context` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `graphics`
[INFO] [stderr]   --> src/core/obstacle.rs:32:40
[INFO] [stderr]    |
[INFO] [stderr] 32 |     fn render(&self, context: Context, graphics: &mut G2d) {
[INFO] [stderr]    |                                        ^^^^^^^^ help: consider using `_graphics` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `other`
[INFO] [stderr]   --> src/core/obstacle.rs:38:46
[INFO] [stderr]    |
[INFO] [stderr] 38 |     fn check_collision<C: Collidable>(&self, other: C) -> bool {
[INFO] [stderr]    |                                              ^^^^^ help: consider using `_other` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `other`
[INFO] [stderr]   --> src/core/obstacle.rs:44:46
[INFO] [stderr]    |
[INFO] [stderr] 44 |     fn check_collision<C: Collidable>(&self, other: C) -> bool {
[INFO] [stderr]    |                                              ^^^^^ help: consider using `_other` instead
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `core::gamestate::GameState`
[INFO] [stderr]   --> src/core/gamestate.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn new() -> Self {
[INFO] [stderr] 19 | |         GameState {
[INFO] [stderr] 20 | |             player: Player::new(),
[INFO] [stderr] 21 | |             enemies: vec!(Enemy::new()),
[INFO] [stderr] 22 | |             obstacles: vec!(Obstacle::new()),
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 17 | impl Default for core::gamestate::GameState {
[INFO] [stderr] 18 |     fn default() -> Self {
[INFO] [stderr] 19 |         Self::new()
[INFO] [stderr] 20 |     }
[INFO] [stderr] 21 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/core/gamestate.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 | /         match button{
[INFO] [stderr] 28 | |             Button::Keyboard(key) => {
[INFO] [stderr] 29 | |                 match key {
[INFO] [stderr] 30 | |                     Key::Up => {
[INFO] [stderr] ...  |
[INFO] [stderr] 39 | |             _ => {},
[INFO] [stderr] 40 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 27 |         if let Button::Keyboard(key) = button {
[INFO] [stderr] 28 |     match key {
[INFO] [stderr] 29 |         Key::Up => {
[INFO] [stderr] 30 |             self.player.jump();
[INFO] [stderr] 31 |         },
[INFO] [stderr] 32 |         Key::Down => {},
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `core::player::Player`
[INFO] [stderr]   --> src/core/player.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     pub fn new() -> Self {
[INFO] [stderr] 26 | |         Player {
[INFO] [stderr] 27 | |             position: Position::from((200.0, 300.0)),
[INFO] [stderr] 28 | |             size: Size::from((100.0, 100.0)),
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |         }
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 23 | impl Default for core::player::Player {
[INFO] [stderr] 24 |     fn default() -> Self {
[INFO] [stderr] 25 |         Self::new()
[INFO] [stderr] 26 |     }
[INFO] [stderr] 27 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/core/player.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 | /         match button {
[INFO] [stderr] 42 | |             Button::Keyboard(Key::Up) => {
[INFO] [stderr] 43 | |                 self.jump();
[INFO] [stderr] 44 | |             }
[INFO] [stderr] 45 | |             _ => {}
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 41 |         if let Button::Keyboard(Key::Up) = button {
[INFO] [stderr] 42 |     self.jump();
[INFO] [stderr] 43 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/core/player.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 |         self.jump_height = self.jump_height + 10.0;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.jump_height += 10.0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]   --> src/core/player.rs:66:16
[INFO] [stderr]    |
[INFO] [stderr] 66 |             if self.jump_pause <= 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]    = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.jump_pause == 0 instead
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/core/player.rs:67:17
[INFO] [stderr]    |
[INFO] [stderr] 67 |                 self.jump_height = self.jump_height - 10.0;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.jump_height -= 10.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/core/player.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |                 self.jump_pause = self.jump_pause - 1;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.jump_pause -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/core/player.rs:90:9
[INFO] [stderr]    |
[INFO] [stderr] 90 | /         let mut color = [0.0, 0.0, 0.0, 1.0];
[INFO] [stderr] 91 | |         if self.has_collided {
[INFO] [stderr] 92 | |             color = [0.0, 0.0, 1.0, 1.0];
[INFO] [stderr] 93 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> color = if self.has_collided { [0.0, 0.0, 1.0, 1.0] } else { [0.0, 0.0, 0.0, 1.0] };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `core::enemy::Enemy`
[INFO] [stderr]   --> src/core/enemy.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     pub fn new() -> Self {
[INFO] [stderr] 21 | |         Enemy {
[INFO] [stderr] 22 | |             position: Position::from((700.0, 300.0)),
[INFO] [stderr] 23 | |             size: Size::from((100.0, 100.0)),
[INFO] [stderr] 24 | |             has_collided: false,
[INFO] [stderr] 25 | |         }
[INFO] [stderr] 26 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 19 | impl Default for core::enemy::Enemy {
[INFO] [stderr] 20 |     fn default() -> Self {
[INFO] [stderr] 21 |         Self::new()
[INFO] [stderr] 22 |     }
[INFO] [stderr] 23 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `core::obstacle::Obstacle`
[INFO] [stderr]   --> src/core/obstacle.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn new() -> Self {
[INFO] [stderr] 19 | |         Obstacle {
[INFO] [stderr] 20 | |             position: Position::from((10.0, 10.0)),
[INFO] [stderr] 21 | |             size: Size::from((10.0, 10.0)),
[INFO] [stderr] 22 | |         }
[INFO] [stderr] 23 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 17 | impl Default for core::obstacle::Obstacle {
[INFO] [stderr] 18 |     fn default() -> Self {
[INFO] [stderr] 19 |         Self::new()
[INFO] [stderr] 20 |     }
[INFO] [stderr] 21 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `core::GameObject`
[INFO] [stderr]   --> src/core/mod.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     pub fn new() -> Self {
[INFO] [stderr] 22 | |         GameObject::from(vec!(0.0, 0.0, 0.0, 0.0))
[INFO] [stderr] 23 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `game`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "a51af648671eee3f74fe3113bd12945a3bf0f41d1d8c0ea2ec8ed31453e52863"`
[INFO] running `"docker" "rm" "-f" "a51af648671eee3f74fe3113bd12945a3bf0f41d1d8c0ea2ec8ed31453e52863"`
[INFO] [stdout] a51af648671eee3f74fe3113bd12945a3bf0f41d1d8c0ea2ec8ed31453e52863