[INFO] updating cached repository DomParfitt/chip-8 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DomParfitt/chip-8 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DomParfitt/chip-8" "work/ex/clippy-test-run/sources/stable/gh/DomParfitt/chip-8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DomParfitt/chip-8'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DomParfitt/chip-8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DomParfitt/chip-8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DomParfitt/chip-8'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3d5eb2d9969b9621efbcd7efbd3956c473e75861 [INFO] sha for GitHub repo DomParfitt/chip-8: 3d5eb2d9969b9621efbcd7efbd3956c473e75861 [INFO] validating manifest of DomParfitt/chip-8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DomParfitt/chip-8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DomParfitt/chip-8 [INFO] finished frobbing DomParfitt/chip-8 [INFO] frobbed toml for DomParfitt/chip-8 written to work/ex/clippy-test-run/sources/stable/gh/DomParfitt/chip-8/Cargo.toml [INFO] started frobbing DomParfitt/chip-8 [INFO] finished frobbing DomParfitt/chip-8 [INFO] frobbed toml for DomParfitt/chip-8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DomParfitt/chip-8/Cargo.toml [INFO] crate DomParfitt/chip-8 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DomParfitt/chip-8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DomParfitt/chip-8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7e06de155b118656d175f6bddea32980813f232c2ea1ae3b275033a49669d056 [INFO] running `"docker" "start" "-a" "7e06de155b118656d175f6bddea32980813f232c2ea1ae3b275033a49669d056"` [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking emu v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/chip8/mod.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/chip8/mod.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/chip8/mod.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/chip8/mod.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/chip8/mod.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/chip8/mod.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused import: `Duration` [INFO] [stderr] --> src/main.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | use std::time::{Duration, Instant}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip8/mod.rs:411:30 [INFO] [stderr] | [INFO] [stderr] 411 | let mut result: u8 = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip8/mod.rs:414:36 [INFO] [stderr] | [INFO] [stderr] 414 | result = result | (0b10000000 >> i) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip8/mod.rs:424:37 [INFO] [stderr] | [INFO] [stderr] 424 | array[i] = temp_byte & (0b10000000 >> i) != 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Duration` [INFO] [stderr] --> src/main.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | use std::time::{Duration, Instant}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip8/mod.rs:411:30 [INFO] [stderr] | [INFO] [stderr] 411 | let mut result: u8 = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip8/mod.rs:414:36 [INFO] [stderr] | [INFO] [stderr] 414 | result = result | (0b10000000 >> i) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip8/mod.rs:424:37 [INFO] [stderr] | [INFO] [stderr] 424 | array[i] = temp_byte & (0b10000000 >> i) != 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable `high` is assigned to, but never used [INFO] [stderr] --> src/assembler/mod.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | let mut high: u8; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_high` instead [INFO] [stderr] [INFO] [stderr] warning: variable `low` is assigned to, but never used [INFO] [stderr] --> src/assembler/mod.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let mut low: u8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_low` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `high` is never read [INFO] [stderr] --> src/assembler/mod.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | high = (0x8 << 8) | get_register_number(x); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `low` is never read [INFO] [stderr] --> src/assembler/mod.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | low = (get_register_number(y) << 8) | 0x2; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `high` is never read [INFO] [stderr] --> src/assembler/mod.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | high = 0x00; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `low` is never read [INFO] [stderr] --> src/assembler/mod.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | low = 0xE0; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `high` is never read [INFO] [stderr] --> src/assembler/mod.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | high = 0x00; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `low` is never read [INFO] [stderr] --> src/assembler/mod.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | low = 0xEE; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `high` is never read [INFO] [stderr] --> src/assembler/mod.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | high = (0x3 << 4) | get_register_number(register_token); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `low` is never read [INFO] [stderr] --> src/assembler/mod.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | low = get_register_number(tokens[i]) << 4; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `low` is never read [INFO] [stderr] --> src/assembler/mod.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | low = u8::from_str_radix(tokens[i], 16).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `high` is never read [INFO] [stderr] --> src/assembler/mod.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | _ => {high = 0x00; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `low` is never read [INFO] [stderr] --> src/assembler/mod.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | low = 0xE0;}//panic!("Unrecognised token."), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `operand` [INFO] [stderr] --> src/assembler/mod.rs:70:34 [INFO] [stderr] | [INFO] [stderr] 70 | fn assemble_opcode(opcode: &str, operand: &str) -> (u8, u8) { [INFO] [stderr] | ^^^^^^^ help: consider using `_operand` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `now` [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let mut now = Instant::now(); [INFO] [stderr] | ^^^ help: consider using `_now` instead [INFO] [stderr] [INFO] [stderr] warning: variable `cycle_count` is assigned to, but never used [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let mut cycle_count = 0; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_cycle_count` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `high_byte` [INFO] [stderr] --> src/chip8/mod.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | let high_byte = opcode.high_byte; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_high_byte` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `high_byte` [INFO] [stderr] --> src/chip8/mod.rs:442:13 [INFO] [stderr] | [INFO] [stderr] 442 | let high_byte = opcode.high_byte; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_high_byte` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let mut now = Instant::now(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `high` is assigned to, but never used [INFO] [stderr] --> src/assembler/mod.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | let mut high: u8; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_high` instead [INFO] [stderr] [INFO] [stderr] warning: variable `low` is assigned to, but never used [INFO] [stderr] --> src/assembler/mod.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let mut low: u8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_low` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `high` is never read [INFO] [stderr] --> src/assembler/mod.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | high = (0x8 << 8) | get_register_number(x); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `low` is never read [INFO] [stderr] --> src/assembler/mod.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | low = (get_register_number(y) << 8) | 0x2; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `high` is never read [INFO] [stderr] --> src/assembler/mod.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | high = 0x00; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `low` is never read [INFO] [stderr] --> src/assembler/mod.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | low = 0xE0; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `high` is never read [INFO] [stderr] --> src/assembler/mod.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | high = 0x00; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `low` is never read [INFO] [stderr] --> src/assembler/mod.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | low = 0xEE; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `high` is never read [INFO] [stderr] --> src/assembler/mod.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | high = (0x3 << 4) | get_register_number(register_token); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `low` is never read [INFO] [stderr] --> src/assembler/mod.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | low = get_register_number(tokens[i]) << 4; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `low` is never read [INFO] [stderr] --> src/assembler/mod.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | low = u8::from_str_radix(tokens[i], 16).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `high` is never read [INFO] [stderr] --> src/assembler/mod.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | _ => {high = 0x00; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `low` is never read [INFO] [stderr] --> src/assembler/mod.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | low = 0xE0;}//panic!("Unrecognised token."), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `operand` [INFO] [stderr] --> src/assembler/mod.rs:70:34 [INFO] [stderr] | [INFO] [stderr] 70 | fn assemble_opcode(opcode: &str, operand: &str) -> (u8, u8) { [INFO] [stderr] | ^^^^^^^ help: consider using `_operand` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `now` [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let mut now = Instant::now(); [INFO] [stderr] | ^^^ help: consider using `_now` instead [INFO] [stderr] [INFO] [stderr] warning: variable `cycle_count` is assigned to, but never used [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let mut cycle_count = 0; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_cycle_count` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `high_byte` [INFO] [stderr] --> src/chip8/mod.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | let high_byte = opcode.high_byte; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_high_byte` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `high_byte` [INFO] [stderr] --> src/chip8/mod.rs:442:13 [INFO] [stderr] | [INFO] [stderr] 442 | let high_byte = opcode.high_byte; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_high_byte` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/assembler/mod.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | let mut assembled_program: Vec = Vec::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/assembler/mod.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | let mut high: u8; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/assembler/mod.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | let mut low: u8; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let mut now = Instant::now(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/assembler/mod.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | let mut assembled_program: Vec = Vec::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/assembler/mod.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | let mut high: u8; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/assembler/mod.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | let mut low: u8; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `assemble` [INFO] [stderr] --> src/assembler/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn assemble(program: String) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `assemble_opcode` [INFO] [stderr] --> src/assembler/mod.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | fn assemble_opcode(opcode: &str, operand: &str) -> (u8, u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_register_number` [INFO] [stderr] --> src/assembler/mod.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | fn get_register_number(token: &str) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load_program` [INFO] [stderr] --> src/chip8/mod.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn load_program(&mut self, program: Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print_display` [INFO] [stderr] --> src/chip8/mod.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn print_display(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `high_nibble_from_byte` [INFO] [stderr] --> src/chip8/mod.rs:402:5 [INFO] [stderr] | [INFO] [stderr] 402 | fn high_nibble_from_byte(byte: u8) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `low_nibble_from_byte` [INFO] [stderr] --> src/chip8/mod.rs:406:5 [INFO] [stderr] | [INFO] [stderr] 406 | fn low_nibble_from_byte(byte: u8) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: attempt to shift left with overflow [INFO] [stderr] --> src/assembler/mod.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | high = (0x8 << 8) | get_register_number(x); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(exceeding_bitshifts)] on by default [INFO] [stderr] [INFO] [stderr] error: attempt to shift left with overflow [INFO] [stderr] --> src/assembler/mod.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | low = (get_register_number(y) << 8) | 0x2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/assembler/mod.rs:6:43 [INFO] [stderr] | [INFO] [stderr] 6 | let tokens: Vec<&str> = program.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/assembler/mod.rs:43:42 [INFO] [stderr] | [INFO] [stderr] 43 | if tokens[i].starts_with("V") { [INFO] [stderr] | ^^^ help: try using a char instead: `'V'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: structure field `V` should have a snake case name such as `v` [INFO] [stderr] --> src/chip8/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub V: [u8; 16], [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `I` should have a snake case name such as `i` [INFO] [stderr] --> src/chip8/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub I: u16, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `program` [INFO] [stderr] --> src/chip8/mod.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | for i in 0..program.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 54 | for (i, ) in program.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/chip8/mod.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | for i in 0..program.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try replacing the loop by: `self.memory[FIRST_ADDRESS..(program.len() + FIRST_ADDRESS)].clone_from_slice(&program[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buffer` [INFO] [stderr] --> src/chip8/mod.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | for i in 0..size { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 63 | for (i, ) in buffer.iter().enumerate().take(size) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/chip8/mod.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | for i in 0..size { [INFO] [stderr] | ^^^^^^^ help: try replacing the loop by: `self.memory[FIRST_ADDRESS..(size + FIRST_ADDRESS)].clone_from_slice(&buffer[..size])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `pixel_byte` [INFO] [stderr] --> src/chip8/mod.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 116 | for (i, ) in pixel_byte.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fonts` [INFO] [stderr] --> src/chip8/mod.rs:128:18 [INFO] [stderr] | [INFO] [stderr] 128 | for i in 0..fonts.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 128 | for (i, ) in fonts.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/chip8/mod.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | / fn decode_opcode(&mut self, opcode: u16) { [INFO] [stderr] 142 | | // println!("Executing: {}", self.print_opcode(opcode)); [INFO] [stderr] 143 | | [INFO] [stderr] 144 | | let opcode = opcode::Opcode::from(opcode); [INFO] [stderr] ... | [INFO] [stderr] 369 | | } [INFO] [stderr] 370 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test` [INFO] [stderr] --> src/assembler/tests.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn test() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `assemble` [INFO] [stderr] --> src/assembler/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn assemble(program: String) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `assemble_opcode` [INFO] [stderr] --> src/assembler/mod.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | fn assemble_opcode(opcode: &str, operand: &str) -> (u8, u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_register_number` [INFO] [stderr] --> src/assembler/mod.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | fn get_register_number(token: &str) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print_display` [INFO] [stderr] --> src/chip8/mod.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn print_display(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `high_nibble_from_byte` [INFO] [stderr] --> src/chip8/mod.rs:402:5 [INFO] [stderr] | [INFO] [stderr] 402 | fn high_nibble_from_byte(byte: u8) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `low_nibble_from_byte` [INFO] [stderr] --> src/chip8/mod.rs:406:5 [INFO] [stderr] | [INFO] [stderr] 406 | fn low_nibble_from_byte(byte: u8) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/mod.rs:204:30 [INFO] [stderr] | [INFO] [stderr] 204 | let mut vx = self.V[x] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.V[x])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/mod.rs:205:23 [INFO] [stderr] | [INFO] [stderr] 205 | vx += low_byte as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 214 | self.V[x] = self.V[x] | self.V[y]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.V[x] |= self.V[y]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:217:25 [INFO] [stderr] | [INFO] [stderr] 217 | self.V[x] = self.V[x] & self.V[y]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.V[x] &= self.V[y]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:220:25 [INFO] [stderr] | [INFO] [stderr] 220 | self.V[x] = self.V[x] ^ self.V[y]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.V[x] ^= self.V[y]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/chip8/mod.rs:224:25 [INFO] [stderr] | [INFO] [stderr] 224 | / let mut vf: u8 = 0; [INFO] [stderr] 225 | | if result > 0xFF { [INFO] [stderr] 226 | | vf = 1; [INFO] [stderr] 227 | | } [INFO] [stderr] | |_________________________^ help: it is more idiomatic to write: `let vf = if result > 0xFF { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/chip8/mod.rs:223:43 [INFO] [stderr] | [INFO] [stderr] 223 | let result: u16 = u16::from(self.V[x] as u16 + self.V[y] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `u16::from()`: `self.V[x] as u16 + self.V[y] as u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/mod.rs:223:53 [INFO] [stderr] | [INFO] [stderr] 223 | let result: u16 = u16::from(self.V[x] as u16 + self.V[y] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.V[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/mod.rs:223:72 [INFO] [stderr] | [INFO] [stderr] 223 | let result: u16 = u16::from(self.V[x] as u16 + self.V[y] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.V[y])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/chip8/mod.rs:240:25 [INFO] [stderr] | [INFO] [stderr] 240 | / let mut vf: u8 = 0; [INFO] [stderr] 241 | | if self.V[x] & 0x1 == 1 { [INFO] [stderr] 242 | | vf = 1; [INFO] [stderr] 243 | | } [INFO] [stderr] | |_________________________^ help: it is more idiomatic to write: `let vf = if self.V[x] & 0x1 == 1 { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:245:25 [INFO] [stderr] | [INFO] [stderr] 245 | self.V[x] = self.V[x] >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.V[x] >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/chip8/mod.rs:256:25 [INFO] [stderr] | [INFO] [stderr] 256 | / let mut vf: u8 = 0; [INFO] [stderr] 257 | | if self.V[x] & 0x80 == 1 { [INFO] [stderr] 258 | | vf = 1; [INFO] [stderr] 259 | | } [INFO] [stderr] | |_________________________^ help: it is more idiomatic to write: `let vf = if self.V[x] & 0x80 == 1 { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: incompatible bit mask: `_ & 128` can never be equal to `1` [INFO] [stderr] --> src/chip8/mod.rs:257:28 [INFO] [stderr] | [INFO] [stderr] 257 | if self.V[x] & 0x80 == 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::bad_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:261:25 [INFO] [stderr] | [INFO] [stderr] 261 | self.V[x] = self.V[x] << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.V[x] <<= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `array` [INFO] [stderr] --> src/chip8/mod.rs:412:18 [INFO] [stderr] | [INFO] [stderr] 412 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 412 | for (i, ) in array.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: attempt to shift left with overflow [INFO] [stderr] --> src/assembler/mod.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | high = (0x8 << 8) | get_register_number(x); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(exceeding_bitshifts)] on by default [INFO] [stderr] [INFO] [stderr] error: attempt to shift left with overflow [INFO] [stderr] --> src/assembler/mod.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | low = (get_register_number(y) << 8) | 0x2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:414:17 [INFO] [stderr] | [INFO] [stderr] 414 | result = result | (0b10000000 >> i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result |= (0b10000000 >> i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `array` [INFO] [stderr] --> src/chip8/mod.rs:422:18 [INFO] [stderr] | [INFO] [stderr] 422 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 422 | for (i, ) in array.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/assembler/mod.rs:6:43 [INFO] [stderr] | [INFO] [stderr] 6 | let tokens: Vec<&str> = program.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `pixels` [INFO] [stderr] --> src/chip8/mod.rs:434:18 [INFO] [stderr] | [INFO] [stderr] 434 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 434 | for (i, ) in pixels.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/assembler/mod.rs:43:42 [INFO] [stderr] | [INFO] [stderr] 43 | if tokens[i].starts_with("V") { [INFO] [stderr] | ^^^ help: try using a char instead: `'V'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: structure field `V` should have a snake case name such as `v` [INFO] [stderr] --> src/chip8/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub V: [u8; 16], [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `I` should have a snake case name such as `i` [INFO] [stderr] --> src/chip8/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub I: u16, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `program` [INFO] [stderr] --> src/chip8/mod.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | for i in 0..program.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 54 | for (i, ) in program.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/chip8/mod.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | for i in 0..program.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try replacing the loop by: `self.memory[FIRST_ADDRESS..(program.len() + FIRST_ADDRESS)].clone_from_slice(&program[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buffer` [INFO] [stderr] --> src/chip8/mod.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | for i in 0..size { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 63 | for (i, ) in buffer.iter().enumerate().take(size) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/chip8/mod.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | for i in 0..size { [INFO] [stderr] | ^^^^^^^ help: try replacing the loop by: `self.memory[FIRST_ADDRESS..(size + FIRST_ADDRESS)].clone_from_slice(&buffer[..size])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/chip8/mod.rs:452:21 [INFO] [stderr] | [INFO] [stderr] 452 | format!("CLR - Clear Display") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"CLR - Clear Display".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/chip8/mod.rs:455:21 [INFO] [stderr] | [INFO] [stderr] 455 | format!("RET - Return from sub") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"RET - Return from sub".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `pixel_byte` [INFO] [stderr] --> src/chip8/mod.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 116 | for (i, ) in pixel_byte.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fonts` [INFO] [stderr] --> src/chip8/mod.rs:128:18 [INFO] [stderr] | [INFO] [stderr] 128 | for i in 0..fonts.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 128 | for (i, ) in fonts.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/chip8/mod.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | / fn decode_opcode(&mut self, opcode: u16) { [INFO] [stderr] 142 | | // println!("Executing: {}", self.print_opcode(opcode)); [INFO] [stderr] 143 | | [INFO] [stderr] 144 | | let opcode = opcode::Opcode::from(opcode); [INFO] [stderr] ... | [INFO] [stderr] 369 | | } [INFO] [stderr] 370 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/mod.rs:204:30 [INFO] [stderr] | [INFO] [stderr] 204 | let mut vx = self.V[x] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.V[x])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/mod.rs:205:23 [INFO] [stderr] | [INFO] [stderr] 205 | vx += low_byte as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 214 | self.V[x] = self.V[x] | self.V[y]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.V[x] |= self.V[y]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:217:25 [INFO] [stderr] | [INFO] [stderr] 217 | self.V[x] = self.V[x] & self.V[y]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.V[x] &= self.V[y]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:220:25 [INFO] [stderr] | [INFO] [stderr] 220 | self.V[x] = self.V[x] ^ self.V[y]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.V[x] ^= self.V[y]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/chip8/mod.rs:224:25 [INFO] [stderr] | [INFO] [stderr] 224 | / let mut vf: u8 = 0; [INFO] [stderr] 225 | | if result > 0xFF { [INFO] [stderr] 226 | | vf = 1; [INFO] [stderr] 227 | | } [INFO] [stderr] | |_________________________^ help: it is more idiomatic to write: `let vf = if result > 0xFF { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/chip8/mod.rs:223:43 [INFO] [stderr] | [INFO] [stderr] 223 | let result: u16 = u16::from(self.V[x] as u16 + self.V[y] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `u16::from()`: `self.V[x] as u16 + self.V[y] as u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/mod.rs:223:53 [INFO] [stderr] | [INFO] [stderr] 223 | let result: u16 = u16::from(self.V[x] as u16 + self.V[y] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.V[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/mod.rs:223:72 [INFO] [stderr] | [INFO] [stderr] 223 | let result: u16 = u16::from(self.V[x] as u16 + self.V[y] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.V[y])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/chip8/mod.rs:240:25 [INFO] [stderr] | [INFO] [stderr] 240 | / let mut vf: u8 = 0; [INFO] [stderr] 241 | | if self.V[x] & 0x1 == 1 { [INFO] [stderr] 242 | | vf = 1; [INFO] [stderr] 243 | | } [INFO] [stderr] | |_________________________^ help: it is more idiomatic to write: `let vf = if self.V[x] & 0x1 == 1 { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:245:25 [INFO] [stderr] | [INFO] [stderr] 245 | self.V[x] = self.V[x] >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.V[x] >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/chip8/mod.rs:256:25 [INFO] [stderr] | [INFO] [stderr] 256 | / let mut vf: u8 = 0; [INFO] [stderr] 257 | | if self.V[x] & 0x80 == 1 { [INFO] [stderr] 258 | | vf = 1; [INFO] [stderr] 259 | | } [INFO] [stderr] | |_________________________^ help: it is more idiomatic to write: `let vf = if self.V[x] & 0x80 == 1 { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: incompatible bit mask: `_ & 128` can never be equal to `1` [INFO] [stderr] --> src/chip8/mod.rs:257:28 [INFO] [stderr] | [INFO] [stderr] 257 | if self.V[x] & 0x80 == 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::bad_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:261:25 [INFO] [stderr] | [INFO] [stderr] 261 | self.V[x] = self.V[x] << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.V[x] <<= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `array` [INFO] [stderr] --> src/chip8/mod.rs:412:18 [INFO] [stderr] | [INFO] [stderr] 412 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 412 | for (i, ) in array.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:414:17 [INFO] [stderr] | [INFO] [stderr] 414 | result = result | (0b10000000 >> i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result |= (0b10000000 >> i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `array` [INFO] [stderr] --> src/chip8/mod.rs:422:18 [INFO] [stderr] | [INFO] [stderr] 422 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 422 | for (i, ) in array.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `pixels` [INFO] [stderr] --> src/chip8/mod.rs:434:18 [INFO] [stderr] | [INFO] [stderr] 434 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 434 | for (i, ) in pixels.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | io::stdin().read_line(&mut input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | / let mut color = [0.0, 0.0, 0.0, 1.0]; //BLACK [INFO] [stderr] 162 | | if chip8.pixel_at(x, y) { [INFO] [stderr] 163 | | color = [1.0, 1.0, 1.0, 1.0]; //WHITE [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________________________^ help: it is more idiomatic to write: `let color = if chip8.pixel_at(x, y) { [1.0, 1.0, 1.0, 1.0] } else { [0.0, 0.0, 0.0, 1.0] };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/chip8/mod.rs:452:21 [INFO] [stderr] | [INFO] [stderr] 452 | format!("CLR - Clear Display") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"CLR - Clear Display".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/chip8/mod.rs:455:21 [INFO] [stderr] | [INFO] [stderr] 455 | format!("RET - Return from sub") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"RET - Return from sub".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `emu`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | io::stdin().read_line(&mut input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | / let mut color = [0.0, 0.0, 0.0, 1.0]; //BLACK [INFO] [stderr] 162 | | if chip8.pixel_at(x, y) { [INFO] [stderr] 163 | | color = [1.0, 1.0, 1.0, 1.0]; //WHITE [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________________________^ help: it is more idiomatic to write: `let color = if chip8.pixel_at(x, y) { [1.0, 1.0, 1.0, 1.0] } else { [0.0, 0.0, 0.0, 1.0] };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `emu`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7e06de155b118656d175f6bddea32980813f232c2ea1ae3b275033a49669d056"` [INFO] running `"docker" "rm" "-f" "7e06de155b118656d175f6bddea32980813f232c2ea1ae3b275033a49669d056"` [INFO] [stdout] 7e06de155b118656d175f6bddea32980813f232c2ea1ae3b275033a49669d056