[INFO] updating cached repository DomLankutis/rust-game-of-life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DomLankutis/rust-game-of-life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DomLankutis/rust-game-of-life" "work/ex/clippy-test-run/sources/stable/gh/DomLankutis/rust-game-of-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DomLankutis/rust-game-of-life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DomLankutis/rust-game-of-life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DomLankutis/rust-game-of-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DomLankutis/rust-game-of-life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 383cfb4906742e2c43ecc8e8543933cc112bf7e9 [INFO] sha for GitHub repo DomLankutis/rust-game-of-life: 383cfb4906742e2c43ecc8e8543933cc112bf7e9 [INFO] validating manifest of DomLankutis/rust-game-of-life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DomLankutis/rust-game-of-life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DomLankutis/rust-game-of-life [INFO] finished frobbing DomLankutis/rust-game-of-life [INFO] frobbed toml for DomLankutis/rust-game-of-life written to work/ex/clippy-test-run/sources/stable/gh/DomLankutis/rust-game-of-life/Cargo.toml [INFO] started frobbing DomLankutis/rust-game-of-life [INFO] finished frobbing DomLankutis/rust-game-of-life [INFO] frobbed toml for DomLankutis/rust-game-of-life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DomLankutis/rust-game-of-life/Cargo.toml [INFO] crate DomLankutis/rust-game-of-life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DomLankutis/rust-game-of-life against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DomLankutis/rust-game-of-life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eabcf615ccae219526c033f0ca9bf672f7837ea31244d0ab8c81fc2d36d8a892 [INFO] running `"docker" "start" "-a" "eabcf615ccae219526c033f0ca9bf672f7837ea31244d0ab8c81fc2d36d8a892"` [INFO] [stderr] Checking rust-game-of-life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/screen.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/screen.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:28:43 [INFO] [stderr] | [INFO] [stderr] 28 | fn round_check(y: usize , x: usize, grid: &Vec>) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | if grid[modulo(y as i32 + y_mod, size.0) as usize][modulo(x as i32 + x_mod, size.1) as usize] == true && !(y_mod == 0 && x_mod == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `grid[modulo(y as i32 + y_mod, size.0) as usize][modulo(x as i32 + x_mod, size.1) as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:54:61 [INFO] [stderr] | [INFO] [stderr] 54 | else if cells_alive > 3 && *x.1 == true { [INFO] [stderr] | _____________________________________________________________^ [INFO] [stderr] 55 | | dead.append(&mut vec![[y.0, x.0]]); [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:51:57 [INFO] [stderr] | [INFO] [stderr] 51 | else if cells_alive < 2 && *x.1 == true { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 52 | | dead.append(&mut vec![[y.0, x.0]]); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:51:44 [INFO] [stderr] | [INFO] [stderr] 51 | else if cells_alive < 2 && *x.1 == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `*x.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:54:48 [INFO] [stderr] | [INFO] [stderr] 54 | else if cells_alive > 3 && *x.1 == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `*x.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:57:53 [INFO] [stderr] | [INFO] [stderr] 57 | else if cells_alive == 2 && *x.1 == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `*x.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-game-of-life`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:28:43 [INFO] [stderr] | [INFO] [stderr] 28 | fn round_check(y: usize , x: usize, grid: &Vec>) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | if grid[modulo(y as i32 + y_mod, size.0) as usize][modulo(x as i32 + x_mod, size.1) as usize] == true && !(y_mod == 0 && x_mod == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `grid[modulo(y as i32 + y_mod, size.0) as usize][modulo(x as i32 + x_mod, size.1) as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:54:61 [INFO] [stderr] | [INFO] [stderr] 54 | else if cells_alive > 3 && *x.1 == true { [INFO] [stderr] | _____________________________________________________________^ [INFO] [stderr] 55 | | dead.append(&mut vec![[y.0, x.0]]); [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:51:57 [INFO] [stderr] | [INFO] [stderr] 51 | else if cells_alive < 2 && *x.1 == true { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 52 | | dead.append(&mut vec![[y.0, x.0]]); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:51:44 [INFO] [stderr] | [INFO] [stderr] 51 | else if cells_alive < 2 && *x.1 == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `*x.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:54:48 [INFO] [stderr] | [INFO] [stderr] 54 | else if cells_alive > 3 && *x.1 == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `*x.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:57:53 [INFO] [stderr] | [INFO] [stderr] 57 | else if cells_alive == 2 && *x.1 == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `*x.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-game-of-life`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "eabcf615ccae219526c033f0ca9bf672f7837ea31244d0ab8c81fc2d36d8a892"` [INFO] running `"docker" "rm" "-f" "eabcf615ccae219526c033f0ca9bf672f7837ea31244d0ab8c81fc2d36d8a892"` [INFO] [stdout] eabcf615ccae219526c033f0ca9bf672f7837ea31244d0ab8c81fc2d36d8a892