[INFO] updating cached repository Direnol/Simplex-Method [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Direnol/Simplex-Method [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Direnol/Simplex-Method" "work/ex/clippy-test-run/sources/stable/gh/Direnol/Simplex-Method"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Direnol/Simplex-Method'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Direnol/Simplex-Method" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Direnol/Simplex-Method"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Direnol/Simplex-Method'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 91ee756515c4e946fc1cd49edbdaf9fd10c3aaec [INFO] sha for GitHub repo Direnol/Simplex-Method: 91ee756515c4e946fc1cd49edbdaf9fd10c3aaec [INFO] validating manifest of Direnol/Simplex-Method on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Direnol/Simplex-Method on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Direnol/Simplex-Method [INFO] finished frobbing Direnol/Simplex-Method [INFO] frobbed toml for Direnol/Simplex-Method written to work/ex/clippy-test-run/sources/stable/gh/Direnol/Simplex-Method/Cargo.toml [INFO] started frobbing Direnol/Simplex-Method [INFO] finished frobbing Direnol/Simplex-Method [INFO] frobbed toml for Direnol/Simplex-Method written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Direnol/Simplex-Method/Cargo.toml [INFO] crate Direnol/Simplex-Method has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Direnol/Simplex-Method against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Direnol/Simplex-Method:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a52e55423ad6077ba4fbbdb707ed3ee7b0cddd1e126e8beeea1839be3a2644b8 [INFO] running `"docker" "start" "-a" "a52e55423ad6077ba4fbbdb707ed3ee7b0cddd1e126e8beeea1839be3a2644b8"` [INFO] [stderr] Checking rsimpl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/simplex/structs.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | pub mat: Box>, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/simplex/structs.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | pub names: Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `simplex::structs::Simplex` [INFO] [stderr] --> src/simplex/structs.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> Simplex { [INFO] [stderr] 42 | | Simplex { [INFO] [stderr] 43 | | action: SimplexMethod::Max, [INFO] [stderr] 44 | | mat: Box::new(Vec::new()), [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 40 | impl Default for simplex::structs::Simplex { [INFO] [stderr] 41 | fn default() -> Self { [INFO] [stderr] 42 | Self::new() [INFO] [stderr] 43 | } [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/simplex/structs.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | let acc = (0usize, self.mat.last().unwrap().first().unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.mat.last().unwrap().first().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/simplex/structs.rs:68:28 [INFO] [stderr] | [INFO] [stderr] 68 | let acc = (0usize, self.res.first().unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.res.first().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/simplex/structs.rs:98:36 [INFO] [stderr] | [INFO] [stderr] 98 | .for_each(|(i, j)| *j = i * tmp + *j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `*j += i * tmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/simplex/structs.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | self.res[r] = self.res[row] * tmp + self.res[r]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.res[r] += self.res[row] * tmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/simplex/structs.rs:105:32 [INFO] [stderr] | [INFO] [stderr] 105 | .for_each(|(i, j)| *j = i * tmp + *j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `*j += i * tmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/simplex/structs.rs:136:18 [INFO] [stderr] | [INFO] [stderr] 136 | for i in 1..self.n + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1..=self.n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/simplex/structs.rs:144:16 [INFO] [stderr] | [INFO] [stderr] 144 | let f: fn((usize, f64), (usize, f64)) -> (usize, f64) = |x: (usize, f64), y: (usize, f64)| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simplex/structs.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | ::std::io::stdin().read(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/simplex/structs.rs:175:18 [INFO] [stderr] | [INFO] [stderr] 175 | for i in 1..self.n + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1..=self.n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simplex/structs.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | writeln!(f, "Action: {:?}, N: {}, K: {}", self.action, self.n, self.k); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simplex/structs.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | write!(f, "X: {: ^6}", 'z'); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/simplex/structs.rs:195:18 [INFO] [stderr] | [INFO] [stderr] 195 | for i in 1..self.n + self.k + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.n + self.k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simplex/structs.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | write!(f, "{:^8}", format!("x{}", i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simplex/structs.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | writeln!(f, " | {: ^5}", "res"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simplex/structs.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | / writeln!( [INFO] [stderr] 202 | | f, [INFO] [stderr] 203 | | "{}: {:>6.3?} | {:.3}", [INFO] [stderr] 204 | | self.names.get(row).or(Some(&zero)).unwrap(), [INFO] [stderr] 205 | | v.0, [INFO] [stderr] 206 | | v.1 [INFO] [stderr] 207 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/simplex/structs.rs:204:37 [INFO] [stderr] | [INFO] [stderr] 204 | self.names.get(row).or(Some(&zero)).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(&zero))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/simplex/mod.rs:47:12 [INFO] [stderr] | [INFO] [stderr] 47 | if c.vars.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `c.vars.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/simplex/mod.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | for i in 1..(count_all_vars + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=count_all_vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/simplex/mod.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | for i in 0..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/simplex/structs.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | pub mat: Box>, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/simplex/structs.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | pub names: Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `simplex::structs::Simplex` [INFO] [stderr] --> src/simplex/structs.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> Simplex { [INFO] [stderr] 42 | | Simplex { [INFO] [stderr] 43 | | action: SimplexMethod::Max, [INFO] [stderr] 44 | | mat: Box::new(Vec::new()), [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 40 | impl Default for simplex::structs::Simplex { [INFO] [stderr] 41 | fn default() -> Self { [INFO] [stderr] 42 | Self::new() [INFO] [stderr] 43 | } [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/simplex/structs.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | let acc = (0usize, self.mat.last().unwrap().first().unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.mat.last().unwrap().first().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/simplex/structs.rs:68:28 [INFO] [stderr] | [INFO] [stderr] 68 | let acc = (0usize, self.res.first().unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.res.first().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/simplex/structs.rs:98:36 [INFO] [stderr] | [INFO] [stderr] 98 | .for_each(|(i, j)| *j = i * tmp + *j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `*j += i * tmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/simplex/structs.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | self.res[r] = self.res[row] * tmp + self.res[r]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.res[r] += self.res[row] * tmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/simplex/structs.rs:105:32 [INFO] [stderr] | [INFO] [stderr] 105 | .for_each(|(i, j)| *j = i * tmp + *j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `*j += i * tmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/simplex/structs.rs:136:18 [INFO] [stderr] | [INFO] [stderr] 136 | for i in 1..self.n + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1..=self.n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/simplex/structs.rs:144:16 [INFO] [stderr] | [INFO] [stderr] 144 | let f: fn((usize, f64), (usize, f64)) -> (usize, f64) = |x: (usize, f64), y: (usize, f64)| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simplex/structs.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | ::std::io::stdin().read(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/simplex/structs.rs:175:18 [INFO] [stderr] | [INFO] [stderr] 175 | for i in 1..self.n + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1..=self.n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simplex/structs.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | writeln!(f, "Action: {:?}, N: {}, K: {}", self.action, self.n, self.k); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simplex/structs.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | write!(f, "X: {: ^6}", 'z'); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/simplex/structs.rs:195:18 [INFO] [stderr] | [INFO] [stderr] 195 | for i in 1..self.n + self.k + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.n + self.k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simplex/structs.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | write!(f, "{:^8}", format!("x{}", i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simplex/structs.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | writeln!(f, " | {: ^5}", "res"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simplex/structs.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | / writeln!( [INFO] [stderr] 202 | | f, [INFO] [stderr] 203 | | "{}: {:>6.3?} | {:.3}", [INFO] [stderr] 204 | | self.names.get(row).or(Some(&zero)).unwrap(), [INFO] [stderr] 205 | | v.0, [INFO] [stderr] 206 | | v.1 [INFO] [stderr] 207 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/simplex/structs.rs:204:37 [INFO] [stderr] | [INFO] [stderr] 204 | self.names.get(row).or(Some(&zero)).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(&zero))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/simplex/mod.rs:47:12 [INFO] [stderr] | [INFO] [stderr] 47 | if c.vars.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `c.vars.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/simplex/mod.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | for i in 1..(count_all_vars + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=count_all_vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/simplex/mod.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | for i in 0..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | let conf_file = args.get(1).ok_or("Not enough argument".to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Not enough argument".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | let conf_file = args.get(1).ok_or("Not enough argument".to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Not enough argument".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.98s [INFO] running `"docker" "inspect" "a52e55423ad6077ba4fbbdb707ed3ee7b0cddd1e126e8beeea1839be3a2644b8"` [INFO] running `"docker" "rm" "-f" "a52e55423ad6077ba4fbbdb707ed3ee7b0cddd1e126e8beeea1839be3a2644b8"` [INFO] [stdout] a52e55423ad6077ba4fbbdb707ed3ee7b0cddd1e126e8beeea1839be3a2644b8