[INFO] updating cached repository DillonJettCallis/rustLetLang
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/DillonJettCallis/rustLetLang
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/DillonJettCallis/rustLetLang" "work/ex/clippy-test-run/sources/stable/gh/DillonJettCallis/rustLetLang"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DillonJettCallis/rustLetLang'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/DillonJettCallis/rustLetLang" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DillonJettCallis/rustLetLang"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DillonJettCallis/rustLetLang'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 374682051b6c0829b36e560100f2665eee23296d
[INFO] sha for GitHub repo DillonJettCallis/rustLetLang: 374682051b6c0829b36e560100f2665eee23296d
[INFO] validating manifest of DillonJettCallis/rustLetLang on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of DillonJettCallis/rustLetLang on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing DillonJettCallis/rustLetLang
[INFO] finished frobbing DillonJettCallis/rustLetLang
[INFO] frobbed toml for DillonJettCallis/rustLetLang written to work/ex/clippy-test-run/sources/stable/gh/DillonJettCallis/rustLetLang/Cargo.toml
[INFO] started frobbing DillonJettCallis/rustLetLang
[INFO] finished frobbing DillonJettCallis/rustLetLang
[INFO] frobbed toml for DillonJettCallis/rustLetLang written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DillonJettCallis/rustLetLang/Cargo.toml
[INFO] crate DillonJettCallis/rustLetLang has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting DillonJettCallis/rustLetLang against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DillonJettCallis/rustLetLang:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fbf993337ad33dee781a4ba65383ef2f2383ee25ca4872327bc0495ea7973ed9
[INFO] running `"docker" "start" "-a" "fbf993337ad33dee781a4ba65383ef2f2383ee25ca4872327bc0495ea7973ed9"`
[INFO] [stderr]     Checking simple-error v0.1.11
[INFO] [stderr]     Checking rust_let_lang v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/parser.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 | const SUM_OPS: &'static [&'static str] = &["+", "-"];
[INFO] [stderr]    |                -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/parser.rs:31:27
[INFO] [stderr]    |
[INFO] [stderr] 31 | const SUM_OPS: &'static [&'static str] = &["+", "-"];
[INFO] [stderr]    |                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:202:7
[INFO] [stderr]     |
[INFO] [stderr] 202 |       return token.expected(value);
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `token.expected(value)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:212:7
[INFO] [stderr]     |
[INFO] [stderr] 212 |       return token.expected(format!("{:?}", kind).as_ref());
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `token.expected(format!("{:?}", kind).as_ref())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/parser.rs:238:20
[INFO] [stderr]     |
[INFO] [stderr] 238 | const SINGLE_OPS: &'static str = "(){}<>[];";
[INFO] [stderr]     |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/parser.rs:239:19
[INFO] [stderr]     |
[INFO] [stderr] 239 | const MERGE_OPS: &'static str = "=+-*/:";
[INFO] [stderr]     |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:293:9
[INFO] [stderr]     |
[INFO] [stderr] 293 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:295:15
[INFO] [stderr]     |
[INFO] [stderr] 295 |       None => return None
[INFO] [stderr]     |               ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:361:5
[INFO] [stderr]     |
[INFO] [stderr] 361 |     return (self.x, self.y);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.x, self.y)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/typechecker.rs:149:10
[INFO] [stderr]     |
[INFO] [stderr] 149 |     } else {
[INFO] [stderr]     |  __________^
[INFO] [stderr] 150 | |     if *defined == found {
[INFO] [stderr] 151 | |       Ok(found)
[INFO] [stderr] 152 | |     } else {
[INFO] [stderr] 153 | |       Err(SimpleError::new(format!("Incompatible types! Declared: {}, but found: {}, {}", defined.pretty(), found.pretty(), loc.pretty())))
[INFO] [stderr] 154 | |     }
[INFO] [stderr] 155 | |   }
[INFO] [stderr]     | |___^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 149 |   } else if *defined == found {
[INFO] [stderr] 150 |   Ok(found)
[INFO] [stderr] 151 | } else {
[INFO] [stderr] 152 |   Err(SimpleError::new(format!("Incompatible types! Declared: {}, but found: {}, {}", defined.pretty(), found.pretty(), loc.pretty())))
[INFO] [stderr] 153 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/parser.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 | const SUM_OPS: &'static [&'static str] = &["+", "-"];
[INFO] [stderr]    |                -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/parser.rs:31:27
[INFO] [stderr]    |
[INFO] [stderr] 31 | const SUM_OPS: &'static [&'static str] = &["+", "-"];
[INFO] [stderr]    |                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:202:7
[INFO] [stderr]     |
[INFO] [stderr] 202 |       return token.expected(value);
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `token.expected(value)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:212:7
[INFO] [stderr]     |
[INFO] [stderr] 212 |       return token.expected(format!("{:?}", kind).as_ref());
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `token.expected(format!("{:?}", kind).as_ref())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/parser.rs:238:20
[INFO] [stderr]     |
[INFO] [stderr] 238 | const SINGLE_OPS: &'static str = "(){}<>[];";
[INFO] [stderr]     |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/parser.rs:239:19
[INFO] [stderr]     |
[INFO] [stderr] 239 | const MERGE_OPS: &'static str = "=+-*/:";
[INFO] [stderr]     |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:293:9
[INFO] [stderr]     |
[INFO] [stderr] 293 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:295:15
[INFO] [stderr]     |
[INFO] [stderr] 295 |       None => return None
[INFO] [stderr]     |               ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:361:5
[INFO] [stderr]     |
[INFO] [stderr] 361 |     return (self.x, self.y);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.x, self.y)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/typechecker.rs:149:10
[INFO] [stderr]     |
[INFO] [stderr] 149 |     } else {
[INFO] [stderr]     |  __________^
[INFO] [stderr] 150 | |     if *defined == found {
[INFO] [stderr] 151 | |       Ok(found)
[INFO] [stderr] 152 | |     } else {
[INFO] [stderr] 153 | |       Err(SimpleError::new(format!("Incompatible types! Declared: {}, but found: {}, {}", defined.pretty(), found.pretty(), loc.pretty())))
[INFO] [stderr] 154 | |     }
[INFO] [stderr] 155 | |   }
[INFO] [stderr]     | |___^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 149 |   } else if *defined == found {
[INFO] [stderr] 150 |   Ok(found)
[INFO] [stderr] 151 | } else {
[INFO] [stderr] 152 |   Err(SimpleError::new(format!("Incompatible types! Declared: {}, but found: {}, {}", defined.pretty(), found.pretty(), loc.pretty())))
[INFO] [stderr] 153 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `raw_shape`
[INFO] [stderr]   --> src/typechecker.rs:69:30
[INFO] [stderr]    |
[INFO] [stderr] 69 |     Expression::Block{shape: raw_shape, loc, body: raw_body} => {
[INFO] [stderr]    |                              ^^^^^^^^^ help: consider using `_raw_shape` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `raw_shape`
[INFO] [stderr]    --> src/typechecker.rs:108:33
[INFO] [stderr]     |
[INFO] [stderr] 108 |     Expression::Variable{shape: raw_shape, loc, id} => {
[INFO] [stderr]     |                                 ^^^^^^^^^ help: consider using `_raw_shape` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `shape`
[INFO] [stderr]    --> src/typechecker.rs:171:43
[INFO] [stderr]     |
[INFO] [stderr] 171 |   if let Expression::FunctionDeclaration {shape, loc, id, ..} = ex {
[INFO] [stderr]     |                                           ^^^^^ help: try ignoring the field: `shape: _`
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `prev`
[INFO] [stderr]    --> src/parser.rs:232:3
[INFO] [stderr]     |
[INFO] [stderr] 232 |   fn prev(&mut self) {
[INFO] [stderr]     |   ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `String`
[INFO] [stderr]    --> src/parser.rs:312:3
[INFO] [stderr]     |
[INFO] [stderr] 312 |   String,
[INFO] [stderr]     |   ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:220:5
[INFO] [stderr]     |
[INFO] [stderr] 220 |     self.index = self.index + 1;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:229:5
[INFO] [stderr]     |
[INFO] [stderr] 229 |     self.index = self.index + 1;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:233:5
[INFO] [stderr]     |
[INFO] [stderr] 233 |     self.index = self.index - 1;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/parser.rs:280:9
[INFO] [stderr]     |
[INFO] [stderr] 280 | /         loop {
[INFO] [stderr] 281 | |           match self.reader.next() {
[INFO] [stderr] 282 | |             Some(next) => if test(next) {
[INFO] [stderr] 283 | |               value.push(next)
[INFO] [stderr] ...   |
[INFO] [stderr] 288 | |           }
[INFO] [stderr] 289 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(next) = self.reader.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:353:7
[INFO] [stderr]     |
[INFO] [stderr] 353 |       self.y = self.y + 1;
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:357:5
[INFO] [stderr]     |
[INFO] [stderr] 357 |     self.x = self.x + 1;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/typechecker.rs:20:7
[INFO] [stderr]    |
[INFO] [stderr] 20 |   for ref ex in &module.exports {
[INFO] [stderr]    |       ^^^^^^    --------------- help: try: `let ex = &&module.exports;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/typechecker.rs:24:7
[INFO] [stderr]    |
[INFO] [stderr] 24 |   for ref ex in &module.locals {
[INFO] [stderr]    |       ^^^^^^    -------------- help: try: `let ex = &&module.locals;`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/typechecker.rs:72:10
[INFO] [stderr]    |
[INFO] [stderr] 72 |       if raw_body.len() == 0 {
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw_body.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/typechecker.rs:158:58
[INFO] [stderr]     |
[INFO] [stderr] 158 | fn verify_function_declaration(defined: &Shape, arg_ids: &Vec<String>, loc: &Location) -> Result<(Vec<Shape>, Shape), SimpleError> {
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/typechecker.rs:180:43
[INFO] [stderr]     |
[INFO] [stderr] 180 | fn set_scope(scope_stack: &mut Scope, id: &String, shape: &Shape, loc: &Location) -> Result<(), SimpleError> {
[INFO] [stderr]     |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/typechecker.rs:191:29
[INFO] [stderr]     |
[INFO] [stderr] 191 | fn check_scope(scope_stack: &Scope, id: &String, loc: &Location) -> Result<Shape, SimpleError> {
[INFO] [stderr]     |                             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/typechecker.rs:191:41
[INFO] [stderr]     |
[INFO] [stderr] 191 | fn check_scope(scope_stack: &Scope, id: &String, loc: &Location) -> Result<Shape, SimpleError> {
[INFO] [stderr]     |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `raw_shape`
[INFO] [stderr]   --> src/typechecker.rs:69:30
[INFO] [stderr]    |
[INFO] [stderr] 69 |     Expression::Block{shape: raw_shape, loc, body: raw_body} => {
[INFO] [stderr]    |                              ^^^^^^^^^ help: consider using `_raw_shape` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `raw_shape`
[INFO] [stderr]    --> src/typechecker.rs:108:33
[INFO] [stderr]     |
[INFO] [stderr] 108 |     Expression::Variable{shape: raw_shape, loc, id} => {
[INFO] [stderr]     |                                 ^^^^^^^^^ help: consider using `_raw_shape` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `shape`
[INFO] [stderr]    --> src/typechecker.rs:171:43
[INFO] [stderr]     |
[INFO] [stderr] 171 |   if let Expression::FunctionDeclaration {shape, loc, id, ..} = ex {
[INFO] [stderr]     |                                           ^^^^^ help: try ignoring the field: `shape: _`
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `prev`
[INFO] [stderr]    --> src/parser.rs:232:3
[INFO] [stderr]     |
[INFO] [stderr] 232 |   fn prev(&mut self) {
[INFO] [stderr]     |   ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `String`
[INFO] [stderr]    --> src/parser.rs:312:3
[INFO] [stderr]     |
[INFO] [stderr] 312 |   String,
[INFO] [stderr]     |   ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:220:5
[INFO] [stderr]     |
[INFO] [stderr] 220 |     self.index = self.index + 1;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:229:5
[INFO] [stderr]     |
[INFO] [stderr] 229 |     self.index = self.index + 1;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:233:5
[INFO] [stderr]     |
[INFO] [stderr] 233 |     self.index = self.index - 1;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/parser.rs:280:9
[INFO] [stderr]     |
[INFO] [stderr] 280 | /         loop {
[INFO] [stderr] 281 | |           match self.reader.next() {
[INFO] [stderr] 282 | |             Some(next) => if test(next) {
[INFO] [stderr] 283 | |               value.push(next)
[INFO] [stderr] ...   |
[INFO] [stderr] 288 | |           }
[INFO] [stderr] 289 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(next) = self.reader.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:353:7
[INFO] [stderr]     |
[INFO] [stderr] 353 |       self.y = self.y + 1;
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/parser.rs:357:5
[INFO] [stderr]     |
[INFO] [stderr] 357 |     self.x = self.x + 1;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/typechecker.rs:20:7
[INFO] [stderr]    |
[INFO] [stderr] 20 |   for ref ex in &module.exports {
[INFO] [stderr]    |       ^^^^^^    --------------- help: try: `let ex = &&module.exports;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/typechecker.rs:24:7
[INFO] [stderr]    |
[INFO] [stderr] 24 |   for ref ex in &module.locals {
[INFO] [stderr]    |       ^^^^^^    -------------- help: try: `let ex = &&module.locals;`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/typechecker.rs:72:10
[INFO] [stderr]    |
[INFO] [stderr] 72 |       if raw_body.len() == 0 {
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw_body.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/typechecker.rs:158:58
[INFO] [stderr]     |
[INFO] [stderr] 158 | fn verify_function_declaration(defined: &Shape, arg_ids: &Vec<String>, loc: &Location) -> Result<(Vec<Shape>, Shape), SimpleError> {
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/typechecker.rs:180:43
[INFO] [stderr]     |
[INFO] [stderr] 180 | fn set_scope(scope_stack: &mut Scope, id: &String, shape: &Shape, loc: &Location) -> Result<(), SimpleError> {
[INFO] [stderr]     |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/typechecker.rs:191:29
[INFO] [stderr]     |
[INFO] [stderr] 191 | fn check_scope(scope_stack: &Scope, id: &String, loc: &Location) -> Result<Shape, SimpleError> {
[INFO] [stderr]     |                             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/typechecker.rs:191:41
[INFO] [stderr]     |
[INFO] [stderr] 191 | fn check_scope(scope_stack: &Scope, id: &String, loc: &Location) -> Result<Shape, SimpleError> {
[INFO] [stderr]     |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.83s
[INFO] running `"docker" "inspect" "fbf993337ad33dee781a4ba65383ef2f2383ee25ca4872327bc0495ea7973ed9"`
[INFO] running `"docker" "rm" "-f" "fbf993337ad33dee781a4ba65383ef2f2383ee25ca4872327bc0495ea7973ed9"`
[INFO] [stdout] fbf993337ad33dee781a4ba65383ef2f2383ee25ca4872327bc0495ea7973ed9